Re: TcpDiscoveryVmIpFinder's isShared property

2016-01-20 Thread Dmitriy Setrakyan
gt;>> actually makes sense only for VmIpFinder. Can we deprecate it and always >>>> return false from isShared() method for JDBC, S3 and others? >>>> >>>> -Val >>>> >>>> On Mon, Jan 18, 2016 at 1:56 AM, Yakov Zhdanov >>>>

Re: TcpDiscoveryVmIpFinder's isShared property

2016-01-19 Thread Yakov Zhdanov
3 and others? >>> >>> -Val >>> >>> On Mon, Jan 18, 2016 at 1:56 AM, Yakov Zhdanov >>> wrote: >>> >>>> Val, can you please review my changes to javadoc in master and update >>>> if necessary? >>>>

Re: TcpDiscoveryVmIpFinder's isShared property

2016-01-19 Thread Dmitriy Setrakyan
s to javadoc in master and update if >>> necessary? >>> >>> --Yakov >>> >>> 2016-01-15 23:13 GMT+03:00 Andrey Kornev : >>> >>>> It does now! Thank you! >>>> >>>> Andrey >>>> >>>>

Re: TcpDiscoveryVmIpFinder's isShared property

2016-01-19 Thread Yakov Zhdanov
ate if >> necessary? >> >> --Yakov >> >> 2016-01-15 23:13 GMT+03:00 Andrey Kornev : >> >>> It does now! Thank you! >>> >>> Andrey >>> >>> -- >>> Date: Fri, 15 Jan 2016 12:10:15 -

Re: TcpDiscoveryVmIpFinder's isShared property

2016-01-18 Thread Valentin Kulichenko
- >> Date: Fri, 15 Jan 2016 12:10:15 -0800 >> Subject: Re: TcpDiscoveryVmIpFinder's isShared property >> From: valentin.kuliche...@gmail.com >> To: user@ignite.apache.org >> >> >> Andrey, >> >> Setting shared=true

Re: TcpDiscoveryVmIpFinder's isShared property

2016-01-18 Thread Yakov Zhdanov
ct to? They need to get the list of > seed nodes from somewhere, right? If so, then setting isShared to true > doesn't really make much difference - an initial list of seeds still must > be provided to every node. > > Thanks > Andrey > > --

RE: TcpDiscoveryVmIpFinder's isShared property

2016-01-15 Thread Andrey Kornev
It does now! Thank you! Andrey Date: Fri, 15 Jan 2016 12:10:15 -0800 Subject: Re: TcpDiscoveryVmIpFinder's isShared property From: valentin.kuliche...@gmail.com To: user@ignite.apache.org Andrey, Setting shared=true for TcpDiscoveryVmIpFinder means that nodes can discover each other

Re: TcpDiscoveryVmIpFinder's isShared property

2016-01-15 Thread Valentin Kulichenko
ode. > > Thanks > Andrey > > -- > Date: Thu, 14 Jan 2016 12:55:52 +0300 > Subject: Re: TcpDiscoveryVmIpFinder's isShared property > From: yzhda...@apache.org > To: user@ignite.apache.org > > > Guys, this property is supported in VM

RE: TcpDiscoveryVmIpFinder's isShared property

2016-01-15 Thread Andrey Kornev
f so, then setting isShared to true doesn't really make much difference - an initial list of seeds still must be provided to every node. Thanks Andrey Date: Thu, 14 Jan 2016 12:55:52 +0300 Subject: Re: TcpDiscoveryVmIpFinder's isShared property From: yzhda...@apache.org To: user@ignite

Re: TcpDiscoveryVmIpFinder's isShared property

2016-01-14 Thread Yakov Zhdanov
Guys, this property is supported in VM IP finder for simplifying discovery in single VM. I agree, that name could be better, but I would not mess with it for now and just fix the javadocs (pls review, I did that in master). "isShared" is a property of any IP finder. If it is "true" then IP finder

Re: TcpDiscoveryVmIpFinder's isShared property

2016-01-13 Thread Dmitriy Setrakyan
Any chance we could get an explanation here, so we can update the docs? Yakov, I think you would know how this flag works. On Wed, Jan 13, 2016 at 11:40 AM, Vladimir Ozerov wrote: > +1 to the question. Very confusing property. At the very least JavaDocs > should be reworked significantly. > > On

Re: TcpDiscoveryVmIpFinder's isShared property

2016-01-13 Thread Vladimir Ozerov
+1 to the question. Very confusing property. At the very least JavaDocs should be reworked significantly. On Wed, Jan 13, 2016 at 8:32 PM, Andrey Kornev wrote: > Hi there, > > I'm a bit confused about the purpose and usage of this property. What is > being shared with who? What are the consequen