Re: Another Elasticsearch patch to allow the long URI

2021-03-25 Thread Shirai Takashi/ 白井隆
Hi, Karl. Karl Wright wrote: >I have now updated (I think) everything that this patch actually has, save >for one deprecated field substitution (the "types" field is now the "doc_" I've confirmed the updated sources via git://git.apache.org/manifoldcf.git, to find some problem in the following

Re: Another Elasticsearch patch to allow the long URI

2021-03-21 Thread Shirai Takashi/ 白井隆
Hi, Karl. Karl Wrightさんは書きました: >field). I would like to know more about this. Does the "types" field no >longer work? Should we send both, in order to be sure that the connector >works with most versions of ElasticSearch? Please help clarify so that I >can finish this off. The "types" field

Re: Another Elasticsearch patch to allow the long URI

2021-03-20 Thread Karl Wright
I have now updated (I think) everything that this patch actually has, save for one deprecated field substitution (the "types" field is now the "doc_" field). I would like to know more about this. Does the "types" field no longer work? Should we send both, in order to be sure that the connector

Re: Another Elasticsearch patch to allow the long URI

2021-03-20 Thread Karl Wright
Hi, Please see https://issues.apache.org/jira/browse/CONNECTORS-1666 . I did not commit the patches as given because I felt that the fix was a relatively narrow one and it could be implemented with no user involvement. Adding control for the user was therefore beyond the scope of the repair.

Re: Another Elasticsearch patch to allow the long URI

2021-03-19 Thread Karl Wright
Thanks for the information. I'll see what I can do. Karl On Thu, Mar 18, 2021 at 7:23 PM Shirai Takashi/ 白井隆 wrote: > Hi, Karl. > > Karl Wright wrote: > >Hi - I'm still waiting for this patch to be attached to a ticket. That is > >the only way I believe we're allowed to accept it legally. >

Re: Another Elasticsearch patch to allow the long URI

2021-03-18 Thread Shirai Takashi/ 白井隆
Hi, Karl. Karl Wright wrote: >Hi - I'm still waiting for this patch to be attached to a ticket. That is >the only way I believe we're allowed to accept it legally. Do you ask me to send the patch to the JIRA ticket? I can't access the JIRA because of our firewall. Sorry. What can I do without

Re: Another Elasticsearch patch to allow the long URI

2021-03-18 Thread Karl Wright
Hi - I'm still waiting for this patch to be attached to a ticket. That is the only way I believe we're allowed to accept it legally. Karl On Thu, Mar 4, 2021 at 7:16 PM Shirai Takashi/ 白井隆 wrote: > Hi, Karl. > > Karl Wrightさんは書きました: > >I agree it is unlikely that the JDK will lose support

Re: Another Elasticsearch patch to allow the long URI

2021-03-04 Thread Shirai Takashi/ 白井隆
Hi, Karl. Karl Wrightさんは書きました: >I agree it is unlikely that the JDK will lose support for SHA-1 because it >is used commonly, as is MD5. So please feel free to use it. I know. I think that SHA-1 is better on the whole. I don't care that apache-manifoldcf-elastic-id-2.patch.gz is discarded.

Re: Another Elasticsearch patch to allow the long URI

2021-03-04 Thread Karl Wright
I agree it is unlikely that the JDK will lose support for SHA-1 because it is used commonly, as is MD5. So please feel free to use it. Karl On Wed, Mar 3, 2021 at 7:54 PM Shirai Takashi/ 白井隆 wrote: > Hi, Horn. > > Jörn Franke wrote: > >Makes sense > > I don't think that it's easy. > > > >>>

Re: Another Elasticsearch patch to allow the long URI

2021-03-03 Thread Shirai Takashi/ 白井隆
Hi, There. Shirai Takashi/ 白井隆 wrote: >I can use SHA-256 with Elasticsearch connector. I've prepared the patch to support SHA-256. It minimizes changes, to avoid the global effects. It seems unbeautiful to include the try-catch clause. I can't decide which is better. Nintendo, Co., Ltd.

Re: Another Elasticsearch patch to allow the long URI

2021-03-03 Thread Shirai Takashi/ 白井隆
Hi, Horn. Jörn Franke wrote: >Makes sense I don't think that it's easy. >>> Maybe use SHA-256 or later. SHA-1 is obsolete and one never knows when it >>> will be removed from JDK. I also know SHA-1 is dangerous. Someone can generate the string which is hashed into the same SHA-1 to pretend

Re: Another Elasticsearch patch to allow the long URI

2021-03-02 Thread Shirai Takashi/ 白井隆
Hi, Karl. Karl Wright wrote: >Backwards compatibility means that we very likely have to >use the hash approach, and not use the decoding approach. Do you object to the decoding? It may be useless for the users with the alphabetical language. But it's useful for the users with the multibyte

Re: Another Elasticsearch patch to allow the long URI

2021-03-02 Thread Karl Wright
Hi - this is very helpful. I would like you to officially create a ticket in Jira: https://issues.apache.org/jira , project "CONNECTORS", and attach these patches. Backwards compatibility means that we very likely have to use the hash approach, and not use the decoding approach. Thanks, Karl

Re: Another Elasticsearch patch to allow the long URI

2021-03-02 Thread Jörn Franke
Makes sense > Am 02.03.2021 um 08:33 schrieb Shirai Takashi/ 白井隆 : > > Hi, Jorn. > > Jörn Franke wrote: >> Maybe use SHA-256 or later. SHA-1 is obsolete and one never knows when it >> will be removed from JDK. > > SHA-1 is used in the ManifoldCF existent class. >

Re: Another Elasticsearch patch to allow the long URI

2021-03-01 Thread Shirai Takashi/ 白井隆
Hi, Jorn. Jörn Franke wrote: >Maybe use SHA-256 or later. SHA-1 is obsolete and one never knows when it will >be removed from JDK. SHA-1 is used in the ManifoldCF existent class. (org.apache.manifoldcf.core.system.ManifoldCF) If "SHA" is replaced "SHA-256" in this class, the default algorism is

Re: Another Elasticsearch patch to allow the long URI

2021-03-01 Thread Jörn Franke
Maybe use SHA-256 or later. SHA-1 is obsolete and one never knows when it will be removed from JDK. > Am 02.03.2021 um 04:10 schrieb Shirai Takashi/ 白井隆 : > > Hi, there. > > I've found another trouble in Elasticsearch connector. > Elasticsearch output connector use the URI string as ID. >

Another Elasticsearch patch to allow the long URI

2021-03-01 Thread Shirai Takashi/ 白井隆
Hi, there. I've found another trouble in Elasticsearch connector. Elasticsearch output connector use the URI string as ID. Elasticsearch allows the length of ID no more than 512 bytes. If the URL length is too long, it causes HTTP 400 error. I prepare two solutions with this attached patch. The