Re: Issue CAMEL-17154: Request for comment and review

2022-01-16 Thread Steve973
Hi, Claus. I have created a ticket to simplify the control channel messages for the Dynamic Router EIP component: https://issues.apache.org/jira/browse/CAMEL-17500 When you have a chance, please have a look and let me know if this is complete enough for the next update to the component. Thanks,

Re: Issue CAMEL-17154: Request for comment and review

2022-01-12 Thread Steve973
I was able to try now, and I get a different error message: [ERROR] error An unexpected error occurred: "Unknown token: { line: 3, col: 2, type: 'INVALID', value: undefined } 3:2 in /home/steve/IdeaProjects/camel-website/yarn.lock". I tried "mvn package" and "mvn clean package" to try to build it

Re: Issue CAMEL-17154: Request for comment and review

2022-01-11 Thread Claus Ibsen
Hi Can you try again as there was some left over we forgot to delete after a starter was removed (spring-javaconfig) On Wed, Jan 12, 2022 at 12:44 AM Steve973 wrote: > > I am having a very hard time getting camel-website to build. it keeps > saying: > > ➤ YN: [18:20:41] Finished 'bundle' af

Re: Issue CAMEL-17154: Request for comment and review

2022-01-11 Thread Steve973
I am having a very hard time getting camel-website to build. it keeps saying: ➤ YN: [18:20:41] Finished 'bundle' after 26 s ➤ YN: {"level":"error","time":1641943633792,"name":"asciidoctor","file":{"path":"docs/spring-boot/modules/ROOT/pages/list.adoc","line":19},"source":{"url":" https://

Re: Issue CAMEL-17154: Request for comment and review

2022-01-11 Thread Steve973
Oh, I am not sure what you mean with regard to the date. The text does not contain the date. On Tue, Jan 11, 2022 at 2:46 PM Steve973 wrote: > Since this is my first contribution to one of my all-time favorite > libraries, this is pretty exciting for me. I would be glad to update the > blog po

Re: Issue CAMEL-17154: Request for comment and review

2022-01-11 Thread Steve973
Since this is my first contribution to one of my all-time favorite libraries, this is pretty exciting for me. I would be glad to update the blog post immediately. I will also add the things that we discussed with regard to how this is a glue component, etc etc. If you need me to change (or short

Re: Issue CAMEL-17154: Request for comment and review

2022-01-11 Thread Claus Ibsen
On Tue, Jan 11, 2022 at 7:13 PM Steve973 wrote: > > Thank you for the review and comments. I completely agree with you that it > is cumbersome to require users to create a java object. Your suggestion of > making the subscription URI-based is good, and I still need to figure out > how to provide

Re: Issue CAMEL-17154: Request for comment and review

2022-01-11 Thread Steve973
Thank you for the review and comments. I completely agree with you that it is cumbersome to require users to create a java object. Your suggestion of making the subscription URI-based is good, and I still need to figure out how to provide the filter (Predicate) for evaluating exchanges for partic

Re: Issue CAMEL-17154: Request for comment and review

2022-01-11 Thread Claus Ibsen
On Sat, Jan 8, 2022 at 4:09 PM Steve973 wrote: > > Hello. I would like to add a little more to this conversation, since you > mentioned my reason for contributing this code. My motivation to add this > EIP component was because a couple of years ago, I read about the dynamic > router EIP within

Re: Issue CAMEL-17154: Request for comment and review

2022-01-11 Thread Claus Ibsen
Hi Steven Thanks for your patience in my slow feedback. On Fri, Jan 7, 2022 at 9:07 PM Steve973 wrote: > > Hi, Claus. Thanks for the feedback. I think my perspective is a little > bit different, so let's look at it a slightly different way, and see what > you think. > > To me, the usefulness

Re: Issue CAMEL-17154: Request for comment and review

2022-01-10 Thread Steve973
Hi, Claus. I am just checking in to see if expanding on my rationale for the component helped at all, and if you have any additional thoughts. In short, is it ok for a component to be "glue"? Thanks, Steve On Sat, Jan 8, 2022 at 10:09 AM Steve973 wrote: > Hello. I would like to add a little

Re: Issue CAMEL-17154: Request for comment and review

2022-01-08 Thread Steve973
Hello. I would like to add a little more to this conversation, since you mentioned my reason for contributing this code. My motivation to add this EIP component was because a couple of years ago, I read about the dynamic router EIP within Camel, and I thought that it would be perfect for what I n

Re: Issue CAMEL-17154: Request for comment and review

2022-01-07 Thread Steve973
Hi, Claus. Thanks for the feedback. I think my perspective is a little bit different, so let's look at it a slightly different way, and see what you think. To me, the usefulness of Camel comes with having so many things to choose from. Anything isolated might have quite limited usefulness when

Re: Issue CAMEL-17154: Request for comment and review

2022-01-07 Thread Claus Ibsen
Hi Steve We can see from your work that you have put a lot of effort and devotion into this, with an example and blog post as well. However you say that the reason you wanted this was due to the dynamic pattern in the EIP book. The issue is that the EIP book is about messaging and integration pa

Issue CAMEL-17154: Request for comment and review

2021-12-25 Thread Steve973
Hello. I have sent a few messages here on this list about an alternate Dynamic Router EIP component implementation that I have been working on. If anyone has some time, I would like to get more community input and opinion on what I have done so far. You can see the ticket here: https://issues.ap