Re: JSF portlets and the mystery of the span.

2005-12-29 Thread Martin Marinschek
Just did that. We'll see if there are any complaints ;) regards, Martin On 12/29/05, Henrik Bentel <[EMAIL PROTECTED]> wrote: > you're right. That sounds like a great idea. > It's a nice one line fix. > > I did a cheap "grep check" through the source code for the use of > UNIQUE_ID_PREFIX > (th

Re: JSF portlets and the mystery of the span.

2005-12-28 Thread Henrik Bentel
you're right. That sounds like a great idea. It's a nice one line fix. I did a cheap "grep check" through the source code for the use of UNIQUE_ID_PREFIX (the constant which defines String "_id") and it's always used checking for component ID's starting with "_id". So unless anyone else knows any

Re: JSF portlets and the mystery of the span.

2005-12-28 Thread Henrik Bentel
thanks, that makes perfect sense. The natural followup question is: Would it makes sense to change HtmlTextRendererBase to check for index of "_id" instead? I dug around in the myfaces code and it seems PortletExternalContextImpl.encodeNamespace(...) is where the portlet name is appended to the ge

Re: JSF portlets and the mystery of the span.

2005-12-28 Thread Martin Marinschek
The reasoning is that every id which doesn't start with _id is meant to be a user-set id. If the user sets an id, the assumption is that he wants to do something with it - so this is the reason for rendering out a span, cause if you don't, the id won't be accessible from CSS or javascript. regards

JSF portlets and the mystery of the span.

2005-12-28 Thread Henrik Bentel
Hi This question is related to issue MYFACES-702 (http://issues.apache.org/jira/browse/MYFACES-702) I've got a couple of JSF Portlet which are running on Liferay 3.6.1. And I'm also experiencing the issue mentioned in MYFACES-702 except that pretty much all my page components gets wrapped in a