Re: 4.0.0 dnsbl_subtests.t test failures

2022-12-28 Thread Michael Orlitzky
On Wed, 2022-12-28 at 16:44 +0200, Henrik K wrote: > > Doesn't look too good for Gentoo packaging though, if since 2009 v310.pre > and newer have been full of all sorts of plugins loaded. It's like nobody > actually cared since most of the stuff is useful. :-) > Nobody noticed until now, and n

Re: 4.0.0 dnsbl_subtests.t test failures

2022-12-28 Thread Matus UHLAR - fantomas
On Wed, Dec 28, 2022 at 08:20:04AM -0500, Philippe Chaintreuil via users wrote: So there's desire that if a user doesn't want Mail::SPF installed, and SpamAssassin doesn't REQUIRE it (which it doesn't), it shouldn't be force installed. But for SpamAssassin to work as installed, that plugin can't

Re: 4.0.0 dnsbl_subtests.t test failures

2022-12-28 Thread Henrik K
On Wed, Dec 28, 2022 at 09:30:30AM -0500, Michael Orlitzky wrote: > On Wed, 2022-12-28 at 16:20 +0200, Henrik K wrote: > > > > Common sense would ask that how is SPF harmful for the user? One would > > think it would be actually desirable like any other network lookups, that > > user might have a

Re: 4.0.0 dnsbl_subtests.t test failures

2022-12-28 Thread Michael Orlitzky
On Wed, 2022-12-28 at 16:20 +0200, Henrik K wrote: > > Common sense would ask that how is SPF harmful for the user? One would > think it would be actually desirable like any other network lookups, that > user might have accidentally left disabled? But sure, if this is the Gentoo > way, so be it.

Re: 4.0.0 dnsbl_subtests.t test failures

2022-12-28 Thread Henrik K
On Wed, Dec 28, 2022 at 09:10:13AM -0500, Michael Orlitzky wrote: > > Without disabling the plugin, how would that work? If the user happens > to install Mail::SPF as a dependency of something else and if the > plugin is *not* disabled, spamassassin will (surprise!) start using SPF > against the us

Re: 4.0.0 dnsbl_subtests.t test failures

2022-12-28 Thread Michael Orlitzky
On Wed, 2022-12-28 at 15:38 +0200, Henrik K wrote: > > Disabling default plugins solves nothing, just creates a worse experience > for user. Educating and guiding users to use DNS properly does not require > this. Gentoo builds everything from source and allows the user to enable/disable some op

Re: 4.0.0 dnsbl_subtests.t test failures

2022-12-28 Thread Kevin A. McGrail
Howdy, if test useflag is in game, all plugins should be disabled, only check plugin should be enabled, while testing .t rules, this test is only for developpers and repo maintainers, not end users on gentoo I'd bring that up on the Gentoo list. i will like to see default all plugins disabled,

Re: 4.0.0 dnsbl_subtests.t test failures

2022-12-28 Thread Henrik K
On Wed, Dec 28, 2022 at 02:29:03PM +0100, Benny Pedersen wrote: > > i will like to see default all plugins disabled, and a install howto enabled > needed plugin as needed, there is not anypoint on enabled all, and all it > gets is dns refused . > > or some *_BLCOKED like apache infra cant sol

Re: 4.0.0 dnsbl_subtests.t test failures

2022-12-28 Thread Henrik K
On Wed, Dec 28, 2022 at 08:20:04AM -0500, Philippe Chaintreuil via users wrote: > > So there's desire that if a user doesn't want Mail::SPF installed, and > SpamAssassin doesn't REQUIRE it (which it doesn't), it shouldn't be force > installed. But for SpamAssassin to work as installed, that plugi

Re: 4.0.0 dnsbl_subtests.t test failures

2022-12-28 Thread Benny Pedersen
Kevin A. McGrail skrev den 2022-12-28 14:22: +1 thanks for bringing this up and bridging the fix! On 12/28/2022 8:20 AM, Philippe Chaintreuil via users wrote: I'm going to make a Gentoo Pull Request to try to remove the init.pre blanket disable, because at this point we do install most of those

Re: 4.0.0 dnsbl_subtests.t test failures

2022-12-28 Thread Kevin A. McGrail
+1 thanks for bringing this up and bridging the fix! On 12/28/2022 8:20 AM, Philippe Chaintreuil via users wrote: I'm going to make a Gentoo Pull Request to try to remove the init.pre blanket disable, because at this point we do install most of those dependencies by default.  Failing that I'll

Re: 4.0.0 dnsbl_subtests.t test failures

2022-12-28 Thread Philippe Chaintreuil via users
TL;DR: I'm going to try get the init.pre disables removed in Gentoo, failing that I'm going to move it to /etc/spamassassin/ modifications instead of changing the files in rules/. I believe Philippe is the package maintainer, so it's up to him I guess. 😄 Disclaimer: I'm just a volunteer

Re: 4.0.0 dnsbl_subtests.t test failures

2022-12-28 Thread Henrik K
I believe Philippe is the package maintainer, so it's up to him I guess. :-) On Wed, Dec 28, 2022 at 06:35:07AM -0500, Kevin A. McGrail wrote: > +1 and over and above by Henrik to install the distro for testing. > > Our project cannot be responsible for the decisions of the distribution > pack

Re: 4.0.0 dnsbl_subtests.t test failures

2022-12-28 Thread Kevin A. McGrail
+1 and over and above by Henrik to install the distro for testing. Our project cannot be responsible for the decisions of the distribution package maintainers. This is definitely one that is not the right decision. Do we have a contact at Gentoo? Regards, KAM On Wed, Dec 28, 2022, 04:38 Henrik

Re: 4.0.0 dnsbl_subtests.t test failures

2022-12-28 Thread Henrik K
On Mon, Dec 26, 2022 at 01:57:20PM -0500, Philippe Chaintreuil via users wrote: > On 12/25/2022 4:38 PM, Sidney Markowitz wrote: > > I can get exactly that set of error messages by commenting out the > > loadplugin for URIDNSBL in rules/init.pre or deleting the file > > rules/init.pre completely, a

Re: 4.0.0 dnsbl_subtests.t test failures

2022-12-26 Thread Benny Pedersen
Bill Cole skrev den 2022-12-26 20:37: Gentoo disables all plugins in init.pre so users have to choose which plugins to use and do any required configuration after install. good to see its on the way, but Bill is not a gentoo user imho That should break MANY tests, and reflects an error in ju

Re: 4.0.0 dnsbl_subtests.t test failures

2022-12-26 Thread Bill Cole
On 2022-12-26 at 13:57:20 UTC-0500 (Mon, 26 Dec 2022 13:57:20 -0500) Philippe Chaintreuil via users is rumored to have said: On 12/25/2022 4:38 PM, Sidney Markowitz wrote: I can get exactly that set of error messages by commenting out the loadplugin for URIDNSBL in rules/init.pre or deleting

Re: 4.0.0 dnsbl_subtests.t test failures

2022-12-26 Thread Philippe Chaintreuil via users
On 12/26/2022 1:57 PM, Philippe Chaintreuil via users wrote: Anyway to check at the top of the dnsbl_subtests.t if Mail::SpamAssassin::Plugin::URIDNSBL has been loaded or not to have it punt? Just noticed how spf.t does this. use co

Re: 4.0.0 dnsbl_subtests.t test failures

2022-12-26 Thread Philippe Chaintreuil via users
On 12/25/2022 4:38 PM, Sidney Markowitz wrote: I can get exactly that set of error messages by commenting out the loadplugin for URIDNSBL in rules/init.pre or deleting the file rules/init.pre completely, and running make test with the default setting of run_net_tests=n in t/config.dist. If I ch

Re: 4.0.0 dnsbl_subtests.t test failures

2022-12-26 Thread Henrik K
On Mon, Dec 26, 2022 at 11:54:12AM +0100, Giovanni Bechis wrote: > > dnsbl_subtests.t tests runs even with run_net_tests=n (fixed few minutes > ago in trunk) The fix is not needed. dnsbl_subtests.t starts a _local_ nameserver and never sends queries to public internet. The intention of run_net_t

Re: 4.0.0 dnsbl_subtests.t test failures

2022-12-26 Thread Giovanni Bechis
On Mon, Dec 26, 2022 at 10:38:07AM +1300, Sidney Markowitz wrote: > Philippe Chaintreuil via users wrote on 26/12/22 6:27 am: > > I'm getting test failures for the dnsbl_subtests.t. Figured I'd check > > here before filing a bug. > > > > I'm running Spam Assassin 4.0.0 on Gentoo Linux. Perl 5.36

Re: 4.0.0 dnsbl_subtests.t test failures

2022-12-25 Thread Sidney Markowitz
Philippe Chaintreuil via users wrote on 26/12/22 6:27 am: I'm getting test failures for the dnsbl_subtests.t. Figured I'd check here before filing a bug. I'm running Spam Assassin 4.0.0 on Gentoo Linux. Perl 5.36.0. Test output: ===

4.0.0 dnsbl_subtests.t test failures

2022-12-25 Thread Philippe Chaintreuil via users
I'm getting test failures for the dnsbl_subtests.t. Figured I'd check here before filing a bug. I'm running Spam Assassin 4.0.0 on Gentoo Linux. Perl 5.36.0. Test output: == ... t/dnsbl_subtests.t 1/46 ru