Re: Relay Checker Plugin (code review please?)

2006-11-02 Thread Billy Huddleston
- From: Dylan Bouterse [EMAIL PROTECTED] To: users@spamassassin.apache.org Sent: Wednesday, November 01, 2006 11:28 PM Subject: RE: Relay Checker Plugin (code review please?) I did a couple of times. :( -Original Message- From: Billy Huddleston [mailto:[EMAIL PROTECTED] Sent: Wednesday

Re: Relay Checker Plugin (code review please?)

2006-11-01 Thread Justin Mason
John Rudd writes: Stuart Johnston wrote: John Rudd wrote: Stuart Johnston wrote: John Rudd wrote: 2) This sort of replaces the other set of rules I created, that did this with metarules instead of a plugin. This made some of the checks less useful. You probably don't need to use

Re: Relay Checker Plugin (code review please?)

2006-11-01 Thread Billy Huddleston
Attached is patch to allow scores to be done in the .cf file --- RelayChecker.pm 2006-10-30 18:02:28.0 -0500 +++ ../RelayChecker.pm 2006-11-01 15:36:53.0 -0500 @@ -31,6 +31,12 @@ # headerRELAY_CHECKER eval:relay_checker() # describe RELAY_CHECKER Check relay

RE: Relay Checker Plugin (code review please?)

2006-11-01 Thread Dylan Bouterse
-Original Message- From: John D. Hardin [mailto:[EMAIL PROTECTED] Sent: Wednesday, November 01, 2006 5:05 PM To: Dylan Bouterse Cc: users@spamassassin.apache.org Subject: RE: Relay Checker Plugin (code review please?) On Wed, 1 Nov 2006, Dylan Bouterse wrote: # header

Re: Relay Checker Plugin (code review please?)

2006-11-01 Thread Billy Huddleston
: Relay Checker Plugin (code review please?) -Original Message- From: John D. Hardin [mailto:[EMAIL PROTECTED] Sent: Wednesday, November 01, 2006 5:05 PM To: Dylan Bouterse Cc: users@spamassassin.apache.org Subject: RE: Relay Checker Plugin (code review please?) On Wed, 1 Nov 2006, Dylan

RE: Relay Checker Plugin (code review please?)

2006-11-01 Thread Dylan Bouterse
I did a couple of times. :( -Original Message- From: Billy Huddleston [mailto:[EMAIL PROTECTED] Sent: Wednesday, November 01, 2006 9:20 PM To: Dylan Bouterse; users@spamassassin.apache.org Subject: Re: Relay Checker Plugin (code review please?) You may want to download new

Re: Relay Checker Plugin (code review please?)

2006-10-31 Thread Rick Macdougall
John Rudd wrote: Rick Macdougall wrote: John Rudd wrote: Hi, Right off the bat I've disabled it. It, of course, hits on all mail my local users send. That's not really acceptable in an ISP situation so I've turned it off until tomorrow when I have the time to look at the code and see

Re: Relay Checker Plugin (code review please?)

2006-10-31 Thread Matthew Newton
Hi, On Mon, Oct 30, 2006 at 03:23:21PM -0800, John Rudd wrote: I've written a plugin for Spam Assassin that does the relay checks I ...and here was me just working out how to get exim to check this, and have SpamAssassin add a score, and your mail arrived :-) 1) no RDNS for the machines that

Re: Relay Checker Plugin (code review please?)

2006-10-31 Thread John Rudd
Stuart Johnston wrote: John Rudd wrote: 2) This sort of replaces the other set of rules I created, that did this with metarules instead of a plugin. This made some of the checks less useful. You probably don't need to use both methods. So, what is the point of doing this as a plugin

Re: Relay Checker Plugin (code review please?)

2006-10-31 Thread Stuart Johnston
John Rudd wrote: Stuart Johnston wrote: John Rudd wrote: 2) This sort of replaces the other set of rules I created, that did this with metarules instead of a plugin. This made some of the checks less useful. You probably don't need to use both methods. So, what is the point of doing

Re: Relay Checker Plugin (code review please?)

2006-10-31 Thread John Rudd
Stuart Johnston wrote: John Rudd wrote: Stuart Johnston wrote: John Rudd wrote: 2) This sort of replaces the other set of rules I created, that did this with metarules instead of a plugin. This made some of the checks less useful. You probably don't need to use both methods. So, what

RE: Relay Checker Plugin (code review please?)

2006-10-30 Thread Dylan Bouterse
-Original Message- From: John Rudd [mailto:[EMAIL PROTECTED] Sent: Monday, October 30, 2006 6:23 PM To: SpamAssassin Users Subject: Relay Checker Plugin (code review please?) I've written a plugin for Spam Assassin that does the relay checks I used to do in MimeDefang. The purpose

Re: Relay Checker Plugin (code review please?)

2006-10-30 Thread John Rudd
Dylan Bouterse wrote: -Original Message- From: John Rudd [mailto:[EMAIL PROTECTED] Sent: Monday, October 30, 2006 6:23 PM To: SpamAssassin Users Subject: Relay Checker Plugin (code review please?) I've written a plugin for Spam Assassin that does the relay checks I used to do in

Re: Relay Checker Plugin (code review please?)

2006-10-30 Thread Rick Macdougall
John Rudd wrote: I've written a plugin for Spam Assassin that does the relay checks I used to do in MimeDefang. The purpose of these checks is to try to identify those messages that are likely to be coming directly (with no intermediary mail server) from a zombie-bot, and are thus likely to

Re: Relay Checker Plugin (code review please?)

2006-10-30 Thread Rick Macdougall
John Rudd wrote: I've written a plugin for Spam Assassin that does the relay checks I used to do in MimeDefang. The purpose of these checks is to try to identify those messages that are likely to be coming directly (with no intermediary mail server) from a zombie-bot, and are thus likely to

Re: Relay Checker Plugin (code review please?)

2006-10-30 Thread John Rudd
Rick Macdougall wrote: John Rudd wrote: I've written a plugin for Spam Assassin that does the relay checks I used to do in MimeDefang. The purpose of these checks is to try to identify those messages that are likely to be coming directly (with no intermediary mail server) from a