Re: [T5.2] Label tags not getting id attribute rendered, why?

2010-12-17 Thread Josh Canfield
Hmm... The id needs to be put back, but before we add a symbol to allow it to be optionally removed I'd like to make sure that Howard (and anyone else) really needed it removed and it wasn't just some house cleaning. I imagine if it was really a number of bytes issue then more than just the label

Re: [T5.2] Label tags not getting id attribute rendered, why?

2010-12-17 Thread Robert Zeigler
On Dec 17, 2010, at 12/1712:53 PM , Thiago H. de Paula Figueiredo wrote: > On Fri, 17 Dec 2010 16:35:43 -0200, Robert Zeigler wrote: > >> Just to clarify, I hope that by "true" you mean that id generation is turned >> /on/ by default. :) > > Your hope isn't in vain. :) true = on in this case.

Re: [T5.2] Label tags not getting id attribute rendered, why?

2010-12-17 Thread Thiago H. de Paula Figueiredo
On Fri, 17 Dec 2010 16:35:43 -0200, Robert Zeigler wrote: Just to clarify, I hope that by "true" you mean that id generation is turned /on/ by default. :) Your hope isn't in vain. :) true = on in this case. warnings as time allowed. The important thing is that even with deprecated meth

Re: [T5.2] Label tags not getting id attribute rendered, why?

2010-12-17 Thread Robert Zeigler
Just to clarify, I hope that by "true" you mean that id generation is turned /on/ by default. :) At least for 5.2.4. It could be off by default in 5.3. But these sorts of seemingly innocuous but actually disruptive changes (and yes: nixing the id of an element is a disruptive change!) should hap

Re: [T5.2] Label tags not getting id attribute rendered, why?

2010-12-17 Thread Thiago H. de Paula Figueiredo
On Fri, 17 Dec 2010 15:40:13 -0200, Andreas Andreou wrote: i wouldn't worry about that js performance and i do believe that the current is the correct default behavior but i do understand that this change breaks existing running apps. I see three options: - bring the ids back (framework chan

Re: [T5.2] Label tags not getting id attribute rendered, why?

2010-12-17 Thread Andreas Andreou
i wouldn't worry about that js performance and i do believe that the current is the correct default behavior but i do understand that this change breaks existing running apps. I see three options: - bring the ids back (framework change) - implement some kind of postprocessor that adds an id to all

Re: [T5.2] Label tags not getting id attribute rendered, why?

2010-12-17 Thread Robert Zeigler
an id. > > >> -Original Message- >> From: andre...@gmail.com [mailto:andre...@gmail.com] On Behalf Of >> Andreas Andreou >> Sent: 17 December 2010 16:51 >> To: Tapestry users >> Subject: Re: [T5.2] Label tags not getting id attribute rendered, why

Re: [T5.2] Label tags not getting id attribute rendered, why?

2010-12-17 Thread Robert Zeigler
That's all true, and well. Except. We have apps out "in the wild" that rely on the id being generated. As for - to _ in identifiers, I don't remember the exact issue, but there's a jira for it and it has to do with invalid identifiers, or the - in names causing problems in some circumstances

RE: [T5.2] Label tags not getting id attribute rendered, why?

2010-12-17 Thread Blower, Andy
Sent: 17 December 2010 16:51 > To: Tapestry users > Subject: Re: [T5.2] Label tags not getting id attribute rendered, why? > > It makes sense to me to not output redundant html > And if you know the id of the control you can get to its label by > $$('label[for=' +

Re: [T5.2] Label tags not getting id attribute rendered, why?

2010-12-17 Thread Andreas Andreou
It makes sense to me to not output redundant html And if you know the id of the control you can get to its label by $$('label[for=' + id + ']') On Fri, Dec 17, 2010 at 18:35, Blower, Andy wrote: > The change was made in July and doesn't appear to be associated with a JIRA: > > r931361 | hlshi

[T5.2] Label tags not getting id attribute rendered, why?

2010-12-17 Thread Blower, Andy
The change was made in July and doesn't appear to be associated with a JIRA: r931361 | hlship | 2010-04-07 00:01:00 BST Do not render an id attribute for Label components, as they can be identified via their for attribute Yes they can, but it's pretty standard to find tags in the dom via id's,