Re: Possible bug in http2 window size handling in tomcat 9.0.45

2021-07-02 Thread Erik Nilsson
Perfect, glad to see a release after the vacation :) Thanks again and happy vacationing. /Erik Den fre 2 juli 2021 kl 14:06 skrev Mark Thomas : > On 02/07/2021 12:46, Erik Nilsson wrote: > > Great!! With tomcat-9.0-20210701.191821-3270 in our environment it seems > to > > be stable without any

Re: Possible bug in http2 window size handling in tomcat 9.0.45

2021-07-02 Thread Mark Thomas
On 02/07/2021 12:46, Erik Nilsson wrote: Great!! With tomcat-9.0-20210701.191821-3270 in our environment it seems to be stable without any RST_STREAMs. Excellent. Thanks for confirming the fix. When will you release this version? Releases happen ~monthly. We aim for early in the month and

Re: Possible bug in http2 window size handling in tomcat 9.0.45

2021-07-02 Thread Erik Nilsson
Great!! With tomcat-9.0-20210701.191821-3270 in our environment it seems to be stable without any RST_STREAMs. When will you release this version? /Erik Den fre 2 juli 2021 kl 10:28 skrev Mark Thomas : > On 01/07/2021 08:57, Mark Thomas wrote: > > On 01/07/2021 08:41, Erik Nilsson wrote: > >>

Re: Possible bug in http2 window size handling in tomcat 9.0.45

2021-07-02 Thread Mark Thomas
On 01/07/2021 08:57, Mark Thomas wrote: On 01/07/2021 08:41, Erik Nilsson wrote: protocol="org.apache.coyote.http11.Http11NioProtocol"     connectionTimeout="2" compression="on" useAsyncIO="false"

Re: Possible bug in http2 window size handling in tomcat 9.0.45

2021-07-01 Thread Mark Thomas
On 01/07/2021 08:41, Erik Nilsson wrote: Tx. It looks like there are multiple issues going on here then - in additional to the sendfile issue I already fixed. I'll fix the issue I'm currently seeing and then try again to recreate the issue you are seeing. I'll keep the

Re: Possible bug in http2 window size handling in tomcat 9.0.45

2021-07-01 Thread Erik Nilsson
Den tors 1 juli 2021 kl 09:32 skrev Mark Thomas : > On 01/07/2021 07:16, Erik Nilsson wrote: > > Hmm I can still get the same exceptions even if I set useAsyncIO="false", > > but with maxConcurrentStreamExecution="1" it's stable. > > Can you provide your entire Connector

Re: Possible bug in http2 window size handling in tomcat 9.0.45

2021-07-01 Thread Mark Thomas
On 01/07/2021 07:16, Erik Nilsson wrote: Hmm I can still get the same exceptions even if I set useAsyncIO="false", but with maxConcurrentStreamExecution="1" it's stable. Can you provide your entire Connector configuration that includes useAsyncIO="false" please? Thanks, Mark /Erik Den

Re: Possible bug in http2 window size handling in tomcat 9.0.45

2021-07-01 Thread Erik Nilsson
Hmm I can still get the same exceptions even if I set useAsyncIO="false", but with maxConcurrentStreamExecution="1" it's stable. /Erik Den ons 30 juni 2021 kl 18:41 skrev Mark Thomas : > On 30/06/2021 16:49, Erik Nilsson wrote: > > Perfect that u can reproduce this with another webapp. Thankful

Re: Possible bug in http2 window size handling in tomcat 9.0.45

2021-06-30 Thread Mark Thomas
On 30/06/2021 16:49, Erik Nilsson wrote: Perfect that u can reproduce this with another webapp. Thankful for your quick response. As I pointed out in the beginning of the conversation we also got this problem behind our f5 loadbalancer. But not with if we connect to Tomcat directly without a

Re: Possible bug in http2 window size handling in tomcat 9.0.45

2021-06-30 Thread Erik Nilsson
Perfect that u can reproduce this with another webapp. Thankful for your quick response. As I pointed out in the beginning of the conversation we also got this problem behind our f5 loadbalancer. But not with if we connect to Tomcat directly without a loadbalancer. /Erik ons 30 juni 2021 kl.

Re: Possible bug in http2 window size handling in tomcat 9.0.45

2021-06-30 Thread Mark Thomas
On 29/06/2021 09:43, Mark Thomas wrote: On 29/06/2021 09:26, Erik Nilsson wrote: Sorry but there seems to be no difference in the behaviour.. /Erik OK. Thanks for testing. I'm going to need those debug logs then to figure out what is going on. Debug logs received off-list. Tx. I'm able to

Re: Possible bug in http2 window size handling in tomcat 9.0.45

2021-06-29 Thread Mark Thomas
On 29/06/2021 09:26, Erik Nilsson wrote: Sorry but there seems to be no difference in the behaviour.. /Erik OK. Thanks for testing. I'm going to need those debug logs then to figure out what is going on. Mark Den mån 28 juni 2021 kl 20:44 skrev Mark Thomas : On 28/06/2021 15:11, Mark

Re: Possible bug in http2 window size handling in tomcat 9.0.45

2021-06-29 Thread Erik Nilsson
Sorry but there seems to be no difference in the behaviour.. /Erik Den mån 28 juni 2021 kl 20:44 skrev Mark Thomas : > On 28/06/2021 15:11, Mark Thomas wrote: > > On 28/06/2021 10:53, Erik Nilsson wrote: > >> Yep, something seems to go wrong with the waitingFor field in > >>

Re: Possible bug in http2 window size handling in tomcat 9.0.45

2021-06-28 Thread Mark Thomas
On 28/06/2021 15:11, Mark Thomas wrote: On 28/06/2021 10:53, Erik Nilsson wrote: Yep, something seems to go wrong with the waitingFor field in WindowAllocationManager. We are developing a quite complex embedded cms application, don't know if I will be able to share this application.

Re: Possible bug in http2 window size handling in tomcat 9.0.45

2021-06-28 Thread Mark Thomas
On 28/06/2021 10:53, Erik Nilsson wrote: Yep, something seems to go wrong with the waitingFor field in WindowAllocationManager. We are developing a quite complex embedded cms application, don't know if I will be able to share this application. Hopefully you can reproduce this anyway by using

Re: Possible bug in http2 window size handling in tomcat 9.0.45

2021-06-28 Thread Erik Nilsson
Yep, something seems to go wrong with the waitingFor field in WindowAllocationManager. We are developing a quite complex embedded cms application, don't know if I will be able to share this application. Hopefully you can reproduce this anyway by using the nghttp client and another large webapp?

Re: Possible bug in http2 window size handling in tomcat 9.0.45

2021-06-28 Thread Mark Thomas
On 27/06/2021 12:05, Erik Nilsson wrote: We might have found an issue with the window size in http2 in Tomcat 9.0.45. Thanks for the heads up. 9.0.45 has fixes for all the known issues with window size management so this looks like a potential new bug. java.lang.IllegalStateException:

Possible bug in http2 window size handling in tomcat 9.0.45

2021-06-27 Thread Erik Nilsson
We might have found an issue with the window size in http2 in Tomcat 9.0.45. java.lang.IllegalStateException: Connection [483], Stream [21], Already waiting at org.apache.coyote.http2.WindowAllocationManager.waitFor(WindowAllocationManager.java:143) at