Re: [PATCH] simplify do_signal_stop() utrace_report_jctl() interaction

2009-07-28 Thread Oleg Nesterov
? This is not strictly needed. Oleg. - [PATCH] simplify do_signal_stop() utrace_report_jctl() interaction do_signal_stop() can call utrace_report_jctl() before decrementing -group_stop_count and setting TASK_STOPPED

Re: [PATCH] simplify do_signal_stop() utrace_report_jctl() interaction

2009-07-28 Thread Roland McGrath
Questions: should I send the change in signal.c to Andrew right now? It can be applied separetely, it doesn't break utrace_report_jctl(). Yes, send it now. It might be best just to send a replacement for signals-tracehook_notify_jctl-change.patch that rolls this in. I wouldn't mention

Re: [PATCH] simplify do_signal_stop() utrace_report_jctl() interaction

2009-07-28 Thread Oleg Nesterov
On 07/28, Roland McGrath wrote: Questions: should I send the change in signal.c to Andrew right now? It can be applied separetely, it doesn't break utrace_report_jctl(). Yes, send it now. OK, will do It might be best just to send a replacement for

Re: [PATCH] simplify do_signal_stop() utrace_report_jctl() interaction

2009-07-28 Thread Roland McGrath
Roland, I'd prefer to send this change separately. Otherwise it will be really hard to review the unified patch. Do it however you think is best for getting all the generic signal.c and tracehook.h bits merged ASAP. And I think this will complicate its way to Linus's tree. I _think_ that

[PATCH] simplify do_signal_stop() utrace_report_jctl() interaction

2009-07-27 Thread Oleg Nesterov
with this change... I don't know how it should be merged. Probably the change in signal.c should be sent separately, but this breaks -mm tree. -- [PATCH] simplify do_signal_stop() utrace_report_jctl() interaction

Re: [PATCH] simplify do_signal_stop() utrace_report_jctl() interaction

2009-07-27 Thread Roland McGrath
Assuming you agree with this change... I don't know how it should be merged. Probably the change in signal.c should be sent separately, but this breaks -mm tree. The relevant -mm differences are just in one patch that folds finish_stop into do_signal_stop, right? If I can apply just that one

Re: [PATCH] simplify do_signal_stop() utrace_report_jctl() interaction

2009-07-27 Thread Oleg Nesterov
On 07/27, Roland McGrath wrote: Assuming you agree with this change... I don't know how it should be merged. Probably the change in signal.c should be sent separately, but this breaks -mm tree. The relevant -mm differences are just in one patch that folds finish_stop into do_signal_stop,

Re: [PATCH] simplify do_signal_stop() utrace_report_jctl() interaction

2009-07-27 Thread Roland McGrath
Ah. I forgot signals-tracehook_notify_jctl-change.patch is still pending in -mm. Perhaps we should just rejigger all these together into one new patch (or two, whatever) before akpm submits any of them. Or you can just merge these 2 patches, perhaps this would be better. As long as we have

Re: [PATCH] simplify do_signal_stop() utrace_report_jctl() interaction

2009-03-19 Thread Roland McGrath
Roland, I think it better to change tracehook definition more, please see below. I don't really object to this in principle. But this touches signal.c a lot more in less obviously-trivial ways than my tracehook patch. That is more of an issue at the outset than some extra fiddling in the

[PATCH] simplify do_signal_stop() utrace_report_jctl() interaction

2009-03-18 Thread Oleg Nesterov
? - [PATCH] simplify do_signal_stop() utrace_report_jctl() interaction do_signal_stop() can call utrace_report_jctl() before decrementing -group_stop_count and setting TASK_STOPPED/SIGNAL_STOP_STOPPED. This allow to greatly simplify utrace_report_jctl() and avoid playing with group-stop