Re: implementation of syscall_get_error()

2008-09-05 Thread Ingo Molnar
it. ok - i've applied the commit below to tip/x86/tracehook. Ingo - From 4ab4ba32aa16b012cb0faabf1a27952508fe67f2 Mon Sep 17 00:00:00 2001 From: Petr Tesarik [EMAIL PROTECTED] Date: Wed, 3 Sep 2008 13:31:42 +0200 Subject: [PATCH] x86, tracehook: clean up implementation

implementation of syscall_get_error()

2008-09-03 Thread Petr Tesarik
Hello Roland, The x86-tracehook code now contains this line in syscall_get_error(): return error = -4095L ? error : 0; Hard-wiring a constant is not nice. Let's use the IS_ERR_VALUE macro from linux/err.h instead. Signed-off-by: Petr Tesarik [EMAIL PROTECTED] diff --git

Re: implementation of syscall_get_error()

2008-09-03 Thread Roland McGrath
That's fine by me. I was thinking of the definition of errorness as arch-dependent magic, and just took the constant used in x86-specific userland code that does this. If IS_ERR_VALUE is always going to be what's right on x86, by all means use it. Thanks, Roland