[v8-dev] [v8 commit] r886 - data/benchmarks/v1

2008-12-02 Thread codesite-noreply
Author: [EMAIL PROTECTED] Date: Tue Dec 2 00:44:32 2008 New Revision: 886 Modified: data/benchmarks/v1/run.html (props changed) Log: Marked run.html in the first version of the benchmarks as text/html so it can be displayed directly from the repository. --~--~-~--~~

[v8-dev] Benchmark precision

2008-12-02 Thread christian . plesner . hansen
Reviewers: sandholm, Description: Changed benchmark runners to always display at least three significant digits in the results. Please review this at http://codereview.chromium.org/12865 Affected files: M benchmarks/base.js M benchmarks/run.html M benchmarks/run.js Index: benchmarks/

[v8-dev] Re: Benchmark precision

2008-12-02 Thread sandholm
LGTM. One proposal to make the change even simpler, though. (Maybe too simple...) http://codereview.chromium.org/12865/diff/1/2 File benchmarks/base.js (left): http://codereview.chromium.org/12865/diff/1/2#oldcode123 Line 123: runner.NotifyScore(Math.round(100 * score)); Just wondering if it wo

[v8-dev] [v8 commit] r895 - branches/bleeding_edge/benchmarks

2008-12-02 Thread codesite-noreply
Author: [EMAIL PROTECTED] Date: Tue Dec 2 05:02:11 2008 New Revision: 895 Modified: branches/bleeding_edge/benchmarks/base.js branches/bleeding_edge/benchmarks/run.html branches/bleeding_edge/benchmarks/run.js Log: Changed benchmark runners to always display at least three significa

[v8-dev] [v8 commit] r896 - branches/bleeding_edge/src

2008-12-02 Thread codesite-noreply
Author: whessev8 Date: Tue Dec 2 05:20:00 2008 New Revision: 896 Modified: branches/bleeding_edge/src/date-delay.js branches/bleeding_edge/src/platform-win32.cc Log: Change Windows daylight saving time calculations to use C stdlib local time functions, not Win32 functions. Win32 time fu

[v8-dev] Re: Change Windows daylight saving time calculations to...

2008-12-02 Thread ager
LGTM. http://codereview.chromium.org/12824 --~--~-~--~~~---~--~~ v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev -~--~~~~--~~--~--~---

[v8-dev] Re: Added regexp-macro-assembler-tracer .cc and .h files to Visual Studio project...

2008-12-02 Thread Lasse R.H. Nielsen
lgtm On Tue, Dec 2, 2008 at 1:42 PM, <[EMAIL PROTECTED]> wrote: > Reviewers: Lasse Reichstein, > > Description: > Added regexp-macro-assembler-tracer .cc and .h files to Visual Studio > project to make it build. > > Please review this at http://codereview.chromium.org/13047 > > SVN Base: http://

[v8-dev] [v8 commit] r897 - branches/0.3/src

2008-12-02 Thread codesite-noreply
Author: [EMAIL PROTECTED] Date: Tue Dec 2 05:49:36 2008 New Revision: 897 Modified: branches/0.3/src/api.cc branches/0.3/src/date-delay.js branches/0.3/src/platform-win32.cc Log: Merge WinXP SP3 performance fix to 0.3 branch (version 0.3.9.3). Modified: branches/0.3/src/api.cc

[v8-dev] Fixed regexp zone issue

2008-12-02 Thread christian . plesner . hansen
Reviewers: Mads Ager, Description: Fixed issue where regexps were parsed without having set up a zone scope, leading to zone exhaustion. Added assertion that a zone scope exists on zone allocation. Please review this at http://codereview.chromium.org/12866 Affected files: M src/jsregexp.cc

[v8-dev] [v8 commit] r898 - in branches/bleeding_edge: src test/cctest

2008-12-02 Thread codesite-noreply
Author: [EMAIL PROTECTED] Date: Tue Dec 2 06:00:24 2008 New Revision: 898 Modified: branches/bleeding_edge/src/jsregexp.cc branches/bleeding_edge/src/v8-counters.h branches/bleeding_edge/src/zone-inl.h branches/bleeding_edge/src/zone.cc branches/bleeding_edge/src/zone.h b

[v8-dev] Re: Fixed regexp zone issue

2008-12-02 Thread ager
LGTM http://codereview.chromium.org/12866 --~--~-~--~~~---~--~~ v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev -~--~~~~--~~--~--~---

[v8-dev] [v8 commit] r893 - data/benchmarks/v2

2008-12-02 Thread codesite-noreply
Author: [EMAIL PROTECTED] Date: Tue Dec 2 02:17:18 2008 New Revision: 893 Added: data/benchmarks/v2/ - copied from r892, /branches/bleeding_edge/benchmarks/ Log: ...and we're back! --~--~-~--~~~---~--~~ v8-dev mailing list v8-dev@googlegroups.com ht

[v8-dev] Re: Fix build problem in Win.

2008-12-02 Thread christian . plesner . hansen
Lgtm http://codereview.chromium.org/12864 --~--~-~--~~~---~--~~ v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev -~--~~~~--~~--~--~---

[v8-dev] Fix build problem in Win.

2008-12-02 Thread lrn
Reviewers: Christian Plesner Hansen, Message: Bugfix review Description: Builds on Windows too. Please review this at http://codereview.chromium.org/12864 Affected files: M src/runtime.cc Index: src/runtime.cc diff --git a/src/runtime.cc b/src/runtime.cc index 5512f8323a99e42769fff93167

[v8-dev] [v8 commit] r885 - data/benchmarks/v1

2008-12-02 Thread codesite-noreply
Author: [EMAIL PROTECTED] Date: Tue Dec 2 00:41:31 2008 New Revision: 885 Added: data/benchmarks/v1/ - copied from r91, /branches/bleeding_edge/benchmarks/ Log: Tagged benchmarks revision 1. --~--~-~--~~~---~--~~ v8-dev mailing list v8-dev@googlegro

[v8-dev] Update benchmark page

2008-12-02 Thread christian . plesner . hansen
Reviewers: Mads Ager, Description: Added revisions page and moved change log there. Please review this at http://codereview.chromium.org/13046 Affected files: A benchmarks/revisions.html M benchmarks/run.html A benchmarks/style.css --~--~-~--~~~---~--~---

[v8-dev] [v8 commit] r887 - branches/bleeding_edge/src

2008-12-02 Thread codesite-noreply
Author: [EMAIL PROTECTED] Date: Tue Dec 2 01:50:39 2008 New Revision: 887 Modified: branches/bleeding_edge/src/runtime.cc Log: Optimization of single character indexOf. Gives small improvement on GCC4.2, but large improvement on GCC 4.3 (which was much worse on that particular code).

[v8-dev] [v8 commit] r899 - branches/bleeding_edge/tools/visual_studio

2008-12-02 Thread codesite-noreply
Author: [EMAIL PROTECTED] Date: Tue Dec 2 06:28:04 2008 New Revision: 899 Modified: branches/bleeding_edge/tools/visual_studio/v8_base.vcproj Log: Added regexp-macro-assembler-tracer .cc and .h files to Visual Studio project to make it build. Review URL: http://codereview.chromium.org/130

[v8-dev] * Changed search for single ASCII character to use memchr.

2008-12-02 Thread lrn
Reviewers: Christian Plesner Hansen, Message: Small review, please. Description: Optimization of single character indexOf. Gives small improvement on GCC4.2, but large improvement on GCC 4.3 (which was much worse on that particular code). Please review this at http://codereview.chromium.org/130

[v8-dev] Issue 111 in v8: Need access to the current line number from V8

2008-12-02 Thread codesite-noreply
Updates: Status: Fixed Comment #2 on issue 111 by [EMAIL PROTECTED]: Need access to the current line number from V8 http://code.google.com/p/v8/issues/detail?id=111 With r854 on bleeding edge V8 has a facility to get to debugging information from JavaScript function. This can be used

[v8-dev] [v8 commit] r892 - data/benchmarks/v2

2008-12-02 Thread codesite-noreply
Author: [EMAIL PROTECTED] Date: Tue Dec 2 02:16:53 2008 New Revision: 892 Removed: data/benchmarks/v2/ Log: Whoops. Removed benchmarks version 2 tag again. --~--~-~--~~~---~--~~ v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8

[v8-dev] Live counters in d8

2008-12-02 Thread christian . plesner . hansen
Reviewers: Feng Qian, Description: Added support in d8 for memory-mapped counters and added the python stats-viewer tool. Please review this at http://codereview.chromium.org/13050 Affected files: M src/d8.h M src/d8.cc M src/flag-definitions.h A tools/stats-viewer.py --~--~-

[v8-dev] [v8 commit] r890 - data/benchmarks/v2

2008-12-02 Thread codesite-noreply
Author: [EMAIL PROTECTED] Date: Tue Dec 2 02:09:44 2008 New Revision: 890 Added: data/benchmarks/v2/ - copied from r889, /branches/bleeding_edge/benchmarks/ Log: Created benchmarks revision 2 tag. --~--~-~--~~~---~--~~ v8-dev mailing list v8-dev@goo

[v8-dev] Re: * Changed search for single ASCII character to use memchr.

2008-12-02 Thread christian . plesner . hansen
Lgtm http://codereview.chromium.org/13045 --~--~-~--~~~---~--~~ v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev -~--~~~~--~~--~--~---

[v8-dev] [v8 commit] r894 - branches/bleeding_edge/src

2008-12-02 Thread codesite-noreply
Author: [EMAIL PROTECTED] Date: Tue Dec 2 02:19:10 2008 New Revision: 894 Modified: branches/bleeding_edge/src/runtime.cc Log: Builds on Windows too. Modified: branches/bleeding_edge/src/runtime.cc == --- branches

[v8-dev] [v8 commit] r884 - data/benchmarks

2008-12-02 Thread codesite-noreply
Author: [EMAIL PROTECTED] Date: Tue Dec 2 00:36:09 2008 New Revision: 884 Added: data/benchmarks/ Log: Created directory for benchmark versions. --~--~-~--~~~---~--~~ v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev -~-

[v8-dev] Re: Change Windows daylight saving time calculations to...

2008-12-02 Thread whesse
Recommended changes made. Other changes also made for correctness. Submitting. Please review again. http://codereview.chromium.org/12824 --~--~-~--~~~---~--~~ v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev -~--~~---

[v8-dev] [v8 commit] r888 - data/benchmarks/current

2008-12-02 Thread codesite-noreply
Author: [EMAIL PROTECTED] Date: Tue Dec 2 02:04:51 2008 New Revision: 888 Added: data/benchmarks/current/ - copied from r887, /data/benchmarks/v1/ Log: Created current benchmarks directory. --~--~-~--~~~---~--~~ v8-dev mailing list v8-dev@googlegrou

[v8-dev] Re: Regexp logging and stl

2008-12-02 Thread ager
LGTM! http://codereview.chromium.org/12861 --~--~-~--~~~---~--~~ v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev -~--~~~~--~~--~--~---

[v8-dev] Regexp logging and stl

2008-12-02 Thread christian . plesner . hansen
Reviewers: Mads Ager, Description: - Fixed regexp logging issue. - Removed use of std::set. Please review this at http://codereview.chromium.org/12861 Affected files: M src/jsregexp.h M src/jsregexp.cc M src/log.cc Index: src/jsregexp.cc diff --git a/src/jsregexp.cc b/src/jsregexp.cc

[v8-dev] [v8 commit] r883 - branches/bleeding_edge/src

2008-12-02 Thread codesite-noreply
Author: [EMAIL PROTECTED] Date: Tue Dec 2 00:16:12 2008 New Revision: 883 Modified: branches/bleeding_edge/src/jsregexp.cc branches/bleeding_edge/src/jsregexp.h branches/bleeding_edge/src/log.cc Log: - Fixed regexp logging issue. - Removed use of std::set. Modified: branches/bleed

[v8-dev] Re: Update benchmark page

2008-12-02 Thread ager
LGTM http://codereview.chromium.org/13046 --~--~-~--~~~---~--~~ v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev -~--~~~~--~~--~--~---

[v8-dev] [v8 commit] r891 - branches/bleeding_edge/benchmarks

2008-12-02 Thread codesite-noreply
Author: [EMAIL PROTECTED] Date: Tue Dec 2 02:14:03 2008 New Revision: 891 Modified: branches/bleeding_edge/benchmarks/revisions.html (props changed) Log: Set mime type on revisions.html. --~--~-~--~~~---~--~~ v8-dev mailing list v8-dev@googlegroups.com h

[v8-dev] Added regexp-macro-assembler-tracer .cc and .h files to Visual Studio project...

2008-12-02 Thread sgjesse
Reviewers: Lasse Reichstein, Description: Added regexp-macro-assembler-tracer .cc and .h files to Visual Studio project to make it build. Please review this at http://codereview.chromium.org/13047 SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/ Affected files: M tools/vis

[v8-dev] Issue 170 in v8: error building d8 console=readline on linux

2008-12-02 Thread codesite-noreply
Comment #1 on issue 170 by perrinmeyer: error building d8 console=readline on linux http://code.google.com/p/v8/issues/detail?id=170 of course the actual command line was $ scons d8 console=readline -- You received this message because you are listed in the owner or CC fields of this issu

[v8-dev] Re: Live counters in d8

2008-12-02 Thread feng
lgtm On 2008/12/02 15:23:03, Christian Plesner Hansen wrote: > http://codereview.chromium.org/13050 --~--~-~--~~~---~--~~ v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev -~--~~~~--~~--~--~---

[v8-dev] Re: Begin using the virtual frame for assignment statements of the form:...

2008-12-02 Thread iposva
http://codereview.chromium.org/10993/diff/1/5 File src/codegen-ia32.cc (right): http://codereview.chromium.org/10993/diff/1/5#newcode3112 Line 3112: frame_->SpillAll(); Is there a single call to Load in this file that is not followed by a frame_->SpillAll()? You should probably move the mandator

[v8-dev] [v8 commit] r902 - data/benchmarks/v2

2008-12-02 Thread codesite-noreply
Author: [EMAIL PROTECTED] Date: Tue Dec 2 23:54:20 2008 New Revision: 902 Added: data/benchmarks/v2/ - copied from r901, /branches/bleeding_edge/benchmarks/ Log: Updated benchmarks v2. --~--~-~--~~~---~--~~ v8-dev mailing list v8-dev@googlegroups.co

[v8-dev] [v8 commit] r901 - data/benchmarks/current

2008-12-02 Thread codesite-noreply
Author: [EMAIL PROTECTED] Date: Tue Dec 2 23:53:30 2008 New Revision: 901 Removed: data/benchmarks/current/ Log: Removed current benchmarks. --~--~-~--~~~---~--~~ v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev -~-