LGTM.
http://codereview.chromium.org/119358
--~--~-~--~~~---~--~~
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
-~--~~~~--~~--~--~---
Author: kmilli...@chromium.org
Date: Wed Jun 10 01:01:30 2009
New Revision: 2128
Modified:
branches/bleeding_edge/src/frames.cc
branches/bleeding_edge/src/ia32/codegen-ia32.cc
branches/bleeding_edge/src/ia32/frames-ia32.h
branches/bleeding_edge/src/ia32/macro-assembler-ia32.cc
LGTM.
http://codereview.chromium.org/114085/diff/2005/1008
File src/x64/assembler-x64.cc (right):
http://codereview.chromium.org/114085/diff/2005/1008#newcode902
Line 902: ASSERT(!Heap::InNewSpace(*value));
Is this from the ia32 code? I didn't know this. It makes sense, though
- we can't fix
Reviewers: Erik Corry, Kasper Lund,
Description:
Cleanup of ARM exception handlers. Remove the unused code and
parameter pointer slots. Change it so that the handler address no
longer points into the middle of the handler.
Please review this at http://codereview.chromium.org/119414
SVN Base:
LGTM.
http://codereview.chromium.org/119414/diff/1/8
File src/arm/frames-arm.h (right):
http://codereview.chromium.org/119414/diff/1/8#newcode330
Line 330: // C entry frames: When calling from JS to C, we construct one
extra
Unless you're sure this is still valid, I would remove the diagrams.
T
Ooops, I meant to do that (they're already gone from ia32). Thanks for the
catch.
On Wed, Jun 10, 2009 at 10:40 AM, wrote:
> LGTM.
>
>
> http://codereview.chromium.org/119414/diff/1/8
> File src/arm/frames-arm.h (right):
>
> http://codereview.chromium.org/119414/diff/1/8#newcode330
> Line 330:
Lasse, you may want to take a quick look at the x64 files.
http://codereview.chromium.org/119414
--~--~-~--~~~---~--~~
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
-~--~~~~--~~--~--~---
Author: kmilli...@chromium.org
Date: Wed Jun 10 02:00:07 2009
New Revision: 2129
Modified:
branches/bleeding_edge/src/arm/codegen-arm.cc
branches/bleeding_edge/src/arm/frames-arm.h
branches/bleeding_edge/src/arm/macro-assembler-arm.cc
branches/bleeding_edge/src/arm/virtual-frame-a
Status: Accepted
Owner:
Labels: Type-FeatureRequest Priority-Medium
New issue 375 by a...@chromium.org: Optimize handling of catch variables.
http://code.google.com/p/v8/issues/detail?id=375
Currently, we use special 'with' statements to implement catch variables.
If
there are no calls t
Updates:
Status: PendingFurtherInfo
Comment #1 on issue 374 by a...@chromium.org: Weird behaviour with
IndexedPropertyHandler
http://code.google.com/p/v8/issues/detail?id=374
Could you provide us with the full code for a reduced test case? That
would be very
helpful in finding out w
Author: l...@chromium.org
Date: Wed Jun 10 02:48:15 2009
New Revision: 2130
Modified:
branches/bleeding_edge/src/ia32/macro-assembler-ia32.h
branches/bleeding_edge/src/x64/assembler-x64-inl.h
branches/bleeding_edge/src/x64/assembler-x64.cc
branches/bleeding_edge/src/x64/assembler-
Author: erik.co...@gmail.com
Date: Wed Jun 10 03:20:37 2009
New Revision: 2131
Modified:
branches/bleeding_edge/src/arm/codegen-arm.cc
branches/bleeding_edge/src/code-stubs.h
branches/bleeding_edge/src/codegen.h
branches/bleeding_edge/src/d8.js
branches/bleeding_edge/src/ia32/
LGTM
http://codereview.chromium.org/119357
--~--~-~--~~~---~--~~
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
-~--~~~~--~~--~--~---
Regression test added. Also fixed some comments and whitespace typos.
http://codereview.chromium.org/119357/diff/1/3
File src/array.js (right):
http://codereview.chromium.org/119357/diff/1/3#newcode817
Line 817: delete obj[i];
On 2009/06/10 05:12:41, Lasse Reichstein wrote:
> For compatability
Comment #2 on issue 374 by whe...@chromium.org: Weird behaviour with
IndexedPropertyHandler
http://code.google.com/p/v8/issues/detail?id=374
If the functions _propGet() and _propSet() are member functions of the class
JSArray, they would not work correctly as callbacks, since they have an
im
Author: whe...@chromium.org
Date: Wed Jun 10 04:42:22 2009
New Revision: 2133
Modified:
branches/bleeding_edge/src/array.js
branches/bleeding_edge/src/objects.cc
branches/bleeding_edge/src/objects.h
branches/bleeding_edge/test/mjsunit/array-sort.js
Log:
Make Array.sort safely gen
Author: erik.co...@gmail.com
Date: Wed Jun 10 04:42:13 2009
New Revision: 2132
Modified:
branches/bleeding_edge/src/arm/builtins-arm.cc
branches/bleeding_edge/src/arm/codegen-arm.cc
branches/bleeding_edge/src/arm/ic-arm.cc
branches/bleeding_edge/src/arm/macro-assembler-arm.cc
Reviewers: Kasper Lund,
Description:
Fix a bug when shifting left by zero. Ensure that the left operand is
writable (non-aliased) so it can be used for the result in the slow
case.
Please review this at http://codereview.chromium.org/118496
SVN Base: http://v8.googlecode.com/svn/branches/blee
LGTM.
On Wed, Jun 10, 2009 at 2:39 PM, wrote:
> Reviewers: Kasper Lund,
>
> Description:
> Fix a bug when shifting left by zero. Ensure that the left operand is
> writable (non-aliased) so it can be used for the result in the slow
> case.
>
>
> Please review this at http://codereview.chromium.o
Author: kmilli...@chromium.org
Date: Wed Jun 10 05:41:57 2009
New Revision: 2134
Modified:
branches/bleeding_edge/src/ia32/codegen-ia32.cc
branches/bleeding_edge/test/mjsunit/smi-ops.js
Log:
Fix a bug when shifting left by zero. Ensure that the left operand is
writable (non-aliased) so
Reviewers: Mads Ager,
Description:
Version 1.2.7.1.
Merge bleeding_e...@2134 to trunk to fix code generation issue
with left shifts with zero. Regression test case added.
Please review this at http://codereview.chromium.org/118497
SVN Base: http://v8.googlecode.com/svn/trunk/
Affected files:
LGTM, thanks!
http://codereview.chromium.org/118497
--~--~-~--~~~---~--~~
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
-~--~~~~--~~--~--~---
Author: kasp...@chromium.org
Date: Wed Jun 10 05:48:11 2009
New Revision: 2135
Modified:
trunk/src/ia32/codegen-ia32.cc
trunk/src/version.cc
trunk/test/mjsunit/smi-ops.js
Log:
Version 1.2.7.1.
Merge bleeding_e...@2134 to trunk to fix code generation issue
with left shifts with zero.
Comment #3 on issue 374 by mattrochon: Weird behaviour with
IndexedPropertyHandler
http://code.google.com/p/v8/issues/detail?id=374
_propGet and _PropSet are defined as static methods. This afternoon I will
try to
isolate a test case for you.
--
You received this message because you are lis
Reviewers: Mads Ager,
http://codereview.chromium.org/118499/diff/1/3
File src/objects.cc (right):
http://codereview.chromium.org/118499/diff/1/3#newcode5215
Line 5215: int entry = dictionary->FindNumberEntry(index);
Code is now an exact copy of the same code in SetElement.
Description:
Make JS
Reviewers: William Hesse,
Description:
Fix fp code for mixed-endian ARM.
Please review this at http://codereview.chromium.org/119420
SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/
Affected files:
M src/arm/codegen-arm.cc
M src/objects.h
--~--~-~--~~
LGTM. How awful that there is that mixed-endian double representation.
http://codereview.chromium.org/119420
--~--~-~--~~~---~--~~
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
-~--~~~~--~~--~--~
http://codereview.chromium.org/118499/diff/1/3
File src/objects.cc (right):
http://codereview.chromium.org/118499/diff/1/3#newcode5215
Line 5215: int entry = dictionary->FindNumberEntry(index);
As we discussed, this is a significant amount of code and we should
refactor to share it.
http://code
Reviewers: Kasper Lund,
Description:
Get rid of the notion of "parameter pointer" that no longer exists in
the implementation but still lives on in comments and identifier
names.
Where it was used, it has been changed to "caller's stack pointer".
Please review this at http://codereview.chromium
LGTM.
http://codereview.chromium.org/118500
--~--~-~--~~~---~--~~
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
-~--~~~~--~~--~--~---
Reviewers: antonm,
Description:
Re-land patch r2110.
tbr=ant...@chromium.org
Please review this at http://codereview.chromium.org/118501
SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/
Affected files:
M src/ic.cc
M test/cctest/test-api.cc
Index: test/cctest/test
All changes made.
http://codereview.chromium.org/118499/diff/1/3
File src/objects.cc (right):
http://codereview.chromium.org/118499/diff/1/3#newcode5215
Line 5215: int entry = dictionary->FindNumberEntry(index);
On 2009/06/10 13:52:44, Mads Ager wrote:
> As we discussed, this is a significant a
Author: kasp...@chromium.org
Date: Wed Jun 10 07:45:46 2009
New Revision: 2136
Modified:
branches/bleeding_edge/src/ic.cc
branches/bleeding_edge/test/cctest/test-api.cc
Log:
Re-land patch r2110.
tbr=ant...@chromium.org
Review URL: http://codereview.chromium.org/118501
Modified: branche
Author: kmilli...@chromium.org
Date: Wed Jun 10 08:08:25 2009
New Revision: 2137
Modified:
branches/bleeding_edge/src/arm/codegen-arm.cc
branches/bleeding_edge/src/arm/frames-arm.h
branches/bleeding_edge/src/arm/macro-assembler-arm.cc
branches/bleeding_edge/src/arm/macro-assembler
LGTM once you remove the GetElementPostInterceptor method and its
declaration.
http://codereview.chromium.org/118499
--~--~-~--~~~---~--~~
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
-~--~~~~--~~---
Author: whe...@chromium.org
Date: Wed Jun 10 08:33:31 2009
New Revision: 2138
Modified:
branches/bleeding_edge/src/objects.cc
branches/bleeding_edge/src/objects.h
branches/bleeding_edge/test/cctest/test-api.cc
Log:
Make JSObjects with both indexed interceptors and indexed accessors w
Author: whe...@chromium.org
Date: Wed Jun 10 08:53:46 2009
New Revision: 2139
Modified:
branches/bleeding_edge/src/x64/assembler-x64.cc
branches/bleeding_edge/src/x64/assembler-x64.h
branches/bleeding_edge/src/x64/builtins-x64.cc
branches/bleeding_edge/src/x64/codegen-x64.cc
b
Updates:
Status: Fixed
Comment #3 on issue 346 by whe...@chromium.org: Crash [@
v8::internal::JSObject::LocalLookup] and CHECK(holder != __null) failed
http://code.google.com/p/v8/issues/detail?id=346
The bug has been fixed in V8 version 2133 with the patch at
http://codereview.chromiu
LGTM. Especially the changes to name the contents in the registers
instead of using result1 and result2 make the bit twiddling code a lot
more readable.
-Ivan
http://codereview.chromium.org/119420/diff/1/2
File src/objects.h (right):
http://codereview.chromium.org/119420/diff/1/2#newcode1175
Author: erik.co...@gmail.com
Date: Wed Jun 10 09:32:15 2009
New Revision: 2140
Modified:
branches/bleeding_edge/src/arm/codegen-arm.cc
branches/bleeding_edge/src/objects.h
Log:
Fix fp code for mixed-endian ARM.
Review URL: http://codereview.chromium.org/119420
Modified: branches/bleedin
40 matches
Mail list logo
