Comment #2 on issue 770 by vlovich: Please stabilize the SONAME
http://code.google.com/p/v8/issues/detail?id=770
You don't have to - someone already has.
http://ispras.linux-foundation.org/index.php/ABI_compliance_checker
I've used it to find ABI breakage on my components before - once you get
Comment #2 on issue 99 by vlovich: Detect whether g++ is installed
http://code.google.com/p/v8/issues/detail?id=99
It would be helpful if it detected the gcc version as well & set the
GCC_VERSION flag automatically.
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/grou
Added a tiny bit:
1. Added GET_ISOLATE(heap_pointer) macro, that does math on pointers to
convert
a heap pointer to isolate pointer w/o extra memory access
2. Started to comment all functions that have 'duplicate' that takes
Isolate*
and Heap* parameter with // TODO(Isolates): duplicate. s
Reviewers: Søren Gjesse, jschuh1,
http://codereview.chromium.org/2832095/diff/6001/7001
File src/platform-win32.cc (right):
http://codereview.chromium.org/2832095/diff/6001/7001#newcode846
src/platform-win32.cc:846: // TODO(pme...@chromium.org): Port to x64 and
Linux
On 2010/07/30 08:08:14, Sør
Updates:
Status: Duplicate
Mergedinto: 672
Comment #2 on issue 803 by lasserei...@gmail.com: //@ sourceURL should be
used in JS stacktrace
http://code.google.com/p/v8/issues/detail?id=803
(No comment was entered for this change.)
--
v8-dev mailing list
v8-dev@googlegroups.com
Comment #4 on issue 672 by lasserei...@gmail.com: Let the eval //@sourceURL
trick work for stack traces.
http://code.google.com/p/v8/issues/detail?id=672
Issue 803 has been merged into this issue.
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Updates:
Status: Accepted
Labels: Type-FeatureRequest
Comment #3 on issue 672 by lasserei...@gmail.com: Let the eval //@sourceURL
trick work for stack traces.
http://code.google.com/p/v8/issues/detail?id=672
WebKit/Safari is introducing support for sourceURL/displayName:
htt
Comment #4 on issue 802 by vlad...@gmail.com: Stack frame handler
corruption CHECK(frame->sp() <= handler->address()) failed
http://code.google.com/p/v8/issues/detail?id=802
Tested with bleeding edge 5161. Problem is fixed already...
--
v8-dev mailing list
v8-dev@googlegroups.com
http://grou
Tested with bleeding edge 5161. Problem is fixed already...
On Jul 30, 10:28 am, vlad wrote:
> Hi,
> Could you point me to the place where the arm code is generated for
> thread_local_.handler_ field updates.
> It seems like somewhere after rev 4875 it is not handled properly for
> arm based plat
Comment #3 on issue 797 by vlovich: v8 fails to compile with arm simulator
due to warnings
http://code.google.com/p/v8/issues/detail?id=797
Setting GCC_VERSION=44 fixed this. Thanks.
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Comment #2 on issue 797 by vlovich: v8 fails to compile with arm simulator
due to warnings
http://code.google.com/p/v8/issues/detail?id=797
$ gcc --version
gcc (Ubuntu 4.4.3-4ubuntu5) 4.4.3
Copyright (C) 2009 Free Software Foundation, Inc.
This is free software; see the source for copying con
I have two comments regarding this CL:
- You un-inlined function Size() which is not very heavily used by most
benchmarks but is heavily used in GC.
I applied your patch and ran oldspace. I observe 20% slowdown of marking
phase which uses Size() heavily. [this BTW corresponds to 5% degradation of
http://codereview.chromium.org/3047027/diff/16001/17006
File src/ic.cc (right):
http://codereview.chromium.org/3047027/diff/16001/17006#newcode574
src/ic.cc:574: AssertNoGC nogc; // GC could invalidate the pointers
held in lookup.
The comment implies that the nogc object should live as long as
http://codereview.chromium.org/3047027/diff/16001/17003
File src/heap.cc (right):
http://codereview.chromium.org/3047027/diff/16001/17003#newcode328
src/heap.cc:328: ASSERT(gc_allowed_);
maybe at the very start of the method?
http://codereview.chromium.org/3047027/diff/16001/17006
File src/ic.c
Hi,
Could you point me to the place where the arm code is generated for
thread_local_.handler_ field updates.
It seems like somewhere after rev 4875 it is not handled properly for
arm based platforms. I'm guessing it is related to inline cache
handling... StoreIC_Miss ???
Thanks
Vlad
--
v8-dev m
Comment #3 on issue 802 by vlad...@gmail.com: Stack frame handler
corruption CHECK(frame->sp() <= handler->address()) failed
http://code.google.com/p/v8/issues/detail?id=802
Last working rev that I tested was 4875. Please find attached simplified
test that fails as well on ARM.
Attachment
Comment #4 on issue 180 by ianbmacdonald: toLocaleDateString and
toLocaleTimeString do not honor the current locale
http://code.google.com/p/v8/issues/detail?id=180
"Currently, the formats used in toLocaleDateString and toLocaleTimeString
are hard-coded, but they should be locale-dependent" .
Status: New
Owner:
New issue 805 by pme...@chromium.org: Port manual heap randomization to x64
and Linux
http://code.google.com/p/v8/issues/detail?id=805
Manual heap randomization should be ported to x64 and Linux from
src/platform-win32.cc void* OS::Allocate()
--
v8-dev mailing lis
Comment #2 on issue 802 by vlad...@gmail.com: Stack frame handler
corruption CHECK(frame->sp() <= handler->address()) failed
http://code.google.com/p/v8/issues/detail?id=802
Tested rev 5133. Just checked rev 5033 and it works fine.
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups
Comment #1 on issue 798 by kpdecker: Reading Error.stack in a
__defineGetter__ callback causes inf loop or tab crash
http://code.google.com/p/v8/issues/detail?id=798
Similar issue with this code, but it is only executed 2 times instead of
infinite:
var x = 0;
TypeError.prototype.toString =
Addressed the comments.
Added AssertNoGC class to prohibit GC while the stubs are being compiled.
http://codereview.chromium.org/3047027/diff/1/2
File src/arm/stub-cache-arm.cc (right):
http://codereview.chromium.org/3047027/diff/1/2#newcode1258
src/arm/stub-cache-arm.cc:1258: __ Jump(Handle(Co
http://codereview.chromium.org/3047027/show
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
http://codereview.chromium.org/3047027/show
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Reviewers: Vladislav Kaznacheev,
Message:
lib8.a compiled in Linux reduced ~1%. Performance did not degrade.
Description:
Out of lining some methods.
Please review this at http://codereview.chromium.org/3015042/show
SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/
Affected files
LGTM.
As discussed offline, we probably need to add guards in ..IC::Load/Store..
methods.
http://codereview.chromium.org/3047027/diff/1/2
File src/arm/stub-cache-arm.cc (right):
http://codereview.chromium.org/3047027/diff/1/2#newcode1258
src/arm/stub-cache-arm.cc:1258: __ Jump(Handle(Code::cas
http://codereview.chromium.org/3047027/diff/1/2
File src/arm/stub-cache-arm.cc (right):
http://codereview.chromium.org/3047027/diff/1/2#newcode1292
src/arm/stub-cache-arm.cc:1292: Object* branch = GenerateMissBranch();
Well, the generator function doesn't return the branch code (in fact, it
real
LGTM.
http://codereview.chromium.org/204/diff/19001/14002
File src/fast-dtoa.cc (right):
http://codereview.chromium.org/204/diff/19001/14002#newcode490
src/fast-dtoa.cc:490: // * w is correct up to 1 ulp (unit in the last
place). That
What does this mean? w is the input. Isn't it exa
Reviewers: antonm, Vitaly,
Description:
Avoid GC when compiling CallIC stubs.
In rare cases GC could be called from ComputeCallMiss function thus
breaking CallIC::LoadFunction.
Please review this at http://codereview.chromium.org/3047027/show
SVN Base: http://v8.googlecode.com/svn/branches/bl
LGTM
http://codereview.chromium.org/3043032/show
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Reviewers: Vyacheslav Egorov,
Description:
Unicode: Reduced size of tables.
Please review this at http://codereview.chromium.org/3043032/show
Affected files:
M src/unicode.cc
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Revision: 5160
Author: peter.ry...@gmail.com
Date: Fri Jul 30 04:58:43 2010
Log: Roll over again fixed 3029033 Fix 'step in' after live edit stack
manipulation
Review URL: http://codereview.chromium.org/3066018
http://code.google.com/p/v8/source/detail?r=5160
Modified:
/branches/bleeding_edg
Updates:
Status: WorkingAsIntended
Comment #2 on issue 561 by sgje...@chromium.org: Compatibility patch for
MSVC 2003
http://code.google.com/p/v8/issues/detail?id=561
The V8 project will net be keep compatibility with MSVC 2003.
--
v8-dev mailing list
v8-dev@googlegroups.com
http://g
Revision: 5159
Author: sgje...@chromium.org
Date: Fri Jul 30 03:18:44 2010
Log: Tagging version 2.2.24.8
http://code.google.com/p/v8/source/detail?r=5159
Added:
/tags/2.2.24.8
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Revision: 5158
Author: sgje...@chromium.org
Date: Fri Jul 30 03:18:18 2010
Log: Merge r5118 to 2.2 branch to make it possible to build d8.
Review URL: http://codereview.chromium.org/3082005
http://code.google.com/p/v8/source/detail?r=5158
Modified:
/branches/2.2/src/version.cc
/branches/2.2/too
LGTM.
http://codereview.chromium.org/3082005/show
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
LGTM.
http://codereview.chromium.org/3082005/show
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Comment #1 on issue 780 by sgje...@chromium.org: freebsd build error
http://code.google.com/p/v8/issues/detail?id=780
What happens when you run
gcc -o obj/release/dtoa-config.o -c -Werror -Wno-uninitialized -m64 -O3
-fomit-frame-pointer -fdata-sections -ffunction-sections -ansi
-DV8_TARGET_
Reviewed up to, but not including, DigitGenCounted in fast-dtoa.cc.
http://codereview.chromium.org/204/diff/19001/14002
File src/fast-dtoa.cc (right):
http://codereview.chromium.org/204/diff/19001/14002#newcode78
src/fast-dtoa.cc:78: // ]w_low; w_low[ (often written as "(w_low;
w_low)")
Comment #1 on issue 797 by sgje...@chromium.org: v8 fails to compile with
arm simulator due to warnings
http://code.google.com/p/v8/issues/detail?id=797
What version of GCC are you using? If you are using 4.4 then the strict
aliasing issue can be resolved by by turning it off, see
http://
Updates:
Status: Fixed
Comment #6 on issue 773 by sgje...@chromium.org: Cannot build d8 on linux
by default
http://code.google.com/p/v8/issues/detail?id=773
The Python issue was fixed in bleeding_edge r5118 and pushed to trunk in
r5133 (version 2.3.3). Will be merged to the 2.2 bran
Revision: 5157
Author: sgje...@chromium.org
Date: Fri Jul 30 02:17:07 2010
Log: Tagging version 2.2.24.7
http://code.google.com/p/v8/source/detail?r=5157
Added:
/tags/2.2.24.7
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Reviewers: William Hesse,
Description:
Merge r5118 to 2.2 branch to make it possible to build d8.
Please review this at http://codereview.chromium.org/3082005/show
SVN Base: http://v8.googlecode.com/svn/branches/2.2/
Affected files:
M src/version.cc
M tools/js2c.py
Index: src/ver
Revision: 5156
Author: sgje...@chromium.org
Date: Fri Jul 30 02:10:05 2010
Log: Update version on 2.2 branch to 2.2.24.7 after r5146
Review URL: http://codereview.chromium.org/3060031
http://code.google.com/p/v8/source/detail?r=5156
Modified:
/branches/2.2/src/version.cc
===
LGTM.
http://codereview.chromium.org/3060031/show
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Reviewers: William Hesse,
Description:
Update version on 2.2 branch to 2.2.24.7 after r5146
Please review this at http://codereview.chromium.org/3060031/show
SVN Base: http://v8.googlecode.com/svn/branches/2.2/
Affected files:
M src/version.cc
Index: src/version.cc
LGTM
http://codereview.chromium.org/3066018/show
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
LGTM
http://codereview.chromium.org/3012035/show
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
OK
http://codereview.chromium.org/2870083/show
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
LGTM
http://codereview.chromium.org/3052026/show
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
OK
http://codereview.chromium.org/3031032/show
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
http://codereview.chromium.org/2832095/diff/6001/7001
File src/platform-win32.cc (right):
http://codereview.chromium.org/2832095/diff/6001/7001#newcode846
src/platform-win32.cc:846: // TODO(pme...@chromium.org): Port to x64 and
Linux
Please create an issue on code.google.com/p/v8 and change this
51 matches
Mail list logo
