http://codereview.chromium.org/3122025/diff/1/2
File src/date.js (right):
http://codereview.chromium.org/3122025/diff/1/2#newcode179
src/date.js:179: cache.increment = 19 * msPerDay;
On 2010/08/18 06:53:12, Kasper Lund wrote:
Maybe have the a cache.initialIncrement or initial_increment so we
d
Revision: 5289
Author: a...@chromium.org
Date: Wed Aug 18 00:01:07 2010
Log: Decrease the DST cache increment to take into account the suspension
of DST in Egypt during Ramadan 2010.
Review URL: http://codereview.chromium.org/3122025
http://code.google.com/p/v8/source/detail?r=5289
Modified:
/b
Updated with the fix for Egypt 2010 Ramadan suspension of DST
http://codereview.chromium.org/3186010/show
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
LGTM
http://codereview.chromium.org/3186010/show
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Since there is a criteria of not having overlapping it doesn't need to be
fixed.
Dismissing the change.
http://codereview.chromium.org/3131019/show
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
LGTM once the GCC 4.4 sentence has been completed. :)
http://codereview.chromium.org/3186010/diff/4001/5001
File ChangeLog (right):
http://codereview.chromium.org/3186010/diff/4001/5001#newcode5
ChangeLog:5: Removed specialized handling of GCC 4.4 by (issue 830).
Incomplete sentence.
http://co
Revision: 5290
Author: ri...@chromium.org
Date: Wed Aug 18 00:14:52 2010
Log: Prepare push of version 2.3.9 to trunk. Now working on versin 2.3.10.
Review URL: http://codereview.chromium.org/3186010
http://code.google.com/p/v8/source/detail?r=5290
Modified:
/branches/bleeding_edge/ChangeLog
/b
Reviewers: Rico,
Description:
Push fix for DST offsets to the 2.2 branch. This is only a problem in
Egypt because of suspended DST during Ramadan in 2010.
Please review this at http://codereview.chromium.org/3148020/show
SVN Base: http://v8.googlecode.com/svn/branches/2.2/
Affected files:
M
LGTM
http://codereview.chromium.org/3148020/show
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Revision: 5291
Author: a...@chromium.org
Date: Wed Aug 18 00:28:48 2010
Log: Push fix for DST offsets to the 2.2 branch. This is only a problem in
Egypt because of suspended DST during Ramadan in 2010.
Review URL: http://codereview.chromium.org/3148020
http://code.google.com/p/v8/source/detail?r=
Reviewers: Rico,
Description:
Push fix for DST offsets to the 2.1 branch. This is only a problem in
Egypt because of suspended DST during Ramadan in 2010.
Please review this at http://codereview.chromium.org/3169021/show
SVN Base: http://v8.googlecode.com/svn/branches/2.1/
Affected files:
M
LGTM
http://codereview.chromium.org/3169021/show
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
LGTM
http://codereview.chromium.org/3167021/show
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Revision: 5292
Author: a...@chromium.org
Date: Wed Aug 18 00:33:55 2010
Log: Tag version 2.2.24.16.
http://code.google.com/p/v8/source/detail?r=5292
Added:
/tags/2.2.24.16
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Revision: 5293
Author: a...@chromium.org
Date: Wed Aug 18 00:35:42 2010
Log: Push fix for DST offsets to the 2.1 branch. This is only a problem in
Egypt because of suspended DST during Ramadan in 2010.
Review URL: http://codereview.chromium.org/3169021
http://code.google.com/p/v8/source/detail?r=
Revision: 5294
Author: a...@chromium.org
Date: Wed Aug 18 00:36:34 2010
Log: Tag version 2.1.10.16.
http://code.google.com/p/v8/source/detail?r=5294
Added:
/tags/2.1.10.16
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Revision: 5296
Author: ri...@chromium.org
Date: Wed Aug 18 00:47:03 2010
Log: Tagging version 2.3.9
http://code.google.com/p/v8/source/detail?r=5296
Added:
/tags/2.3.9
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
LGTM
http://codereview.chromium.org/3161015/diff/10002/37005
File src/spaces.cc (right):
http://codereview.chromium.org/3161015/diff/10002/37005#newcode296
src/spaces.cc:296: #if defined(V8_REPORT_EXECUTABLE_MEMORY_USAGE)
I don't think we need this conditional compile unless this will have
perf
Revision: 5297
Author: mikhail.naga...@gmail.com
Date: Wed Aug 18 01:19:29 2010
Log: Heap profiler: allow returning aggregated snapshots via the new API.
This is intended for smoother migration to the new API in Chromium.
Also, aggregated heap snapshots can be used for cheaply obtaining
heap stat
Revision: 5298
Author: sgje...@chromium.org
Date: Wed Aug 18 01:54:25 2010
Log: Use consistent types when calling RegExpImpl::IrregexpExecOnce
Review URL: http://codereview.chromium.org/3167021
http://code.google.com/p/v8/source/detail?r=5298
Modified:
/branches/bleeding_edge/src/jsregexp.cc
/b
Without this change most of the tests crashed during heap teardown.
http://codereview.chromium.org/3161015/diff/10002/37005
File src/spaces.cc (right):
http://codereview.chromium.org/3161015/diff/10002/37005#newcode2617
src/spaces.cc:2617: Page* page = Page::FromAddress(chunk->address());
This
Status: New
Owner:
New issue 832 by rodolph.perfetta: Sunspider crypto-md5 and sha1 segfault
on ARM (issue with left shift)
http://code.google.com/p/v8/issues/detail?id=832
Two of the Sunspider tests crashes on ARM after revision 5273.
The revision gives more detailed typeinfo for shift
Paul,
all the work in v8 is done against bleeding edge branch. And twice a
week changes are brought to trunk.
yours,
anton.
On Tue, Aug 17, 2010 at 9:13 PM, wrote:
> 3030048
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
On 2010/08/18 09:36:26, Søren Gjesse wrote:
Without this change most of the tests crashed during heap teardown.
http://codereview.chromium.org/3161015/diff/10002/37005
File src/spaces.cc (right):
http://codereview.chromium.org/3161015/diff/10002/37005#newcode2617
src/spaces.cc:2617: Page* p
Revision: 5299
Author: sgje...@chromium.org
Date: Wed Aug 18 03:45:15 2010
Log: Tracks the maximum usage of executable memory allocated by V8 and
allows the histogram data to be gathered and reported.
This patch is contains only the usage tracking logic from 3030048 (already
LGTM'd). It does
Reviewers: Erik Corry,
Description:
Add useless code to ARM simulator to avoid getting bitten by GCC bug.
GCC Bug: http://gcc.gnu.org/bugzilla/show_bug.cgi?id=43949
Please review this at http://codereview.chromium.org/3104017/show
Affected files:
M src/arm/simulator-arm.cc
Index: src/arm/si
o Renamed kVariableSize to kVariableSizeSentinel.
o Added more comments.
o Completely removed SlowSizeFromMap.
Please take another look.
Thanks,
Vitaly
http://codereview.chromium.org/3127016/show
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Reviewers: Vyacheslav Egorov,
Message:
The change to spaces-inl.h:254 was not required to make it compile, but I
added
anyway.
Description:
Fix Windows x64 build broken by r5299.
Please review this at http://codereview.chromium.org/3158019/show
SVN Base: http://v8.googlecode.com/svn/branche
LGTM
http://codereview.chromium.org/3158019/show
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Revision: 5300
Author: sgje...@chromium.org
Date: Wed Aug 18 04:49:40 2010
Log: Fix Windows x64 build broken by r5299.
Review URL: http://codereview.chromium.org/3158019
http://code.google.com/p/v8/source/detail?r=5300
Modified:
/branches/bleeding_edge/src/spaces-inl.h
/branches/bleeding_edge/s
LGTM
http://codereview.chromium.org/3127016/show
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Revision: 5301
Author: vita...@chromium.org
Date: Wed Aug 18 06:00:38 2010
Log: Make instance_size immediately useful for all fixed size objects.
For variable sized objects this field doesn't really make any sense so
by putting a special value there we can improve SizeFromMap().
Review URL: http
Reviewers: Mads Ager,
Message:
Mads, a tiny review for you, if you please.
Description:
Remove unused typedef.
Please review this at http://codereview.chromium.org/3164022/show
Affected files:
M include/v8.h
Index: include/v8.h
diff --git a/include/v8.h b/include/v8.h
index
ff732269253e0
Reviewers: Kasper Lund, Vyacheslav Egorov, Erik Corry,
Message:
Erik: Could you take a look at the snapshot part?
Slave: Could you take a look at the GC part?
Kasper: Could you take a look at everything :-)
Description:
Change code pointer in function objects to a pointer to the first
instruct
LGTM
http://codereview.chromium.org/3164022/show
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Revision: 5302
Author: ant...@chromium.org
Date: Wed Aug 18 06:29:20 2010
Log: Remove unused typedef.
Review URL: http://codereview.chromium.org/3164022
http://code.google.com/p/v8/source/detail?r=5302
Modified:
/branches/bleeding_edge/include/v8.h
===
--- /
Status: Assigned
Owner: mikhail.naganov
CC: ant...@chromium.org
Labels: Type-Bug Priority-Medium OS-Linux
New issue 833 by mikhail.naganov: RecordStackTraceAtStartProfiling and
CrashIfStoppingLastNonExistentProfile stall if test.py is run in release
mode with -j value >> than CPU cores count
LGTM. Shouldn't it be possible to simplify the builtin function/code tables
and
only have the functions again?
http://codereview.chromium.org/3156028/diff/6002/12003
File src/arm/macro-assembler-arm.cc (right):
http://codereview.chromium.org/3156028/diff/6002/12003#newcode1501
src/arm/macro-a
Reviewers: Erik Corry,
Description:
Fix an issue in the ARM port where a left shift was predicted to have
a Smi result when it had an int32 result.
BUG=none
TEST=using the --nofull_compiler option, the following code should not
crash: "var s = 0x3fff; ((s << 1) + 0x00ff) > 0;"
Please r
Reviewers: Kasper Lund,
Description:
Refactor the tools/test.py script and related testcfg.py files.
This makes it possible to run several variants of the tests (with different
flags that is) by adding extra lists to the VARIANT_FLAGS list. In addition,
there is a number of smaller refactorings.
Reviewers: ,
Message:
I'm helping out with building Chrome using Clang and this broke the build
when
we rolled in a new V8 version the other day.
Description:
Fix two-phase lookup problem in FlexibleBodyVisitor and FixedBodyVisitor.
In FlexibleBodyVisitor and FixedBodyVisitor, the calls to I
LGTM
will land it.
http://codereview.chromium.org/3119026/show
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Comment #9 on issue 361 by timur...@google.com: ThreadSanitizer reports
dubious practices in V8
http://code.google.com/p/v8/issues/detail?id=361
One more (found on Chromium tests).
v8/src/v8threads.cc:
50 // Constructor for the Locker object. Once the Locker is constructed
the
51 // cu
Landed in r5303. Closing issue. Thanks for patch!
http://codereview.chromium.org/3119026/show
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Revision: 5303
Author: vego...@chromium.org
Date: Wed Aug 18 08:24:52 2010
Log: Fix two-phase lookup problem in FlexibleBodyVisitor and
FixedBodyVisitor.
In FlexibleBodyVisitor and FixedBodyVisitor, the calls to IteratePointers,
which lives in the base class BodyVisitorBase, needs to be
qu
Reviewers: antonm,
Description:
Fix issue 833: eliminate race condition in ProfilerEventsProcessor.
When under a load, the ProfilerEventsProcessor thread can start
(enter Run) after Stop has been called, thus resetting running_
data member back to 'true', and starting an infinite loop.
BUG=833
Reviewers: Vitaly,
Message:
Medium size, but not very complicated, review.
Description:
Use Copy-on-write arrays for cached regexp results.
Please review this at http://codereview.chromium.org/3158020/show
Affected files:
M src/arm/codegen-arm.h
M src/arm/codegen-arm.cc
M src/arm/full-co
LGTM and thanks.
yours,
anton.
On Wed, Aug 18, 2010 at 7:28 PM, wrote:
> Reviewers: antonm,
>
> Description:
> Fix issue 833: eliminate race condition in ProfilerEventsProcessor.
>
> When under a load, the ProfilerEventsProcessor thread can start
> (enter Run) after Stop has been called, thus r
Revision: 5304
Author: mikhail.naga...@gmail.com
Date: Wed Aug 18 08:36:00 2010
Log: Fix issue 833: eliminate race condition in ProfilerEventsProcessor.
When under a load, the ProfilerEventsProcessor thread can start
(enter Run) after Stop has been called, thus resetting running_
data member back
Driveby pendantry: The "running_" variable would now be better named
"may_run_" since it's true even before the event processor is running.
/L
On Wed, Aug 18, 2010 at 17:33, Anton Muhin wrote:
> LGTM and thanks.
>
> yours,
> anton.
>
> On Wed, Aug 18, 2010 at 7:28 PM, wrote:
> > Reviewers: an
http://codereview.chromium.org/3156028/diff/6002/12003
File src/arm/macro-assembler-arm.cc (right):
http://codereview.chromium.org/3156028/diff/6002/12003#newcode1501
src/arm/macro-assembler-arm.cc:1501:
On 2010/08/18 14:25:10, Kasper Lund wrote:
Extra newline here.
Done.
http://codereview.c
GC part LGTM
http://codereview.chromium.org/3156028/show
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
I agree. Will fix in the next change.
On Wed, Aug 18, 2010 at 19:38, Lasse R.H. Nielsen wrote:
> Driveby pendantry: The "running_" variable would now be better named
> "may_run_" since it's true even before the event processor is running.
> /L
>
> On Wed, Aug 18, 2010 at 17:33, Anton Muhin wrote
Updates:
Status: Fixed
Comment #1 on issue 833 by mikhail.naganov:
RecordStackTraceAtStartProfiling and CrashIfStoppingLastNonExistentProfile
stall if test.py is run in release mode with -j value >> than CPU cores
count
http://code.google.com/p/v8/issues/detail?id=833
Fixed in htt
LGTM with comments.
-- Vitaly
http://codereview.chromium.org/3158020/diff/1/2
File src/arm/codegen-arm.cc (right):
http://codereview.chromium.org/3158020/diff/1/2#newcode5301
src/arm/codegen-arm.cc:5301: __ ldm(ib, r0, r3.bit() | r4.bit() |
r5.bit() | r6.bit() | r7.bit());
See ia32 comments o
Reviewers: Vyacheslav Egorov,
Description:
Remove unused function.
Please review this at http://codereview.chromium.org/3107022/show
Affected files:
M src/objects.h
M src/objects.cc
Index: src/objects.cc
diff --git a/src/objects.cc b/src/objects.cc
index
87a7efd4940210d30be68cb8828625e3
Reviewers: Lasse Reichstein,
Message:
Old versions of gcc (e.g. 3.4.3) cannot differentiate between
template
inline Dest BitCast(const Source& source)
and
template
inline Dest BitCast(Source* const & source)
/home/jill/projects/node/deps/v8/src/factory.h:343: error: call of
overloaded `Bi
Kasper: Regarding the functions/code table for builtins, you are absolutely
right. I will do this in another change.
http://codereview.chromium.org/3156028/show
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
DBC:
http://codereview.chromium.org/3130033/diff/1/2
File src/utils.h (right):
http://codereview.chromium.org/3130033/diff/1/2#newcode744
src/utils.h:744: return
BitCast(reinterpret_cast(source));
Nit: Indentation is off here. Should be 2 spaces not 4.
http://codereview.chromium.org/3130033/sh
59 matches
Mail list logo
