Revision: 7313
Author: mm...@chromium.org
Date: Tue Mar 22 20:45:48 2011
Log: Implement poison pill for non-strict mode function.caller
when caller is strict mode function.
Review URL: http://codereview.chromium.org/6713059/
http://code.google.com/p/v8/source/detail?r=7313
Modified:
I take it back, sorry. I looked at it with -omit-frame-pointer turned off
and
then the changes do make a difference. They do not make a difference when I
enable this switch back, so this patch is perf-neutral. Lets not check it
in :-)
As a side note, my local testing on shell.exe shows we do
Reviewers: Vitaly Repeshko, Mads Ager,
Message:
We used to push Isolate pointer through into regexp generated code, and use
it
once inside. As it turned out, it is more expensive then to just pull
Isolate at
that one place (it's RegExpMacroAssemblerIA32::CheckStackGuardState etc).
This make
Reviewers: ,
Message:
The FACTORY macro (v8::internal::Isolate::Current()->factory()) is
unnecessarily
used in few cases in api.cc.
This macro should be changed to isolate->factory() where the current isolate
variable is avialable to avoid the unnecessary function calls.
(first attempt: http:
Updates:
Status: Invalid
Comment #1 on issue 1269 by a...@chromium.org: Remove redundant usage of
FACTORY macro in api.cc
http://code.google.com/p/v8/issues/detail?id=1269
Thanks for your patch.
Please use the procedure at http://code.google.com/p/v8/wiki/Contributing
for contribut
Code review feedback addressed
http://codereview.chromium.org/6715016/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Revision: 7312
Author: vita...@chromium.org
Date: Tue Mar 22 12:15:02 2011
Log: Some Isolate usage cleanups in objects.{h,cc}.
Review URL: http://codereview.chromium.org/6723001
http://code.google.com/p/v8/source/detail?r=7312
Modified:
/branches/bleeding_edge/src/objects-inl.h
/bra
LGTM!
http://codereview.chromium.org/6723001/diff/1/src/objects-inl.h
File src/objects-inl.h (right):
http://codereview.chromium.org/6723001/diff/1/src/objects-inl.h#newcode2856
src/objects-inl.h:2856:
isolate()->counters()->map_slow_to_fast_elements()->Increment();
Hey, that's part of my next
Reviewers: Mads Ager,
Description:
Some Isolate usage cleanups in objects.{h,cc}.
Please review this at http://codereview.chromium.org/6723001/
Affected files:
M src/objects-inl.h
M src/objects.h
M src/objects.cc
Index: src/objects-inl.h
diff --git a/src/objects-inl.h b/src/objects-inl.
Looks great!
http://codereview.chromium.org/6716023/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Revision: 7311
Author: dim...@chromium.org
Date: Tue Mar 22 11:44:32 2011
Log: Cleanup of Isolate usage (guided by SunSpider profiling)
Review URL: http://codereview.chromium.org/6718023
http://code.google.com/p/v8/source/detail?r=7311
Modified:
/branches/bleeding_edge/src/mark-compa
I would prefer not to do this. I would leave it to the developer to make
sure that the functions that he passes to sort are correctly bound to the
right things. That is the way JavaScript works and I don't think we should
attempt to hide that fact here?
Cheers,-- Mads
On Tue, Mar 22, 2011 at
On 2011/03/22 14:46:20, Vitaly Repeshko wrote:
http://codereview.chromium.org/6717018/diff/1/src/builtins.cc
File src/builtins.cc (right):
http://codereview.chromium.org/6717018/diff/1/src/builtins.cc#newcode1689
src/builtins.cc:1689: return
Handle(isolate->builtins()->builtin(name),
isolat
Revision: 7310
Author: podivi...@chromium.org
Date: Tue Mar 22 11:02:23 2011
Log: Fix crash in Debug::SendCommand.
R=vita...@chromium.org
BUG=
TEST=
Review URL: http://codereview.chromium.org/6715029
http://code.google.com/p/v8/source/detail?r=7310
Modified:
/branches/bleeding_edge/
Revision: 7309
Author: mm...@chromium.org
Date: Tue Mar 22 11:00:03 2011
Log: Merge TemporaryScope with LexicalScope.
http://code.google.com/p/v8/source/detail?r=7309
Modified:
/branches/bleeding_edge/src/parser.cc
/branches/bleeding_edge/src/parser.h
===
Status: New
Owner:
New issue 1269 by pva...@inf.u-szeged.hu: Remove redundant usage of FACTORY
macro in api.cc
http://code.google.com/p/v8/issues/detail?id=1269
The FACTORY macro (v8::internal::Isolate::Current()->factory()) is
unnecessarily used in few cases in api.cc.
This macro shou
Comment #2 on issue 1268 by petermar...@googlemail.com: Building for ARM
Platform fails
http://code.google.com/p/v8/issues/detail?id=1268
this helps, thx
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Florian, thanks for having a look!
When testing locally I see no differences in compilation time on average (as
reported by --hydrogen-stats).
Thanks,
Vitaly
http://codereview.chromium.org/6707001/diff/1/src/small-pointer-list.h
File src/small-pointer-list.h (right):
http://codereview.chromi
http://codereview.chromium.org/6715016/diff/1/src/api.cc
File src/api.cc (right):
http://codereview.chromium.org/6715016/diff/1/src/api.cc#newcode2049
src/api.cc:2049: i::Isolate* isolate = i::Isolate::Current();
On 2011/03/22 16:36:42, dslomov wrote:
On 2011/03/22 16:14:25, Vitaly Repeshko wro
http://codereview.chromium.org/6715016/diff/1/src/api.cc
File src/api.cc (right):
http://codereview.chromium.org/6715016/diff/1/src/api.cc#newcode2049
src/api.cc:2049: i::Isolate* isolate = i::Isolate::Current();
On 2011/03/22 16:14:25, Vitaly Repeshko wrote:
I think it's safe to move this to t
The question still stands, should we actually do this (.bind) or not, since
most
of the core API don't...
On 2011/03/22 16:04:17, Nebojša Ćirić wrote:
Also, defineProperty is part of Harmony but it seems only Opera doesn't
have
it
(FF4, IE9, Chrome 5 have it, and IE8 only for DOM).
On 20
http://codereview.chromium.org/6715016/diff/1/src/api.cc
File src/api.cc (right):
http://codereview.chromium.org/6715016/diff/1/src/api.cc#newcode2049
src/api.cc:2049: i::Isolate* isolate = i::Isolate::Current();
I think it's safe to move this to the "else" branch below. The fast case
doesn't re
Revision: 7308
Author: mikhail.naga...@gmail.com
Date: Tue Mar 22 09:10:01 2011
Log: Add support for CPU and heap profiles deletion.
R=vita...@chromium.org
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6685084
http://code.google.com/p/v8/source/detail?r=7308
Modified:
Also, defineProperty is part of Harmony but it seems only Opera doesn't
have it
(FF4, IE9, Chrome 5 have it, and IE8 only for DOM).
On 2011/03/22 16:02:58, Nebojša Ćirić wrote:
I've presented the problem to EcmaScript body, and they proposed 2
solutions.
Q:
So if we have something like
http://codereview.chromium.org/6685084/diff/3001/include/v8-profiler.h
File include/v8-profiler.h (right):
http://codereview.chromium.org/6685084/diff/3001/include/v8-profiler.h#newcode143
include/v8-profiler.h:143: void Delete() const;
On 2011/03/22 14:30:36, Vitaly Repeshko wrote:
"const" loo
I've presented the problem to EcmaScript body, and they proposed 2
solutions.
Q:
So if we have something like this:
LocaleInfo.Collator.prototype.compare = function(a, b) {
...
};
How do you specify it's bound by default?
A:
Two choices:
1) Don't put it on the prototype. Rather, make it p
LGTM
http://codereview.chromium.org/6715029/diff/1/src/api.cc
File src/api.cc (right):
http://codereview.chromium.org/6715029/diff/1/src/api.cc#newcode4910
src/api.cc:4910: i::Isolate* internal_isolate =
reinterpret_cast(isolate);
Replace tabs with spaces and fix indentation.
http://codereview
Reviewers: Vitaly Repeshko,
Description:
Fix crash in Debug::SendCommand.
R=vita...@chromium.org
BUG=
TEST=
Please review this at http://codereview.chromium.org/6715029/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M include/v8-debug.h
M src/api.cc
In
http://codereview.chromium.org/6716023/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Revision: 7307
Author: vita...@chromium.org
Date: Tue Mar 22 08:16:29 2011
Log: Remove TLS fetches in v8::String API implementation.
Patch by Dmitry Lomov.
Original review: http://codereview.chromium.org/6716004/
TBR=ager
Review URL: http://codereview.chromium.org/6716023
http://cod
Reviewers: ager_chromim.org,
Description:
Remove TLS fetches in v8::String API implementation.
Patch by Dmitry Lomov.
Original review: http://codereview.chromium.org/6716004/
TBR=ager
Please review this at http://codereview.chromium.org/6716023/
Affected files:
M src/api.cc
Index: src/ap
Reviewers: Kevin Millikin,
Message:
RFC: Only ia32 for now.
We should also discuss what to do for stores.
Description:
Enable GVN for polymorphic loads by not expanding them at the HIR level.
This change adds a new IR instruction for polymorphic loads. It performs
map compares and loads in one
http://codereview.chromium.org/6717018/diff/1/src/builtins.cc
File src/builtins.cc (right):
http://codereview.chromium.org/6717018/diff/1/src/builtins.cc#newcode1689
src/builtins.cc:1689: return
Handle(isolate->builtins()->builtin(name), isolate);
I think we can reuse builtin address to avoid al
LGTM! I'll land.
Thanks,
Vitaly
http://codereview.chromium.org/6716004/diff/4001/src/api.cc
File src/api.cc (right):
http://codereview.chromium.org/6716004/diff/4001/src/api.cc#newcode3919
src/api.cc:3919: EnsureInitializedForIsolate(isolate,
"v8::String::New()");
The string tags are wrong he
LGTM
http://codereview.chromium.org/6685084/diff/3001/include/v8-profiler.h
File include/v8-profiler.h (right):
http://codereview.chromium.org/6685084/diff/3001/include/v8-profiler.h#newcode143
include/v8-profiler.h:143: void Delete() const;
"const" looks weird here.
http://codereview.chromium
Reviewers: Erik Corry,
Description:
Preserve marking bits across scavenges if incremental marker is running.
This avoids hurry if incremental marking did not complete before scavenge.
Please review this at http://codereview.chromium.org/6715028/
SVN Base: https://v8.googlecode.com/svn/branches
Updates:
Status: Fixed
Comment #1 on issue 1267 by whe...@chromium.org: cctest
test-reloc-info/Positions is failing on Windows x64 build
http://code.google.com/p/v8/issues/detail?id=1267
Fixed in bleeding-edge r7302. The reloc-info iterators were reading
uninitialized memory becaus
I can't get rid of movq(Register, ExternalReference) yet, since I didn't
change
codegen-x64.cc (soon to be dead anyway) and I probably left a few uses in
debug-only code as well.
However, I do think it's a good idea for a future patch.
http://codereview.chromium.org/6716018/diff/1/src/x64/
Revision: 7306
Author: sgje...@chromium.org
Date: Tue Mar 22 07:11:08 2011
Log: Use different syscall constants on Android
Review URL: http://codereview.chromium.org/6716021
http://code.google.com/p/v8/source/detail?r=7306
Modified:
/branches/bleeding_edge/src/platform-linux.cc
=
LGTM
http://codereview.chromium.org/6716021/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
LGTM.
Shouldn't you get rid of
movq(Register, ExternalReference), and eliminate all uses of it, or make it
protected? Your new functions should be able to replace all uses of it,
right?
http://codereview.chromium.org/6716018/diff/1/src/x64/deoptimizer-x64.cc
File src/x64/deoptimizer-x64.cc
LGTM
http://codereview.chromium.org/6713074/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Reviewers: Mads Ager,
Description:
Use different syscall constants on Android
Please review this at http://codereview.chromium.org/6716021/
SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/
Affected files:
M src/platform-linux.cc
Index: src/platform-linux.cc
==
LGTM
http://codereview.chromium.org/6676084/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
http://codereview.chromium.org/6718023/diff/1/src/spaces.h
File src/spaces.h (right):
http://codereview.chromium.org/6718023/diff/1/src/spaces.h#newcode1740
src/spaces.h:1740: explicit OldSpaceFreeList(Heap* heap, AllocationSpace
owner);
"explicit" no longer required.
http://codereview.chromium
LGTM
http://codereview.chromium.org/6718023/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
LGTM
http://codereview.chromium.org/6716012/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
LGTM
http://codereview.chromium.org/6708070/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
LGTM
http://codereview.chromium.org/6676076/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Reviewers: Vitaly Repeshko,
Description:
Introduce a static method Builtins::builtin to get builtins without TLS
access.
R=vita...@chromium.org
Please review this at http://codereview.chromium.org/6717018/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M
Revision: 7304
Author: sgje...@chromium.org
Date: Tue Mar 22 04:58:03 2011
Log:
Add file missing from last commit
TBR=a...@chromium.org
Review URL: http://codereview.chromium.org/6715026
http://code.google.com/p/v8/source/detail?r=7304
Modified:
/branches/bleeding_edge/src/safepoint-table
LGTM
http://codereview.chromium.org/6715026/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Revision: 7303
Author: ant...@chromium.org
Date: Tue Mar 22 04:52:38 2011
Log: Shorten bail out checks when calling code which can fail.
Review URL: http://codereview.chromium.org/6713004
http://code.google.com/p/v8/source/detail?r=7303
Modified:
/branches/bleeding_edge/src/arm/stub-
Reviewers: Mads Ager,
Description:
Add file missing from last commit
TBR=a...@chromium.org
Please review this at http://codereview.chromium.org/6715026/
SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/
Affected files:
M src/safepoint-table.h
Index: src/safepoint-table.h
Revision: 7302
Author: whe...@chromium.org
Date: Tue Mar 22 04:51:16 2011
Log: Fix error in test-reloc-info/Positions. This error caused a
failure on Windows 64-bit V8.
BUG=1267
TEST=test-reloc-info/Positions
Review URL: http://codereview.chromium.org/6719022
http://code.google.co
Revision: 7301
Author: sgje...@chromium.org
Date: Tue Mar 22 04:50:39 2011
Log: Rename memory.h to v8memory.h
This is to avoid name collision with system include file named memory.h
causing problems on some platforms.
Review URL: http://codereview.chromium.org/6716020
http://code.go
Changed to 10 * KB.
On 2011/03/22 11:42:44, Lasse Reichstein wrote:
LGTM
http://codereview.chromium.org/6719022/diff/1/test/cctest/test-reloc-info.cc
File test/cctest/test-reloc-info.cc (right):
http://codereview.chromium.org/6719022/diff/1/test/cctest/test-reloc-info.cc#newcode45
test/cc
LGTM
http://codereview.chromium.org/6716020/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Reviewers: Mads Ager,
Description:
Rename memory.h to v8memory.h
This is to avoid name collision with system include file named memory.h
causing
problems on some platforms.
Please review this at http://codereview.chromium.org/6716020/
SVN Base: http://v8.googlecode.com/svn/branches/bleeding
Reviewers: William Hesse,
Description:
X64: Optimize access to external references.
Access to an ExternalReference in non-serializable code will try to use
an offset relative to the root-array register.
Since the root-array is in the Heap object, and the Heap object is in
the Isolate object, the
LGTM
http://codereview.chromium.org/6719022/diff/1/test/cctest/test-reloc-info.cc
File test/cctest/test-reloc-info.cc (right):
http://codereview.chromium.org/6719022/diff/1/test/cctest/test-reloc-info.cc#newcode45
test/cctest/test-reloc-info.cc:45: const int code_size = 10 << 10;
Odd way to wri
Reviewers: Lasse Reichstein,
Message:
This test was reading uninitialized data from the buffer using a
RelocIterator.
Fixed so only the written relocation
info is read, not extra unused bytes.
Description:
Fix error in test-reloc-info/Positions. This error caused a failure on
Windows
64-b
Thanks a lot for review, Mads and Vitaly.
http://codereview.chromium.org/6685087/diff/7001/src/api.cc
File src/api.cc (right):
http://codereview.chromium.org/6685087/diff/7001/src/api.cc#newcode2784
src/api.cc:2784: static Local GetPropertyByLookup(i::Isolate*
isolate,
On 2011/03/22 07:32:14, M
Ported to other platforms. I'd like to get this in and then iterate when/if
we
find a better solution.
http://codereview.chromium.org/6713074/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Added Kevin.
It seems to be a good idea to have a compact data structure for one-element
use-lists. Did you see any difference in compile-time?
Kevin and me were discussing representing uses not just as HValue*, but as a
pair (HValue*, operand_index) instead. This would allow us to simplify the
LGTM
Committed: http://code.google.com/p/v8/source/detail?r=7300
Thank you for the patch.
http://codereview.chromium.org/6676060/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Revision: 7300
Author: sgje...@chromium.org
Date: Tue Mar 22 03:00:43 2011
Log: Improved modulo operation in lithium as well as bailout on -0.
TEST=none
BUG=none
Patch by Rodolph Perfetta from ARM Ltd.
Review URL: http://codereview.chromium.org/6612017
http://code.google.com/p/v8/so
LGTM
http://codereview.chromium.org/6685087/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
LGTM
http://codereview.chromium.org/6685087/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
http://codereview.chromium.org/6713074/diff/1/src/assembler.h
File src/assembler.h (right):
http://codereview.chromium.org/6713074/diff/1/src/assembler.h#newcode504
src/assembler.h:504: explicit ExternalReference(Builtins::CFunctionId
id, Isolate* isolate);
On 2011/03/21 17:06:57, Vitaly Repeshk
This is mainly needed for heap snapshots, as they consume significant
amounts of
memory on engine side, but I added support for CPU profiles deletion as
well.
The approach isn't ideal, as after deleting a profile, embedder will get
stale
pointers for previously retrieved nodes etc., but I d
Updates:
Status: Fixed
Comment #5 on issue 1263 by mikhail@gmail.com:
cctest/test-cpu-profiler/CrashIfStoppingLastNonExistentProfile time outs on
Linux after Isolates
http://code.google.com/p/v8/issues/detail?id=1263
I see no timeouts after I have enabled the tests back in
htt
Updates:
Status: Fixed
Comment #4 on issue 1262 by mikhail@gmail.com:
cctest/test-profile-generator/RecordStackTraceAtStartProfiling time outs on
Linux after Isolates
http://code.google.com/p/v8/issues/detail?id=1262
I see no timeouts after I have enabled the tests back in
htt
LGTM
http://codereview.chromium.org/6685087/diff/7001/src/api.cc
File src/api.cc (right):
http://codereview.chromium.org/6685087/diff/7001/src/api.cc#newcode2784
src/api.cc:2784: static Local GetPropertyByLookup(i::Isolate*
isolate,
The isolate parameter is not used. Remove?
http://codereview.
74 matches
Mail list logo
