Revision: 8067
Author: sgje...@chromium.org
Date: Thu May 26 00:02:35 2011
Log: MIPS: port Fix GC-unsafe corner case in bit-not on ARM.
Port r8055 to mips.
(5b50df9c)
BUG=
TEST=
Review URL: http://codereview.chromium.org//7075003
http://code.google.com/p/v8/source/detail?r=8067
Modi
STV
http://codereview.chromium.org/7069017/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
LGTM
I will address the i -> I and commit.
http://codereview.chromium.org/7062014/diff/1/src/mips/simulator-mips.h
File src/mips/simulator-mips.h (right):
http://codereview.chromium.org/7062014/diff/1/src/mips/simulator-mips.h#newcode292
src/mips/simulator-mips.h:292: // Stop helper functions.
The right fix seems to be adding value contexts in the full code generator,
not
removing context in crankshaft, so I'll close this issue.
http://codereview.chromium.org/7008009/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
http://codereview.chromium.org/6930006/diff/2001/src/objects.h
File src/objects.h (right):
http://codereview.chromium.org/6930006/diff/2001/src/objects.h#newcode577
src/objects.h:577: // Boundary for promotion to old data
ia32-v8-buildspace/old pointer space.
Argh. Fixed.
http://codereview.chro
Revision: 8068
Author: l...@chromium.org
Date: Thu May 26 00:35:09 2011
Log: Make RegExp objects not callable.
Review URL: http://codereview.chromium.org/6930006
http://code.google.com/p/v8/source/detail?r=8068
Deleted:
/branches/bleeding_edge/test/mjsunit/override-eval-with-non-func
Revision: 8069
Author: sgje...@chromium.org
Date: Thu May 26 00:46:18 2011
Log: MIPS: Added the stop() instruction with same behavior as on Arm
simulator.
The already working watchpoint break mechanism has been extended to
handle "stop" instructions, with text messages.
Explanat
LGTM with superficial comments below.
http://codereview.chromium.org/6961019/diff/11001/src/arm/lithium-arm.cc
File src/arm/lithium-arm.cc (right):
http://codereview.chromium.org/6961019/diff/11001/src/arm/lithium-arm.cc#newcode1775
src/arm/lithium-arm.cc:1775: LDoubleToI* res = new LDoubleToI(
Rubber stamp LGTM. Push the button!
http://codereview.chromium.org/7053013/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
LGTM
http://codereview.chromium.org/7068009/diff/1/src/compiler.h
File src/compiler.h (right):
http://codereview.chromium.org/7068009/diff/1/src/compiler.h#newcode92
src/compiler.h:92: void MarkAsES5Native() {
Why ES5Native and not just Native?
Is there any native code that isn't ES5Native?
ht
Updates:
Status: Invalid
Comment #1 on issue 1408 by a...@chromium.org: Document the status/roadmap
or position with regard to ECMAScript 5, or better implement ECMAScript 5
http://code.google.com/p/v8/issues/detail?id=1408
V8 implements the EcmaScript 262 5th edition. If you find par
Reviewers: fschneider,
Description:
Do not allow inlining functions with direct arguments access.
Our implementations of arguments without materializing the arguments
object (based on inspecting the stack frame) does not work for inlined
functions. Guard all attempts by disallowing them if poss
LGTM.
Den 26. maj 2011 11.21 skrev :
> Reviewers: fschneider,
>
> Description:
> Do not allow inlining functions with direct arguments access.
>
> Our implementations of arguments without materializing the arguments
> object (based on inspecting the stack frame) does not work for inlined
> functi
The set trap looks good to me. I've solicited some more feedback on the
name
changes to make sure we get them approximately right, so let's wait a short
bit
before committing.
http://codereview.chromium.org/6992072/diff/1/include/v8.h
File include/v8.h (right):
http://codereview.chromium.o
http://codereview.chromium.org/7068009/diff/1/src/compiler.h
File src/compiler.h (right):
http://codereview.chromium.org/7068009/diff/1/src/compiler.h#newcode92
src/compiler.h:92: void MarkAsES5Native() {
On 2011/05/26 08:26:55, Lasse Reichstein wrote:
Why ES5Native and not just Native?
Is ther
LGTM.
http://codereview.chromium.org/6976022/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Added updated sputnik test expectations. A bunch of tests expect call of
builtins through variables to pass in the global object which was true in
ES3
but no longer in ES5.
http://codereview.chromium.org/7068009/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8
Reviewers: Lasse Reichstein, Rico,
Description:
JSON.stringify improvement. Fast case in C++ for string arrays.
Please review this at http://codereview.chromium.org/7077004/
SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/
Affected files:
M src/json.js
M src/runtime.h
Reviewers: William Hesse,
Description:
Add a simple test for inlining of arguments accesses.
R=whe...@chromium.org
BUG=
TEST=
Please review this at http://codereview.chromium.org/7062018/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
A test/mjsunit/compile
Revision: 8071
Author: vego...@chromium.org
Date: Thu May 26 03:47:57 2011
Log: Update write-barrier when short-circuiting strings during
scavenge.
TEST=test/mjsunit/regress/short-circuit.js
Review URL: http://codereview.chromium.org/7069017
http://code.google.com/p/v8/source/detai
LGTM.
http://codereview.chromium.org/7062018/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Reviewers: Lasse Reichstein,
Description:
Revert "Pass undefined to JS builtins when called with implicit receiver."
Presubmit and failing test.
TBR=l...@chromium.org
BUG=
TEST=
Please review this at http://codereview.chromium.org/7071009/
SVN Base: https://v8.googlecode.com/svn/branches/ble
LGTM
http://codereview.chromium.org/7077004/diff/3001/src/runtime.cc
File src/runtime.cc (right):
http://codereview.chromium.org/7077004/diff/3001/src/runtime.cc#newcode3538
src/runtime.cc:3538: ASSERT(2 <= radix && radix <= 36);
ASSERT -> RUNTIME_ASSERT
http://codereview.chromium.org/7077004/
http://codereview.chromium.org/7077004/diff/3001/src/runtime.cc
File src/runtime.cc (right):
http://codereview.chromium.org/7077004/diff/3001/src/runtime.cc#newcode3538
src/runtime.cc:3538: ASSERT(2 <= radix && radix <= 36);
On 2011/05/26 11:24:43, Lasse Reichstein wrote:
ASSERT -> RUNTIME_ASSE
Reviewers: Erik Corry,
Description:
Fix gc-nvp-trace-processor.py after merge.
TBR=erik.co...@gmail.com
Please review this at http://codereview.chromium.org/6976023/
SVN Base: https://v8.googlecode.com/svn/branches/experimental/gc
Affected files:
M tools/gc-nvp-trace-processor.py
Index: t
Revision: 8072
Author: kmilli...@chromium.org
Date: Thu May 26 03:56:07 2011
Log: Do not allow inlining functions with direct arguments access.
Our implementations of arguments without materializing the arguments
object (based on inspecting the stack frame) does not work for inlined
fu
Reviewers: Lasse Reichstein,
Message:
I think this is dead code.
Description:
Remove unused DummyScope implementation.
R=l...@chromium.org
BUG=
TEST=
Please review this at http://codereview.chromium.org/7062020/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
Comment #6 on issue 1394 by fschnei...@chromium.org: PC emulator is about 2
times slower using V8 than Jaeger Monkey
http://code.google.com/p/v8/issues/detail?id=1394
Chrome 12 (beta, Windows) should also work fine.
We're still working on speed improvements.
--
v8-dev mailing list
v8-dev@go
Reviewers: Erik Corry,
Description:
Fix bogus assertion in DiscoverGreyObjectsOnPage.
TBR=erik.co...@gmail.com
Please review this at http://codereview.chromium.org/7071012/
SVN Base: https://v8.googlecode.com/svn/branches/experimental/gc
Affected files:
M src/mark-compact.cc
Index: src/ma
lgtm
http://codereview.chromium.org/7071012/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Reviewers: Søren Gjesse,
Description:
Simplify the Scope API.
Eliminate the LocalType enum in favor of a pair of functions, one for var
and const declarations and one for parameters. Move the responsibility for
adding a parameter variable to the Scope's internal data structure into the
Scope an
Status: Assigned
Owner: vego...@chromium.org
Labels: Type-Bug Priority-Medium ExperimentalGC
New issue 1409 by jkumme...@chromium.org: ExperimentalGC branch crashes
when trying to load Mandreel demo (case 1).
http://code.google.com/p/v8/issues/detail?id=1409
Steps to reproduce:
Using the Expe
LGTM.
More changes like this!
http://codereview.chromium.org/7062020/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Status: Assigned
Owner: vego...@chromium.org
Labels: Type-Bug Priority-Medium ExperimentalGC
New issue 1410 by jkumme...@chromium.org: ExperimentalGC branch crashes
when trying to load Mandreel demo (case 2).
http://code.google.com/p/v8/issues/detail?id=1410
Steps to reproduce:
Using the Expe
Updates:
Status: Fixed
Comment #1 on issue 1409 by vego...@chromium.org: ExperimentalGC branch
crashes when trying to load Mandreel demo (case 1).
http://code.google.com/p/v8/issues/detail?id=1409
Bogus assertion fixed in r8079.
--
v8-dev mailing list
v8-dev@googlegroups.com
http:/
Revision: 8076
Author: vego...@chromium.org
Date: Thu May 26 04:43:24 2011
Log: Fix gc-nvp-trace-processor.py after merge.
TBR=erik.co...@gmail.com
Review URL: http://codereview.chromium.org/6976023
http://code.google.com/p/v8/source/detail?r=8076
Modified:
/branches/experimental/gc
A quick round of comments.
http://codereview.chromium.org/6992072/diff/4002/src/arm/builtins-arm.cc
File src/arm/builtins-arm.cc (right):
http://codereview.chromium.org/6992072/diff/4002/src/arm/builtins-arm.cc#newcode953
src/arm/builtins-arm.cc:953: __ b(ge, &exit);
Not your code, but these co
Reviewers: Erik Corry,
Description:
ARM: Avoid using ldrd/strd with post increment
These instructions seems to cause problems in some situations. This reverts
parts of r7873.
R=erik.co...@gmail.com
BUG=none
TEST=none
Please review this at http://codereview.chromium.org/6962010/
SVN Base: ht
LGTM
http://codereview.chromium.org/6962010/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Reviewers: William Hesse,
Description:
Double allocation size for special json strings on every resize (fixes
crbug 83877)
The issue was that with the relatively small start and increment size of the
string we created a ton of string handles when scanning a large string with
special characters (
LGTM
http://codereview.chromium.org/6976025/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
LGTM, except that delta is wrong where noted.
http://codereview.chromium.org/7075009/diff/1/src/json-parser.cc
File src/json-parser.cc (right):
http://codereview.chromium.org/7075009/diff/1/src/json-parser.cc#newcode455
src/json-parser.cc:455: Address start_filler_object =
seq_two_byte->address
http://codereview.chromium.org/7075009/diff/1/src/json-parser.cc
File src/json-parser.cc (right):
http://codereview.chromium.org/7075009/diff/1/src/json-parser.cc#newcode455
src/json-parser.cc:455: Address start_filler_object =
seq_two_byte->address() + delta;
On 2011/05/26 14:00:52, William Hes
Reviewers: Mads Ager,
Message:
Will merge to 3.3 as well
Description:
Merge revision 8082 to trunk (fixes crbug 83877)
Please review this at http://codereview.chromium.org/6976027/
SVN Base: http://v8.googlecode.com/svn/trunk/
Affected files:
M src/json-parser.h
M src/json-parser.
Thanks, LGTM
http://codereview.chromium.org/6976027/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Reviewers: Mads Ager,
Description:
Merge revision 8082 to 3.3 branch (fixes crbug 83877)
Please review this at http://codereview.chromium.org/7075011/
SVN Base: http://v8.googlecode.com/svn/branches/3.3/
Affected files:
M src/json-parser.h
M src/json-parser.cc
M src/version.c
Reviewers: Erik Corry,
Description:
Merge r8080 to the 3.3 branch
r8080:
ARM: Avoid using ldrd/strd with post increment
These instructions seems to cause problems in some situations. This reverts
parts of r7873.
R=erik.co...@gmail.com
BUG=none
TEST=none
Please review this at http://coderevie
LGTM.
http://codereview.chromium.org/6976029/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
LGTM
http://codereview.chromium.org/7075011/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Reviewers: fschneider, Kevin Millikin,
Description:
Reduced the code ping-pong between the full code generator and contexts a
bit.
* Centralized AND/OR handling, keeping related code together.
* Removed HandleExpression/HandleInNonTestContext and introduced
VisitInSameContext instead, making
Reviewers: Rico,
Message:
TBR=ricow
Description:
Fix Win compilation issue introduced in r8081.
Please review this at http://codereview.chromium.org/7074009/
SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/
Affected files:
M src/runtime.cc
Index: src/runtime.cc
=
Revision: 8078
Author: da...@chromium.org
Date: Thu May 26 05:16:13 2011
Log: Fix stray character in last build
TBR=kmilli...@chromium.org
http://code.google.com/p/v8/source/detail?r=8078
Modified:
/branches/bleeding_edge/src/arm/lithium-arm.cc
==
LGTM
http://codereview.chromium.org/7074009/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
http://codereview.chromium.org/7074009/diff/1/src/runtime.cc
File src/runtime.cc (right):
http://codereview.chromium.org/7074009/diff/1/src/runtime.cc#newcode5112
src/runtime.cc:5112: *(write_cursor++) = static_cast(c);
Well actually, consider making a comment why this always goes well
http://c
Status: Accepted
Owner: vego...@chromium.org
CC: ri...@chromium.org
Labels: Type-Bug Priority-Medium
New issue 1411 by ri...@chromium.org: Assertion failure in
cctest/test-lockers/SeparateIsolatesLocksNonexclusive
http://code.google.com/p/v8/issues/detail?id=1411
This test fails in debug mode
Status: Accepted
Owner: a...@chromium.org
Labels: Type-Bug Priority-Medium ES5
New issue 1412 by a...@chromium.org: Apply with arguments optimization
needs updating for ES5
http://code.google.com/p/v8/issues/detail?id=1412
The apply with arguments optimization converts undefined and null to t
Updates:
Labels: Experimental-GC
Comment #1 on issue 1411 by ri...@chromium.org: Assertion failure in
cctest/test-lockers/SeparateIsolatesLocksNonexclusive
http://code.google.com/p/v8/issues/detail?id=1411
(No comment was entered for this change.)
--
v8-dev mailing list
v8-dev@google
Updates:
Labels: -Experimental-GC ExperimentalGC
Comment #2 on issue 1411 by vego...@chromium.org: Assertion failure in
cctest/test-lockers/SeparateIsolatesLocksNonexclusive
http://code.google.com/p/v8/issues/detail?id=1411
(No comment was entered for this change.)
--
v8-dev mailing
Comment #3 on issue 1411 by kasp...@chromium.org: Assertion failure in
cctest/test-lockers/SeparateIsolatesLocksNonexclusive
http://code.google.com/p/v8/issues/detail?id=1411
Just hit this assertion in Gmail too. No repro yet.
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.goog
Revision: 8077
Author: da...@chromium.org
Date: Thu May 26 05:07:22 2011
Log: Prevent deopt on double value assignment to typed arrays
Implement truncation of double and tagged values when assigning to an
element of a typed arrays in order to avoid depots.
BUG=1313
TEST=test/mjsuni
Revision: 8088
Author: ri...@chromium.org
Date: Thu May 26 08:22:31 2011
Log: Tagging version 3.3.10.2
http://code.google.com/p/v8/source/detail?r=8088
Added:
/tags/3.3.10.2
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Comment #7 on issue 1168 by ad...@chromium.org: Test failures on some
Mozilla strict mode tests
http://code.google.com/p/v8/issues/detail?id=1168
fast/js/mozilla/strict/this-for-function-expression-recursion.html seems to
have been fixed as of 3.3.10.
--
v8-dev mailing list
v8-dev@googleg
Revision: 8074
Author: kmilli...@chromium.org
Date: Thu May 26 04:17:15 2011
Log: Add a simple test for inlining of arguments accesses.
R=whe...@chromium.org
BUG=
TEST=
Review URL: http://codereview.chromium.org/7062018
http://code.google.com/p/v8/source/detail?r=8074
Added:
/branch
Revision: 8082
Author: ri...@chromium.org
Date: Thu May 26 07:03:30 2011
Log: Double allocation size for special json strings on every resize
(fixes
crbug 83877)
The issue was that with the relatively small start and increment size of
the string we created a ton of string handles
Reviewers: Nico, rvargas, Søren Gjesse, Mads Ager,
Description:
linux: extend the ifdefs in shell.cc to cover V8_SHARED too
Please review this at http://codereview.chromium.org/7076030/
SVN Base: http://v8.googlecode.com/svn/trunk/
Affected files:
M samples/shell.cc
Index: samples/shel
I think it would be nice to unify the macros across OSes at some point.
(and or
course, my lgtm is pointless here)
http://codereview.chromium.org/7076030/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
On 2011/05/26 23:34:16, rvargas wrote:
I think it would be nice to unify the macros across OSes at some point.
(and
or
course, my lgtm is pointless here)
Your LGTM is useful in the sense that you might have htoughts on whether the
change is correct. :) I will wait for a v8 master to land i
Reviewers: Evan Martin, Mads Ager,
Message:
I've tested componentized build on linux and windows, and static build on
linux.
I've also build webkit on mac (build-webkit --chromium) with this patch and
everything passed.
Description:
Removed all references to v8/src from i18n extension code.
Revision: 8084
Author: sgje...@chromium.org
Date: Thu May 26 07:18:46 2011
Log: Merge r8080 to the 3.3 branch
r8080:
ARM: Avoid using ldrd/strd with post increment
These instructions seems to cause problems in some situations. This reverts
parts of r7873.
R=erik.co...@gmail.com
BUG=
Revision: 8085
Author: sgje...@chromium.org
Date: Thu May 26 07:19:52 2011
Log: Tagging version 3.3.10.1
http://code.google.com/p/v8/source/detail?r=8085
Added:
/tags/3.3.10.1
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
71 matches
Mail list logo
