Updates:
Status: Fixed
Comment #2 on issue 2871 by yu...@chromium.org:
cctest/test-cpu-profiler/CollectCpuProfile flakes after r16549
http://code.google.com/p/v8/issues/detail?id=2871
Committed: https://code.google.com/p/v8/source/detail?r=16564
--
You received this message because t
Committed patchset #1 manually as r16564 (presubmit successful).
https://codereview.chromium.org/23455036/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To un
Revision: 16564
Author: yu...@chromium.org
Date: Fri Sep 6 06:25:06 2013 UTC
Log: Check if timeout has expired after processing each sample
To avoid long intervals between taking samples due to processing all
accumulated samples at once, the samples are processed one by one and we
Updates:
Status: Fixed
Comment #7 on issue 2281 by dcar...@chromium.org: FunctionTemplate should
have SetAccessor()
http://code.google.com/p/v8/issues/detail?id=2281
(No comment was entered for this change.)
--
You received this message because this project is configured to send all
LGTM.
https://chromiumcodereview.appspot.com/23455036/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails
lgtm
https://codereview.chromium.org/23819026/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from i
Revision: 16562
Author: mstarzin...@chromium.org
Date: Thu Sep 5 18:41:20 2013 UTC
Log: Consistently use CHECK_ALIVE_OR_RETURN in graph builder.
R=verwa...@chromium.org
Review URL: https://codereview.chromium.org/23819026
http://code.google.com/p/v8/source/detail?r=16562
Modified:
hey, ptal
https://codereview.chromium.org/23938003/diff/3001/src/x64/lithium-codegen-x64.cc
File src/x64/lithium-codegen-x64.cc (right):
https://codereview.chromium.org/23938003/diff/3001/src/x64/lithium-codegen-x64.cc#newcode4712
src/x64/lithium-codegen-x64.cc:4712: __ jmp(done);
On 2013/09/05
LGTM with comments.
https://codereview.chromium.org/23615012/diff/1/src/ast.h
File src/ast.h (right):
https://codereview.chromium.org/23615012/diff/1/src/ast.h#newcode291
src/ast.h:291: void FilterForPossibleTransitions(Map* root_map, Zone*
zone) {
The "zone" parameter is obsolete, as we only r
Note that I am now only seeing the crash under GC stress:
/Volumes/src/v8/out/ia32.debug/d8 --test --nocrankshaft --nobreak-on-abort
--nodead-code-elimination --nofold-constants --enable-slow-asserts
--debug-code --verify-heap --harmony-observation --harmony-proxies
--harmony-collections --harmony
yep, will add tests
https://codereview.chromium.org/23549019/diff/1/src/ia32/stub-cache-ia32.cc
File src/ia32/stub-cache-ia32.cc (left):
https://codereview.chromium.org/23549019/diff/1/src/ia32/stub-cache-ia32.cc#oldcode1359
src/ia32/stub-cache-ia32.cc:1359:
ASSERT(call_optimization.is_simple_a
Committed patchset #1 manually as r16563 (presubmit successful).
https://codereview.chromium.org/23453030/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To un
Reviewers: Toon Verwaest,
Description:
Fix wraparound of deoptimization count in shared function info.
BUG=
Please review this at https://codereview.chromium.org/23803007/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+20, -6 lines):
M src/objects-inl.h
M
Revision: 16563
Author: mstarzin...@chromium.org
Date: Thu Sep 5 18:53:39 2013 UTC
Log: Remove obsolete global V8::has_been_fooed flags.
R=yang...@chromium.org
BUG=v8:2744
TEST=cctest/test-api/InitializeAndDispose
Review URL: https://codereview.chromium.org/23453030
http://code.googl
Committed patchset #1 manually as r16562 (presubmit successful).
https://codereview.chromium.org/23819026/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To un
Not quite done yet. First round of comments. I'll continue tomorrow.
https://codereview.chromium.org/23533015/diff/1/src/debug-debugger.js
File src/debug-debugger.js (right):
https://codereview.chromium.org/23533015/diff/1/src/debug-debugger.js#newcode960
src/debug-debugger.js:960: ExecutionSta
Reviewers: Michael Starzinger,
Message:
PTAL
Description:
Properly filter types using the initial map from HAllocate.
Please review this at https://chromiumcodereview.appspot.com/23615012/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+46, -8 lines):
M src/a
lgtm with nit
https://codereview.chromium.org/23803007/diff/1/src/objects-inl.h
File src/objects-inl.h (right):
https://codereview.chromium.org/23803007/diff/1/src/objects-inl.h#newcode4892
src/objects-inl.h:4892: deopt_count = (deopt_count + 1) &
DeoptCountBits::kMax;
I guess this mask isn't n
On 2013/09/05 17:28:37, Sven Panne wrote:
On 2013/09/05 15:36:39, rmcilroy wrote:
> Thanks Sven. I've had to slightly change the API to take a pointer to a
boolean
> so that the setResourceConstraints will not re-set
is_memory_constrained if
the
> ResourceConstraint being passed didn't have a
Comment #1 on issue 2872 by pry...@chromium.org: LiveEdit leaves closures
in incorrect state.
http://code.google.com/p/v8/issues/detail?id=2872
JS unit test that demonstrates the problem:
Debug = debug.Debug
eval(
"function TestFunction() {\n"
+ " var a = 'a';\n"
+ " var b = 'b';\n"
+ "
Status: Accepted
Owner: pry...@chromium.org
Labels: Type-Bug Priority-Medium
New issue 2872 by pry...@chromium.org: LiveEdit leaves closures in
incorrect state.
http://code.google.com/p/v8/issues/detail?id=2872
If edit to closure changes heap context structure in outer function (for
example
Thank you. Please feel free to ask if you want any comments about the
change.
https://codereview.chromium.org/23533015/diff/1/src/debug-debugger.js
File src/debug-debugger.js (right):
https://codereview.chromium.org/23533015/diff/1/src/debug-debugger.js#newcode960
src/debug-debugger.js:960: E
On 2013/09/05 15:36:39, rmcilroy wrote:
Thanks Sven. I've had to slightly change the API to take a pointer to a
boolean
so that the setResourceConstraints will not re-set is_memory_constrained
if
the
ResourceConstraint being passed didn't have a call to
set_memory_constrained
(e.g., treat
LGTM
https://codereview.chromium.org/23868007/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it,
Revision: 16561
Author: jkumme...@chromium.org
Date: Thu Sep 5 16:33:01 2013 UTC
Log: Tagging version 3.21.11
http://code.google.com/p/v8/source/detail?r=16561
Added:
/tags/3.21.11
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You recei
LGTM. Can we haz test coverage?
https://codereview.chromium.org/23549019/diff/1/src/ia32/stub-cache-ia32.cc
File src/ia32/stub-cache-ia32.cc (left):
https://codereview.chromium.org/23549019/diff/1/src/ia32/stub-cache-ia32.cc#oldcode1359
src/ia32/stub-cache-ia32.cc:1359:
ASSERT(call_optimization
Committed patchset #2 manually as r16557.
https://codereview.chromium.org/23868007/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this gro
Reviewers: Toon Verwaest,
Description:
Consistently use CHECK_ALIVE_OR_RETURN in graph builder.
R=verwa...@chromium.org
Please review this at https://codereview.chromium.org/23819026/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+3, -6 lines):
M src/hydroge
Committed patchset #1 manually as r16559 (presubmit successful).
https://codereview.chromium.org/23519008/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To un
Revision: 16559
Author: jkumme...@chromium.org
Date: Thu Sep 5 16:29:07 2013 UTC
Log: Prepare push to trunk. Now working on version 3.21.12.
R=verwa...@chromium.org
Review URL: https://codereview.chromium.org/23519008
http://code.google.com/p/v8/source/detail?r=16559
Modified:
/br
lgtm
https://codereview.chromium.org/23519008/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from i
Reviewers: Toon Verwaest,
Description:
Prepare push to trunk. Now working on version 3.21.12.
R=verwa...@chromium.org
Please review this at https://codereview.chromium.org/23519008/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+6, -1 lines):
M ChangeLog
Committed patchset #1 manually as r16558.
https://chromiumcodereview.appspot.com/23903017/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from t
Revision: 16558
Author: verwa...@chromium.org
Date: Thu Sep 5 16:22:46 2013 UTC
Log: Wrap PushLoad and BuildStoreInEffect in CHECK_ALIVE.
R=jkumme...@chromium.org
Review URL: https://chromiumcodereview.appspot.com/23903017
http://code.google.com/p/v8/source/detail?r=16558
Modified:
Revision: 16557
Author: jkumme...@chromium.org
Date: Thu Sep 5 16:19:33 2013 UTC
Log: MIPS: load ics for js api accessors.
Port r16551 (61ce507)
BUG=
R=gerg...@homejinni.com
Review URL: https://codereview.chromium.org/23868007
Patch from Balazs Kilvady .
http://code.google.com/p/v8
On 2013/09/05 08:49:45, Sven Panne wrote:
LGTM if there is no veto from Michael. I think the right way to proceed
is to
use the new predicate for a few low-memory-device CLs and perhaps
refactor the
external API a bit if possible. I am not 100% happy with the introduction
of
magic flags, bu
https://codereview.chromium.org/23455036/diff/1/src/cpu-profiler.cc
File src/cpu-profiler.cc (right):
https://codereview.chromium.org/23455036/diff/1/src/cpu-profiler.cc#newcode119
src/cpu-profiler.cc:119: if (ticks_from_vm_buffer_.IsEmpty()) return
NoSamplesInQueue;
On 2013/09/05 14:56:51, lois
https://codereview.chromium.org/23455036/diff/1/src/cpu-profiler.cc
File src/cpu-profiler.cc (right):
https://codereview.chromium.org/23455036/diff/1/src/cpu-profiler.cc#newcode119
src/cpu-profiler.cc:119: if (ticks_from_vm_buffer_.IsEmpty()) return
NoSamplesInQueue;
I'd move this statement to l
Reviewers: loislo, Benedikt Meurer,
Description:
Check if timeout has expired after processing each sample
To avoid long intervals between taking samples due to processing all
accumulated
samples at once, the samples are processed one by one and we check if the
sampling interval has elapsed a
Reviewers: titzer,
Description:
Consider out-of-bounds accesses as escaping uses.
R=tit...@chromium.org
TEST=mjsunit/compiler/escape-analysis
Please review this at https://codereview.chromium.org/23892007/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+54, -6
lgtm
https://codereview.chromium.org/23455036/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from i
Revision: 16556
Author: yang...@chromium.org
Date: Thu Sep 5 14:32:49 2013 UTC
Log: Fix bug in regexp result object construction.
R=verwa...@chromium.org
BUG=
Review URL: https://codereview.chromium.org/23548018
http://code.google.com/p/v8/source/detail?r=16556
Added:
/branches/b
Committed patchset #1 manually as r16556 (presubmit successful).
https://codereview.chromium.org/23548018/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To un
lgtm
https://chromiumcodereview.appspot.com/23903017/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails
Reviewers: Toon Verwaest,
Description:
Fix bug in regexp result object construction.
R=verwa...@chromium.org
BUG=
Please review this at https://codereview.chromium.org/23548018/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+15, -14 lines):
M src/runtime.cc
lgtm
https://codereview.chromium.org/23548018/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from i
lgtm
lgtm
https://codereview.chromium.org/23938003/diff/3001/src/x64/lithium-codegen-x64.cc
File src/x64/lithium-codegen-x64.cc (right):
https://codereview.chromium.org/23938003/diff/3001/src/x64/lithium-codegen-x64.cc#newcode4712
src/x64/lithium-codegen-x64.cc:4712: __ jmp(done);
Maybe not
Reviewers: Jakob,
Message:
PTAL
Description:
Wrap PushLoad and BuildStoreInEffect in CHECK_ALIVE.
Please review this at https://chromiumcodereview.appspot.com/23903017/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+32, -19 lines):
M src/hydrogen.h
M src/h
Committed patchset #4 manually as r16555 (presubmit successful).
https://codereview.chromium.org/23817003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To un
Revision: 16555
Author: loi...@chromium.org
Date: Thu Sep 5 13:20:51 2013 UTC
Log: Functions may not be optimized and we would like to know in cpu
profiler what was the reason.
Current v8 implementation may disable optimization for a particular
function or block it with help of d
A code review. Reviewers: Michael Starzinger,
Message:
ptal
Description:
store ics for js api accessors
R=mstarzin...@chromium.org
BUG=
Please review this at https://codereview.chromium.org/23549019/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files +188, -48:
M
ACK-LGTM. :)
https://codereview.chromium.org/23401003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails
On 2013/09/05 12:44:44, loislo wrote:
https://codereview.chromium.org/23817003/diff/20001/src/objects.h
File src/objects.h (right):
https://codereview.chromium.org/23817003/diff/20001/src/objects.h#newcode1124
src/objects.h:1124: V(kExportDeclaration, "Export declaration")
\
https://codereview.chromium.org/23817003/diff/20001/src/objects.h
File src/objects.h (right):
https://codereview.chromium.org/23817003/diff/20001/src/objects.h#newcode1124
src/objects.h:1124: V(kExportDeclaration, "Export declaration")
\
On 2013/09/05 12:19:42, Yang wrote:
On 2013/09/04 13:24:29, Michael Starzinger wrote:
https://codereview.chromium.org/23453030/diff/1/test/cctest/test-api.cc
File test/cctest/test-api.cc (right):
https://codereview.chromium.org/23453030/diff/1/test/cctest/test-api.cc#newcode179
test/cctest/test-api.cc:179: // for (int i = 0; i
Revision: 16554
Author: verwa...@chromium.org
Date: Thu Sep 5 12:33:14 2013 UTC
Log: Properly close the CountOperation value/effect context after
leaving the store effect context.
R=jkumme...@chromium.org
Review URL: https://chromiumcodereview.appspot.com/23897003
http://code.goog
Committed patchset #3 manually as r16554 (presubmit successful).
https://chromiumcodereview.appspot.com/23897003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
LGTM, thanks!
https://chromiumcodereview.appspot.com/23897003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving
Comment #1 on issue 2871 by yu...@chromium.org:
cctest/test-cpu-profiler/CollectCpuProfile flakes after r16549
http://code.google.com/p/v8/issues/detail?id=2871
I managed to reproduce it locally on x64 Linux with the following output:
No connection to distribution server; running tests local
https://codereview.chromium.org/23817003/diff/20001/src/objects.h
File src/objects.h (right):
https://codereview.chromium.org/23817003/diff/20001/src/objects.h#newcode1124
src/objects.h:1124: V(kExportDeclaration, "Export declaration")
\
What do you need this for? Same for
A medium-sized code review. Reviewers: Benedikt Meurer, loislo, dcarney,
Description:
Revert r16548 due to cpu profiler test falkiness
The change made cctest/test-cpu-profiler/CollectCpuProfile and
cctest/test-cpu-profiler/JsNative1JsNative2JsSample flaky.
BUG=v8:2871
TBR=bmeu...@chromium.org
Revision: 16553
Author: yu...@chromium.org
Date: Thu Sep 5 12:17:17 2013 UTC
Log: Revert r16548 due to cpu profiler test falkiness
The change made cctest/test-cpu-profiler/CollectCpuProfile and
cctest/test-cpu-profiler/JsNative1JsNative2JsSample flaky.
BUG=v8:2871
TBR=bmeu...@chro
Committed patchset #1 manually as r16553 (presubmit successful).
https://codereview.chromium.org/23615011/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To un
https://codereview.chromium.org/23868007/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send
A small code review. Reviewers: Jakob,
Message:
PTAL
Description:
Properly close the CountOperation value/effect context after leaving the
store
effect context.
Please review this at https://chromiumcodereview.appspot.com/23897003/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_e
Status: Accepted
Owner: yu...@chromium.org
CC: loi...@chromium.org, a...@chromium.org
Labels: Type-Bug Priority-Medium
New issue 2871 by yu...@chromium.org:
cctest/test-cpu-profiler/CollectCpuProfile flakes after r16549
http://code.google.com/p/v8/issues/detail?id=2871
cctest/test-cpu-profil
Revision: 16552
Author: dcar...@chromium.org
Date: Thu Sep 5 11:27:22 2013 UTC
Log: remove most Isolate::Current asserts
R=svenpa...@chromium.org
BUG=
Review URL: https://codereview.chromium.org/23493019
http://code.google.com/p/v8/source/detail?r=16552
Modified:
/branches/bleeding
Committed patchset #1 manually as r16552 (presubmit successful).
https://codereview.chromium.org/23493019/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To un
A code review. Reviewers: Michael Starzinger,
Message:
Committed patchset #1 manually as r16551 (presubmit successful).
Description:
load ics for js api accessors
TBR=mstarzin...@chromium.org
BUG=
Committed: https://code.google.com/p/v8/source/detail?r=16551
Please review this at https://code
Revision: 16551
Author: dcar...@chromium.org
Date: Thu Sep 5 11:18:52 2013 UTC
Log: load ics for js api accessors
TBR=mstarzin...@chromium.org
BUG=
Review URL: https://codereview.chromium.org/23984002
http://code.google.com/p/v8/source/detail?r=16551
Modified:
/branches/bleeding_ed
A large code review. Reviewers: Benedikt Meurer,
Message:
PTAL
Description:
Let BuildStore/BuildLoad distinguish between keyed/named load/stores.
Please review this at https://chromiumcodereview.appspot.com/23537024/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected file
lgtm
https://codereview.chromium.org/23452023/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from i
A tiny code review. Reviewers: Benedikt Meurer, Yury Semikhatsky,
Message:
Committed patchset #1 manually as r16550.
Description:
fix mac build after 16548
TBR=bmeu...@chromium.org,yu...@chromium.org
BUG=
Committed: https://code.google.com/p/v8/source/detail?r=16550
Please review this at http
Revision: 16550
Author: dcar...@chromium.org
Date: Thu Sep 5 11:14:14 2013 UTC
Log: fix mac build after 16548
TBR=bmeu...@chromium.org,yu...@chromium.org
BUG=
Review URL: https://codereview.chromium.org/23452023
http://code.google.com/p/v8/source/detail?r=16550
Modified:
/branches/
A code review. Reviewers: danno, ulan, bmeurer-g,
Message:
This is the first patch breaking down issue 23156006 (improving lithium
register
constraints).
This patch does not contain any contentious changes (changes to Lithium
framework), these will be subject of a dedicated patch later. In th
A small code review. Reviewers: danno, Jakob, Paul Lind, palfia, kisg,
dcarney,
Description:
MIPS: load ics for js api accessors.
Port r16543 (3686ceb)
BUG=
Please review this at https://codereview.chromium.org/23868007/
SVN Base: https://github.com/v8/v8.git@gbl
Affected files +19, -1:
Committed patchset #2 manually as r16549 (presubmit successful).
https://codereview.chromium.org/23686006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To un
Revision: 16549
Author: yu...@chromium.org
Date: Thu Sep 5 10:31:18 2013 UTC
Log: Rename some of SamplingCircularQueue methods
Renamed StartDequeue -> Peek, FinishDequeue -> Remove.
BUG=None
R=bmeu...@chromium.org, loi...@chromium.org
Review URL: https://codereview.chromium.org/2368
Revision: 16548
Author: yu...@chromium.org
Date: Thu Sep 5 10:28:57 2013 UTC
Log: Check if timeout has expired after processing each sample
To avoid long intervals between taking samples due to processing all
accumulated samples at once, the samples are processed one by one and we
Committed patchset #2 manually as r16548 (presubmit successful).
https://codereview.chromium.org/23583036/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To un
A code review. Reviewers: Michael Starzinger,
Message:
Committed patchset #1 manually as r16547.
Description:
revert 16543 for breaking windows build
load ics for js api accessors
TBR=mstarzin...@chromium.org
BUG=
Committed: https://code.google.com/p/v8/source/detail?r=16547
Please review th
Revision: 16547
Author: dcar...@chromium.org
Date: Thu Sep 5 10:21:29 2013 UTC
Log: revert 16543 for breaking windows build
load ics for js api accessors
TBR=mstarzin...@chromium.org
BUG=
Review URL: https://codereview.chromium.org/23819021
http://code.google.com/p/v8/source/detail?
LGTM with a nit
https://codereview.chromium.org/23493019/diff/1/src/compiler.h
File src/compiler.h (right):
https://codereview.chromium.org/23493019/diff/1/src/compiler.h#newcode63
src/compiler.h:63: Isolate* isolate() {
While we're here: Can we make this and zone() const?
https://codereview.c
Looking OK from my end. I'll leave the final decision up to Cris.
https://codereview.chromium.org/23458022/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
Revision: 16546
Author: mstarzin...@chromium.org
Date: Thu Sep 5 09:01:28 2013 UTC
Log: Prevent representation inference from double-visiting.
This prevents representation inference from pushing the current value
into the worklist while it is still being worked on. This might lead
to
Committed patchset #1 manually as r16546 (presubmit successful).
https://codereview.chromium.org/23452020/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To un
A medium-sized code review. Reviewers: Sven Panne,
Description:
remove most Isolate::Current asserts
R=svenpa...@chromium.org
BUG=
Please review this at https://codereview.chromium.org/23493019/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files +4, -27:
M src/bui
+cdn
Original OS::Guard was submitted by Cris Neckar. I always assumed that
choice of
PROT_GUARD was intentional.
https://codereview.chromium.org/23458022/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are s
lgtm
https://codereview.chromium.org/23452020/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from i
Revision: 16545
Author: dcar...@chromium.org
Date: Thu Sep 5 08:48:34 2013 UTC
Log: add isolate parameter for Execution::Call
R=svenpa...@chromium.org
BUG=
Review URL: https://codereview.chromium.org/23661004
http://code.google.com/p/v8/source/detail?r=16545
Modified:
/branches/ble
LGTM if there is no veto from Michael. I think the right way to proceed is
to
use the new predicate for a few low-memory-device CLs and perhaps refactor
the
external API a bit if possible. I am not 100% happy with the introduction of
magic flags, but currently I don't know a better alternative
Committed patchset #2 manually as r16545 (presubmit successful).
https://codereview.chromium.org/23661004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To un
A tiny code review. Reviewers: Toon Verwaest,
Description:
Prevent representation inference from double-visiting.
This prevents representation inference from pushing the current value
into the worklist while it is still being worked on. This might lead
to having a value in the worklist that isn'
Ah, OK. So the revivable stuff is only there for a transitional phase,
right?
that's correct
https://codereview.chromium.org/23401003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Goog
LGTM, perhaps wait for a "LGTM" or "don't really care" from Michael.
https://codereview.chromium.org/23401003/diff/1/src/global-handles.h
File src/global-handles.h (right):
https://codereview.chromium.org/23401003/diff/1/src/global-handles.h#newcode148
src/global-handles.h:148: WeakCallback wea
A small code review. Reviewers: Michael Starzinger,
Message:
Hey Michi,
Here's the change we discussed offline to use PAGE_NOACCESS on Windows,
PTAL.
-- Benedikt
Description:
Use PAGE_NOACCESS for guard pages in Windows.
Up until now we used PAGE_GUARD for guard pages in Windows, which
will
LGTM. It is somehow tragic that we need that parameter at all, it is
basically
for throwing an exception only. :-P
https://codereview.chromium.org/23661004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are su
Committed patchset #1 manually as r16544 (presubmit successful).
https://chromiumcodereview.appspot.com/23892005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
Revision: 16544
Author: verwa...@chromium.org
Date: Thu Sep 5 08:36:10 2013 UTC
Log: Disable map-check relying on cache behavior sensitive to GC-timing
R=mstarzin...@chromium.org
Review URL: https://chromiumcodereview.appspot.com/23892005
http://code.google.com/p/v8/source/detail?r=1
LGTM (rubber-stamped).
https://codereview.chromium.org/23892005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receivi
1 - 100 of 115 matches
Mail list logo
