https://codereview.chromium.org/23890007/diff/1/src/arm/lithium-codegen-arm.cc
File src/arm/lithium-codegen-arm.cc (right):
https://codereview.chromium.org/23890007/diff/1/src/arm/lithium-codegen-arm.cc#newcode1985
src/arm/lithium-codegen-arm.cc:1985: FieldMemOperand(string,
Committed patchset #2 manually as r16584 (presubmit successful).
https://codereview.chromium.org/23561007/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Revision: 16584
Author: dcar...@chromium.org
Date: Mon Sep 9 07:08:34 2013 UTC
Log: add uncached Function::New
R=mstarzin...@chromium.org
BUG=
Review URL: https://codereview.chromium.org/23561007
http://code.google.com/p/v8/source/detail?r=16584
Modified:
Reviewers: Michael Starzinger,
Message:
Committed patchset #1 manually as r16585.
Description:
revert 16584 for breaking build
TBR=mstarzin...@chromium.org
BUG=
Committed: https://code.google.com/p/v8/source/detail?r=16585
Please review this at https://codereview.chromium.org/23680014/
SVN
Revision: 16585
Author: dcar...@chromium.org
Date: Mon Sep 9 07:16:24 2013 UTC
Log: revert 16584 for breaking build
TBR=mstarzin...@chromium.org
BUG=
Review URL: https://codereview.chromium.org/23680014
http://code.google.com/p/v8/source/detail?r=16585
Modified:
lgtm
https://codereview.chromium.org/23767009/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
On 2013/08/01 09:25:29, Michael Starzinger wrote:
https://codereview.chromium.org/21340002/diff/14001/src/runtime.cc
File src/runtime.cc (right):
https://codereview.chromium.org/21340002/diff/14001/src/runtime.cc#newcode8247
src/runtime.cc:8247: if (it.frame()-function()-code() ==
Hmmm, actually I would prefer PAGE_NOACCESS, too. MSDN explicitly describes
PAGE_GUARD as a mechanism for growable data structures, e.g.
http://msdn.microsoft.com/en-us/library/windows/desktop/aa366549(v=vs.85).aspx.
Therefore I think it is a terrible idea to use this for security, this is
Status: New
Owner:
CC: bmeu...@chromium.org
Labels: Type-Bug Priority-Medium
New issue 2874 by machenb...@chromium.org: Threading problems in test-api
http://code.google.com/p/v8/issues/detail?id=2874
Recently we saw some threading-related issues on arm-sim. The check output
in the
Hi, Manager
Have a good day.
You may remember that we have contacted your for many times. We are so happy to
give you our latest price of refrigerant gas. So the price is here,
R22 13.6kg/30lb $24/piece FOB China
R134a13.6kg/31lb $41.5/piece Fob China
We
Reviewers: Michael Starzinger,
Message:
Committed patchset #1 manually as r16586 (presubmit successful).
Description:
add uncached Function::New
TBR=mstarzin...@chromium.org
BUG=
Committed: https://code.google.com/p/v8/source/detail?r=16586
Please review this at
Revision: 16586
Author: dcar...@chromium.org
Date: Mon Sep 9 07:52:52 2013 UTC
Log: add uncached Function::New
TBR=mstarzin...@chromium.org
BUG=
Review URL: https://codereview.chromium.org/24071002
http://code.google.com/p/v8/source/detail?r=16586
Modified:
Committed patchset #1 manually as r16587 (presubmit successful).
https://codereview.chromium.org/24027004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Revision: 16587
Author: dcar...@chromium.org
Date: Mon Sep 9 07:57:23 2013 UTC
Log: thread isolate for HConstant::handle
R=svenpa...@chromium.org
BUG=
Review URL: https://codereview.chromium.org/24027004
http://code.google.com/p/v8/source/detail?r=16587
Modified:
Oops, I'm in the reviewer list too. lgtm, though I'm not a V8 committer
even :)
https://codereview.chromium.org/23401003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups
Status: New
Owner:
New issue 2875 by conrad.i...@gmail.com: Can generate (and parse) invalid
UTF-8
http://code.google.com/p/v8/issues/detail?id=2875
If a String contains an unpaired Unicode surrogate (U+D800 through U+DFFF)
encoding it as UTF-8 will result in an invalid string. This
On 2013/09/09 07:17:09, Sven Panne wrote:
lgtm
Thanks Sven. Could you land this for me please?
https://codereview.chromium.org/23767009/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the
https://codereview.chromium.org/23890007/diff/1/src/arm/lithium-codegen-arm.cc
File src/arm/lithium-codegen-arm.cc (right):
https://codereview.chromium.org/23890007/diff/1/src/arm/lithium-codegen-arm.cc#newcode1985
src/arm/lithium-codegen-arm.cc:1985: FieldMemOperand(string,
lgtm
https://codereview.chromium.org/23892007/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Comment #1 on issue 2873 by svenpa...@chromium.org: Compiled Lua VM slowness
http://code.google.com/p/v8/issues/detail?id=2873
I took a quick look at this: There are a few deopts we should look into,
but they don't seem to be the root cause. Furthermore, no
relevant disabled optimization
svenpanne: this would be ready for landing now. Does V8 have try jobs
nowadays?
It would be good to run a try job - Chrome *should* be migrated but it's
possible that I missed something, or that somebody introduced a new call to
the
default ctor meanwhile.
lgtm
https://codereview.chromium.org/23818005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Comment #1 on issue 2874 by machenb...@chromium.org: Threading problems in
test-api
http://code.google.com/p/v8/issues/detail?id=2874
And:
cctest/test-api/CallICFastApi_TrivialSignatureWithProfiler
On 2013/09/09 08:44:08, marja wrote:
svenpanne: this would be ready for landing now. Does V8 have try jobs
nowadays?
It would be good to run a try job - Chrome *should* be migrated but it's
possible that I missed something, or that somebody introduced a new call
to
the
default ctor
Committed patchset #2 manually as r16588 (presubmit successful).
https://codereview.chromium.org/23401003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Revision: 16588
Author: dcar...@chromium.org
Date: Mon Sep 9 09:25:23 2013 UTC
Log: new persistent semantics
adds copying and autodispose as traits
R=ma...@chromium.org, mstarzin...@chromium.org, svenpa...@chromium.org
BUG=
Review URL: https://codereview.chromium.org/23401003
Reviewers: Hannes Payer,
Message:
I'll add support for other architectures if you think this looks OK.
Description:
Enable preaging of code objects for low-memory devices.
This change means that code which is never re-executed is garbage collected
more quickly (limiting heap growth), however,
Another lo-tech solution: Make chromium/src/v8 a link to your bleeding_edge
v8 repo, gclient runhooks + ninja will tell you if there will be breakage.
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
I did try this locally, ofc, when I created the CL.
2013/9/9 Sven Panne svenpa...@chromium.org:
Another lo-tech solution: Make chromium/src/v8 a link to your bleeding_edge
v8 repo, gclient runhooks + ninja will tell you if there will be breakage.
--
--
v8-dev mailing list
Revision: 16589
Author: mstarzin...@chromium.org
Date: Mon Sep 9 09:53:58 2013 UTC
Log: Consider out-of-bounds accesses as escaping uses.
R=tit...@chromium.org
TEST=mjsunit/compiler/escape-analysis
Review URL: https://codereview.chromium.org/23892007
Committed patchset #1 manually as r16589 (presubmit successful).
https://codereview.chromium.org/23892007/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Reviewers: danno, dcarney, Paul Lind, kisg, palfia,
Description:
MIPS: thread isolate for HConstant::handle.
Port r16587 (45fc067)
BUG=
Please review this at https://codereview.chromium.org/23444041/
SVN Base: g...@github.com:paul99/v8m-rb.git@master
Affected files (+9, -7 lines):
M
Reviewers: Dmitry Lomov (chromium),
Message:
Committed patchset #1 manually as r16590.
Description:
temporarily remove persistent destructor to allow trunk push
TBR=dslo...@chromium.org
BUG=
Committed: https://code.google.com/p/v8/source/detail?r=16590
Please review this at
Revision: 16590
Author: dcar...@chromium.org
Date: Mon Sep 9 10:10:26 2013 UTC
Log: temporarily remove persistent destructor to allow trunk push
TBR=dslo...@chromium.org
BUG=
Review URL: https://codereview.chromium.org/24023004
http://code.google.com/p/v8/source/detail?r=16590
Reviewers: Dmitry Lomov (chromium),
Message:
Committed patchset #1 manually as r16591.
Description:
remove commented out code in v8.h
TBR=dslo...@chromium.org
BUG=
Committed: https://code.google.com/p/v8/source/detail?r=16591
Please review this at https://codereview.chromium.org/23676007/
Revision: 16591
Author: dcar...@chromium.org
Date: Mon Sep 9 10:26:25 2013 UTC
Log: remove commented out code in v8.h
TBR=dslo...@chromium.org
BUG=
Review URL: https://codereview.chromium.org/23676007
http://code.google.com/p/v8/source/detail?r=16591
Modified:
IMO, this approach is a no-go. I find it very hard to believe that there
are no
regressions with this patch on the core benchmarks. It significantly bloats
the
allocation path and adds instructions to the critical path in the optimized
code
case. This is fundamentally not a wise strategy for
Updates:
Status: Assigned
Owner: svenpa...@chromium.org
Comment #2 on issue 2873 by svenpa...@chromium.org: Compiled Lua VM slowness
http://code.google.com/p/v8/issues/detail?id=2873
Further investigation revealed that there are at least 2 problems: The
first one is that we
Status: New
Owner:
New issue 2876 by 4tmue...@gmail.com: Can't build if v8 is hosted in a
directory containing a space
http://code.google.com/p/v8/issues/detail?id=2876
For some reason my harddrive had a label with a space. It was mounted in a
directory whose name also contained that
not lgtm!
Let's not have commented out code in public API.
Thanks for fixing in follow-up CL.
https://codereview.chromium.org/24023004/diff/1/include/v8.h
File include/v8.h (right):
https://codereview.chromium.org/24023004/diff/1/include/v8.h#newcode552
include/v8.h:552: //
lgtm
https://codereview.chromium.org/23676007/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from it,
Reviewers: rossberg,
Description:
Prepare push to trunk. Now working on version 3.21.13.
R=rossb...@chromium.org
Please review this at https://codereview.chromium.org/23684035/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+21, -1 lines):
M ChangeLog
M
lgtm
https://codereview.chromium.org/23684035/diff/1/ChangeLog
File ChangeLog (right):
https://codereview.chromium.org/23684035/diff/1/ChangeLog#newcode3
ChangeLog:3: Fix bitwise negation on x64
Nit: Use past tense everywhere.
https://codereview.chromium.org/23684035/
--
--
v8-dev mailing
Committed patchset #2 manually as r16592 (presubmit successful).
https://codereview.chromium.org/23684035/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Revision: 16592
Author: dslo...@chromium.org
Date: Mon Sep 9 11:50:28 2013 UTC
Log: Prepare push to trunk. Now working on version 3.21.13.
R=rossb...@chromium.org
Review URL: https://codereview.chromium.org/23684035
http://code.google.com/p/v8/source/detail?r=16592
Modified:
Revision: 16594
Author: dslo...@chromium.org
Date: Mon Sep 9 11:59:47 2013 UTC
Log: Tagging version 3.21.12
http://code.google.com/p/v8/source/detail?r=16594
Added:
/tags/3.21.12
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You
Updates:
Status: Invalid
Comment #1 on issue 2876 by svenpa...@chromium.org: Can't build if v8 is
hosted in a directory containing a space
http://code.google.com/p/v8/issues/detail?id=2876
This is actually a bug in GYP, not in v8 itself, so you should report it in
that project.
Updates:
Cc: verwa...@chromium.org tit...@chromium.org
Comment #3 on issue 2873 by svenpa...@chromium.org: Compiled Lua VM slowness
http://code.google.com/p/v8/issues/detail?id=2873
The underlying problem (apart from the ad-hoc limit mentioned aboved) is as
follows: We somehow infer
Reviewers: rossberg,
Description:
First implementation of HUniqueT and HUniqueSetT, which is supposed to
replace UniqueValueId.
BUG=
Please review this at https://codereview.chromium.org/23609020/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+699, -0 lines):
Reviewers: Paul Lind, kisg, kilvadyb, danno, Jakob, Yang,
Message:
PTAL.
Description:
MIPS/ARM: Fix benchmarks failures on simulator.
The default x87 FPU precision is usually 80-bit extended precision,
which can lead to precision failures on several tests.
This patch fixes the precision
LGTM
https://codereview.chromium.org/23444041/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from it,
Reviewers: Michael Starzinger,
Message:
Hey Michi,
Here's the random cleanup. PTAL
-- Benedikt
Description:
Introduce a RandonNumberGenerator class. Refactor the random/private_random
uses
in Isolate/Context.
The RandomNumberGenerator is a proper pseudorandom number generator
with 48-bit
Committed patchset #1 manually as r16595 (presubmit successful).
https://codereview.chromium.org/23818005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Revision: 16595
Author: mstarzin...@chromium.org
Date: Mon Sep 9 14:29:47 2013 UTC
Log: Handlify JSObject::EnsureCanContainHeapObjectElements method.
R=verwa...@chromium.org
Review URL: https://codereview.chromium.org/23818005
http://code.google.com/p/v8/source/detail?r=16595
Reviewers: Benedikt Meurer,
Description:
Don't switch left/right operand when they are double value
BUG=
Please review this at https://codereview.chromium.org/23717039/
SVN Base: git://github.com/v8/v8.git@master
Affected files (+4, -4 lines):
M src/ia32/lithium-ia32.cc
M
What is the benefit?
https://codereview.chromium.org/23717039/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving
lgtm
https://codereview.chromium.org/23480051/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Revision: 16596
Author: pal...@homejinni.com
Date: Mon Sep 9 15:02:41 2013 UTC
Log: MIPS: thread isolate for HConstant::handle.
Port r16587 (45fc067)
BUG=
Review URL: https://codereview.chromium.org/23444041
Patch from Balazs Kilvady kilva...@homejinni.com.
Committed patchset #2 manually as r16597 (presubmit successful).
https://codereview.chromium.org/23816009/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Committed as r16596.
https://codereview.chromium.org/23444041/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving
I am wondering about the performance impact of that change. What happens if
you
preage also on non-low-memory devices?
https://codereview.chromium.org/23480031/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you
Avoid unnecessary register move.
For example, it brings more than 40% improve for misc-basic-fpops.js on
IA32 in awfy*
*http://www.arewefastyet.com/#machine=11view=breakdownsuite=misc
On Mon, Sep 9, 2013 at 10:39 PM, bmeu...@chromium.org wrote:
What is the benefit?
Reviewers: Yang,
Message:
Corresponding Chrome bug:
https://code.google.com/p/chromium/issues/detail?id=275672
Description:
Support stepin for combination of apply and bound function
Please review this at https://codereview.chromium.org/23513023/
SVN Base:
LTGM, but we need v8 team to review the ARM fix as well. PTAL.
https://codereview.chromium.org/24067002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Reviewers: Michael Starzinger,
Description:
put js accessor ics behind a flags until fixed
R=mstarzin...@chromium.org
BUG=
Please review this at https://codereview.chromium.org/23816009/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+23, -3 lines):
M
Reviewers: Toon Verwaest,
Description:
Correctly stringify mixed encoding indirect strings.
R=verwa...@chromium.org
BUG=287476
Please review this at https://codereview.chromium.org/23480051/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+60, -2 lines):
M
Reviewers: titzer,
Description:
Enable escape analysis for Hydrogen.
R=tit...@chromium.org
Please review this at https://codereview.chromium.org/23458036/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+1, -1 lines):
M src/flag-definitions.h
Index:
Make test(mem, imm) employ test_b too.
https://codereview.chromium.org/23679007/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group
Committed patchset #1 manually as r16598.
https://codereview.chromium.org/23480051/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this
... now this is ready to land for real (removed 1 more case in Chromium
which I
had weirdly missed before).
https://codereview.chromium.org/23530045/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
LGTM with final round of comments.
https://codereview.chromium.org/21340002/diff/21001/src/compiler.cc
File src/compiler.cc (right):
https://codereview.chromium.org/21340002/diff/21001/src/compiler.cc#newcode1219
src/compiler.cc:1219: return result; // return null.
nit: Can we just write down
LGTM, what could possibly go wrong?
https://codereview.chromium.org/23458036/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and
LGTM.
https://codereview.chromium.org/23816009/diff/1/test/cctest/test-accessors.cc
File test/cctest/test-accessors.cc (right):
https://codereview.chromium.org/23816009/diff/1/test/cctest/test-accessors.cc#newcode562
test/cctest/test-accessors.cc:562: v8::Function::New(isolate,
Revision: 16598
Author: yang...@chromium.org
Date: Mon Sep 9 16:15:40 2013 UTC
Log: Correctly stringify mixed encoding indirect strings.
R=verwa...@chromium.org
BUG=287476
Review URL: https://codereview.chromium.org/23480051
http://code.google.com/p/v8/source/detail?r=16598
Reviewers: Toon Verwaest,
Description:
Add a missing instruction to the ia32 disassembler.
BUG=
Please review this at https://codereview.chromium.org/23451024/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+1, -0 lines):
M src/ia32/disasm-ia32.cc
Index:
Revision: 16600
Author: ol...@chromium.org
Date: Mon Sep 9 16:57:35 2013 UTC
Log: Extend assembler and codegen with more fpu arithmetic
BUG=
R=mvstan...@chromium.org
Review URL: https://codereview.chromium.org/21509003
http://code.google.com/p/v8/source/detail?r=16600
Modified:
Committed patchset #1 manually as r16600 (presubmit successful).
https://codereview.chromium.org/21509003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
https://codereview.chromium.org/23548024/diff/4001/src/bootstrapper.cc
File src/bootstrapper.cc (right):
https://codereview.chromium.org/23548024/diff/4001/src/bootstrapper.cc#newcode1320
src/bootstrapper.cc:1320: HandleByteArray
random_seed(factory-NewByteArray(kRandomStateSize));
nit: Use
On 2013/09/09 15:34:43, Michael Starzinger wrote:
LGTM with final round of comments.
https://codereview.chromium.org/21340002/diff/21001/src/compiler.cc
File src/compiler.cc (right):
https://codereview.chromium.org/21340002/diff/21001/src/compiler.cc#newcode1219
src/compiler.cc:1219:
Committed patchset #5 manually as r16599 (presubmit successful).
https://codereview.chromium.org/21340002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Committed patchset #1 manually as r16601 (presubmit successful).
https://codereview.chromium.org/23458036/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Reviewers: Benedikt Meurer,
Message:
Ceterum censeo V8_WARN_UNUSED_RESULT esse delendam.
Description:
Remove V8_WARN_UNUSED_RESULT for simple getters.
R=bmeu...@chromium.org
Please review this at https://codereview.chromium.org/23629031/
SVN Base:
Revision: 16601
Author: mstarzin...@chromium.org
Date: Mon Sep 9 17:12:59 2013 UTC
Log: Enable escape analysis for Hydrogen.
R=tit...@chromium.org
Review URL: https://codereview.chromium.org/23458036
http://code.google.com/p/v8/source/detail?r=16601
Modified:
Revision: 16597
Author: dcar...@chromium.org
Date: Mon Sep 9 15:03:03 2013 UTC
Log: put js accessor ics behind a flags until fixed
R=mstarzin...@chromium.org
BUG=
Review URL: https://codereview.chromium.org/23816009
http://code.google.com/p/v8/source/detail?r=16597
Modified:
On 2013/09/04 10:17:50, Benedikt Meurer wrote:
Currently there are 21 test cases are calling CopyBytes function:
=== mjsunit/array-constructor ===
=== mjsunit/array-functions-prototype-misc ===
=== mjsunit/array-join ===
=== mjsunit/array-tostring ===
=== mjsunit/cyclic-array-to-string ===
This does not lgtm. It is very unintuitive why Double vs. Int32
representation
would have anything to do with whether operands are better swapped or not.
Probably this benchmark just happens to create a situation where our
heuristic
makes the wrong decision. Maybe Better{Left,Right}Operand()
Patch set 1 LGTM with comment.
Does your second comment refer to another patch set that you forgot to
upload?
https://codereview.chromium.org/23679007/diff/1/src/ia32/assembler-ia32.cc
File src/ia32/assembler-ia32.cc (right):
Reviewers: Toon Verwaest,
Description:
Merged r16597 into trunk branch.
Put js accessor ics behind a flags until fixed
R=verwa...@chromium.org
BUG=chromium:287879
Please review this at https://codereview.chromium.org/23816012/
SVN Base: https://v8.googlecode.com/svn/trunk
Affected files
Updated to use the Maybe template. PTAL.
https://codereview.chromium.org/23464022/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this
Revision: 16602
Author: mstarzin...@chromium.org
Date: Mon Sep 9 18:50:22 2013 UTC
Log: Merged r16597 into trunk branch.
Put js accessor ics behind a flags until fixed
R=verwa...@chromium.org
BUG=chromium:287879
Review URL: https://codereview.chromium.org/23816012
Committed patchset #1 manually as r16602 (presubmit successful).
https://codereview.chromium.org/23816012/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
lgtm (rubberstamp)
https://codereview.chromium.org/23816012/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving
lgtm
https://codereview.chromium.org/23458022/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from it,
On 2013/09/09 07:40:39, Sven Panne wrote:
Hmmm, actually I would prefer PAGE_NOACCESS, too. MSDN explicitly
describes
PAGE_GUARD as a mechanism for growable data structures, e.g.
http://msdn.microsoft.com/en-us/library/windows/desktop/aa366549%28v=vs.85%29.aspx.
Therefore I think it is a
Added Petar to reviewers (to do DEPS roll once this lands).
https://codereview.chromium.org/23766017/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Reviewers: Jakob,
Description:
Merged r16596 into trunk branch.
MIPS: thread isolate for HConstant::handle.
R=jkumme...@chromium.org
BUG=
Please review this at https://codereview.chromium.org/23766017/
SVN Base: https://v8.googlecode.com/svn/trunk
Affected files (+10, -8 lines):
M
PTAL.
https://codereview.chromium.org/23766017/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from it,
On 2013/09/09 14:39:02, Benedikt Meurer wrote:
What is the benefit?
Avoid unnecessary register move.
For example, it brings more than 40% improve for misc-basic-fpops.js on
IA32 in
awfy
http://www.arewefastyet.com/#machine=11view=breakdownsuite=misc
Revision: 16603
Author: mstarzin...@chromium.org
Date: Mon Sep 9 18:50:47 2013 UTC
Log: Tagging version 3.21.12.1
http://code.google.com/p/v8/source/detail?r=16603
Added:
/tags/3.21.12.1
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
https://codereview.chromium.org/23679007/diff/1/src/ia32/assembler-ia32.cc
File src/ia32/assembler-ia32.cc (right):
https://codereview.chromium.org/23679007/diff/1/src/ia32/assembler-ia32.cc#newcode1170
src/ia32/assembler-ia32.cc:1170: }
On 2013/09/09 19:16:51, Jakob wrote:
I think we may want
1 - 100 of 104 matches
Mail list logo
