Committed patchset #6 manually as r17094 (presubmit successful).
https://codereview.chromium.org/22267005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To un
Revision: 17094
Author: haitao.f...@intel.com
Date: Thu Oct 3 01:22:25 2013 UTC
Log: Use StackArgumenstAccessor and kPCOnStackSize/kFPOnStackSize to
compute stack address/operand for X64
R=da...@chromium.org
Review URL: https://codereview.chromium.org/22267005
http://code.google.c
Revision: 17093
Author: haitao.f...@intel.com
Date: Thu Oct 3 00:33:23 2013 UTC
Log: Use StackArgumentsAccessor for PropertyCallback and
FunctionCallback for X64
R=da...@chromium.org
Review URL: https://codereview.chromium.org/25682002
http://code.google.com/p/v8/source/detail?r=1
Committed patchset #1 manually as r17093 (presubmit successful).
https://codereview.chromium.org/25682002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To un
Status: New
Owner:
New issue 2918 by imi...@google.com: Stack trace for exceptions miss all
but top 10 stack frames
http://code.google.com/p/v8/issues/detail?id=2918
Reproduced in Chrome 30.0.1599.66 beta and node.js v0.10.15
Demo (open console): http://plnkr.co/edit/bU3vS7YX2xRYecuOhyf
Adding an OWNER to the review.
https://codereview.chromium.org/25582002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop
LGTM if comments are addressed.
https://codereview.chromium.org/25669004/diff/4001/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/25669004/diff/4001/src/objects.cc#newcode12964
src/objects.cc:12964: Handle holder,
nit: s/holder/object/ for consistency.
https://code
LGTM if comments are addressed.
https://codereview.chromium.org/25732002/diff/1/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/25732002/diff/1/src/objects.cc#newcode510
src/objects.cc:510: Handle
JSObject::GetPropertyWithCallback(Handle holder,
nit: s/holder/object/
Revision: 17091
Author: ol...@chromium.org
Date: Wed Oct 2 18:15:57 2013 UTC
Log: Inline some more compare operations.
BUG=
R=hpa...@chromium.org
Review URL: https://codereview.chromium.org/25009003
http://code.google.com/p/v8/source/detail?r=17091
Added:
/branches/bleeding_edge/te
Committed patchset #2 manually as r17091 (presubmit successful).
https://codereview.chromium.org/25009003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To un
Committed as r17092.
https://codereview.chromium.org/25560006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving
Revision: 17092
Author: plin...@gmail.com
Date: Wed Oct 2 18:19:44 2013 UTC
Log: MIPS: Fix test262 failures and x64 compile failure.
Port r17082 (fc909df)
BUG=
R=plin...@gmail.com
Review URL: https://codereview.chromium.org/25560006
Patch from Balazs Kilvady .
http://code.google.co
https://codereview.chromium.org/22852024/diff/84001/src/heap.cc
File src/heap.cc (right):
https://codereview.chromium.org/22852024/diff/84001/src/heap.cc#newcode4979
src/heap.cc:4979: HeapProfiler* profiler = isolate()->heap_profiler();
On 2013/10/02 18:00:29, Hannes Payer wrote:
Why do you tra
LGTM, I'll land it.
https://codereview.chromium.org/25560006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving
Reviewers: danno, Jakob, Paul Lind, palfia, kisg,
Description:
MIPS: Fix test262 failures and x64 compile failure.
Port r17082 (fc909df)
BUG=
Please review this at https://codereview.chromium.org/25560006/
SVN Base: https://github.com/v8/v8.git@gbl
Affected files (+4, -13 lines):
M src/mip
Updates:
Status: Fixed
Comment #2 on issue 2907 by ad...@chromium.org: Object.observe access
checks cause allocation while in DisallowHeapAllocation scope
http://code.google.com/p/v8/issues/detail?id=2907
Fixed in https://code.google.com/p/v8/source/detail?r=17090
--
You received thi
Committed patchset #1 manually as r17090 (presubmit successful).
https://codereview.chromium.org/24999007/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To un
Revision: 17090
Author: ad...@chromium.org
Date: Wed Oct 2 18:06:20 2013 UTC
Log: Avoid allocations in Object.observe access check tests
BUG=v8:2907
R=mstarzin...@chromium.org
Review URL: https://codereview.chromium.org/24999007
http://code.google.com/p/v8/source/detail?r=17090
Modi
A few comments and a general question:
Is it a problem for your tool if allocations of many objects happen using a
single allocation operation or is that fine? For example we allocate object
A,
B, and C together allocate(sizeof(A,B,C)) and then align the object start
pointers at runtime. I am n
Committed patchset #1 manually as r17088 (presubmit successful).
https://chromiumcodereview.appspot.com/25464004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
Revision: 17089
Author: verwa...@chromium.org
Date: Wed Oct 2 17:23:30 2013 UTC
Log: Don't use StubType to probe the code caches.
There is only one stub-type in the cache at all times. By ignoring the type
up-front, we can in a later phase move cache probing before even computing
t
Committed patchset #1 manually as r17089 (presubmit successful).
https://chromiumcodereview.appspot.com/25520003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
Revision: 17088
Author: verwa...@chromium.org
Date: Wed Oct 2 17:20:58 2013 UTC
Log: Use PatchCache for call ICs.
R=u...@chromium.org
Review URL: https://chromiumcodereview.appspot.com/25464004
http://code.google.com/p/v8/source/detail?r=17088
Modified:
/branches/bleeding_edge/src/
Committed patchset #2 manually as r17087 (presubmit successful).
https://chromiumcodereview.appspot.com/25529002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
Revision: 17087
Author: verwa...@chromium.org
Date: Wed Oct 2 17:18:13 2013 UTC
Log: Cleanup map deprecation handling in the ICs
R=u...@chromium.org
Review URL: https://chromiumcodereview.appspot.com/25529002
http://code.google.com/p/v8/source/detail?r=17087
Modified:
/branches/ble
Revision: 17086
Author: verwa...@chromium.org
Date: Wed Oct 2 17:17:00 2013 UTC
Log: Rename ComputeLoadStoreField to just handle ComputeStoreField.
R=jkumme...@chromium.org
Review URL: https://chromiumcodereview.appspot.com/25683005
http://code.google.com/p/v8/source/detail?r=17086
Committed as r17085.
https://codereview.chromium.org/25460003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving
Committed patchset #1 manually as r17086 (presubmit successful).
https://chromiumcodereview.appspot.com/25683005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
Revision: 17085
Author: plin...@gmail.com
Date: Wed Oct 2 17:16:27 2013 UTC
Log: MIPS: Add support to load/store byte fields.
Port r17079 (0885ac2)
Original commit message:
This adds a new Byte representation and support for zero-extended
loads in HLoadNamedField and truncated stores
LGTM, I'll land it.
https://codereview.chromium.org/25460003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving
Committed as r17084.
https://codereview.chromium.org/25708004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving
Revision: 17084
Author: plin...@gmail.com
Date: Wed Oct 2 16:58:37 2013 UTC
Log: MIPS: Improve and simplify removal of unreachable code.
Port r17073 (ba68149)
Original commit message:
- Detect unreachable basic blocks of code either following an unconditional
deopt or after a prova
LGTM on the changes to the lithium-codegen.cc file.
https://codereview.chromium.org/25708004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe fro
Reviewers: ulan,
Description:
Unify and fix checkers for duplicate object literal properties.
R=u...@chromium.org
TEST=preparser/duplicate-property
Please review this at https://codereview.chromium.org/25755002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+3
LGTM, rubber-stamped the first patch set and looked at the deltas, one
comment
to address.
https://codereview.chromium.org/25494007/diff/58001/src/code-stubs.cc
File src/code-stubs.cc (right):
https://codereview.chromium.org/25494007/diff/58001/src/code-stubs.cc#newcode296
src/code-stubs.cc:2
LGTM, I'll land it.
https://codereview.chromium.org/25708004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving
This one requires approval from v8-team as well, Jakob, Danno, Michael, can
one
of you PTAL?
https://codereview.chromium.org/25708004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google
Reviewers: danno, Benedikt Meurer, Paul Lind, kisg, palfia,
Description:
MIPS: Add support to load/store byte fields.
Port r17079 (0885ac2)
Original commit message:
This adds a new Byte representation and support for zero-extended
loads in HLoadNamedField and truncated stores in HStoreNamedFiel
Addressed comments, PTAL again.
https://chromiumcodereview.appspot.com/23537067/diff/6001/src/code-stubs-hydrogen.cc
File src/code-stubs-hydrogen.cc (right):
https://chromiumcodereview.appspot.com/23537067/diff/6001/src/code-stubs-hydrogen.cc#newcode586
src/code-stubs-hydrogen.cc:586: }
On 2013
DBC. Unless I'm missing something, this patch is buggy.
https://codereview.chromium.org/25696004/diff/21001/src/ia32/lithium-codegen-ia32.cc
File src/ia32/lithium-codegen-ia32.cc (right):
https://codereview.chromium.org/25696004/diff/21001/src/ia32/lithium-codegen-ia32.cc#newcode4440
src/ia32/l
Committed patchset #1 manually as r17083.
https://codereview.chromium.org/25665006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this gro
Revision: 17083
Author: da...@chromium.org
Date: Wed Oct 2 16:13:49 2013 UTC
Log: Fix failure in unit tests
R=jkumme...@chromium.org
Review URL: https://codereview.chromium.org/25665006
http://code.google.com/p/v8/source/detail?r=17083
Modified:
/branches/bleeding_edge/src/hydrogen
lgtm
https://codereview.chromium.org/25665006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from i
Reviewers: Jakob,
Description:
Fix failure in unit tests
R=jkumme...@chromium.org
Please review this at https://codereview.chromium.org/25665006/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+12, -8 lines):
M src/hydrogen-instructions.h
M src/hydrogen.cc
Comment #5 on issue 2917 by techwiz2...@gmail.com: Parser doesn't work well
when keywords are used as parameter names
http://code.google.com/p/v8/issues/detail?id=2917
Ok thanks for the response, I guess I'll report the issue to the Chromium
team see if they can find a workaround.
--
You
LGTM. Thanks for that.
https://codereview.chromium.org/25666006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receivi
Updates:
Status: WorkingAsIntended
Comment #4 on issue 2917 by jkumme...@chromium.org: Parser doesn't work
well when keywords are used as parameter names
http://code.google.com/p/v8/issues/detail?id=2917
(No comment was entered for this change.)
--
You received this message because t
Revision: 17082
Author: da...@chromium.org
Date: Wed Oct 2 15:27:51 2013 UTC
Log: Fix test262 failures and x64 compile failure.
R=jkumme...@chromium.org
Review URL: https://codereview.chromium.org/25604008
http://code.google.com/p/v8/source/detail?r=17082
Modified:
/branches/bleedi
Committed patchset #3 manually as r17082.
https://codereview.chromium.org/25604008/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this gro
Comment #3 on issue 2917 by edy.b...@gmail.com: Parser doesn't work well
when keywords are used as parameter names
http://code.google.com/p/v8/issues/detail?id=2917
I feel like I need to pedantic: 1.7 is Mozilla's versioning, the standard
(in draft form) is ES6 (ECMAScript version 6), coden
LGTM
https://codereview.chromium.org/25604008/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it,
Reviewers: Jakob,
Message:
ptal
Description:
Fix test262 failures and x64 compile failure.
Please review this at https://codereview.chromium.org/25604008/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+37, -44 lines):
M src/arm/lithium-arm.cc
M src/hydroge
On 2013/10/02 11:51:01, aandrey wrote:
LGTM.
https://codereview.chromium.org/25605005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this
Reviewers: danno, Jakob, Paul Lind, palfia, kisg, Michael Starzinger,
Description:
MIPS: Improve and simplify removal of unreachable code.
Port r17073 (ba68149)
Original commit message:
- Detect unreachable basic blocks of code either following an unconditional
deopt or after a provably untaken
Reviewers: Michael Starzinger,
Message:
hei, ptal
Description:
Reland "Hydrogenisation of binops"
BUG=
Please review this at https://codereview.chromium.org/25494007/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+960, -3778 lines):
M src/arm/code-stubs-arm
Reviewers: Michael Starzinger,
Message:
Please take a look.
Description:
Handlify GetPropertyWithFailedAccessCheck.
R=mstarzin...@chromium.org
BUG=
Please review this at https://codereview.chromium.org/25732002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+
Reviewers: Michael Starzinger,
Description:
Handlify JSObject::GetPropertyInterceptor.
R=mstarzin...@chromium.org
BUG=
Please review this at https://codereview.chromium.org/25669004/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+98, -64 lines):
M src/ob
https://codereview.chromium.org/25722002/diff/1/src/types.cc
File src/types.cc (right):
https://codereview.chromium.org/25722002/diff/1/src/types.cc#newcode134
src/types.cc:134: if (value->ToInt32(&i)) return kOtherSigned32;
On 2013/10/02 13:35:06, Jakob wrote:
How about:
if (value->To
Reviewers: Michael Starzinger,
Message:
Hey Michi,
This one was marked with TODO(mstarzinger), so you get to review this
CL. :-)
-- Benedikt
Description:
Get rid of the HInstanceSize instruction.
Please review this at https://codereview.chromium.org/25666006/
SVN Base: https://v8.googlecode
LGTM
https://chromiumcodereview.appspot.com/25683005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails f
OK, I will do that.
https://codereview.chromium.org/24978006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving
This was committed with revision 17080, but SVN returned an error (even tho
it
actually did the commit) so the CL was not updated.
https://code.google.com/p/v8/source/detail?r=17080
https://codereview.chromium.org/25468003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.googl
Revision: 17081
Author: hpa...@chromium.org
Date: Wed Oct 2 13:36:38 2013 UTC
Log: Tweak default max heap size constants for platforms with swap.
Configure platforms with swap memory with larger heap size by default. Also
introduce an additional "bucket" between 1GB-2GBs.
BUG=None
R=
Committed patchset #4 manually as r17081 (presubmit successful).
https://codereview.chromium.org/24978006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To un
Comment #2 on issue 2917 by techwiz2...@gmail.com: Parser doesn't work well
when keywords are used as parameter names
http://code.google.com/p/v8/issues/detail?id=2917
So now the question is, does the flag force the 1.7 interpreter to be
always on? I figured it would enable toe features not
LGTM with comment.
https://codereview.chromium.org/25722002/diff/1/src/types.cc
File src/types.cc (right):
https://codereview.chromium.org/25722002/diff/1/src/types.cc#newcode134
src/types.cc:134: if (value->ToInt32(&i)) return kOtherSigned32;
How about:
if (value->ToInt32(&i)) {
Revision: 17080
Author: bmeu...@chromium.org
Date: Wed Oct 2 13:30:31 2013 UTC
Log: Always use timeGetTime() for TimeTicks::Now() on Windows.
This way, we also ensure that timeGetTime() is used for Time::Now(),
and thereby Date.now() even if GetTickCount64() is available.
Also add te
LGTM, minor nits.
https://codereview.chromium.org/25009003/diff/7001/src/hydrogen.cc
File src/hydrogen.cc (right):
https://codereview.chromium.org/25009003/diff/7001/src/hydrogen.cc#newcode8304
src/hydrogen.cc:8304: } else if (combined_type->NumClasses() == 1 &&
fits in one line
https://codere
Revision: 17079
Author: bmeu...@chromium.org
Date: Wed Oct 2 13:27:53 2013 UTC
Log: Add support to load/store byte fields.
This adds a new Byte representation and support for zero-extended
loads in HLoadNamedField and truncated stores in HStoreNamedField.
R=mvstan...@chromium.org
Re
Committed patchset #5 manually as r17079 (presubmit successful).
https://codereview.chromium.org/25696004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To un
Updates:
Owner: rossb...@chromium.org
Cc: -rossb...@chromium.org jkumme...@chromium.org
Comment #4 on issue 2910 by rossb...@chromium.org: non-smi int32 constants
confuse representation inference
http://code.google.com/p/v8/issues/detail?id=2910
(No comment was entered for thi
Reviewers: Jakob,
Description:
More precise type lub for numbers
R=jkumme...@chromium.org
BUG=v8:2910
Please review this at https://codereview.chromium.org/25722002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+9, -3 lines):
M src/types.cc
Index: src/typ
Revision: 17078
Author: verwa...@chromium.org
Date: Wed Oct 2 13:24:08 2013 UTC
Log: Only fold polymorphic into monomorphic load if all load from
either receiver or same prototype.
R=jkumme...@chromium.org
Review URL: https://chromiumcodereview.appspot.com/25718002
http://code.goo
Committed patchset #2 manually as r17078.
https://chromiumcodereview.appspot.com/25718002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from t
Reviewers: Jakob,
Message:
PTAL
Description:
Rename ComputeLoadStoreField to just handle ComputeStoreField.
Please review this at https://chromiumcodereview.appspot.com/25683005/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+27, -28 lines):
M src/hydrogen.c
LGTM
https://chromiumcodereview.appspot.com/25718002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails f
Reviewers: Jakob,
Message:
PTAL
Description:
Only fold polymorphic into monomorphic load if all load from either
receiver or
same prototype.
Please review this at https://chromiumcodereview.appspot.com/25718002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files
Could someone land this when convenient please.
https://codereview.chromium.org/24978006/diff/15001/src/defaults.cc
File src/defaults.cc (right):
https://codereview.chromium.org/24978006/diff/15001/src/defaults.cc#newcode55
src/defaults.cc:55: if (physical_memory <= 512ul * i::MB) {
On 2013/10/
LGTM, with comments.
https://codereview.chromium.org/24978006/diff/1/src/globals.h
File src/globals.h (right):
https://codereview.chromium.org/24978006/diff/1/src/globals.h#newcode286
src/globals.h:286: #if V8_OS_ANDROID
On 2013/10/01 13:34:17, rmcilroy wrote:
On 2013/09/27 13:47:50, Hannes Pa
On 2013/10/01 14:02:12, Jakob wrote:
lgtm
Hannes, do you have any comments?
https://codereview.chromium.org/24978006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev"
LGTM
https://codereview.chromium.org/25468003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it,
And a test would be awesome.
https://codereview.chromium.org/23477061/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop r
Renamed to VerifyWeakEmbeddedObjectsInOptimizedCode in new patchset.
https://chromiumcodereview.appspot.com/23477061/diff/25002/src/mark-compact.cc
File src/mark-compact.cc (right):
https://chromiumcodereview.appspot.com/23477061/diff/25002/src/mark-compact.cc#newcode433
src/mark-compact.cc:433
PTAL
https://codereview.chromium.org/25468003/diff/1/src/platform/time.cc
File src/platform/time.cc (right):
https://codereview.chromium.org/25468003/diff/1/src/platform/time.cc#newcode183
src/platform/time.cc:183: // Check if we need to resynchronize due to
backwards time
On 2013/10/02 11:27:2
LGTM, a few renaming/reformatting nits
https://codereview.chromium.org/23477061/diff/25002/src/mark-compact.cc
File src/mark-compact.cc (right):
https://codereview.chromium.org/23477061/diff/25002/src/mark-compact.cc#newcode433
src/mark-compact.cc:433: if
(heap()->weak_embedded_maps_verificatio
Revision: 17077
Author: da...@chromium.org
Date: Wed Oct 2 12:16:57 2013 UTC
Log: Fix improper usage of V8_OVERRIDE.
R=jkumme...@chromium.org
Review URL: https://codereview.chromium.org/25715002
http://code.google.com/p/v8/source/detail?r=17077
Modified:
/branches/bleeding_edge/src
lgtm
https://codereview.chromium.org/25715002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from i
Reviewers: Jakob,
Message:
PTAL
Description:
Fix improper usage of V8_OVERRIDE.
Please review this at https://codereview.chromium.org/25715002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+2, -2 lines):
M src/hydrogen-instructions.h
Index: src/hydrogen-i
Preserved the test suite. PTAL.
https://codereview.chromium.org/25277003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and sto
Thanks for the review. I will commit it when the tree is open again.
https://codereview.chromium.org/25682002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
T
right on, looks good.
https://codereview.chromium.org/25696004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receivin
Revision: 17076
Author: jkumme...@chromium.org
Date: Wed Oct 2 11:50:10 2013 UTC
Log: Tagging version 3.22.6
http://code.google.com/p/v8/source/detail?r=17076
Added:
/tags/3.22.6
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You receive
Reviewers: Yang, yurys,
Description:
Debug: Allow stepping into on a given call frame.
R=yang...@chromium.org,yurys
Please review this at https://codereview.chromium.org/25605005/
SVN Base: git://github.com/v8/v8.git@master
Affected files (+71, -31 lines):
M src/runtime.cc
M test/mjsunit/
lgtm
https://codereview.chromium.org/25682002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from i
https://codereview.chromium.org/25696004/diff/1/src/x64/lithium-codegen-x64.cc
File src/x64/lithium-codegen-x64.cc (right):
https://codereview.chromium.org/25696004/diff/1/src/x64/lithium-codegen-x64.cc#newcode2791
src/x64/lithium-codegen-x64.cc:2791: MemOperand operand =
MemOperand(ToRegister(i
Committed patchset #2 manually as r17074 (presubmit successful).
https://codereview.chromium.org/24754002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To un
Revision: 17074
Author: haitao.f...@intel.com
Date: Wed Oct 2 11:46:01 2013 UTC
Log: Tweak SmiAdd for X64
R=da...@chromium.org
Review URL: https://codereview.chromium.org/24754002
http://code.google.com/p/v8/source/detail?r=17074
Modified:
/branches/bleeding_edge/src/x64/macro-asse
Committed patchset #22 manually as r17073 (presubmit successful).
https://codereview.chromium.org/22876009/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
Revision: 17072
Author: ol...@chromium.org
Date: Wed Oct 2 11:32:19 2013 UTC
Log: Add flag for printing the time it took to deserialize the
snapshot.
BUG=
R=yang...@chromium.org
Review URL: https://codereview.chromium.org/25695002
http://code.google.com/p/v8/source/detail?r=17072
Committed patchset #1 manually as r17072 (presubmit successful).
https://codereview.chromium.org/25695002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To un
1 - 100 of 159 matches
Mail list logo
