On 2013/12/05 07:38:12, Sven Panne wrote:
On 2013/12/05 07:15:22, yurys wrote:
> Sven, I've made the destructor protected, do you have any other
concerns?
I think it is OK, moving to std::unique_ptr might still take a few
years...
:-}
Could you provide OWNER's approval then ? :-)
https:/
On 2013/12/05 07:15:22, yurys wrote:
Sven, I've made the destructor protected, do you have any other concerns?
I think it is OK, moving to std::unique_ptr might still take a few
years... :-}
https://codereview.chromium.org/101763003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http:/
On 2013/12/05 07:15:22, yurys wrote:
Sven, I've made the destructor protected, do you have any other concerns?
I think it is OK, moving to std::unique_ptr might still take a few
years... :-}
https://codereview.chromium.org/101763003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http:/
Comment #7 on issue 3035 by svenpa...@chromium.org: Math.sin(Math.PI)
inaccurate
http://code.google.com/p/v8/issues/detail?id=3035
Every argument made about floating point and accuracy which doesn't involve
the notion of ranges if basically invalid. Every floating point value does
not rep
Comment #5 on issue 2228 by kyzl...@gmail.com: Generate SIMD instructions
for SIMD-like code patterns
http://code.google.com/p/v8/issues/detail?id=2228
Recently I wrote a program in C. During code execution, data calculation is
bottleneck. I would like to solve the problem using SIMD, but h
Sven, I've made the destructor protected, do you have any other concerns?
https://codereview.chromium.org/101763003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" gro
Reviewers: Toon Verwaest,
Message:
PTAL.
I worked out this patch by modifying the python x32 generator to only
replace
movq with movp for x64 files at the places when we need to replace movq to
movl.
I have applied this patch to x32 at
https://github.com/fenghaitao/v8/commit/29230a30ceba1dd
Status: New
Owner:
New issue 3036 by mgi...@chromium.org: objects-debug.cc check-failed in
Chrome
http://code.google.com/p/v8/issues/detail?id=3036
Chrome Version: 33 (SVN 238529) aura
OS: Linux
URL (if applicable) where crash occurred:
chrome://extensions
Can you reproduce this crash?
LGTM with 1 comment. Make sure to check performance though.
https://codereview.chromium.org/96083005/diff/210001/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/96083005/diff/210001/src/objects.cc#newcode10868
src/objects.cc:10868: if (!needs_extended_extra_ic_state(
Reviewers: machenbach,
Message:
With this, the global makefile wouldn't have to set `builddir` in the
`buildbot`
target either (but that target isn't used any more).
If this lgty, you probably have to land this yourself since this is
probably off
the wrong branch (?)
Description:
Pass -Go
Comment #6 on issue 3035 by r...@chromium.org: Math.sin(Math.PI) inaccurate
http://code.google.com/p/v8/issues/detail?id=3035
No, the expected answer cannot not be zero because Math.PI is NOT pi.
--
You received this message because this project is configured to send all
issue notifications t
Comment #5 on issue 3035 by oao.hika...@gmail.com: Math.sin(Math.PI)
inaccurate
http://code.google.com/p/v8/issues/detail?id=3035
0.0001224646798818428 (actual)
0.000 (expected)
(1.224646798818428e-16 - 0) <= 1e-15 // true
--
You received this messag
Whew. PTAL.
https://codereview.chromium.org/96083005/diff/160001/src/disassembler.cc
File src/disassembler.cc (right):
https://codereview.chromium.org/96083005/diff/160001/src/disassembler.cc#newcode240
src/disassembler.cc:240: if (!code->needs_extended_extra_ic_state(kind)
&&
On 2013/12/04 18:
Hi!
Dan, please take a look at the API part of the change.
Danno, could you please review or find a reviewer for a Hydrogen part of
this
change?
Alternative to fixing SCE would be to insert stack guards into each CallIC
stub
and each builtin which I think is not robust and will break when
Comment #4 on issue 3035 by r...@chromium.org: Math.sin(Math.PI) inaccurate
http://code.google.com/p/v8/issues/detail?id=3035
I filed a bug because the current value is only accurate to about 10
digits, out of about 15. The C library produces 15 digits.
--
You received this message becaus
Comment #3 on issue 3035 by jkumme...@chromium.org: Math.sin(Math.PI)
inaccurate
http://code.google.com/p/v8/issues/detail?id=3035
OK, maybe I wasn't clear.
My first statement commented on the fact that the new result is much closer
to what you stated to be the correct answer. Given this,
I like this change! Looking good. Added comments and nitty nits.
https://codereview.chromium.org/96083005/diff/160001/src/disassembler.cc
File src/disassembler.cc (right):
https://codereview.chromium.org/96083005/diff/160001/src/disassembler.cc#newcode240
src/disassembler.cc:240: if (!code->nee
https://codereview.chromium.org/99013003/diff/40001/src/runtime.cc
File src/runtime.cc (right):
https://codereview.chromium.org/99013003/diff/40001/src/runtime.cc#newcode8670
src/runtime.cc:8670: if (!unoptimized->contains(frame->pc())) {
I am not sure this is an improvement to no longer take th
Added comments.
https://codereview.chromium.org/57123002/diff/1270001/src/code-stubs-hydrogen.cc
File src/code-stubs-hydrogen.cc (right):
https://codereview.chromium.org/57123002/diff/1270001/src/code-stubs-hydrogen.cc#newcode1331
src/code-stubs-hydrogen.cc:1331: HValue* elements =
AddLoadEleme
Comment #2 on issue 3035 by r...@chromium.org: Math.sin(Math.PI) inaccurate
http://code.google.com/p/v8/issues/detail?id=3035
Your two statements are inconsistent. You can't claim that it's better and
also believe abs(expected-actual) <= 1e-15 is the best you can hope for.
And I don't under
sheriff's notice: ok to land since this is under the flag
https://codereview.chromium.org/104173002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubsc
Hi Toon,
Okay, per your verbal comments, I've moved loads and stores out of the
builtins
into the stub cache. Thanks!
--Michael
https://codereview.chromium.org/96083005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message beca
NOT LGTM.
https://codereview.chromium.org/104843002/diff/1/src/hydrogen-check-elimination.cc
File src/hydrogen-check-elimination.cc (right):
https://codereview.chromium.org/104843002/diff/1/src/hydrogen-check-elimination.cc#newcode292
src/hydrogen-check-elimination.cc:292:
removed->DeleteAndRep
https://codereview.chromium.org/104903002/diff/10001/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/104903002/diff/10001/src/objects.cc#newcode9181
src/objects.cc:9181: if (FLAG_track_allocation_sites) {
On 2013/12/04 16:16:50, mvstanton wrote:
I think you want to a
Provided the comment below is addressed, then LGTM.
https://codereview.chromium.org/104903002/diff/10001/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/104903002/diff/10001/src/objects.cc#newcode9181
src/objects.cc:9181: if (FLAG_track_allocation_sites) {
I think y
Reviewers: mvstanton,
Description:
Generalize AllocationMemento::FindForHeapObject and remove corresponding new
space check.
BUG=
Please review this at https://codereview.chromium.org/104903002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+13, -13 lines):
Ben, can you take a look?
Weiliang, did you consider my other suggestion to only check the map once
explicitly? This can be done both for the IsClass case and the non-IsClass
case,
since the equality guarantees one check suffices.
https://codereview.chromium.org/104843002/
--
--
v8-dev maili
LGTM
https://codereview.chromium.org/104173002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it
Reviewers: Hannes Payer,
Description:
[platform] Implement a worker pool
We don't use the worker pool yet, however, there are tests. Yay. The
next step is to use the worker pool for parallel sweeping.
I've also started to move the platform related files into a sub
directory. The goal is to even
Updates:
Status: Assigned
Owner: vego...@chromium.org
Cc: da...@chromium.org
Comment #2 on issue 1652 by vego...@chromium.org: The Crankshaft stack
check eliminator assume all calls have stack checks
http://code.google.com/p/v8/issues/detail?id=1652
I will steal this,
Looking good. Just one comment.
https://codereview.chromium.org/100613004/diff/60001/src/runtime.cc
File src/runtime.cc (right):
https://codereview.chromium.org/100613004/diff/60001/src/runtime.cc#newcode8695
src/runtime.cc:8695:
function->shared()->InstallFromOptimizedCodeMap(*function,
cached
On 2013/12/04 09:21:07, jarin wrote:
lgtm.
thanks.
I updated the implementation for asinh to better deal with large negative
input.
https://codereview.chromium.org/104173002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this m
On 2013/12/04 09:52:56, Toon Verwaest wrote:
LGTM. The use of NONE64 is a bit odd given that Move (movp) will move a
NONE32
on x32. Should we introduce a NONEP perhaps? We can defer this to a
future CL
though.
We could introduce a static function in X64 Assembler.
static inline RelocInfo::
Revision: 18256
Author: yang...@chromium.org
Date: Wed Dec 4 11:39:24 2013 UTC
Log: Remove unused trigonometric code.
R=jkumme...@chromium.org
Review URL: https://codereview.chromium.org/104203003
http://code.google.com/p/v8/source/detail?r=18256
Modified:
/branches/bleeding_edge/s
Committed patchset #4 manually as r18256.
https://codereview.chromium.org/104203003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this gr
Adding Dan, just to avoid any possibly duplicated work/plans/etc.
Note that this is still work in progress, I'll have to remove the support
for
old skool final^H^H^H callbacks.
If there is more stuff to remove (e.g. the tons of "TODO(dcarney) Remove
me"),
please yell. If we can remove this
Comment #6 on issue 2825 by deve...@gmail.com: breakpoint resolved to
incorrect location
http://code.google.com/p/v8/issues/detail?id=2825
Any news? Any progress?
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjus
Reviewers: Paul Lind, dusmil, palfia,
Description:
MIPS: Faster memcpy.
BUG=
Please review this at https://codereview.chromium.org/104353002/
SVN Base: git://github.com/v8/v8.git@bleeding_edge
Affected files (+523, -0 lines):
M src/mips/assembler-mips.h
M src/mips/assembler-mips.cc
M sr
Committed patchset #2 manually as r18255.
https://codereview.chromium.org/104313003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this gr
Revision: 18255
Author: mvstan...@chromium.org
Date: Wed Dec 4 10:46:18 2013 UTC
Log: Remove unnecessary overflow check in
HGraphBuilder::BuildCreateAllocationMemento().
With this fix codegen looks like:
mov ecx,[eax+0xf] ;;; <@52,#38> load-named-field
add ecx,0x2 ;;; <@54,#40>
sheriff's notice: ok to land
https://codereview.chromium.org/104313003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop
LGTM, just make the comment more precise
https://codereview.chromium.org/104313003/diff/1/src/hydrogen.cc
File src/hydrogen.cc (right):
https://codereview.chromium.org/104313003/diff/1/src/hydrogen.cc#newcode2595
src/hydrogen.cc:2595: // This smi value is reset to zero after every gc,
overflow
Reviewers: Benedikt Meurer, Hannes Payer,
Message:
Hi guys, here is the restored overflow check. Hannes, the reason we didn't
see
it was because we cleared the overflow bit on the wrong instruction (the
store,
not the add).
Thanks,
--Michael
Description:
Remove unnecessary overflow check in
LGTM, go ahead! :-)
https://codereview.chromium.org/104313003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving
LGTM.
https://codereview.chromium.org/104203003/diff/1/src/heap-inl.h
File src/heap-inl.h (left):
https://codereview.chromium.org/104203003/diff/1/src/heap-inl.h#oldcode774
src/heap-inl.h:774: case EXP:
You can delete EXP while you are at it. AFAICS it is only ever used in
this function here.
Committed patchset #2 manually as r18254.
https://codereview.chromium.org/104183002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this gr
Revision: 18254
Author: svenpa...@chromium.org
Date: Wed Dec 4 10:09:08 2013 UTC
Log: Remove internal uses of HandleScope::Close().
R=dslo...@chromium.org
Review URL: https://codereview.chromium.org/104183002
http://code.google.com/p/v8/source/detail?r=18254
Modified:
/branches/ble
Reviewers: Jakob,
Description:
Remove unused trigonometric code.
R=jkumme...@chromium.org
Please review this at https://codereview.chromium.org/104203003/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+14, -765 lines):
M src/arm/code-stubs-arm.cc
M src/ar
Revision: 18253
Author: mvstan...@chromium.org
Date: Wed Dec 4 09:54:23 2013 UTC
Log: AllocationSite::memento_found_count() and friends need Smi access.
Some new AllocationSite fields weren't accessed with the correct
representation.
R=hpa...@chromium.org
Review URL: https://coderev
Committed patchset #1 manually as r18253 (presubmit successful).
https://codereview.chromium.org/101783005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
lgtm
https://codereview.chromium.org/100843002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
LGTM. The use of NONE64 is a bit odd given that Move (movp) will move a
NONE32
on x32. Should we introduce a NONEP perhaps? We can defer this to a future
CL
though.
https://codereview.chromium.org/64453002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-d
lgtm
https://codereview.chromium.org/101083002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
Revision: 18252
Author: machenb...@chromium.org
Date: Wed Dec 4 09:43:21 2013 UTC
Log: Tagging version 3.23.18
http://code.google.com/p/v8/source/detail?r=18252
Added:
/tags/3.23.18
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You rece
Revision: 18250
Author: machenb...@chromium.org
Date: Wed Dec 4 09:42:29 2013 UTC
Log: Prepare push to trunk. Now working on version 3.23.19.
R=dslo...@chromium.org
TBR=dslo...@chromium.org
Review URL: https://codereview.chromium.org/104183003
http://code.google.com/p/v8/source/deta
lgtm
https://codereview.chromium.org/104183003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
Committed patchset #1 manually as r18250 (presubmit successful).
https://codereview.chromium.org/104183003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
Reviewers: Dmitry Lomov (chromium),
Description:
Prepare push to trunk. Now working on version 3.23.19.
R=dslo...@chromium.org
TBR=dslo...@chromium.org
Please review this at https://codereview.chromium.org/104183003/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected fil
lgtm
https://codereview.chromium.org/104183002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
Revision: 18249
Author: bmeu...@chromium.org
Date: Wed Dec 4 09:27:48 2013 UTC
Log: Revert "Use constant types to represent the fixed right arg of a
MOD."
This reverts commit r18246 for tanking all benchmarks.
TBR=svenpa...@chromium.org
Review URL: https://codereview.chromium.org
Reviewers: Sven Panne,
Message:
Committed patchset #1 manually as r18249.
Description:
Revert "Use constant types to represent the fixed right arg of a MOD."
This reverts commit r18246 for tanking all benchmarks.
TBR=svenpa...@chromium.org
Committed: https://code.google.com/p/v8/source/detail
Mostly stylistic comments + objection to shipping deref/relying on defer in
tests that might be addressed in a separate CL
https://codereview.chromium.org/99573002/diff/1/src/promise.js
File src/promise.js (right):
https://codereview.chromium.org/99573002/diff/1/src/promise.js#newcode230
src/pr
lgtm.
thanks.
https://codereview.chromium.org/104173002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving ema
Reviewers: jarin,
Message:
Please take a look. The second patch set is the fix.
Description:
Reland "Implement hyperbolic math functions for ES6."
BUG=v8:2938
LOG=N
Please review this at https://codereview.chromium.org/104173002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Reviewers: Dmitry Lomov (chromium),
Description:
Remove internal uses of HandleScope::Close().
Please review this at https://codereview.chromium.org/104183002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+28, -28 lines):
M samples/process.cc
M src/d8.cc
Committed patchset #1 manually as r18246 (presubmit successful).
https://codereview.chromium.org/103933002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
https://codereview.chromium.org/103973002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send
Hi guys,
I prefer this style because it's object-oriented. Fields of a single object
deserve an encapsulating structure, and the case statement does that. If
each
field access for a single object has to be maintained with three or 4 lines
that
only appear "together" by convention in the header
Committed patchset #2 manually as r18247.
https://codereview.chromium.org/102253002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this gr
Revision: 18245
Author: yang...@chromium.org
Date: Wed Dec 4 08:32:18 2013 UTC
Log: Implement hyperbolic math functions for ES6.
R=ja...@chromium.org
BUG=v8:2938
LOG=Y
Review URL: https://codereview.chromium.org/102023003
http://code.google.com/p/v8/source/detail?r=18245
Added:
/br
https://codereview.chromium.org/93843004/diff/1/src/api.cc#newcode7500
src/api.cc:7500:
nit: add an empty line
Done.
https://codereview.chromium.org/93843004/diff/1/test/cctest/test-heap-profiler.cc#newcode1067
test/cctest/test-heap-profiler.cc:1067:
heap_profiler->StopTrackingHeapObjects();
May
Revision: 18248
Author: yang...@chromium.org
Date: Wed Dec 4 08:53:17 2013 UTC
Log: Revert "Implement hyperbolic math functions for ES6."
BUG=
Review URL: https://codereview.chromium.org/104003002
http://code.google.com/p/v8/source/detail?r=18248
Deleted:
/branches/bleeding_edge/te
Reviewers: ,
Message:
Committed patchset #1 manually as r18248.
Description:
Revert "Implement hyperbolic math functions for ES6."
BUG=
Committed: https://code.google.com/p/v8/source/detail?r=18248
Please review this at https://codereview.chromium.org/104003002/
SVN Base: https://v8.googleco
lgtm (rubberstamp)
but please add the revert reason to description before landing
https://codereview.chromium.org/103973002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-
https://codereview.chromium.org/103973002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send
https://codereview.chromium.org/103973002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send
Reviewers: Dmitry Lomov (chromium),
Description:
Revert "Implement hyperbolic math functions for ES6."
R=dslo...@chromium.org
BUG=
Please review this at https://codereview.chromium.org/103973002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+1, -210 lines):
Revision: 18247
Author: machenb...@chromium.org
Date: Wed Dec 4 08:47:18 2013 UTC
Log: Add fully automated mode to push-to-trunk script.
Now there are three modes to run the script:
(1) default: semi-automated
(2) manual (-m option), like in the old script
(3) forced (-f option), no u
On 2013/12/04 08:07:47, jochen wrote:
we can't use std::unique_ptr because it's not available on mac os 10.6's
libstdc++
Using get() however is inline with the std::unique_ptr API so I think
this is
a
good change.
scoped_ptr doesn't depend on unique_ptr while provides similar interface
Revision: 18246
Author: bmeu...@chromium.org
Date: Wed Dec 4 08:37:34 2013 UTC
Log: Use constant types to represent the fixed right arg of a MOD.
R=svenpa...@chromium.org
Review URL: https://codereview.chromium.org/103933002
http://code.google.com/p/v8/source/detail?r=18246
Modified
lgtm
https://codereview.chromium.org/93843004/diff/1/src/api.cc
File src/api.cc (right):
https://codereview.chromium.org/93843004/diff/1/src/api.cc#newcode7500
src/api.cc:7500:
nit: add an empty line
https://codereview.chromium.org/93843004/diff/1/test/cctest/test-heap-profiler.cc
File test/
On 2013/12/04 07:44:47, alph wrote:
https://codereview.chromium.org/101763003/diff/1/src/smart-pointers.h
File src/smart-pointers.h (right):
https://codereview.chromium.org/101763003/diff/1/src/smart-pointers.h#newcode54
src/smart-pointers.h:54: ~SmartPointerBase() { if (p_)
Deallocator::Del
lgtm
https://codereview.chromium.org/102943003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/103933002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
Committed patchset #2 manually as r18245 (presubmit successful).
https://codereview.chromium.org/102023003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
https://codereview.chromium.org/93843004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send
Reviewers: alph, loislo, Michael Starzinger, Hannes Payer,
Description:
Add methods for finding object by its snapshot id and id for an object
Object<-->id mapping doesn't depend on a particular snapshot, actually same
object may appear in several heap snapshots. The API for converting between
Reviewers: Sven Panne,
Message:
Next try...
Description:
Use constant types to represent the fixed right arg of a MOD.
Please review this at https://codereview.chromium.org/103933002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+52, -59 lines):
M src/ast.h
https://codereview.chromium.org/61463005/diff/540001/src/hydrogen-instructions.cc
File src/hydrogen-instructions.cc (right):
https://codereview.chromium.org/61463005/diff/540001/src/hydrogen-instructions.cc#newcode3443
src/hydrogen-instructions.cc:3443: // because otherwise it will prevent
write
Revision: 18244
Author: bmeu...@chromium.org
Date: Wed Dec 4 08:25:58 2013 UTC
Log: Fix performance regression in Kraken audio-oscillator.
BUG=325529
LOG=y
R=hpa...@chromium.org
Review URL: https://codereview.chromium.org/103903002
http://code.google.com/p/v8/source/detail?r=18244
M
Committed patchset #1 manually as r18244 (presubmit successful).
https://codereview.chromium.org/103903002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
LGTM
https://codereview.chromium.org/103903002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it
Updates:
Status: WorkingAsIntended
Comment #1 on issue 3035 by jkumme...@chromium.org: Math.sin(Math.PI)
inaccurate
http://code.google.com/p/v8/issues/detail?id=3035
So precision got much better with the new implementation, that's great!
FWIW, in my opinion Math.sin(Math.PI) should b
LGTM
https://codereview.chromium.org/102253002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it
we can't use std::unique_ptr because it's not available on mac os 10.6's
libstdc++
Using get() however is inline with the std::unique_ptr API so I think this
is a
good change.
https://codereview.chromium.org/101763003/diff/1/src/smart-pointers.h
File src/smart-pointers.h (right):
https://co
Reviewers: Hannes Payer,
Message:
PTAL
Description:
Fix performance regression in Kraken audio-oscillator.
BUG=325529
LOG=y
Please review this at https://codereview.chromium.org/103903002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+1, -1 lines):
M src/i
https://codereview.chromium.org/102943003/diff/1/src/x64/stub-cache-x64.cc
File src/x64/stub-cache-x64.cc (right):
https://codereview.chromium.org/102943003/diff/1/src/x64/stub-cache-x64.cc#newcode478
src/x64/stub-cache-x64.cc:478: __ lea(rax,
args.GetArgumentOperand(offset - FCA::kHolderIndex))
97 matches
Mail list logo
