LGTM, I'll land it for you. Note that the CQ does not work for the v8
project.
https://codereview.chromium.org/203263017/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-d
Comment #17 on issue 3205 by svenpa...@chromium.org: "Too many variables"
limit prohibits new Emscripten application from running
http://code.google.com/p/v8/issues/detail?id=3205
Regarding #15: The fix is extremely localized and is low-risk, so I think
we should really back-merge it. The p
Committed patchset #1 manually as r20140 (presubmit successful).
https://codereview.chromium.org/196893003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer or
a lowly provisional committer, _not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing
CQ is trying da patch. Follow status at
https://v8-status.appspot.com/cq/frkoe...@google.com/203263017/20001
https://codereview.chromium.org/203263017/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscrib
Comment #16 on issue 3205 by alonza...@gmail.com: "Too many variables"
limit prohibits new Emscripten application from running
http://code.google.com/p/v8/issues/detail?id=3205
More details that are now public: the demo mentioned here is a Unity 3D
game, Dead Trigger 2, shown at GDC a few d
lgtm
https://codereview.chromium.org/203263017/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
Reviewers: Sven Panne, jbramley, Rodolph Perfetta (ARM), Rodolph Perfetta,
https://codereview.chromium.org/203263017/diff/1/src/a64/simulator-a64.h
File src/a64/simulator-a64.h (right):
https://codereview.chromium.org/203263017/diff/1/src/a64/simulator-a64.h#newcode171
src/a64/simulator-a64.h:1
Committed as r20139.
https://codereview.chromium.org/206763002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receivin
Revision: 20139
Author: plin...@gmail.com
Date: Thu Mar 20 19:12:08 2014 UTC
Log: MIPS: Fix register usage of r20076.
BUG=
R=plin...@gmail.com
Review URL: https://codereview.chromium.org/206763002
Patch from Balazs Kilvady .
http://code.google.com/p/v8/source/detail?r=20139
Modified
LGTM, thanks for the fix.
https://codereview.chromium.org/206763002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop rec
Reviewers: danno, rossberg, Paul Lind, kisg, dusmil, palfia,
Description:
MIPS: Fix register usage of r20076.
BUG=
Please review this at https://codereview.chromium.org/206763002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+5, -5 lines):
M src/mips/builti
Revision: 20138
Author: mstarzin...@chromium.org
Date: Thu Mar 20 18:14:33 2014 UTC
Log: Fix missing access check in Runtime_SetPrototype.
R=rossb...@chromium.org
BUG=chromium:354123
TEST=cctest/test-api/Regress354123
LOG=y
Review URL: https://codereview.chromium.org/205033011
http://
Reviewers: rossberg,
Message:
Committed patchset #1 manually as r20138 (presubmit successful).
Description:
Fix missing access check in Runtime_SetPrototype.
R=rossb...@chromium.org
BUG=chromium:354123
TEST=cctest/test-api/Regress354123
LOG=y
Committed: https://code.google.com/p/v8/source/deta
lgtm
https://codereview.chromium.org/205033011/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
+Benedikt for review!
https://codereview.chromium.org/206253003/diff/20001/src/platform-win32.cc
File src/platform-win32.cc (right):
https://codereview.chromium.org/206253003/diff/20001/src/platform-win32.cc#newcode1426
src/platform-win32.cc:1426: static void setCurThreadName(const char*
name)
lgtm
https://codereview.chromium.org/198463006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
Reviewers: Jakob,
Message:
PTAL
Description:
Ensure that lazy deopt sequence does not override calls.
BUG=354433
LOG=N
TEST=mjsunit/regress/regress-354433.js
Please review this at https://codereview.chromium.org/198463006/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affect
Revision: 20137
Author: jkumme...@chromium.org
Date: Thu Mar 20 16:25:24 2014 UTC
Log: Fix polymorphic hydrogen handling of SLOPPY_ARGUMENTS_ELEMENTS
BUG=chromium:354391
LOG=y
R=verwa...@chromium.org
Review URL: https://codereview.chromium.org/206073008
http://code.google.com/p/v8/sou
Comment #17 on issue 3060 by clearscr...@gmail.com: V8 3.23.1 and later do
not honor v8::V8::IgnoreOutOfMemoryException()
http://code.google.com/p/v8/issues/detail?id=3060
Thanks for following up! Just curious - what if the isolate exceeds its
resource limit by allocating lots of small obje
Committed patchset #1 manually as r20137 (presubmit successful).
https://codereview.chromium.org/206073008/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
lgtm
https://codereview.chromium.org/206073008/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
Reviewers: Toon Verwaest,
Message:
PTAL.
Description:
Fix polymorphic hydrogen handling of SLOPPY_ARGUMENTS_ELEMENTS
BUG=chromium:354391
LOG=y
R=verwa...@chromium.org
Please review this at https://codereview.chromium.org/206073008/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edg
Revision: 20136
Author: rossb...@chromium.org
Date: Thu Mar 20 16:13:09 2014 UTC
Log: Reland "Implement ES6 symbol registry and predefined symbols"
Only change relative to original CL is the updated assertion condition at
objects-inl.h:2119
R=mstarzin...@chromium.org
BUG=
Review U
Committed patchset #1 manually as r20136 (presubmit successful).
https://codereview.chromium.org/204913006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
Comment #15 on issue 3205 by k...@chromium.org: "Too many variables" limit
prohibits new Emscripten application from running
http://code.google.com/p/v8/issues/detail?id=3205
FYI - I am not sure it is wise to merge this fix to M34 due to the
potential for breakage. There is no urgent rush t
Reviewers: Michael Starzinger,
Message:
mstarzinger, ptal
https://codereview.chromium.org/206433003/diff/1/src/parser.h
File src/parser.h (left):
https://codereview.chromium.org/206433003/diff/1/src/parser.h#oldcode745
src/parser.h:745: Expression* ParseUnaryExpression(bool* ok);
These are lef
Committed as r20135.
https://codereview.chromium.org/206373004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receivin
Revision: 20135
Author: plin...@gmail.com
Date: Thu Mar 20 16:04:51 2014 UTC
Log: MIPS: Implement flooring division by a constant via truncating
division by a constant.
Port r20123 (31ab416)
BUG=
R=plin...@gmail.com
Review URL: https://codereview.chromium.org/206373004
Patch from
lgtm
https://codereview.chromium.org/206373004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
Hi Toon,
Thanks for the comments, and sorry for the delay in addressing! PTAL,
thanks,
--Michael
https://codereview.chromium.org/172523002/diff/160001/src/code-stubs.h
File src/code-stubs.h (right):
https://codereview.chromium.org/172523002/diff/160001/src/code-stubs.h#newcode837
src/code-st
Revision: 20134
Author: machenb...@chromium.org
Date: Thu Mar 20 15:46:59 2014 UTC
Log: Tagging version 3.25.22
http://code.google.com/p/v8/source/detail?r=20134
Added:
/tags/3.25.22
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You rece
Revision: 20132
Author: machenb...@chromium.org
Date: Thu Mar 20 15:44:30 2014 UTC
Log: Allow to push arbitrary revisions when pushing to trunk.
BUG=
R=jkumme...@chromium.org
Review URL: https://codereview.chromium.org/206133004
http://code.google.com/p/v8/source/detail?r=20132
Modif
Committed patchset #1 manually as r20132 (presubmit successful).
https://codereview.chromium.org/206133004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
LGTM with a comment.
https://codereview.chromium.org/206223003/diff/1/src/objects-inl.h
File src/objects-inl.h (right):
https://codereview.chromium.org/206223003/diff/1/src/objects-inl.h#newcode6584
src/objects-inl.h:6584: // static
We don't have the convention of denoting implementations of st
Revision: 20131
Author: alexandre.ra...@arm.com
Date: Thu Mar 20 15:25:27 2014 UTC
Log: A64: Restore the stack limit protection to 1KB.
R=u...@chromium.org
Review URL: https://codereview.chromium.org/206393002
http://code.google.com/p/v8/source/detail?r=20131
Modified:
/branches/ble
Committed patchset #1 manually as r20131 (presubmit successful).
https://codereview.chromium.org/206393002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
Reviewers: danno, Sven Panne, Paul Lind, kisg, palfia, dusmil,
Description:
MIPS: Implement flooring division by a constant via truncating division by a
constant.
Port r20123 (31ab416)
BUG=
Please review this at https://codereview.chromium.org/206373004/
SVN Base: https://github.com/v8/v8.git
Revision: 20130
Author: yang...@chromium.org
Date: Thu Mar 20 15:23:31 2014 UTC
Log: Fix assertions wrt concurrent OSR.
R=u...@chromium.org
Review URL: https://codereview.chromium.org/206473002
http://code.google.com/p/v8/source/detail?r=20130
Modified:
/branches/bleeding_edge/src/a
Committed patchset #2 manually as r20130 (presubmit successful).
https://codereview.chromium.org/206473002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
some comments.
https://codereview.chromium.org/206073007/diff/1/src/builtins.cc
File src/builtins.cc (right):
https://codereview.chromium.org/206073007/diff/1/src/builtins.cc#newcode980
src/builtins.cc:980: accessor->CopyElements(
I should have noticed this in an earlier CL. Why do we no longer
lgtm, thanks for fixing!
https://codereview.chromium.org/206473002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop rece
lgtm
https://codereview.chromium.org/206343002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/199733012/diff/60001/tools/push-to-trunk/chromium_roll.py
File tools/push-to-trunk/chromium_roll.py (right):
https://codereview.chromium.org/199733012/diff/60001/tools/push-to-trunk/chromium_roll.py#newcode3
tools/push-to-trunk/chromium_roll.py:3: # Redist
On 2014/03/20 13:50:45, ulan wrote:
https://codereview.chromium.org/206473002/diff/1/src/a64/full-codegen-a64.cc
File src/a64/full-codegen-a64.cc (left):
https://codereview.chromium.org/206473002/diff/1/src/a64/full-codegen-a64.cc#oldcode4883
src/a64/full-codegen-a64.cc:4883: 6 * kInstruction
lgtm
https://codereview.chromium.org/206133004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
Updates:
Owner: yang...@chromium.org
Comment #16 on issue 3060 by yang...@chromium.org: V8 3.23.1 and later do
not honor v8::V8::IgnoreOutOfMemoryException()
http://code.google.com/p/v8/issues/detail?id=3060
We are going to go two ways here:
- V8::IgnoreOutOfMemoryException is going t
LGTM to objects-inl.h:2119, didn't look at the rest.
https://codereview.chromium.org/204913006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe f
Revision: 20129
Author: yang...@chromium.org
Date: Thu Mar 20 14:12:06 2014 UTC
Log: Remove outdated OOM tests.
R=ish...@chromium.org
Review URL: https://codereview.chromium.org/206373003
http://code.google.com/p/v8/source/detail?r=20129
Modified:
/branches/bleeding_edge/test/cctest
Reviewers: Yang,
Message:
PTAL
Description:
JSArray::SetContent() handlified.
Please review this at https://codereview.chromium.org/206223003/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+42, -35 lines):
M src/elements.cc
M src/factory.h
M src/factory.
Committed patchset #1 manually as r20129 (tree was closed).
https://codereview.chromium.org/206373003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubs
lgtm
https://codereview.chromium.org/206373003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
Reviewers: Igor Sheludko,
Description:
Remove outdated OOM tests.
R=ish...@chromium.org
Please review this at https://codereview.chromium.org/206373003/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+0, -113 lines):
M test/cctest/cctest.status
M test/cctes
lgtm
https://codereview.chromium.org/203463011/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/203463011/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
Reviewers: danno, Michael Starzinger,
Message:
PTAL. I will not land it before getting benchmark results.
Description:
Visit return statement of inlined function in value context.
BUG=354357
LOG=N
TEST=mjsunit/regress/regress-354357.js
Please review this at https://codereview.chromium.org/2064
PTAL
https://codereview.chromium.org/203463011/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it
On 2014/03/20 13:43:32, ulan wrote:
On 2014/03/20 13:22:17, aandrey wrote:
> On 2014/03/20 13:13:08, ulan wrote:
> > Thanks for fixing. Something seems to be wrong with the Patch Set 4:
it
> changes
> > unrelated lines. Did you accidentally upload with incorrect base?
>
> Seems OK to me:
>
h
Comment #2 on issue 3225 by yang...@chromium.org: runtime.cc:11391:
CHECK(!frame->GetParameter(i)->IsTheHole()) failed
http://code.google.com/p/v8/issues/detail?id=3225
pure d8 repro. To be honest I'm not surprised the debugger does not work
with generators.
// Flags: --expose-debug-as de
https://codereview.chromium.org/206473002/diff/1/src/a64/full-codegen-a64.cc
File src/a64/full-codegen-a64.cc (left):
https://codereview.chromium.org/206473002/diff/1/src/a64/full-codegen-a64.cc#oldcode4883
src/a64/full-codegen-a64.cc:4883: 6 * kInstructionSize);
On 2014/03/20 13:33:05, Yang wro
Reviewers: Jakob,
Message:
PTAL
Description:
Split of rolling Chromium from push-to-trunk.
This moves rolling Chromium into a new script with its own tests.
BUG=
Please review this at https://codereview.chromium.org/199733012/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
A
Reviewers: Michael Starzinger,
Message:
mstarzinger, ptal
Description:
Move ParsePostfixExpression into ParserBase.
+ enable a test which checks that Parser and PreParser produce the "invalid
left
hand side" errors consistently.
R=mstarzin...@chromium.org
BUG=
Please review this at https:/
On 2014/03/20 13:22:17, aandrey wrote:
On 2014/03/20 13:13:08, ulan wrote:
> Thanks for fixing. Something seems to be wrong with the Patch Set 4: it
changes
> unrelated lines. Did you accidentally upload with incorrect base?
Seems OK to me:
https://codereview.chromium.org/203463011/diff2/40001
Revision: 20128
Author: ish...@chromium.org
Date: Thu Mar 20 13:40:08 2014 UTC
Log: Callers of JSArray::SetContent() handlified.
R=yang...@chromium.org
Review URL: https://codereview.chromium.org/206383003
http://code.google.com/p/v8/source/detail?r=20128
Modified:
/branches/bleedin
Committed patchset #1 manually as r20128 (presubmit successful).
https://codereview.chromium.org/206383003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
Revision: 20127
Author: mvstan...@chromium.org
Date: Thu Mar 20 13:38:08 2014 UTC
Log: Fix for performance issue 353661 - 23% regression in dromaeo.
The issue was that a previous fix to avoid a logic error was not
targeted enough: it allowed non-transitioning stores to fall
into a code
Committed patchset #1 manually as r20127 (presubmit successful).
https://codereview.chromium.org/206353002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
Revision: 20126
Author: ma...@chromium.org
Date: Thu Mar 20 13:37:26 2014 UTC
Log: Increase the "local variables in a function" limit.
The limit was originally added to avoid having large user-controlled
constants
(variable indexes) in the code generated by full-codegen.
History be
Reviewers: dcarney, Jakob, rossberg, Sven Panne,
Message:
Committed patchset #2 manually as r20126 (presubmit successful).
Description:
Increase the "local variables in a function" limit.
The limit was originally added to avoid having large user-controlled
constants
(variable indexes) in the
On 2014/03/20 13:32:04, Igor Sheludko wrote:
PTAL
lgtm.
https://codereview.chromium.org/206463002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubsc
https://codereview.chromium.org/206473002/diff/1/src/a64/full-codegen-a64.cc
File src/a64/full-codegen-a64.cc (left):
https://codereview.chromium.org/206473002/diff/1/src/a64/full-codegen-a64.cc#oldcode4883
src/a64/full-codegen-a64.cc:4883: 6 * kInstructionSize);
Those assertions are bogus. We w
Reviewers: Yang,
Message:
PTAL
Description:
ArraySplice builtin handlified.
Please review this at https://codereview.chromium.org/206073007/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+79, -64 lines):
M src/builtins.cc
M src/factory.h
M src/factory.cc
Reviewers: Yang,
Message:
PTAL
Description:
ArrayUnshift builtin handlified.
Please review this at https://codereview.chromium.org/206463002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+20, -25 lines):
M src/builtins.cc
Index: src/builtins.cc
diff --git
Reviewers: ulan,
Description:
Fix assertions wrt concurrent OSR.
R=u...@chromium.org
Please review this at https://codereview.chromium.org/206473002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+3, -7 lines):
M src/a64/full-codegen-a64.cc
M test/mjsunit/
Reviewers: Michael Starzinger,
Description:
Reland "Implement ES6 symbol registry and predefined symbols"
Only change relative to original CL is the updated assertion condition at
objects-inl.h:2119
R=mstarzin...@chromium.org
BUG=
Please review this at https://codereview.chromium.org/204913006
On 2014/03/20 13:28:13, Igor Sheludko wrote:
https://codereview.chromium.org/206383003/diff/1/src/runtime.cc
File src/runtime.cc (right):
https://codereview.chromium.org/206383003/diff/1/src/runtime.cc#newcode13101
src/runtime.cc:13101:
isolate->factory()->SetContent(Handle::cast(result), inst
https://codereview.chromium.org/206383003/diff/1/src/runtime.cc
File src/runtime.cc (right):
https://codereview.chromium.org/206383003/diff/1/src/runtime.cc#newcode13101
src/runtime.cc:13101:
isolate->factory()->SetContent(Handle::cast(result),
instances);
On 2014/03/20 13:22:07, Yang wrote:
fo
Comment #14 on issue 3205 by svenpa...@chromium.org: "Too many variables"
limit prohibits new Emscripten application from running
http://code.google.com/p/v8/issues/detail?id=3205
Fix under way: https://codereview.chromium.org/206143004/, we should
probably merge this back to M34 after cana
On 2014/03/20 13:13:08, ulan wrote:
Thanks for fixing. Something seems to be wrong with the Patch Set 4: it
changes
unrelated lines. Did you accidentally upload with incorrect base?
Seems OK to me:
https://codereview.chromium.org/203463011/diff2/40001:60001/src/runtime.cc
https://codereview.
LGTM with suggestion.
https://codereview.chromium.org/206383003/diff/1/src/runtime.cc
File src/runtime.cc (right):
https://codereview.chromium.org/206383003/diff/1/src/runtime.cc#newcode13101
src/runtime.cc:13101:
isolate->factory()->SetContent(Handle::cast(result),
instances);
for the sake of
Revision: 20125
Author: ma...@chromium.org
Date: Thu Mar 20 13:18:15 2014 UTC
Log: Make PreParser track valid left hand sides.
Notes:
- This makes PreParser produce invalid_lhs_in_assignment and
invalid_lhs_in_prefix_op. Other errors will follow as the corresponding
funcs
move to Pa
Committed patchset #3 manually as r20125 (presubmit successful).
https://codereview.chromium.org/196343033/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
Revision: 20124
Author: ish...@chromium.org
Date: Thu Mar 20 13:16:19 2014 UTC
Log: ArrayShift builtin handlified.
R=yang...@chromium.org
Review URL: https://codereview.chromium.org/206423002
http://code.google.com/p/v8/source/detail?r=20124
Modified:
/branches/bleeding_edge/src/bui
Committed patchset #1 manually as r20124 (presubmit successful).
https://codereview.chromium.org/206423002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
Thanks for fixing. Something seems to be wrong with the Patch Set 4: it
changes
unrelated lines. Did you accidentally upload with incorrect base?
https://codereview.chromium.org/203463011/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You receive
Revision: 20123
Author: svenpa...@chromium.org
Date: Thu Mar 20 13:10:23 2014 UTC
Log: Implement flooring division by a constant via truncating division
by a constant.
R=bmeu...@chromium.org
Review URL: https://codereview.chromium.org/204583002
http://code.google.com/p/v8/source/de
Committed patchset #3 manually as r20123 (presubmit successful).
https://codereview.chromium.org/204583002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
https://codereview.chromium.org/203463011/diff/40001/src/runtime.cc
File src/runtime.cc (right):
https://codereview.chromium.org/203463011/diff/40001/src/runtime.cc#newcode11737
src/runtime.cc:11737: bool fast = false)
On 2014/03/20 12:11:49, ulan wrote:
fast => ignore_nested_scopes
Done.
ht
Doh! :) LGTM
https://codereview.chromium.org/206353002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails
Revision: 20122
Author: ish...@chromium.org
Date: Thu Mar 20 13:01:08 2014 UTC
Log: ArrayPush builtin handlified.
R=yang...@chromium.org
Review URL: https://codereview.chromium.org/206183006
http://code.google.com/p/v8/source/detail?r=20122
Modified:
/branches/bleeding_edge/src/buil
Committed patchset #1 manually as r20122 (presubmit successful).
https://codereview.chromium.org/206183006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
On 2014/03/20 12:56:18, rossberg wrote:
lgtm.
https://codereview.chromium.org/204353004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from th
Revision: 20121
Author: rossb...@chromium.org
Date: Thu Mar 20 12:56:41 2014 UTC
Log: Revert "Implement ES6 symbol registry and predefined symbols"
TBR=yang...@chromium.org
BUG=
Review URL: https://codereview.chromium.org/204353004
http://code.google.com/p/v8/source/detail?r=20121
Mo
Committed patchset #1 manually as r20121.
https://codereview.chromium.org/204353004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this gr
Reviewers: Yang,
Description:
Revert "Implement ES6 symbol registry and predefined symbols"
TBR=yang...@chromium.org
BUG=
Please review this at https://codereview.chromium.org/204353004/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+12, -135 lines):
M inclu
LGTM, too
https://codereview.chromium.org/206143004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails fr
Comment #13 on issue 3205 by ma...@chromium.org: "Too many variables" limit
prohibits new Emscripten application from running
http://code.google.com/p/v8/issues/detail?id=3205
Even more discussion: masking is not feasible. The best guess so far:
https://codereview.chromium.org/206143004/
lgtm
https://codereview.chromium.org/206143004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
Reviewers: dcarney, Jakob, rossberg, Sven Panne,
Message:
... this is not good either, closing this.
The latest try is https://codereview.chromium.org/206143004
Description:
Increase the "local variables in a function" limit by a huge amount.
The limit was originally added to avoid having larg
Reviewers: Yang,
Message:
PTAL
Description:
Callers of JSArray::SetContent() handlified.
Please review this at https://codereview.chromium.org/206383003/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+30, -39 lines):
M src/runtime.cc
Index: src/runtime.cc
1 - 100 of 210 matches
Mail list logo
