[v8-dev] Fix regexp compilation cache. (issue 230283002)

2014-04-09 Thread yangguo
Reviewers: ulan, Description: Fix regexp compilation cache. R=u...@chromium.org Please review this at https://codereview.chromium.org/230283002/ SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge Affected files (+12, -20 lines): M src/compilation-cache.cc Index:

[v8-dev] [v8] r20588 committed - Add stack overflow check for inlined property getter...

2014-04-09 Thread codesite-noreply
Revision: 20588 Author: ja...@chromium.org Date: Wed Apr 9 07:35:12 2014 UTC Log: Add stack overflow check for inlined property getter We should check for overflow for each inlined property getter; otherwise, we can get an overflow from inlining property getter while still having

[v8-dev] Re: Add stack overflow check for inlined property getter (issue 220813003)

2014-04-09 Thread jarin
Committed patchset #1 manually as r20588 (presubmit successful). https://codereview.chromium.org/220813003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To

[v8-dev] Version 3.25.28.8 (rollback of r20375) (issue 230353002)

2014-04-09 Thread danno
Reviewers: jochen, Description: Version 3.25.28.8 (rollback of r20375) Store i18n meta data in hidden symbols instead of js accessible properties BUG=354967 LOG=N R=joc...@chromium.org Please review this at https://codereview.chromium.org/230353002/ SVN Base:

[v8-dev] Re: Avoid hydrogen compare-objects-equal assertions in dead code (issue 228883005)

2014-04-09 Thread yangguo
https://codereview.chromium.org/228883005/diff/1/test/mjsunit/regress/regress-359491.js File test/mjsunit/regress/regress-359491.js (right): https://codereview.chromium.org/228883005/diff/1/test/mjsunit/regress/regress-359491.js#newcode28 test/mjsunit/regress/regress-359491.js:28: f(); function

[v8-dev] Re: Version 3.25.28.8 (rollback of r20375) (issue 230353002)

2014-04-09 Thread jochen
lgtm https://codereview.chromium.org/230353002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: Version 3.25.28.8 (rollback of r20375) (issue 230353002)

2014-04-09 Thread danno
Committed patchset #1 manually as r20589. https://codereview.chromium.org/230353002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this

[v8-dev] [v8] r20589 committed - Version 3.25.28.8 (rollback of r20375)...

2014-04-09 Thread codesite-noreply
Revision: 20589 Author: da...@chromium.org Date: Wed Apr 9 07:59:59 2014 UTC Log: Version 3.25.28.8 (rollback of r20375) Store i18n meta data in hidden symbols instead of js accessible properties BUG=354967 LOG=N R=joc...@chromium.org Review URL:

[v8-dev] [v8] r20590 committed - Tagging version 3.25.28.8

2014-04-09 Thread codesite-noreply
Revision: 20590 Author: da...@chromium.org Date: Wed Apr 9 08:00:19 2014 UTC Log: Tagging version 3.25.28.8 http://code.google.com/p/v8/source/detail?r=20590 Added: /tags/3.25.28.8 -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You

[v8-dev] Re: Version 3.25.28.9 (merged r20388) (issue 230143003)

2014-04-09 Thread jochen
lgtm https://codereview.chromium.org/230143003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Version 3.25.28.9 (merged r20388) (issue 230143003)

2014-04-09 Thread danno
Reviewers: jochen, Description: Version 3.25.28.9 (merged r20388) Store i18n meta data in hidden symbols instead of js accessible properties BUG=354967 LOG=N R=joc...@chromium.org Please review this at https://codereview.chromium.org/230143003/ SVN Base:

[v8-dev] Re: Version 3.25.28.9 (merged r20388) (issue 230143003)

2014-04-09 Thread danno
Committed patchset #1 manually as r20591. https://codereview.chromium.org/230143003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this

[v8-dev] [v8] r20591 committed - Version 3.25.28.9 (merged r20388)...

2014-04-09 Thread codesite-noreply
Revision: 20591 Author: da...@chromium.org Date: Wed Apr 9 08:07:57 2014 UTC Log: Version 3.25.28.9 (merged r20388) Store i18n meta data in hidden symbols instead of js accessible properties BUG=354967 LOG=N R=joc...@chromium.org Review URL:

[v8-dev] Remove calls to non-handlified version of GetProperty(name). (issue 229973004)

2014-04-09 Thread yangguo
Reviewers: Igor Sheludko, Description: Remove calls to non-handlified version of GetProperty(name). R=ish...@chromium.org Please review this at https://codereview.chromium.org/229973004/ SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge Affected files (+173, -175 lines): M

[v8-dev] [v8] r20592 committed - Tagging version 3.25.28.9

2014-04-09 Thread codesite-noreply
Revision: 20592 Author: da...@chromium.org Date: Wed Apr 9 08:08:28 2014 UTC Log: Tagging version 3.25.28.9 http://code.google.com/p/v8/source/detail?r=20592 Added: /tags/3.25.28.9 -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You

[v8-dev] Version 3.24.35.30 (rollback of r20375) (issue 230383002)

2014-04-09 Thread danno
Reviewers: jochen, Description: Version 3.24.35.30 (rollback of r20375) Store i18n meta data in hidden symbols instead of js accessible properties BUG=354967 LOG=N R=joc...@chromium.org Please review this at https://codereview.chromium.org/230383002/ SVN Base:

[v8-dev] Re: Version 3.24.35.30 (rollback of r20375) (issue 230383002)

2014-04-09 Thread jochen
lgtm https://codereview.chromium.org/230383002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: Merged r20315 into 3.25 branch. (issue 230023002)

2014-04-09 Thread palfia
Rebased and fixed version.cc. https://codereview.chromium.org/230023002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop

[v8-dev] [v8] r20593 committed - Version 3.24.35.30 (rollback of r20375)...

2014-04-09 Thread codesite-noreply
Revision: 20593 Author: da...@chromium.org Date: Wed Apr 9 08:14:32 2014 UTC Log: Version 3.24.35.30 (rollback of r20375) Store i18n meta data in hidden symbols instead of js accessible properties BUG=354967 LOG=N R=joc...@chromium.org Review URL:

[v8-dev] Re: Version 3.24.35.30 (rollback of r20375) (issue 230383002)

2014-04-09 Thread danno
Committed patchset #1 manually as r20593. https://codereview.chromium.org/230383002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this

[v8-dev] Version 3.24.35.31 (merged r20388) (issue 230403002)

2014-04-09 Thread danno
Reviewers: jochen, Description: Version 3.24.35.31 (merged r20388) Store i18n meta data in hidden symbols instead of js accessible properties BUG=354967 LOG=N R=joc...@chromium.org Please review this at https://codereview.chromium.org/230403002/ SVN Base:

[v8-dev] Re: Version 3.24.35.31 (merged r20388) (issue 230403002)

2014-04-09 Thread jochen
lgtm https://codereview.chromium.org/230403002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails from

[v8-dev] [v8] r20594 committed - Tagging version 3.24.35.30

2014-04-09 Thread codesite-noreply
Revision: 20594 Author: da...@chromium.org Date: Wed Apr 9 08:14:52 2014 UTC Log: Tagging version 3.24.35.30 http://code.google.com/p/v8/source/detail?r=20594 Added: /tags/3.24.35.30 -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You

[v8-dev] Handlify all context allocators from the Heap. (issue 230393002)

2014-04-09 Thread mstarzinger
Reviewers: Yang, Description: Handlify all context allocators from the Heap. R=yang...@chromium.org BUG= Please review this at https://codereview.chromium.org/230393002/ SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge Affected files (+101, -209 lines): M src/factory.h M

[v8-dev] Re: Version 3.24.35.31 (merged r20388) (issue 230403002)

2014-04-09 Thread danno
Committed patchset #1 manually as r20595. https://codereview.chromium.org/230403002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this

[v8-dev] [v8] r20595 committed - Version 3.24.35.31 (merged r20388)...

2014-04-09 Thread codesite-noreply
Revision: 20595 Author: da...@chromium.org Date: Wed Apr 9 08:17:02 2014 UTC Log: Version 3.24.35.31 (merged r20388) Store i18n meta data in hidden symbols instead of js accessible properties BUG=354967 LOG=N R=joc...@chromium.org Review URL:

[v8-dev] [v8] r20596 committed - Tagging version 3.24.35.31

2014-04-09 Thread codesite-noreply
Revision: 20596 Author: da...@chromium.org Date: Wed Apr 9 08:17:27 2014 UTC Log: Tagging version 3.24.35.31 http://code.google.com/p/v8/source/detail?r=20596 Added: /tags/3.24.35.31 -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You

[v8-dev] Re: Merged r20315 into 3.25 branch. (issue 230023002)

2014-04-09 Thread palfia
Committed patchset #2 manually as r20597. https://codereview.chromium.org/230023002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this

[v8-dev] [v8] r20597 committed - Merged r20315 into 3.25 branch....

2014-04-09 Thread codesite-noreply
Revision: 20597 Author: pal...@homejinni.com Date: Wed Apr 9 08:19:46 2014 UTC Log: Merged r20315 into 3.25 branch. Add Bogus initialization for external_elements_kind and fixed_elements_kind R=da...@chromium.org BUG= Review URL: https://codereview.chromium.org/230023002

[v8-dev] [v8] r20599 committed - Tagging version 3.25.28.10

2014-04-09 Thread codesite-noreply
Revision: 20599 Author: pal...@homejinni.com Date: Wed Apr 9 08:20:15 2014 UTC Log: Tagging version 3.25.28.10 http://code.google.com/p/v8/source/detail?r=20599 Added: /tags/3.25.28.10 -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You

[v8-dev] Re: Introduced Atomic8 and added no-barrier Atomic8 accessors. (issue 228613005)

2014-04-09 Thread hpayer
Committed patchset #4 manually as r20598 (presubmit successful). https://codereview.chromium.org/228613005/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To

[v8-dev] Re: Handlify all context allocators from the Heap. (issue 230393002)

2014-04-09 Thread yangguo
On 2014/04/09 08:16:34, Michael Starzinger wrote: lgtm. https://codereview.chromium.org/230393002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To

[v8-dev] Re: Make new space iterable when transitioning double array to objects (issue 228643002)

2014-04-09 Thread hpayer
LGTM https://codereview.chromium.org/228643002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails from it,

[v8-dev] [v8] r20598 committed - Introduced Atomic8 and added no-barrier Atomic8 accessors....

2014-04-09 Thread codesite-noreply
Revision: 20598 Author: hpa...@chromium.org Date: Wed Apr 9 08:20:10 2014 UTC Log: Introduced Atomic8 and added no-barrier Atomic8 accessors. BUG= R=ja...@chromium.org Review URL: https://codereview.chromium.org/228613005 http://code.google.com/p/v8/source/detail?r=20598 Modified:

[v8-dev] Re: Fix regexp compilation cache. (issue 230283002)

2014-04-09 Thread ulan
lgtm, thanks for fixing it. https://codereview.chromium.org/230283002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop

[v8-dev] Fix return value of push() and unshift() on Array.prototype. (issue 230453002)

2014-04-09 Thread mstarzinger
Reviewers: ulan, Description: Fix return value of push() and unshift() on Array.prototype. R=u...@chromium.org TEST=mjsunit/regress/regress-builtinbust-3 Please review this at https://codereview.chromium.org/230453002/ SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge Affected

[v8-dev] Re: Implement handling of arrow functions in the parser (issue 160073006)

2014-04-09 Thread aperez
https://codereview.chromium.org/160073006/diff/380001/src/parser.cc File src/parser.cc (right): https://codereview.chromium.org/160073006/diff/380001/src/parser.cc#newcode3139 src/parser.cc:3139: VectorVariableProxy* Parser::ParameterListFromExpression( On 2014/03/25 12:35:34, rossberg wrote:

[v8-dev] Re: Use abstract configurations to switch between opt debug settings (issue 224443003)

2014-04-09 Thread machenbach
lgtm https://codereview.chromium.org/224443003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails from it,

[v8-dev] Re: Handlify all context allocators from the Heap. (issue 230393002)

2014-04-09 Thread mstarzinger
Committed patchset #1 manually as r20600 (presubmit successful). https://codereview.chromium.org/230393002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To

[v8-dev] [v8] r20600 committed - Handlify all context allocators from the Heap....

2014-04-09 Thread codesite-noreply
Revision: 20600 Author: mstarzin...@chromium.org Date: Wed Apr 9 08:51:46 2014 UTC Log: Handlify all context allocators from the Heap. R=yang...@chromium.org BUG= Review URL: https://codereview.chromium.org/230393002 http://code.google.com/p/v8/source/detail?r=20600 Modified:

[v8-dev] Re: Fix regexp compilation cache. (issue 230283002)

2014-04-09 Thread yangguo
Committed patchset #1 manually as r20601 (presubmit successful). https://codereview.chromium.org/230283002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To

[v8-dev] [v8] r20601 committed - Fix regexp compilation cache....

2014-04-09 Thread codesite-noreply
Revision: 20601 Author: yang...@chromium.org Date: Wed Apr 9 09:01:38 2014 UTC Log: Fix regexp compilation cache. R=u...@chromium.org Review URL: https://codereview.chromium.org/230283002 http://code.google.com/p/v8/source/detail?r=20601 Modified:

[v8-dev] Re: Fix return value of push() and unshift() on Array.prototype. (issue 230453002)

2014-04-09 Thread ulan
lgtm, good catch! https://codereview.chromium.org/230453002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving

[v8-dev] Re: Fix return value of push() and unshift() on Array.prototype. (issue 230453002)

2014-04-09 Thread mstarzinger
Committed patchset #1 manually as r20602 (presubmit successful). https://codereview.chromium.org/230453002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To

[v8-dev] [v8] r20602 committed - Fix return value of push() and unshift() on Array.prototype....

2014-04-09 Thread codesite-noreply
Revision: 20602 Author: mstarzin...@chromium.org Date: Wed Apr 9 09:14:56 2014 UTC Log: Fix return value of push() and unshift() on Array.prototype. R=u...@chromium.org TEST=mjsunit/regress/regress-builtinbust-3 Review URL: https://codereview.chromium.org/230453002

[v8-dev] Re: Allow race-full access of map instance size when sweeping concurrently. (issue 227133007)

2014-04-09 Thread hpayer
Thx Jaro for the comments, but as discussed yesterday I decided to redo this cl based on atomic byte accessors which makes the original cl obsolete. Please check out the new version. https://codereview.chromium.org/227133007/ -- -- v8-dev mailing list v8-dev@googlegroups.com

[v8-dev] Re: Allow race-full access of map instance size when sweeping concurrently. (issue 227133007)

2014-04-09 Thread jarin
lgtm https://codereview.chromium.org/227133007/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: Handlefy Descriptor and other code in objects.cc (issue 228333003)

2014-04-09 Thread mvstanton
Reviewers: Toon Verwaest, Message: Hi Toon, Thanks for the great comments, I've addressed all but one where I have a question (JSObject::ResetElements() change). thx, --Michael https://codereview.chromium.org/228333003/diff/1/src/objects.cc File src/objects.cc (right):

[v8-dev] Re: Further ElementsAccessor handlification (GetKeyForIndex(), GetCapacity(), GetType() and GetAttribut... (issue 228643003)

2014-04-09 Thread verwaest
lgtm https://codereview.chromium.org/228643003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: Make new space iterable when transitioning double array to objects (issue 228643002)

2014-04-09 Thread jarin
Committed patchset #2 manually as r20603 (presubmit successful). https://codereview.chromium.org/228643002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To

[v8-dev] Re: Allow race-full access of map instance size when sweeping concurrently. (issue 227133007)

2014-04-09 Thread hpayer
Committed patchset #7 manually as r20604 (presubmit successful). https://codereview.chromium.org/227133007/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To

[v8-dev] [v8] r20603 committed - Make new space iterable when transitioning double array to objects...

2014-04-09 Thread codesite-noreply
Revision: 20603 Author: ja...@chromium.org Date: Wed Apr 9 09:50:08 2014 UTC Log: Make new space iterable when transitioning double array to objects R=hpa...@chromium.org BUG= Review URL: https://codereview.chromium.org/228643002 http://code.google.com/p/v8/source/detail?r=20603

[v8-dev] [v8] r20604 committed - Allow race-full access of map instance size when sweeping concurrently...

2014-04-09 Thread codesite-noreply
Revision: 20604 Author: hpa...@chromium.org Date: Wed Apr 9 09:50:25 2014 UTC Log: Allow race-full access of map instance size when sweeping concurrently. BUG= R=ja...@chromium.org, mstarzin...@chromium.org Review URL: https://codereview.chromium.org/227133007

[v8-dev] Re: Remove calls to non-handlified version of GetProperty(name). (issue 229973004)

2014-04-09 Thread ishell
lgtm with nits: https://codereview.chromium.org/229973004/diff/1/src/runtime.cc File src/runtime.cc (right): https://codereview.chromium.org/229973004/diff/1/src/runtime.cc#newcode9352 src/runtime.cc:9352: isolate, value, MakePair(Failure::Exception(), NULL)); Is it OK to return NULL instead

[v8-dev] Re: Use abstract configurations to switch between opt debug settings (issue 224443003)

2014-04-09 Thread jochen
Committed patchset #5 manually as r20605 (presubmit successful). https://codereview.chromium.org/224443003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To

[v8-dev] [v8] r20605 committed - Use abstract configurations to switch between opt debug settings...

2014-04-09 Thread codesite-noreply
Revision: 20605 Author: joc...@chromium.org Date: Wed Apr 9 09:54:49 2014 UTC Log: Use abstract configurations to switch between opt debug settings The problem is that conditions are evaluated before configuration inheritance is resolved, so we can't just define a configuration

[v8-dev] [v8] r20606 committed - Further ElementsAccessor handlification (GetKeyForIndex(), GetCapacity...

2014-04-09 Thread codesite-noreply
Revision: 20606 Author: ish...@chromium.org Date: Wed Apr 9 09:58:26 2014 UTC Log: Further ElementsAccessor handlification (GetKeyForIndex(), GetCapacity(), GetType() and GetAttributes()). R=verwa...@chromium.org Review URL: https://codereview.chromium.org/228643003

[v8-dev] Re: Further ElementsAccessor handlification (GetKeyForIndex(), GetCapacity(), GetType() and GetAttribut... (issue 228643003)

2014-04-09 Thread ishell
Committed patchset #1 manually as r20606 (presubmit successful). https://codereview.chromium.org/228643003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To

[v8-dev] ElementsAccessor::SetLength() maybehandlified. (issue 229943006)

2014-04-09 Thread ishell
Reviewers: Yang, Message: PTAL Description: ElementsAccessor::SetLength() maybehandlified. Please review this at https://codereview.chromium.org/229943006/ SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge Affected files (+42, -34 lines): M src/accessors.cc M src/elements.h

[v8-dev] Re: Fix build with gcc 4.8 on Linux. (issue 229683003)

2014-04-09 Thread ishell
lgtm https://codereview.chromium.org/229683003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Remove uses of non-handlified GetProperty. (issue 229373007)

2014-04-09 Thread yangguo
Reviewers: Igor Sheludko, Description: Remove uses of non-handlified GetProperty. R=ish...@chromium.org Please review this at https://codereview.chromium.org/229373007/ SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge Affected files (+11, -36 lines): M src/objects.h M

[v8-dev] Re: Remove calls to non-handlified version of GetProperty(name). (issue 229973004)

2014-04-09 Thread yangguo
https://codereview.chromium.org/229973004/diff/1/src/runtime.cc File src/runtime.cc (right): https://codereview.chromium.org/229973004/diff/1/src/runtime.cc#newcode9352 src/runtime.cc:9352: isolate, value, MakePair(Failure::Exception(), NULL)); On 2014/04/09 09:52:33, Igor Sheludko wrote: Is

[v8-dev] Fix various bugs in the type systems, and improve test coverage. (issue 230463003)

2014-04-09 Thread bmeurer
Reviewers: rossberg, Message: PTAL Description: Fix various bugs in the type systems, and improve test coverage. R=rossb...@chromium.org Please review this at https://codereview.chromium.org/230463003/ SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge Affected files (+231, -13

[v8-dev] Populate receiver types when there is no type feedback (issue 230363003)

2014-04-09 Thread p . antonov
Reviewers: Toon Verwaest, Message: This should fix the issue in VisitCall where the immutable property inlining patch ends up returning an HConstant for a JSFunction and VisitCall assumes types-length() 0 in this situation. I also have the immutable property inlining patch separately

[v8-dev] Re: Fix various bugs in the type systems, and improve test coverage. (issue 230463003)

2014-04-09 Thread rossberg
LGTM with nits https://codereview.chromium.org/230463003/diff/1/src/types.h File src/types.h (right): https://codereview.chromium.org/230463003/diff/1/src/types.h#newcode300 src/types.h:300: bool IsInhabited() { Nit: move this up to line 222

[v8-dev] [v8] r20607 committed - Revert Further ElementsAccessor handlification (GetKeyForIndex(), Get...

2014-04-09 Thread codesite-noreply
Revision: 20607 Author: ish...@chromium.org Date: Wed Apr 9 10:58:17 2014 UTC Log: Revert Further ElementsAccessor handlification (GetKeyForIndex(), GetCapacity(), GetType() and GetAttributes()). This reverts commit r20606 for breaking tests on windows. TBR=dcar...@chromium.org

[v8-dev] Revert Further ElementsAccessor handlification (GetKeyForIndex(), GetCapacity(), GetType() and Get... (issue 230603002)

2014-04-09 Thread ishell
Reviewers: dcarney, Message: Committed patchset #1 manually as r20607 (tree was closed). Description: Revert Further ElementsAccessor handlification (GetKeyForIndex(), GetCapacity(), GetType() and GetAttributes()). This reverts commit r20606 for breaking tests on windows.

[v8-dev] Re: Implement structural function and array types (issue 228263005)

2014-04-09 Thread rossberg
https://codereview.chromium.org/228263005/diff/20001/src/types.h File src/types.h (right): https://codereview.chromium.org/228263005/diff/20001/src/types.h#newcode301 src/types.h:301: ClassType* AsClass() { return ClassType::cast(this); } On 2014/04/09 05:33:14, Benedikt Meurer wrote: I really

[v8-dev] Use no barrier size accessor in FreeListCategory::SumFreeList. (issue 230613002)

2014-04-09 Thread hpayer
Reviewers: jarin, Description: Use no barrier size accessor in FreeListCategory::SumFreeList. BUG= Please review this at https://codereview.chromium.org/230613002/ SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge Affected files (+1, -1 lines): M src/spaces.cc Index:

[v8-dev] Re: Fix build with gcc 4.8 on Linux. (issue 229683003)

2014-04-09 Thread palfia
Committed patchset #1 manually as r20608 (presubmit successful). https://codereview.chromium.org/229683003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To

[v8-dev] [v8] r20608 committed - Fix build with gcc 4.8 on Linux....

2014-04-09 Thread codesite-noreply
Revision: 20608 Author: pal...@homejinni.com Date: Wed Apr 9 11:01:58 2014 UTC Log: Fix build with gcc 4.8 on Linux. This fixes a build failure on Linux with gcc 4.8, after r20581. BUG= R=ish...@chromium.org Review URL: https://codereview.chromium.org/229683003

[v8-dev] Re: Fix various bugs in the type systems, and improve test coverage. (issue 230463003)

2014-04-09 Thread bmeurer
https://codereview.chromium.org/230463003/diff/1/src/types.h File src/types.h (right): https://codereview.chromium.org/230463003/diff/1/src/types.h#newcode300 src/types.h:300: bool IsInhabited() { On 2014/04/09 10:56:56, rossberg wrote: Nit: move this up to line 222 Done.

[v8-dev] [v8] r20609 committed - Fix various bugs in the type systems, and improve test coverage....

2014-04-09 Thread codesite-noreply
Revision: 20609 Author: bmeu...@chromium.org Date: Wed Apr 9 11:12:15 2014 UTC Log: Fix various bugs in the type systems, and improve test coverage. R=rossb...@chromium.org Review URL: https://codereview.chromium.org/230463003 http://code.google.com/p/v8/source/detail?r=20609

[v8-dev] MIPS: Make new space iterable when transitioning double array to objects. (issue 230243004)

2014-04-09 Thread kilvadyb
Reviewers: danno, jarin, Paul Lind, kisg, palfia, dusmil, Description: MIPS: Make new space iterable when transitioning double array to objects. Port r20603 (a8e7478) BUG= Please review this at https://codereview.chromium.org/230243004/ SVN Base: https://github.com/v8/v8.git@gbl Affected

[v8-dev] Re: Fix various bugs in the type systems, and improve test coverage. (issue 230463003)

2014-04-09 Thread bmeurer
Committed patchset #2 manually as r20609 (presubmit successful). https://codereview.chromium.org/230463003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To

[v8-dev] Re: Allow the embedder to pass the virtual memory limit to v8 (issue 228923002)

2014-04-09 Thread jochen
updated to have less defaults all over the place https://codereview.chromium.org/228923002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from

[v8-dev] Re: ARM64: Use pair memory access in deoptimizer entry (issue 228573003)

2014-04-09 Thread ulan
https://codereview.chromium.org/228573003/diff/1/src/arm64/deoptimizer-arm64.cc File src/arm64/deoptimizer-arm64.cc (right): https://codereview.chromium.org/228573003/diff/1/src/arm64/deoptimizer-arm64.cc#newcode170 src/arm64/deoptimizer-arm64.cc:170: __ Peek(scratch1, (reg_count - 1) *

[v8-dev] Re: Handlefy Descriptor and other code in objects.cc (issue 228333003)

2014-04-09 Thread mvstanton
Okay, here is an update with the use of SetMapAndElements() in JSObject::ResetElements(). PTAL, thx, --Michael https://codereview.chromium.org/228333003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are

[v8-dev] Further improve test coverage for types. (issue 230673002)

2014-04-09 Thread bmeurer
Reviewers: rossberg, Message: Work in progress Description: Further improve test coverage for types. Please review this at https://codereview.chromium.org/230673002/ SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge Affected files (+25, -83 lines): M test/cctest/test-types.cc

[v8-dev] Add V8 releases script. (issue 227583002)

2014-04-09 Thread machenbach
Reviewers: jarin, Message: PTAL Description: Add V8 releases script. This script retrieves the history of all V8 branches and trunk revisions and their corresponding Chromium revisions. TEST=tools/push-to-trunk/releases.py -c chrome path --csv test.csv BUG= Please review this at

[v8-dev] Re: Use no barrier size accessor in FreeListCategory::SumFreeList. (issue 230613002)

2014-04-09 Thread jarin
lgtm https://codereview.chromium.org/230613002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: Allow the embedder to pass the virtual memory limit to v8 (issue 228923002)

2014-04-09 Thread mstarzinger
LGTM, only nits left. Thanks for addressing my verbal comments already. https://codereview.chromium.org/228923002/diff/40001/src/heap.cc File src/heap.cc (right): https://codereview.chromium.org/228923002/diff/40001/src/heap.cc#newcode6372 src/heap.cc:6372: // On 64-bit platform(s), we put all

[v8-dev] Fix argument expectation Runtime_StringParseInt. (issue 230693002)

2014-04-09 Thread yangguo
Reviewers: Sven Panne, Description: Fix argument expectation Runtime_StringParseInt. R=svenpa...@chromium.org Please review this at https://codereview.chromium.org/230693002/ SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge Affected files (+19, -1 lines): M src/runtime.cc A

[v8-dev] Re: Revert Further ElementsAccessor handlification (GetKeyForIndex(), GetCapacity(), GetType() and Get... (issue 230603002)

2014-04-09 Thread yangguo
On 2014/04/09 10:58:43, Igor Sheludko wrote: Committed patchset #1 manually as r20607 (tree was closed). The actual problem is very flaky and independent from this change. The fix is here: https://codereview.chromium.org/230693002/ https://codereview.chromium.org/230603002/ -- -- v8-dev

[v8-dev] Re: ARM64: Use pair memory access in deoptimizer entry (issue 228573003)

2014-04-09 Thread m . m . capewell
On 2014/04/09 11:42:41, ulan wrote: https://codereview.chromium.org/228573003/diff/1/src/arm64/deoptimizer-arm64.cc File src/arm64/deoptimizer-arm64.cc (right): https://codereview.chromium.org/228573003/diff/1/src/arm64/deoptimizer-arm64.cc#newcode170 src/arm64/deoptimizer-arm64.cc:170: __

[v8-dev] Re: ElementsAccessor::SetLength() maybehandlified. (issue 229943006)

2014-04-09 Thread yangguo
On 2014/04/09 10:07:43, Igor Sheludko wrote: PTAL lgtm. https://codereview.chromium.org/229943006/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To

[v8-dev] Re: ARM64: Use pair memory access in deoptimizer entry (issue 228573003)

2014-04-09 Thread ulan
lgtm https://codereview.chromium.org/228573003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails from

[v8-dev] [v8] r20610 committed - Use no barrier size accessor in FreeListCategory::SumFreeList....

2014-04-09 Thread codesite-noreply
Revision: 20610 Author: hpa...@chromium.org Date: Wed Apr 9 12:21:20 2014 UTC Log: Use no barrier size accessor in FreeListCategory::SumFreeList. BUG= R=ja...@chromium.org Review URL: https://codereview.chromium.org/230613002 http://code.google.com/p/v8/source/detail?r=20610

[v8-dev] Re: Use no barrier size accessor in FreeListCategory::SumFreeList. (issue 230613002)

2014-04-09 Thread hpayer
Committed patchset #1 manually as r20610 (presubmit successful). https://codereview.chromium.org/230613002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To

[v8-dev] Re: Remove calls to non-handlified version of GetProperty(name). (issue 229973004)

2014-04-09 Thread yangguo
Committed patchset #2 manually as r20611 (presubmit successful). https://codereview.chromium.org/229973004/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To

[v8-dev] [v8] r20611 committed - Remove calls to non-handlified version of GetProperty(name)....

2014-04-09 Thread codesite-noreply
Revision: 20611 Author: yang...@chromium.org Date: Wed Apr 9 12:21:47 2014 UTC Log: Remove calls to non-handlified version of GetProperty(name). R=ish...@chromium.org Review URL: https://codereview.chromium.org/229973004 http://code.google.com/p/v8/source/detail?r=20611 Modified:

[v8-dev] Re: Avoid hydrogen compare-objects-equal assertions in dead code (issue 228883005)

2014-04-09 Thread jarin
Thanks for the beautiful test case! As discussed in person, I have update the change with your test and changed the deoptimization from eager to soft. On 2014/04/09 07:59:47, Yang wrote: https://codereview.chromium.org/228883005/diff/1/test/mjsunit/regress/regress-359491.js File

[v8-dev] Turn on concurrent sweeping. (issue 230733002)

2014-04-09 Thread hpayer
Reviewers: jarin, Michael Starzinger, Description: Turn on concurrent sweeping. BUG= Please review this at https://codereview.chromium.org/230733002/ SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge Affected files (+2, -2 lines): M src/flag-definitions.h Index:

[v8-dev] Re: Issue 3216 in v8: Add the ability to disable tests in nosnap mode

2014-04-09 Thread codesite-noreply
Comment #2 on issue 3216 by machenb...@chromium.org: Add the ability to disable tests in nosnap mode http://code.google.com/p/v8/issues/detail?id=3216 We currently need it to fix the windows nosnap builder by skipping some tests. -- You received this message because this project is

[v8-dev] Re: Turn on concurrent sweeping. (issue 230733002)

2014-04-09 Thread jarin
lgtm. Let's have some fun! https://codereview.chromium.org/230733002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop

[v8-dev] Re: Avoid hydrogen compare-objects-equal assertions in dead code (issue 228883005)

2014-04-09 Thread yangguo
On 2014/04/09 12:23:39, jarin wrote: Thanks for the beautiful test case! As discussed in person, I have update the change with your test and changed the deoptimization from eager to soft. On 2014/04/09 07:59:47, Yang wrote:

[v8-dev] [v8] r20612 committed - Turn on concurrent sweeping....

2014-04-09 Thread codesite-noreply
Revision: 20612 Author: hpa...@chromium.org Date: Wed Apr 9 12:27:20 2014 UTC Log: Turn on concurrent sweeping. BUG= R=ja...@chromium.org Review URL: https://codereview.chromium.org/230733002 http://code.google.com/p/v8/source/detail?r=20612 Modified:

[v8-dev] Re: Turn on concurrent sweeping. (issue 230733002)

2014-04-09 Thread hpayer
Committed patchset #1 manually as r20612 (presubmit successful). https://codereview.chromium.org/230733002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To

[v8-dev] [v8] r20613 committed - ARM64: Use pair memory access in deoptimizer entry...

2014-04-09 Thread codesite-noreply
Revision: 20613 Author: m.m.capew...@googlemail.com Date: Wed Apr 9 12:27:51 2014 UTC Log: ARM64: Use pair memory access in deoptimizer entry BUG= R=u...@chromium.org Review URL: https://codereview.chromium.org/228573003 http://code.google.com/p/v8/source/detail?r=20613 Modified:

[v8-dev] Re: ARM64: Use pair memory access in deoptimizer entry (issue 228573003)

2014-04-09 Thread m . m . capewell
Committed patchset #2 manually as r20613 (presubmit successful). https://codereview.chromium.org/228573003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To

  1   2   3   >