LGTM
https://codereview.chromium.org/236303015/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it
Reviewers: Benedikt Meurer,
Description:
Remove some uses of MaybeObject methods.
R=bmeu...@chromium.org
Please review this at https://codereview.chromium.org/236303015/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+66, -105 lines):
M src/isolate.cc
M src
Committed patchset #1 manually as r20785 (presubmit successful).
https://codereview.chromium.org/239143003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
Revision: 20785
Author: yang...@chromium.org
Date: Wed Apr 16 06:18:37 2014 UTC
Log: Remove further unhandlified call sites of number allocations.
R=dslo...@chromium.org
Review URL: https://codereview.chromium.org/239143003
http://code.google.com/p/v8/source/detail?r=20785
Modified:
Hi Michael,
Thanks for the fix!
-Haitao
https://codereview.chromium.org/237673007/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this gr
Revision: 20784
Author: haitao.f...@intel.com
Date: Wed Apr 16 02:06:14 2014 UTC
Log: Introduce DontEmitDebugCodeScope to fix the x64 nosnapshot build.
R=yang...@chromium.org
Review URL: https://codereview.chromium.org/232673003
http://code.google.com/p/v8/source/detail?r=20784
Modif
Committed patchset #7 manually as r20784 (presubmit successful).
https://codereview.chromium.org/232673003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
Hi Michael,
Thanks for your fix. This makes the DontEmitDebugCodeScope unnecessary in
VisitCountOperation.
Thanks
-Haitao
https://codereview.chromium.org/232673003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because yo
Revision: 20783
Author: pal...@homejinni.com
Date: Wed Apr 16 01:08:23 2014 UTC
Log: MIPS: Reland r20692 "Check stack limit in
ArgumentAdaptorTrampoline."
Port r20751 (18578019)
BUG=
R=plin...@gmail.com
Review URL: https://codereview.chromium.org/239803004
http://code.google.com/p
Committed patchset #1 manually as r20783 (presubmit successful).
https://codereview.chromium.org/239803004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
On 2014/04/16 00:40:18, adamk wrote:
Committed patchset #11 manually as r20781 (presubmit successful).
This got reverted in https://code.google.com/p/v8/source/detail?r=20782 for
breaking the Win32 build due to some unresolved symbols:
http://build.chromium.org/p/client.v8/builders/V8%20Win32%
Reviewers: Michael Starzinger,
Message:
Committed patchset #1 manually as r20782 (tree was closed).
Description:
Revert "ES6: Add support for Map/Set forEach"
This reverts commit https://code.google.com/p/v8/source/detail?r=20781.
It broke the Win32 builders.
TBR=mstarzin...@chromium.org
Com
lgtm
https://codereview.chromium.org/239803004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
Reviewers: ulan, danno, kisg, kilvadyb, dusmil, Paul Lind,
Message:
PTAL.
Description:
MIPS: Reland r20692 "Check stack limit in ArgumentAdaptorTrampoline."
Port r20751 (18578019)
BUG=
Please review this at https://codereview.chromium.org/239803004/
SVN Base: https://v8.googlecode.com/svn/br
Committed patchset #11 manually as r20781 (presubmit successful).
https://codereview.chromium.org/236143002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To
Revision: 20780
Author: machenb...@chromium.org
Date: Wed Apr 16 00:05:45 2014 UTC
Log: Tagging version 3.26.16
http://code.google.com/p/v8/source/detail?r=20780
Added:
/tags/3.26.16
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You rece
On 2014/04/15 22:02:30, Michael Starzinger wrote:
LGTM.
Thanks for the review. Can you land this for me?
https://codereview.chromium.org/236143002/diff/120001/src/objects-visiting.h
File src/objects-visiting.h (right):
https://codereview.chromium.org/236143002/diff/120001/src/objects-visit
LGTM.
https://codereview.chromium.org/236143002/diff/120001/src/objects-visiting.h
File src/objects-visiting.h (right):
https://codereview.chromium.org/236143002/diff/120001/src/objects-visiting.h#newcode101
src/objects-visiting.h:101: V(JSMapIterator)\
On 2014/04/15 17:07:23, arv w
https://codereview.chromium.org/160073006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send
On 2014/04/15 08:59:58, aperez wrote:
On 2014/04/15 08:32:49, marja wrote:
> Btw, I just refactored ParseFunctionLiteral. Con: you'll need to rebase.
Pro:
> The function is less monstrous now, so people are probably more willing
to
> accept additions. You might still want to refactor parsing t
On 2014/04/15 19:05:42, adamk wrote:
On 2014/04/15 17:31:02, adamk wrote:
> On 2014/04/15 05:57:55, Toon Verwaest wrote:
> > TL;DR: No, the global proxy is rebound to a new global object after
> navigation,
> > and we need to ensure that existing references outside of that context
persist
> > pro
On 2014/04/15 17:31:02, adamk wrote:
On 2014/04/15 05:57:55, Toon Verwaest wrote:
> TL;DR: No, the global proxy is rebound to a new global object after
navigation,
> and we need to ensure that existing references outside of that context
persist
> properly. Hence the identity has to stay the sam
On 2014/04/15 05:57:55, Toon Verwaest wrote:
TL;DR: No, the global proxy is rebound to a new global object after
navigation,
and we need to ensure that existing references outside of that context
persist
properly. Hence the identity has to stay the same.
The global proxy is the unique obje
PTAL
Michael, I'm not sure what your concern about GC is? At this point the
references are all strong refs.
I added a test but I'm not sure what you had in mind?
https://codereview.chromium.org/236143002/diff/120001/src/bootstrapper.cc
File src/bootstrapper.cc (right):
https://codereview.chro
Committed as r20778.
https://codereview.chromium.org/228943009/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receivin
Revision: 20778
Author: plin...@gmail.com
Date: Tue Apr 15 16:39:21 2014 UTC
Log: MIPS: Add big-endian support for MIPS.
Important notices:
- The snapshot cannot be created for big-endian target in cross-compilation
environment on little-endian host using simulator.
- In order to h
One more comment.
https://codereview.chromium.org/236143002/diff/140001/test/mjsunit/harmony/collections.js
File test/mjsunit/harmony/collections.js (right):
https://codereview.chromium.org/236143002/diff/140001/test/mjsunit/harmony/collections.js#newcode820
test/mjsunit/harmony/collections.js:
Looking good. One round of comments, mostly nits.
https://codereview.chromium.org/236143002/diff/120001/src/bootstrapper.cc
File src/bootstrapper.cc (right):
https://codereview.chromium.org/236143002/diff/120001/src/bootstrapper.cc#newcode1370
src/bootstrapper.cc:1370:
ASSERT(object_function->i
Committed patchset #1 manually as r20777 (presubmit successful).
https://codereview.chromium.org/239293002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
Revision: 20777
Author: joc...@chromium.org
Date: Tue Apr 15 15:37:42 2014 UTC
Log: Remove assertion scopes from V8_Fatal
V8_Fatal no longer tries to print a js stack, so we don't need those
scopes
BUG=none
R=yang...@chromium.org
LOG=n
Review URL: https://codereview.chromium.org/2392
Platform-independent changes LGTM.
https://codereview.chromium.org/228943009/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and
Revision: 20776
Author: mvstan...@chromium.org
Date: Tue Apr 15 15:29:23 2014 UTC
Log: JumpPatchSites can/should easily deal with uint8 sized offsets.
Motivation is that x64 nosnapshot builds need a 129 byte delta at the
moment.
R=mstarzin...@chromium.org
Review URL: https://coder
Committed patchset #1 manually as r20776 (presubmit successful).
https://codereview.chromium.org/237673007/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
On 2014/04/15 15:16:50, jochen wrote:
Lgtm
https://codereview.chromium.org/239293002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this
Reviewers: Dmitry Lomov (chromium),
Message:
As discussed, this is my current work in progress. Any comments so far?
https://codereview.chromium.org/239313002/diff/1/src/runtime.cc
File src/runtime.cc (right):
https://codereview.chromium.org/239313002/diff/1/src/runtime.cc#newcode565
src/runti
https://codereview.chromium.org/228943009/diff/1/src/objects.h
File src/objects.h (right):
https://codereview.chromium.org/228943009/diff/1/src/objects.h#newcode1959
src/objects.h:1959: #if __BYTE_ORDER == __LITTLE_ENDIAN
On 2014/04/15 08:11:20, Jakob wrote:
Any reason this doesn't use V8_TARGE
Revision: 20775
Author: ish...@chromium.org
Date: Tue Apr 15 15:17:04 2014 UTC
Log: Revert "Handlifying clients of StringTable, step 1."
This reverts commit r20772.
TBR=ja...@chromium.org
Review URL: https://codereview.chromium.org/239273002
http://code.google.com/p/v8/source/detail?
https://codereview.chromium.org/239203003/diff/20001/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/239203003/diff/20001/src/objects.cc#newcode7280
src/objects.cc:7280: Isolate* isolate = map->GetIsolate();
Note that map->code_cache is cleared on GC.
Could you add H
Hi Haitao,
I just ran into issues myself with x64 nosnap, and am happy to see your
fix. You
might also run into this issue, which I'm checking in the fix for today:
https://codereview.chromium.org/237673007/
All the best, thanks!
--Michael
https://codereview.chromium.org/232673003/
--
--
v8-
Reviewers: jarin,
Message:
Committed patchset #1 manually as r20775 (tree was closed).
Description:
Revert "Handlifying clients of StringTable, step 1."
This reverts commit r20772.
TBR=ja...@chromium.org
Committed: https://code.google.com/p/v8/source/detail?r=20775
Please review this at http
Reviewers: Yang,
Description:
Remove assertion scopes from V8_Fatal
V8_Fatal no longer tries to print a js stack, so we don't need those
scopes
BUG=none
R=yang...@chromium.org
LOG=n
Please review this at https://codereview.chromium.org/239293002/
SVN Base: https://v8.googlecode.com/svn/branch
Committed as r20774.
https://codereview.chromium.org/238943002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receivin
On Tue, Apr 15, 2014 at 9:21 AM, wrote:
> On 2014/04/15 13:05:23, arv wrote:
>
>> How are the callables in DOM represented? We use
>> ObjectTemplate::SetCallAsFunctionHandler for these
>>
>
>
> https://code.google.com/p/chromium/codesearch#search/&q=
> LegacyCallAsFunction%20file:%5C.idl&sq=packa
Revision: 20774
Author: plin...@gmail.com
Date: Tue Apr 15 15:11:36 2014 UTC
Log: MIPS: Reland "Track field types.".
Port r20746 (09f9176)
Original commit message:
This is an initial step towards tracking the exact types instead of just
the representations of fields. It adds support t
Reviewers: Hannes Payer,
Message:
Hi Hannes,
Here is one of the issues to address. PTAL, thx,
--Michael
ps - I think I see a comment to be removed.
Description:
LazyInstance should be thread safe by default.
The only ways we use this class require it, as multiple isolates can race
to initializ
LGTM.
https://codereview.chromium.org/237673007/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from i
lgtm with nits:
https://codereview.chromium.org/238543005/diff/90001/src/objects.cc
File src/objects.cc (left):
https://codereview.chromium.org/238543005/diff/90001/src/objects.cc#oldcode1887
src/objects.cc:1887: TransitionFlag flag = attributes != NONE ?
OMIT_TRANSITION : initial_flag;
This co
lgtm
https://codereview.chromium.org/239143003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
On 2014/04/15 14:55:18, ulan wrote:
https://codereview.chromium.org/239223003/diff/1/src/accessors.cc
File src/accessors.cc (right):
https://codereview.chromium.org/239223003/diff/1/src/accessors.cc#newcode389
src/accessors.cc:389: const v8::PropertyCallbackInfo& info) {
On 2014/04/15 14:50:35
https://codereview.chromium.org/239223003/diff/1/src/accessors.cc
File src/accessors.cc (right):
https://codereview.chromium.org/239223003/diff/1/src/accessors.cc#newcode389
src/accessors.cc:389: const v8::PropertyCallbackInfo& info) {
On 2014/04/15 14:50:35, Yang wrote:
You could have one sing
On 2014/04/11 13:15:38, Yang wrote:
*creeping up behind your shoulder*
https://codereview.chromium.org/235153003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group
lgtm.
https://codereview.chromium.org/239223003/diff/1/src/accessors.cc
File src/accessors.cc (right):
https://codereview.chromium.org/239223003/diff/1/src/accessors.cc#newcode389
src/accessors.cc:389: const v8::PropertyCallbackInfo& info) {
You could have one single setter that's unreachable,
feedback addressed, landing
https://codereview.chromium.org/239203003/diff/1/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/239203003/diff/1/src/objects.cc#newcode7526
src/objects.cc:7526: Handle CodeCache::Update(
On 2014/04/15 14:33:09, Yang wrote:
I think this c
Revision: 20773
Author: ma...@chromium.org
Date: Tue Apr 15 14:48:21 2014 UTC
Log: Refactoring: HashMap: provide a pointer match function, so users
don't need to.
R=yang...@chromium.org
Review URL: https://codereview.chromium.org/239133002
http://code.google.com/p/v8/source/detail?
Committed patchset #2 manually as r20773 (presubmit successful).
https://codereview.chromium.org/239133002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
Reviewers: Dmitry Lomov (chromium),
Description:
Remove further unhandlified call sites of number allocations.
R=dslo...@chromium.org
Please review this at https://codereview.chromium.org/239143003/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+54, -173 line
Reviewers: Michael Starzinger,
Message:
Hi Michael, here is the issue we discussed, found in x64 nosnapshot builds.
Thx,
--Michael
Description:
JumpPatchSites can/should easily deal with uint8 sized offsets.
R=mstarzin...@chromium.org
Please review this at https://codereview.chromium.org/23
On 2014/04/11 14:22:13, haitao.feng wrote:
Yang, thanks for the comments. I introduced a DontEmitDebugCodeScope to
wrapper
the emit_debug_code_ variable. It is more general than
NoSmiConstantRegisterUninitializationCheckScope and semantically clearer
than
using PredictableCodeSizeScope.
LG
Reviewers: jarin,
Message:
PTAL
Description:
Let releases script retrieve information about chromium branches.
BUG=
Please review this at https://codereview.chromium.org/238443005/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+74, -3 lines):
M tools/push-t
Reviewers: Yang,
Message:
PTAL
Description:
Handlify and convert Script accesssors to new API-style accessors.
BUG=
Please review this at https://codereview.chromium.org/239223003/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+163, -93 lines):
M src/access
LGTM. Adding Igor to CC to prevent him from redoing this.
https://codereview.chromium.org/239203003/diff/1/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/239203003/diff/1/src/objects.cc#newcode7526
src/objects.cc:7526: Handle CodeCache::Update(
I think this can retu
Reviewers: Yang,
Message:
PTAL
Description:
Handlify CodeCache.
R=yang...@chromium.org
BUG=
Please review this at https://codereview.chromium.org/239203003/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+101, -75 lines):
M src/factory.h
M src/factory.cc
lgtm
https://codereview.chromium.org/238943002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
Revision: 20772
Author: ish...@chromium.org
Date: Tue Apr 15 14:20:59 2014 UTC
Log: Handlifying clients of StringTable, step 1.
R=yang...@chromium.org
Review URL: https://codereview.chromium.org/239113002
http://code.google.com/p/v8/source/detail?r=20772
Modified:
/branches/bleeding
Committed patchset #2 manually as r20772 (presubmit successful).
https://codereview.chromium.org/239113002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
Reviewers: Igor Sheludko,
Message:
PTAL
Description:
Move CopyReplaceDescriptors to private
BUG=
Please review this at https://codereview.chromium.org/239203002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+25, -31 lines):
M src/objects.h
M src/objects.
lgtm
https://codereview.chromium.org/239113002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it
PTAL
https://codereview.chromium.org/239113002/diff/1/src/heap.cc
File src/heap.cc (right):
https://codereview.chromium.org/239113002/diff/1/src/heap.cc#newcode5951
src/heap.cc:5951: Runtime::InitializeIntrinsicFunctionNames(
On 2014/04/15 13:31:40, Yang wrote:
I guess at some point we want to
Committed patchset #1 manually as r20771 (presubmit successful).
https://codereview.chromium.org/230553004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
Revision: 20771
Author: jacob.bram...@arm.com
Date: Tue Apr 15 14:03:25 2014 UTC
Log: ARM64: Access has_pending_message_ correctly.
This fixes accesses in ARM and ARM64; the field is a bool, with size 1,
but we were accessing it with pointer-sized loads and stores.
BUG=
R=u...@chromiu
Committed patchset #1 manually as r20770 (tree was closed).
https://codereview.chromium.org/239173002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubs
Reviewers: Igor Sheludko,
Message:
PTAL
Description:
Introduce an abstraction to write to a field.
BUG=
Please review this at https://codereview.chromium.org/236063016/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+28, -46 lines):
M src/objects.h
M src/o
Revision: 20770
Author: yang...@chromium.org
Date: Tue Apr 15 13:56:51 2014 UTC
Log: Fix MUST_USE_RESULT warning.
R=ja...@chromium.org
Review URL: https://codereview.chromium.org/239173002
http://code.google.com/p/v8/source/detail?r=20770
Modified:
/branches/bleeding_edge/src/json-s
lgtm
https://codereview.chromium.org/239173002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
Reviewers: jarin,
Description:
Fix MUST_USE_RESULT warning.
R=ja...@chromium.org
Please review this at https://codereview.chromium.org/239173002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+1, -1 lines):
M src/json-stringifier.h
Index: src/json-stringif
Revision: 20769
Author: yang...@chromium.org
Date: Tue Apr 15 13:42:41 2014 UTC
Log: Use a wrapper for copying object.
R=mvstan...@chromium.org
Review URL: https://codereview.chromium.org/238113003
http://code.google.com/p/v8/source/detail?r=20769
Modified:
/branches/bleeding_edge/s
Committed patchset #1 manually as r20769 (presubmit successful).
https://codereview.chromium.org/238113003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
Revision: 20768
Author: yang...@chromium.org
Date: Tue Apr 15 13:37:15 2014 UTC
Log: Handlify BasicJsonStringifier.
R=ish...@chromium.org
Review URL: https://codereview.chromium.org/238273005
http://code.google.com/p/v8/source/detail?r=20768
Modified:
/branches/bleeding_edge/src/jso
Committed patchset #3 manually as r20768 (presubmit successful).
https://codereview.chromium.org/238273005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
On 2014/04/15 13:23:07, marja wrote:
yangguo, ptal
lgtm.
https://codereview.chromium.org/239133002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubs
LGTM!
https://codereview.chromium.org/239113002/diff/1/src/heap.cc
File src/heap.cc (right):
https://codereview.chromium.org/239113002/diff/1/src/heap.cc#newcode5951
src/heap.cc:5951: Runtime::InitializeIntrinsicFunctionNames(
I guess at some point we want to put this back into
CreateInitialObj
Revision: 20767
Author: u...@chromium.org
Date: Tue Apr 15 13:25:17 2014 UTC
Log: Reland r20652 "Handlify and convert string.length to new
API-style accessor."
BUG=
R=dcar...@chromium.org, yang...@chromium.org
Review URL: https://codereview.chromium.org/231973004
http://code.google
Committed patchset #4 manually as r20767 (presubmit successful).
https://codereview.chromium.org/231973004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
yangguo, ptal
https://codereview.chromium.org/239133002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving email
Reviewers: ,
Message:
yangguo, ptal
Description:
Refactoring: HashMap: provide a pointer match function, so users don't need
to.
BUG=yang...@chromium.org
Please review this at https://codereview.chromium.org/239133002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affecte
On 2014/04/15 13:05:23, arv wrote:
How are the callables in DOM represented? We use
ObjectTemplate::SetCallAsFunctionHandler for these
https://code.google.com/p/chromium/codesearch#search/&q=LegacyCallAsFunction%20file:%5C.idl&sq=package:chromium&type=cs
https://code.google.com/p/chromium/cod
Reviewers: Yang,
Message:
PTAL
Description:
Handlifying clients of StringTable, step 1.
Please review this at https://codereview.chromium.org/239113002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+123, -162 lines):
M src/factory.h
M src/factory.cc
M s
Reviewers: ulan,
Description:
Handlify callers of AllocateUninitializedFixedArray.
R=u...@chromium.org
Please review this at https://codereview.chromium.org/235943015/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+12, -25 lines):
M src/runtime.cc
Index:
Object::GetPrototype does not allocate, so it cannot cause a GC. I'm fine
with
using the handlified wrapper of Object::GetPrototype inside already
handlified
functions.
But using it inside functions that use raw object pointers is misleading and
potentially dangerous: it appears to make the c
On 2014/04/15 10:49:29, rossberg wrote:
https://codereview.chromium.org/236143002/diff/1/src/collection.js
File src/collection.js (right):
https://codereview.chromium.org/236143002/diff/1/src/collection.js#newcode130
src/collection.js:130: if (typeof f !== 'function') {
On 2014/04/14 19:51:49,
On 2014/04/15 10:47:23, Michael Starzinger wrote:
One high-level comment: Is there a particular reason why SetIterator and
MapIterator are JSObjects (with mutable properties and elements)? Will
they
ever
be exposed to user-land JavaScript? If not then I would vote for making
them
internal o
Revision: 20766
Author: mstarzin...@chromium.org
Date: Tue Apr 15 12:52:41 2014 UTC
Log: Fix bogus call to Object.hasOwnProperty in Array builtin.
R=mvstan...@chromium.org
TEST=mjsunit/regress/regress-builtinbust-5
Review URL: https://codereview.chromium.org/239033002
http://code.goog
Committed patchset #1 manually as r20766 (presubmit successful).
https://codereview.chromium.org/239033002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
On 2014/04/15 12:47:31, Dmitry Lomov (chromium) wrote:
https://codereview.chromium.org/238933002/diff/1/src/runtime.cc
File src/runtime.cc (right):
https://codereview.chromium.org/238933002/diff/1/src/runtime.cc#newcode620
src/runtime.cc:620: RETURN_IF_EMPTY_HANDLE(isolate, symbol);
Removed ma
https://codereview.chromium.org/238933002/diff/1/src/runtime.cc
File src/runtime.cc (right):
https://codereview.chromium.org/238933002/diff/1/src/runtime.cc#newcode620
src/runtime.cc:620: RETURN_IF_EMPTY_HANDLE(isolate, symbol);
Removed macro as discussed offline.
https://codereview.chromium.or
lgtm once note is addressed:
https://codereview.chromium.org/238273005/diff/20001/src/json-stringifier.h
File src/json-stringifier.h (right):
https://codereview.chromium.org/238273005/diff/20001/src/json-stringifier.h#newcode400
src/json-stringifier.h:400: if (elements->get(i) == *object) {
We
Reviewers: Yang,
Message:
PTAL
Description:
Handlify Object::GetPrototype and (most) callers.
R=yang...@chromium.org
Please review this at https://codereview.chromium.org/238973003/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+130, -104 lines):
M src/acce
+1 to Michael's comment too.
https://codereview.chromium.org/236063015/diff/1/src/heap.cc
File src/heap.cc (right):
https://codereview.chromium.org/236063015/diff/1/src/heap.cc#newcode5958
src/heap.cc:5958: if (max_old_generation_size_ <= 256 * MB) {
On 2014/04/15 12:11:50, Michael Starzinger w
lgtm
https://codereview.chromium.org/239033002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
Nice :).
LGTM.
https://codereview.chromium.org/238113003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving ema
1 - 100 of 205 matches
Mail list logo
