On 2014/04/15 10:47:23, Michael Starzinger wrote:
One high-level comment: Is there a particular reason why SetIterator and
MapIterator are JSObjects (with mutable properties and elements)? Will
they
ever
be exposed to user-land JavaScript? If not then I would vote for making
them
internal objects (ideally a subclass of v8::internal::Struct). That should
simplify the implementation (e.g. no context-dependent map for these
objects,
support code is automatically generated, fixed instance size).
MapIterator is returned by Map.prototype.{keys,values,entries} and
SetIterator
is returned by Set.prototype.{values,entries}.
http://people.mozilla.org/~jorendorff/es6-draft.html#sec-createmapiterator
http://people.mozilla.org/~jorendorff/es6-draft.html#sec-createsetiterator
These are not yet exposed but they will need to be eventually.
https://codereview.chromium.org/236143002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
