https://codereview.chromium.org/258993002/diff/1/src/arm/assembler-arm.cc
File src/arm/assembler-arm.cc (left):
https://codereview.chromium.org/258993002/diff/1/src/arm/assembler-arm.cc#oldcode137
src/arm/assembler-arm.cc:137: PrintFeatures();
On 2014/04/29 15:25:17, vincent.belliard.arm wrote:
Yes we can!
https://codereview.chromium.org/252213002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails
Committed patchset #2 manually as r21069 (presubmit successful).
https://codereview.chromium.org/252213002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Revision: 21069
Author: yang...@chromium.org
Date: Wed Apr 30 06:26:50 2014 UTC
Log: Hide some more heap allocators.
R=mstarzin...@chromium.org
Review URL: https://codereview.chromium.org/252213002
http://code.google.com/p/v8/source/detail?r=21069
Modified:
Reviewers: jarin,
Description:
Enable concurrent sweeping.
BUG=
Please review this at https://codereview.chromium.org/266463002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+2, -2 lines):
M src/flag-definitions.h
Index: src/flag-definitions.h
diff --git
Updates:
Status: PendingFurtherInfo
Comment #1 on issue 3301 by svenpa...@chromium.org: repeatedly allocation
causes segfault
http://code.google.com/p/v8/issues/detail?id=3301
I can't reproduce this...
--
You received this message because this project is configured to send all
lgtm
https://codereview.chromium.org/266463002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
LGTM. Cool stuff! I left just nits.
Would you mind renaming all variable and parameter names in all functions
you
touched to correspond to our coding style guide (Function names, variable
names, and
filenames should be descriptive; eschew abbreviation.). I started
commenting in
one file but
Revision: 21070
Author: hpa...@chromium.org
Date: Wed Apr 30 07:07:39 2014 UTC
Log: Enable concurrent sweeping.
BUG=
R=ja...@chromium.org
Review URL: https://codereview.chromium.org/266463002
http://code.google.com/p/v8/source/detail?r=21070
Modified:
Committed patchset #1 manually as r21070 (presubmit successful).
https://codereview.chromium.org/266463002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
done, thanks!
https://codereview.chromium.org/253903003/diff/1/test/mjsunit/regress/supported-locales-of.js
File test/mjsunit/regress/supported-locales-of.js (right):
https://codereview.chromium.org/253903003/diff/1/test/mjsunit/regress/supported-locales-of.js#newcode1
Seems reasonable to me, but I wonder if we care about the access_check bit
at
all? Is that just for performance that check? It seems like you could just
always do the same origin check on enqueue and call it a day.
We're trying to move everything except property reads and writes away from
Revision: 21071
Author: mvstan...@chromium.org
Date: Wed Apr 30 07:36:12 2014 UTC
Log: Bugfix: internationalization routines fail on monkeypatching.
Calls to Object.defineProperty() and Object.apply() are not safe.
R=mstarzin...@chromium.org
Review URL:
Good idea, lgtm.
https://codereview.chromium.org/255273004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving
Committed patchset #2 manually as r21071 (presubmit successful).
https://codereview.chromium.org/253903003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
:)
LGTM.
https://codereview.chromium.org/254103002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails
Comment #32 on issue 847 by ale...@zerkalenkov.de: 1gb memory limit
http://code.google.com/p/v8/issues/detail?id=847
@#31: hey thank you for the hint regarding typed arrays -- didn't know that
they are outside js heap. Actually after I've moved all geometry to typed
arrays I've also
A few rambling remarks about naming:
I'm not sure if renaming all that stuff is really worth and if it's implied
by
http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml#General_Naming_Rules
at all. It says Give as descriptive a name as possible, within reason.
This is
I think this is going in the right direction, cool stuff.
If performance is not *significantly* negatively impacted we should get rid
of
the macros.
https://codereview.chromium.org/253293003/diff/1/src/heap.h
File src/heap.h (right):
On 2014/04/30 07:56:14, Hannes Payer wrote:
I don't think it is vague, it is very precise General Naming Rules:
Function
names, variable names, and filenames should be descriptive; eschew
abbreviation..
It *is* vague, otherwise i, j, k, ... would be disallowed, which they
are
obviously
Committed patchset #1 manually as r21072 (presubmit successful).
https://codereview.chromium.org/255273004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Revision: 21072
Author: mstarzin...@chromium.org
Date: Wed Apr 30 08:16:16 2014 UTC
Log: Remove duplicate ToObject implementaion from i18n.
R=mvstan...@chromium.org
BUG=
Review URL: https://codereview.chromium.org/255273004
http://code.google.com/p/v8/source/detail?r=21072
Modified:
Yay! LGTM
https://codereview.chromium.org/254273002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails
Reviewers: Benedikt Meurer,
Message:
Committed patchset #1 manually as r21073 (presubmit successful).
Description:
Remove BootUpMemoryUse test.
BUG=
R=bmeu...@chromium.org
Committed: https://code.google.com/p/v8/source/detail?r=21073
Please review this at
Revision: 21073
Author: hpa...@chromium.org
Date: Wed Apr 30 08:19:38 2014 UTC
Log: Remove BootUpMemoryUse test.
BUG=
R=bmeu...@chromium.org
Review URL: https://codereview.chromium.org/254273002
http://code.google.com/p/v8/source/detail?r=21073
Modified:
Committed patchset #2 manually as r21074 (presubmit successful).
https://codereview.chromium.org/240873002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Revision: 21074
Author: dslo...@chromium.org
Date: Wed Apr 30 08:28:29 2014 UTC
Log: ES6: Add support for Array.prototype.fill()
BUG=v8:3273
LOG=Y
R=dslo...@chromium.org
Review URL: https://codereview.chromium.org/240873002
Patch from Adrian Perez ape...@igalia.com.
Hi Benedikt, thanks for the comments.
I've addressed, and also checking into performance of the array copy (I
think it
should be okay though, since previously we used to copy the type cells into
a
dictionary).
--Michael
https://codereview.chromium.org/254623002/diff/60001/src/compiler.cc
Committed patchset #2 manually as r21075 (presubmit successful).
https://codereview.chromium.org/242603002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Revision: 21075
Author: haitao.f...@intel.com
Date: Wed Apr 30 08:38:20 2014 UTC
Log: Update ElementsTransitionGenerator::GenerateSmiToDouble to
support x32 port.
R=verwa...@chromium.org
Review URL: https://codereview.chromium.org/242603002
Revision: 21076
Author: ish...@chromium.org
Date: Wed Apr 30 08:40:33 2014 UTC
Log: TODO in Dictionary resolved.
R=yang...@chromium.org
Review URL: https://codereview.chromium.org/251043008
http://code.google.com/p/v8/source/detail?r=21076
Modified:
Committed patchset #1 manually as r21076 (presubmit successful).
https://codereview.chromium.org/251043008/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
LGTM, let's see how it works in the wild! :-)
https://codereview.chromium.org/254623002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this
Reviewers: Michael Starzinger,
Message:
Hi Michael, PTAL, thx!
Description:
A new test needs to exit early on non-internationalization builds.
R=mstarzin...@chromium.org
Please review this at https://codereview.chromium.org/265513003/
SVN Base:
Reviewers: Yang,
Message:
PTAL #8
Description:
Public interface of KeyedLookupCache handlified.
Please review this at https://codereview.chromium.org/264563003/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+20, -18 lines):
M src/heap.h
M src/heap.cc
M
Reviewers: Yang,
Message:
PTAL #9
Description:
ScopeInfo::ContextSlotIndex() handlified.
Please review this at https://codereview.chromium.org/253263003/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+34, -26 lines):
M src/contexts.cc
M src/objects.h
M
LGTM.
https://codereview.chromium.org/265513003/diff/1/test/mjsunit/regress/regress-builtinbust-7.js
File test/mjsunit/regress/regress-builtinbust-7.js (right):
https://codereview.chromium.org/265513003/diff/1/test/mjsunit/regress/regress-builtinbust-7.js#newcode4
Committed patchset #1 manually as r21077 (presubmit successful).
https://codereview.chromium.org/254103002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Revision: 21077
Author: mstarzin...@chromium.org
Date: Wed Apr 30 08:52:00 2014 UTC
Log: Fix some more missing ToObject on Array.prototype.
R=mvstan...@chromium.org
BUG=
Review URL: https://codereview.chromium.org/254103002
http://code.google.com/p/v8/source/detail?r=21077
Modified:
Reviewers: Yang,
Message:
PTAL #10
Description:
ContextSlotCache::Update() handlified.
Please review this at https://codereview.chromium.org/263613003/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+17, -18 lines):
M src/scopeinfo.h
M src/scopeinfo.cc
Hydrogen changes LGTM.
https://codereview.chromium.org/258793002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop
Committed patchset #2 manually as r21078 (presubmit successful).
https://codereview.chromium.org/265513003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Revision: 21078
Author: mvstan...@chromium.org
Date: Wed Apr 30 09:04:17 2014 UTC
Log: A new test needs to exit early on non-internationalization builds.
R=mstarzin...@chromium.org
Review URL: https://codereview.chromium.org/265513003
http://code.google.com/p/v8/source/detail?r=21078
Reviewers: Yang,
Message:
PTAL #11
Description:
StringTable::Lookup*IfExist() handlified.
Please review this at https://codereview.chromium.org/265553003/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+58, -52 lines):
M src/factory.cc
M src/heap.h
M
Committed patchset #1 manually as r21079 (presubmit successful).
https://codereview.chromium.org/240473009/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Revision: 21079
Author: haitao.f...@intel.com
Date: Wed Apr 30 09:08:21 2014 UTC
Log: Update SafeMove, SafePush, SmiToIndex and SmiToNegativeIndex for
x32 port.
R=verwa...@chromium.org
Review URL: https://codereview.chromium.org/240473009
Revision: 21080
Author: haitao.f...@intel.com
Date: Wed Apr 30 09:12:18 2014 UTC
Log: Introduce PushQuad and PopQuad for x64 port.
R=verwa...@chromium.org
Review URL: https://codereview.chromium.org/238253013
http://code.google.com/p/v8/source/detail?r=21080
Modified:
Revision: 21081
Author: ish...@chromium.org
Date: Wed Apr 30 09:13:21 2014 UTC
Log: Handlification TODOs in scanner and string stream resolved.
R=yang...@chromium.org
Review URL: https://codereview.chromium.org/251263004
http://code.google.com/p/v8/source/detail?r=21081
Modified:
Committed patchset #1 manually as r21081 (presubmit successful).
https://codereview.chromium.org/251263004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
https://codereview.chromium.org/258793002/diff/50001/src/arm64/lithium-arm64.h
File src/arm64/lithium-arm64.h (right):
https://codereview.chromium.org/258793002/diff/50001/src/arm64/lithium-arm64.h#newcode1912
src/arm64/lithium-arm64.h:1912: /* Math.floor with a double result. */
Please use //
LGTM with comments.
https://codereview.chromium.org/260003006/diff/1/src/objects-visiting-inl.h
File src/objects-visiting-inl.h (right):
https://codereview.chromium.org/260003006/diff/1/src/objects-visiting-inl.h#newcode315
src/objects-visiting-inl.h:315:
Revision: 21082
Author: haitao.f...@intel.com
Date: Wed Apr 30 09:23:41 2014 UTC
Log: Introduce DropUnderReturnAddress for x64 port.
R=verwa...@chromium.org
Review URL: https://codereview.chromium.org/242113005
http://code.google.com/p/v8/source/detail?r=21082
Modified:
Committed patchset #1 manually as r21082 (presubmit successful).
https://codereview.chromium.org/242113005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
https://codereview.chromium.org/258793002/diff/50001/src/arm64/lithium-arm64.h
File src/arm64/lithium-arm64.h (right):
https://codereview.chromium.org/258793002/diff/50001/src/arm64/lithium-arm64.h#newcode1912
src/arm64/lithium-arm64.h:1912: /* Math.floor with a double result. */
On 2014/04/30
Feedback addressed, landing.
https://codereview.chromium.org/260003006/diff/1/src/objects-visiting-inl.h
File src/objects-visiting-inl.h (right):
https://codereview.chromium.org/260003006/diff/1/src/objects-visiting-inl.h#newcode315
src/objects-visiting-inl.h:315:
Comment #2 on issue 3301 by anton.gr...@gmail.com: repeatedly allocation
causes segfault
http://code.google.com/p/v8/issues/detail?id=3301
Thanks for looking into this.
Attaching more information:
- commit 98aba5f2dd921bdf55ae415253f2c064f0ec doesn't segfault
- commit
If the input is greater or equal to zero, the 'lt' (less than) condition
is
not met, so FCCMP sets the Z condition flag, and the following branch is
taken.
Thanks, lgtm.
https://codereview.chromium.org/258793002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
LGTM as discussed offline, keeping the c/p issues and improvement
suggestions
from the original test case for future CLs.
https://codereview.chromium.org/252143002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because
Committed patchset #2 manually as r21083 (presubmit successful).
https://codereview.chromium.org/260003006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
DBC:
I'm with Sven here. When it can reasonably be assumed that everyone (in our
team
and beyond) will immediately and unambiguously understand a short name, then
it's fine to keep it: obj, src, dst, str, args, etc are all very
common; expanding/renaming them is not worth our time and adds
https://codereview.chromium.org/265593002/diff/40001/include/v8.h
File include/v8.h (right):
https://codereview.chromium.org/265593002/diff/40001/include/v8.h#newcode1134
include/v8.h:1134: * Returns the resource name for the script from where
the function causing
Returns the resource name or
Revision: 21084
Author: svenpa...@chromium.org
Date: Wed Apr 30 10:24:03 2014 UTC
Log: Unbreak the build after r21083.
TBR=mstarzin...@chromium.org
Review URL: https://codereview.chromium.org/266493003
http://code.google.com/p/v8/source/detail?r=21084
Modified:
Reviewers: Michael Starzinger,
Message:
Committed patchset #1 manually as r21084 (presubmit successful).
Description:
Unbreak the build after r21083.
TBR=mstarzin...@chromium.org
Committed: https://code.google.com/p/v8/source/detail?r=21084
Please review this at
On 2014/04/30 09:58:12, Jakob wrote:
DBC:
I'm with Sven here. When it can reasonably be assumed that everyone (in
our
team
and beyond) will immediately and unambiguously understand a short name,
then
it's fine to keep it: obj, src, dst, str, args, etc are all very
common;
Committed patchset #3 manually as r21085 (presubmit successful).
https://codereview.chromium.org/254623002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Revision: 21085
Author: mvstan...@chromium.org
Date: Wed Apr 30 10:51:01 2014 UTC
Log: Simplify feedback vector creation and store in SharedFunctionInfo.
LOG=N
BUG=v8:3212
R=bmeu...@chromium.org
Review URL: https://codereview.chromium.org/254623002
Reviewers: Sven Panne,
Message:
Hi Sven, a small cleanup since deferred slot processing was removed from
type
vectors. PTAL, thx,
--Michael
Description:
Small cleanup: AstConstructionVisitor no longer needs a Zone pointer.
R=svenpa...@chromium.org
Please review this at
Reviewers: Michael Starzinger,
Description:
Object.defineProperty shouldn't be a hint that we're constructing a
dictionary.
BUG=362870
LOG=y
Please review this at https://codereview.chromium.org/261583004/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+42,
Fixed bugs in first patchset and added tests. The tests fail on master.
PTAL.
https://codereview.chromium.org/260423002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups
lgtm
https://codereview.chromium.org/265623002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Reviewers: mcilroy, Michael Starzinger,
Description:
When maximum space size flags are set, overwrite the resource constraints.
BUG=
Please review this at https://codereview.chromium.org/262653002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+11, -0 lines):
Reviewers: rossberg,
Description:
Trigger exception debug event for promises at the throw site.
R=rossb...@chromium.org
Please review this at https://codereview.chromium.org/260723002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+147, -123 lines):
M
On 2014/04/30 12:04:25, Yang wrote:
Main changes are:
- Trigger the debug event for uncaught exceptions in promises at the throw
site.
- Folded PendingExceptionInPromise event into Exception. The difference
being
whether there is a promise attached.
- If calling deferred.reject throws, we
I'll work on making the performance impact for non-debugging less in an
upcoming
CL.
https://codereview.chromium.org/260723002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google
On 2014/04/30 12:04:25, Yang wrote:
Main changes are:
- Trigger the debug event for uncaught exceptions in promises at the throw
site.
- Folded PendingExceptionInPromise event into Exception. The difference
being
whether there is a promise attached.
- If calling deferred.reject throws, we
https://codereview.chromium.org/262653002/diff/1/src/api.cc
File src/api.cc (right):
https://codereview.chromium.org/262653002/diff/1/src/api.cc#newcode474
src/api.cc:474:
Would it be better to put this code in Heap::ConfigureHeap()? That way
the flags would be respected even if the embedder
Comment #2 on issue 3292 by wi...@igalia.com: Implement generator mirror
http://code.google.com/p/v8/issues/detail?id=3292
I guess you mean generator objects? Generator functions seem to inspect
just fine, given that they are just functions.
--
You received this message because this
Comment #3 on issue 3301 by svenpa...@chromium.org: repeatedly allocation
causes segfault
http://code.google.com/p/v8/issues/detail?id=3301
Hmmm, I still can't reproduce this, I tried memcheck with both ia32 and x64
versions of d8. It would be great if you can build a debug version (make
https://codereview.chromium.org/259173003/diff/1/src/heap-inl.h
File src/heap-inl.h (right):
https://codereview.chromium.org/259173003/diff/1/src/heap-inl.h#newcode406
src/heap-inl.h:406: return false;
On 2014/04/30 07:07:07, Hannes Payer wrote:
Is this necessary here? This case is caught by
Committed patchset #2 manually as r21086 (presubmit successful).
https://codereview.chromium.org/259173003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
On 2014/04/30 10:39:45, Hannes Payer wrote:
On 2014/04/30 09:58:12, Jakob wrote:
DBC:
I'm with Sven here. When it can reasonably be assumed that everyone (in
our
team
and beyond) will immediately and unambiguously understand a short name,
then
it's fine to keep it: obj, src, dst, str,
https://codereview.chromium.org/259173003/diff/1/src/heap-inl.h
File src/heap-inl.h (right):
https://codereview.chromium.org/259173003/diff/1/src/heap-inl.h#newcode406
src/heap-inl.h:406: return false;
On 2014/04/30 12:25:34, Yang wrote:
The compiler would otherwise complain that there is no
Reviewers: Yang,
Message:
Hi Yang, here is the gcmole warning, thx!
Description:
Fix gcmole warning in EnsureSlotContainsAllocationSite().
R=yang...@chromium.org
Please review this at https://codereview.chromium.org/268443002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
On 2014/04/30 12:31:41, mvstanton wrote:
Hi Yang, here is the gcmole warning, thx!
lgtm.
https://codereview.chromium.org/268443002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google
Revision: 21087
Author: mvstan...@chromium.org
Date: Wed Apr 30 12:33:16 2014 UTC
Log: Fix gcmole warning in EnsureSlotContainsAllocationSite().
R=yang...@chromium.org
Review URL: https://codereview.chromium.org/268443002
http://code.google.com/p/v8/source/detail?r=21087
Modified:
Committed patchset #1 manually as r21087 (presubmit successful).
https://codereview.chromium.org/268443002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Reviewers: Sven Panne,
Description:
Do not use default for switch over AllocationSpace.
R=svenpa...@chromium.org
Please review this at https://codereview.chromium.org/262583004/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+2, -2 lines):
M src/heap.cc
M
Comment #3 on issue 3292 by yang...@chromium.org: Implement generator mirror
http://code.google.com/p/v8/issues/detail?id=3292
You are right. Generator objects are what I meant.
--
You received this message because this project is configured to send all
issue notifications to this address.
https://codereview.chromium.org/262653002/diff/1/src/api.cc
File src/api.cc (right):
https://codereview.chromium.org/262653002/diff/1/src/api.cc#newcode474
src/api.cc:474:
On 2014/04/30 12:17:13, rmcilroy wrote:
Would it be better to put this code in Heap::ConfigureHeap()? That
way the
Revision: 21088
Author: mvstan...@chromium.org
Date: Wed Apr 30 12:35:41 2014 UTC
Log: Small cleanup: AstConstructionVisitor no longer needs a Zone
pointer.
R=svenpa...@chromium.org
Review URL: https://codereview.chromium.org/265623002
lgtm
https://codereview.chromium.org/262583004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Committed patchset #1 manually as r21089 (presubmit successful).
https://codereview.chromium.org/262583004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Revision: 21089
Author: yang...@chromium.org
Date: Wed Apr 30 12:38:39 2014 UTC
Log: Do not use default for switch over AllocationSpace.
R=svenpa...@chromium.org
Review URL: https://codereview.chromium.org/262583004
http://code.google.com/p/v8/source/detail?r=21089
Modified:
Comment #4 on issue 3292 by wi...@igalia.com: Implement generator mirror
http://code.google.com/p/v8/issues/detail?id=3292
I'm on it if you like. The proposal would be to add a case to
serializeObject like:
if (mirror.isGenerator()) {
// Add generator specific properties.
Comment #5 on issue 3292 by yang...@chromium.org: Implement generator mirror
http://code.google.com/p/v8/issues/detail?id=3292
Sounds good. Though this doesn't have high priority, and I'd like to talk
to the devtools guys about this before you sink time into this.
--
You received this
https://codereview.chromium.org/260723002/diff/1/src/debug.cc
File src/debug.cc (right):
https://codereview.chromium.org/260723002/diff/1/src/debug.cc#newcode1334
src/debug.cc:1334: current_promise_catch_handler_ = NULL;
Are we sure that PromiseHandle can never be reentered recursively?
lgtm - thanks!
https://codereview.chromium.org/262653002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving
Reviewers: Dmitry Lomov (chromium),
Message:
PTAL.
Description:
Harden more runtime functions
Please review this at https://codereview.chromium.org/255333004/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+61, -17 lines):
M src/objects.h
M src/objects.cc
looks good
https://codereview.chromium.org/260723002/diff/1/test/mjsunit/es6/debug-promises-throw-in-reject.js
File test/mjsunit/es6/debug-promises-throw-in-reject.js (right):
https://codereview.chromium.org/260723002/diff/1/test/mjsunit/es6/debug-promises-throw-in-reject.js#newcode46
lgtm with a nit.
https://codereview.chromium.org/255333004/diff/1/src/runtime.cc
File src/runtime.cc (right):
https://codereview.chromium.org/255333004/diff/1/src/runtime.cc#newcode961
src/runtime.cc:961: RUNTIME_ASSERT(arrayId = 1 arrayId = 9);
Add FIRST_ and LAST_ to TypedArrayId enum
1 - 100 of 176 matches
Mail list logo
