Updates:
Status: Assigned
Owner: yang...@chromium.org
Comment #1 on issue 3469 by svenpa...@chromium.org: Math.fround slowness
http://code.google.com/p/v8/issues/detail?id=3469
Hmmm, if I see this correctly, the polyfill for Math.fround in
box2d_f32_2.js is the identity
lgtm
https://codereview.chromium.org/416123002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Reviewers: Igor Sheludko,
Message:
PTAL
Description:
Move extra_ic_state to the PropertyICCompiler
BUG=
Please review this at https://codereview.chromium.org/426593002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+16, -26 lines):
M src/ic.cc
M
LGTM
https://codereview.chromium.org/396803009/diff/60001/test/cctest/test-constantpool.cc
File test/cctest/test-constantpool.cc (right):
https://codereview.chromium.org/396803009/diff/60001/test/cctest/test-constantpool.cc#newcode287
test/cctest/test-constantpool.cc:287:
Reviewers: Toon Verwaest, Weiliang,
Message:
hello. Toon.
please help to review and commit this porting patch.
thanks.
Description:
X87: Restructure the IC / Handler compilers
port r22622.
original commit message:
Restructure the IC / Handler compilers.
BUG=
Please review this at
lgtm with a nit:
https://codereview.chromium.org/426593002/diff/1/src/stub-cache.h
File src/stub-cache.h (right):
https://codereview.chromium.org/426593002/diff/1/src/stub-cache.h#newcode594
src/stub-cache.h:594: // Handlers do not use strict mode.
Does this comment still make sense?
Updates:
Cc: jkumme...@chromium.org k...@chromium.org
Comment #7 on issue 3241 by jkumme...@chromium.org:
Object.prototype.toString.call(Promise.resolve()) should be [object
Promise]
http://code.google.com/p/v8/issues/detail?id=3241
Issue chromium:397871 has been merged into this
Updates:
Cc: -jkumme...@chromium.org -k...@chromium.org
Comment #8 on issue 3241 by jkumme...@chromium.org:
Object.prototype.toString.call(Promise.resolve()) should be [object
Promise]
http://code.google.com/p/v8/issues/detail?id=3241
(No comment was entered for this change.)
--
https://codereview.chromium.org/420753002/diff/60001/src/counters.cc
File src/counters.cc (right):
https://codereview.chromium.org/420753002/diff/60001/src/counters.cc#newcode58
src/counters.cc:58: #define HR(name, caption) name##_ =
Histogram(#caption, 0, 1000, 1001, isolate);
why cap it at
On 2014/07/25 18:27:21, Hannes Payer wrote:
LGTM, if the overhead of this call is negligible
The overhead is very low, if Chrome tracing is not enabled.
We should also move the histogram timer from AdvanceIdleIncrementalMarking
into
this function. I guess the intent was to log every
On 2014/07/28 at 08:54:17, ernstm wrote:
On 2014/07/25 18:27:21, Hannes Payer wrote:
LGTM, if the overhead of this call is negligible
The overhead is very low, if Chrome tracing is not enabled.
We should also move the histogram timer from
AdvanceIdleIncrementalMarking
into
this
Adding Ben as reviewer.
https://codereview.chromium.org/410153002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop
https://codereview.chromium.org/420753002/diff/60001/src/counters.cc
File src/counters.cc (right):
https://codereview.chromium.org/420753002/diff/60001/src/counters.cc#newcode58
src/counters.cc:58: #define HR(name, caption) name##_ =
Histogram(#caption, 0, 1000, 1001, isolate);
On 2014/07/25
https://codereview.chromium.org/420753002/diff/60001/src/counters.cc
File src/counters.cc (right):
https://codereview.chromium.org/420753002/diff/60001/src/counters.cc#newcode58
src/counters.cc:58: #define HR(name, caption) name##_ =
Histogram(#caption, 0, 1000, 1001, isolate);
On 2014/07/28
On 2014/07/26 at 01:43:22, jianghua.yjh wrote:
please review .
I couldn't find a CCLA entry for you
(https://developers.google.com/open-source/cla/corporate?csw=1) Without it,
we
can't accept patches, sorry.
https://codereview.chromium.org/417353002/
--
--
v8-dev mailing list
Committed patchset #5 manually as r22632 (presubmit successful).
https://codereview.chromium.org/420753002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Revision: 22632
Author: hpa...@chromium.org
Date: Mon Jul 28 09:13:33 2014 UTC
Log: Added histogram to track distribution of requested idle
notifications.
BUG=397026
LOG=n
R=rmcil...@chromium.org
Review URL: https://codereview.chromium.org/420753002
Revision: 22633
Author: joc...@chromium.org
Date: Mon Jul 28 09:15:10 2014 UTC
Log: Reland r22460 - Bootstrapper::DetachGlobal also need to unset
g...
| DetachGlobal detaches original context of a global proxy object.
|
| Before this patch, the constructor JSFunction still carried
Reviewers: dcarney (ooto),
Message:
Committed patchset #1 manually as r22633.
Description:
Reland r22460 - Bootstrapper::DetachGlobal also need to unset g...
| DetachGlobal detaches original context of a global proxy object.
|
| Before this patch, the constructor JSFunction still carried a
|
Thanks.
https://codereview.chromium.org/396803009/diff/60001/test/cctest/test-constantpool.cc
File test/cctest/test-constantpool.cc (right):
https://codereview.chromium.org/396803009/diff/60001/test/cctest/test-constantpool.cc#newcode287
test/cctest/test-constantpool.cc:287:
Updates:
Status: Fixed
Comment #3 on issue 3212 by mvstan...@chromium.org: Type feedback is lost
on recompile with deoptimization support
http://code.google.com/p/v8/issues/detail?id=3212
Oops, forgot about this old issue. It is fixed.
--
You received this message because this
lgtm other than small comments
https://codereview.chromium.org/410153002/diff/1/src/factory.cc
File src/factory.cc (right):
https://codereview.chromium.org/410153002/diff/1/src/factory.cc#newcode1376
src/factory.cc:1376: !isolate()-bootstrapper()-IsActive()
Comment me, TODO me?
Committed patchset #5 manually as r22634 (presubmit successful).
https://codereview.chromium.org/396803009/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Revision: 22634
Author: rmcil...@chromium.org
Date: Mon Jul 28 10:04:36 2014 UTC
Log: Tests that the GC doesn't mistake non-pointer constant pool
entries as pointers.
Adds a test for ConstantPoolArray to ensure that the GC
doesn't mistake non-pointer entries as pointers and try
to
On 2014/07/25 10:12:49, haraken wrote:
On 2014/07/25 10:10:53, jochen wrote:
i'm out today, but I'll take care of it on Monday (Kentaro, to answer
your
question: bleeding_edge.
fetch v8
cd v8
git cl patch -b land 397953009
git cl dcommit -c '...'
)
For safety, let me ask you to
Moved HistogramTimerScope from Heap::AdvanceIdleIncrementalMarking to
IncrementalMarking::Step. The diff looks bigger, because the added scope
around
the timed code and git cl format touched almost every line in Step.
https://codereview.chromium.org/420613006/
--
--
v8-dev mailing list
Committed patchset #1 manually as r22635 (presubmit successful).
https://codereview.chromium.org/426593002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Revision: 22635
Author: verwa...@chromium.org
Date: Mon Jul 28 10:55:32 2014 UTC
Log: Move extra_ic_state to the PropertyICCompiler
BUG=
R=ish...@chromium.org
Review URL: https://codereview.chromium.org/426593002
http://code.google.com/p/v8/source/detail?r=22635
Modified:
Reviewers: Igor Sheludko,
Message:
PTAL
Description:
Remove all compilation related interface from the StubCache
BUG=
Please review this at https://codereview.chromium.org/422853003/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+215, -232 lines):
M
https://codereview.chromium.org/401783003/diff/1/AUTHORS
File AUTHORS (right):
https://codereview.chromium.org/401783003/diff/1/AUTHORS#newcode37
AUTHORS:37: Isiah Meadows impinb...@gmail.com
Did you already sign the CLA. I wasn't able to find you on the list.
Instructions on how to do so can
lgtm
https://codereview.chromium.org/420613006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from it,
lgtm
https://codereview.chromium.org/420613006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Reviewers: jochen,
Description:
Revert Fix a potential overflow in SortedListBSearch.
This reverts r21960.
R=joc...@chromium.org
Please review this at https://codereview.chromium.org/422853005/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+1, -1 lines):
M
On 2014/07/28 11:20:57, Yang wrote:
Reverted for the time being. Contributor needs to sign the CCLA.
https://codereview.chromium.org/422853005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to
lgtm
https://codereview.chromium.org/422853005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Reviewers: Toon Verwaest,
Description:
Use return value of GetPropertyAttributes to make compiler happy.
BUG=
Please review this at https://codereview.chromium.org/420443006/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+6, -3 lines):
M src/objects.cc
M
Do we have (or want) a policy on when a company is listed as a contributor,
whether contributing employees of that company should be listed
individually?
Right now we seem to have examples for both yes and no.
Personally, I don't feel strongly about it either way, but would weakly
prefer
to
I see this has already happened in patch set 2. Ignore me then :-)
https://codereview.chromium.org/399243002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
There is actually a very specific policy about how the AUTHORS file should
work,
and I'm currently working with various folks, including Paul, to make sure
that
we implement it.
https://codereview.chromium.org/399243002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
https://codereview.chromium.org/411263004/diff/20001/src/math.js
File src/math.js (right):
https://codereview.chromium.org/411263004/diff/20001/src/math.js#newcode188
src/math.js:188: macro REMPIO2(X)
On 2014/07/24 18:08:44, Raymond Toy wrote:
Does this have to be a macro? Dropping this big
Committed patchset #1 manually as r22636 (presubmit successful).
https://codereview.chromium.org/422853005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Revision: 22636
Author: yang...@chromium.org
Date: Mon Jul 28 11:42:52 2014 UTC
Log: Revert Fix a potential overflow in SortedListBSearch.
This reverts r21960.
R=joc...@chromium.org
Review URL: https://codereview.chromium.org/422853005
Committed patchset #1 manually as r22637 (presubmit successful).
https://codereview.chromium.org/416123002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Revision: 22637
Author: yang...@chromium.org
Date: Mon Jul 28 11:47:10 2014 UTC
Log: Properly propagate serialization flag when compiling hydrogen
code stubs.
R=mvstan...@chromium.org
Review URL: https://codereview.chromium.org/416123002
On 2014/07/28 03:45:53, jianghua wrote:
please review , thanks!
waiting for the CCLA issue to be resolved.
https://codereview.chromium.org/421153002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
Updates:
Status: WorkingAsIntended
Comment #1 on issue 3468 by jkumme...@chromium.org: Math.exp(100) is
inaccurate
http://code.google.com/p/v8/issues/detail?id=3468
Our Math.exp implementation sacrifices 1-2 decimal digits of precision for
a 6x increase in performance. That's a
lgtm
https://codereview.chromium.org/420443006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Committed patchset #1 manually as r22638 (presubmit successful).
https://codereview.chromium.org/420443006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Revision: 22638
Author: hpa...@chromium.org
Date: Mon Jul 28 12:00:05 2014 UTC
Log: Use return value of GetPropertyAttributes to make compiler happy.
BUG=
R=verwa...@chromium.org
Review URL: https://codereview.chromium.org/420443006
http://code.google.com/p/v8/source/detail?r=22638
Committed patchset #1 manually as r22639.
https://codereview.chromium.org/422003002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this
Reviewers: Michael Achenbach,
Description:
[Auto-roll] Bump up version to 3.28.44.0
TBR=machenb...@chromium.org
Please review this at https://codereview.chromium.org/422003002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+1, -1 lines):
M src/version.cc
Revision: 22639
Author: machenb...@chromium.org
Date: Mon Jul 28 12:04:13 2014 UTC
Log: [Auto-roll] Bump up version to 3.28.44.0
TBR=machenb...@chromium.org
Review URL: https://codereview.chromium.org/422003002
http://code.google.com/p/v8/source/detail?r=22639
Modified:
Reviewers: jarin,
Description:
Fix bogus assert in HeapIterator.
BUG=397485
LOG=n
Please review this at https://codereview.chromium.org/416403011/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+6, -5 lines):
M src/heap.cc
M src/spaces.h
M src/spaces.cc
On 2014/07/28 11:29:00, Yang wrote:
https://codereview.chromium.org/411263004/diff/20001/src/math.js
File src/math.js (right):
https://codereview.chromium.org/411263004/diff/20001/src/math.js#newcode188
src/math.js:188: macro REMPIO2(X)
On 2014/07/24 18:08:44, Raymond Toy wrote:
Does this
FYI
https://codereview.chromium.org/421913006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from it,
Reviewers: Igor Sheludko,
Description:
Version 3.28.43.1 (merged r22638)
Use return value of GetPropertyAttributes to make compiler happy.
R=ish...@chromium.org
BUG=
Please review this at https://codereview.chromium.org/421913006/
SVN Base: https://v8.googlecode.com/svn/trunk
Affected files
lgtm
https://codereview.chromium.org/416403011/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Revision: 22640
Author: machenb...@chromium.org
Date: Mon Jul 28 12:25:10 2014 UTC
Log: Version 3.28.43.1 (merged r22638)
Use return value of GetPropertyAttributes to make compiler happy.
TBR=ish...@chromium.org
BUG=
Review URL: https://codereview.chromium.org/421913006
Committed patchset #1 manually as r22640 (tree was closed).
https://codereview.chromium.org/421913006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Revision: 22641
Author: machenb...@chromium.org
Date: Mon Jul 28 12:25:25 2014 UTC
Log: Tagging version 3.28.43.1
http://code.google.com/p/v8/source/detail?r=22641
Added:
/tags/3.28.43.1
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You
Revision: 22642
Author: hpa...@chromium.org
Date: Mon Jul 28 12:28:28 2014 UTC
Log: Fix bogus assert in HeapIterator.
BUG=397485
LOG=n
R=ja...@chromium.org
Review URL: https://codereview.chromium.org/416403011
http://code.google.com/p/v8/source/detail?r=22642
Modified:
Committed patchset #1 manually as r22642 (presubmit successful).
https://codereview.chromium.org/416403011/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Revision: 22643
Author: ern...@chromium.org
Date: Mon Jul 28 12:32:55 2014 UTC
Log: Trace every incremental marking step.
- This information is required in the chrome trace for a GC telemetry
benchmark.
R=hpa...@chromium.org, joc...@chromium.org
BUG=
Review URL:
Reviewers: Igor Sheludko,
Message:
PTAL
Description:
Clean up name distinction between Keyed ICs and Element Handlers
BUG=
Please review this at https://codereview.chromium.org/424743002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+287, -319 lines):
M
Committed patchset #2 manually as r22643 (presubmit successful).
https://codereview.chromium.org/420613006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Reviewers: Toon Verwaest,
Description:
Unbreak NaCL build
Please review this at https://codereview.chromium.org/422863004/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+6, -1 lines):
M src/objects.cc
Index: src/objects.cc
diff --git a/src/objects.cc
Reviewers: Hannes Payer,
Message:
PTAL
Description:
Regression test for chromium:30 added.
BUG=chromium:30
LOG=N
Please review this at https://codereview.chromium.org/424693006/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+58, -0 lines):
M
Reviewers: Hannes Payer,
Message:
PTAL
Description:
More accurate usages of Heap::AdjustLiveBytes().
Please review this at https://codereview.chromium.org/424663004/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+10, -8 lines):
M src/factory.cc
M
Reviewers: Hannes Payer,
Message:
PTAL
Description:
Track size of incremental marking steps in GCTracer.
- Track size of bytes marked incrementally
- Add method to compute marking speed in bytes/millisecond
- Distinguish between cumulative and differential marking stats.
- Fix methods that
Revision: 22644
Author: svenpa...@chromium.org
Date: Mon Jul 28 12:47:24 2014 UTC
Log: Unbreak NaCL build
TBR=verwa...@chromium.org
Review URL: https://codereview.chromium.org/422863004
http://code.google.com/p/v8/source/detail?r=22644
Modified:
Committed patchset #1 manually as r22644 (presubmit successful).
https://codereview.chromium.org/422863004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
LGTM.
https://codereview.chromium.org/422013002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
https://codereview.chromium.org/422013002/diff/1/src/heap.cc
File src/heap.cc (right):
https://codereview.chromium.org/422013002/diff/1/src/heap.cc#newcode4258
src/heap.cc:4258: if (!FLAG_incremental_marking) return true;
why not return false (meaning no need to call again?)
Revision: 22645
Author: da...@chromium.org
Date: Mon Jul 28 13:12:26 2014 UTC
Log: Keep new arrays allocated with 'new Array(N)' in fast mode
(revisited)
Also explicit length setting with a.length = N should remain in fast mode.
R=verwa...@chromium.org
Review URL:
Committed patchset #4 manually as r22645 (presubmit successful).
https://codereview.chromium.org/416403002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
lgtm
https://codereview.chromium.org/421553002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Committed patchset #1 manually as r22646 (presubmit successful).
https://codereview.chromium.org/421553002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Revision: 22646
Author: machenb...@chromium.org
Date: Mon Jul 28 13:49:07 2014 UTC
Log: Teach releases script to read bleeding_edge tags.
The command 'git svn log' does unfortunately not provide the tag-revision
relation. We therefore use 'svn log' to retrieve it from the remote
Reviewers: jochen, ernstm, mstarzinger, Michael Starzinger,
https://codereview.chromium.org/422013002/diff/1/src/heap.cc
File src/heap.cc (right):
https://codereview.chromium.org/422013002/diff/1/src/heap.cc#newcode4258
src/heap.cc:4258: if (!FLAG_incremental_marking) return true;
On
Reviewers: Igor Sheludko,
Message:
PTAL
Description:
Encapsulate type in the PropertyHandlerCompiler
BUG=
Please review this at https://codereview.chromium.org/426633002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+225, -243 lines):
M
lgtm with nit.
You can land the repro separately.
https://codereview.chromium.org/418023002/diff/1/src/arm/code-stubs-arm.cc
File src/arm/code-stubs-arm.cc (right):
https://codereview.chromium.org/418023002/diff/1/src/arm/code-stubs-arm.cc#newcode2972
src/arm/code-stubs-arm.cc:2972: __ ldr(r5,
Revision: 22647
Author: hpa...@chromium.org
Date: Mon Jul 28 14:18:40 2014 UTC
Log: Removed IdleGlobalGC and just perform IdleNotification when
incremental marking is on.
BUG=397026
LOG=n
R=mstarzin...@chromium.org
Review URL: https://codereview.chromium.org/422013002
Committed patchset #1 manually as r22647 (tree was closed).
https://codereview.chromium.org/422013002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
lgtm, one nit
https://codereview.chromium.org/424693006/diff/20001/test/cctest/test-heap.cc
File test/cctest/test-heap.cc (right):
https://codereview.chromium.org/424693006/diff/20001/test/cctest/test-heap.cc#newcode4460
test/cctest/test-heap.cc:4460:
Revision: 22648
Author: ish...@chromium.org
Date: Mon Jul 28 14:38:35 2014 UTC
Log: Skip long-running mjsunit/array-functions-prototype-misc.js test
TBR=da...@chromium.org
Review URL: https://codereview.chromium.org/428593002
http://code.google.com/p/v8/source/detail?r=22648
Reviewers: danno,
Message:
Committed patchset #1 manually as r22648 (tree was closed).
Description:
Skip long-running mjsunit/array-functions-prototype-misc.js test
TBR=da...@chromium.org
Committed: https://code.google.com/p/v8/source/detail?r=22648
Please review this at
lgtm
https://codereview.chromium.org/424663004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
https://codereview.chromium.org/420213002/diff/1/src/gc-tracer.cc
File src/gc-tracer.cc (right):
https://codereview.chromium.org/420213002/diff/1/src/gc-tracer.cc#newcode277
src/gc-tracer.cc:277: PrintF(stepscount=%d ,
current_.incremental_marking_steps);
On 2014/07/28 13:04:12, Hannes Payer
Committed patchset #2 manually as r22649 (presubmit successful).
https://codereview.chromium.org/420213002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Revision: 22649
Author: ern...@chromium.org
Date: Mon Jul 28 14:48:53 2014 UTC
Log: Track size of incremental marking steps in GCTracer.
- Track size of bytes marked incrementally
- Add method to compute marking speed in bytes/millisecond
- Distinguish between cumulative and
Reviewers: Hannes Payer,
Message:
Committed patchset #1 manually as r22650 (tree was closed).
Description:
Fix printf formatting.
TBR=hpa...@chromium.org
BUG=
Committed: https://code.google.com/p/v8/source/detail?r=22650
Please review this at https://codereview.chromium.org/420273002/
SVN
Revision: 22650
Author: ern...@chromium.org
Date: Mon Jul 28 15:01:57 2014 UTC
Log: Fix printf formatting.
TBR=hpa...@chromium.org
BUG=
Review URL: https://codereview.chromium.org/420273002
http://code.google.com/p/v8/source/detail?r=22650
Modified:
Revision: 22651
Author: machenb...@chromium.org
Date: Mon Jul 28 15:09:15 2014 UTC
Log: Tagging version 3.28.42
http://code.google.com/p/v8/source/detail?r=22651
Added:
/tags/3.28.42
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You
Addressed comments. Ported to other architectures. Adapted two more test
cases.
PTAL.
Rodolph, could you check if the change to the ARM64 is OK?
https://codereview.chromium.org/410153002/diff/1/src/factory.cc
File src/factory.cc (right):
Reviewers: Igor Sheludko,
Message:
PTAL
Description:
Encapsulate the holder in the PropertyHolderCompilers
BUG=
Please review this at https://codereview.chromium.org/422023003/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+173, -205 lines):
M
Reviewers: Jakob, Sven Panne,
Description:
Activate SSE2 for all Visual Studio builds
BUG=
Please review this at https://codereview.chromium.org/424763002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+12, -2 lines):
M src/d8.gyp
M test/cctest/cctest.gyp
Compiler settings belong in build/toolchain.gypi, in this case around line
458,
so that we only need to define them once.
https://codereview.chromium.org/424763002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because
Committed patchset #3 manually as r22652 (presubmit successful).
https://codereview.chromium.org/424693006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Revision: 22652
Author: ish...@chromium.org
Date: Mon Jul 28 15:33:24 2014 UTC
Log: Regression test for chromium:30 added.
BUG=chromium:30
LOG=N
R=hpa...@chromium.org
Review URL: https://codereview.chromium.org/424693006
http://code.google.com/p/v8/source/detail?r=22652
On 2014/07/11 07:24:36, Igor Sheludko wrote:
On 2014/07/11 07:10:07, jochen wrote:
is it possible to add a test for this?
I'll try to make a test.
Test added: https://codereview.chromium.org/424693006/
https://codereview.chromium.org/333903003/
--
--
v8-dev mailing list
1 - 100 of 129 matches
Mail list logo
