Committed patchset #3 (id:40001) manually as 24344 (presubmit successful).
https://codereview.chromium.org/613143004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" gr
Revision: 24344
Author: svenpa...@chromium.org
Date: Wed Oct 1 06:32:05 2014 UTC
Log: Changes to ALLOW_UNUSED to match upcoming changes to the Chromium
trunk:
* Eliminate usage of ALLOW_UNUSED to define COMPILE_ASSERT and just use
static_assert() in all cases now that all platform
LGTM. Regarding the other comments: We will not introduce some kind of grace
period for v8 and C++11, this would only complicate things because we'll
diverge
from Chrome for that time. This in turn would mean that we can't simply get
the
relevant Chrome changes for free. (Thanks Peter, it's g
Revision: 24343
Author: paul.l...@imgtec.com
Date: Wed Oct 1 04:14:01 2014 UTC
Log: MIPS: Add cvt_d_s to disassembler.
BUG=
R=dusan.milosavlje...@imgtec.com
Review URL: https://codereview.chromium.org/605113002
https://code.google.com/p/v8/source/detail?r=24343
Modified:
/branches/
Committed patchset #1 (id:1) manually as 24343 (presubmit successful).
https://codereview.chromium.org/605113002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
On 2014/09/30 19:47:15, Jakob wrote:
DBC: I'm not sure V8 is ready to drop pre-C++11 support, for the benefit
of
non-Chrome embedders. If we do decide to make this cut, we should
announce it
broadly (and ideally with some warning / grace period) on v8-users@.
Would you be willing to do that
Comment #8 on issue 180 by franklin...@gmail.com: toLocaleDateString and
toLocaleTimeString do not honor the current locale
https://code.google.com/p/v8/issues/detail?id=180
I don't think still localeCompare api work as intended in chrome.
My Language and input setting of chrom is Swedish-sv
Revision: 24342
Author: machenb...@chromium.org
Date: Wed Oct 1 00:08:18 2014 UTC
Log: Tagging version 3.30.1
https://code.google.com/p/v8/source/detail?r=24342
Added:
/tags/3.30.1
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You recei
DBC: I'm not sure V8 is ready to drop pre-C++11 support, for the benefit of
non-Chrome embedders. If we do decide to make this cut, we should announce
it
broadly (and ideally with some warning / grace period) on v8-users@. In the
meantime I'd suggest to keep STATIC_ASSERT as it is.
https://cod
Update to the latest code level. All comments addressed.
Anything else you guys need to approve this change set?
https://codereview.chromium.org/551803004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subs
Reviewers: Sven Panne, titzer,
Description:
Remove extraneous line from CompareWrapper test
On platforms without TurboFan (PowerPC) the CompareWrapper test was
failing. It appears the line
RawMachineAssemblerTester m;
was causing the issue, and does not appear to be required for the
test to op
Reviewers: jochen (slow for reviews),
Description:
Changes to ALLOW_UNUSED to match upcoming changes to the Chromium trunk:
* Eliminate usage of ALLOW_UNUSED to define COMPILE_ASSERT and just use
static_assert() in all cases now that all platforms build with C++11.
* Convert remaining uses of A
Comment #8 on issue 3443 by math...@qiwi.be:
Object.getOwnProperty[Symbols,Names] called on non-object
https://code.google.com/p/v8/issues/detail?id=3443
Caitlin's CL for `getOwnProperty{Names,Descriptors}`:
https://codereview.chromium.org/613283002/
--
You received this message because t
Comment #7 on issue 3443 by math...@qiwi.be:
Object.getOwnProperty[Symbols,Names] called on non-object
https://code.google.com/p/v8/issues/detail?id=3443
Caitlin's CL for `getOwnProperty{Names,Symbols}`:
https://codereview.chromium.org/613283002/
--
You received this message because this
Committed patchset #1 (id:1) manually as 24340 (presubmit successful).
https://codereview.chromium.org/615043002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
Comment #22 on issue 3330 by bugdro...@chromium.org: Implement ES6 classes
https://code.google.com/p/v8/issues/detail?id=3330#c22
The following revision refers to this bug:
https://chromium.googlesource.com/v8/v8.git/+/953af8bd9ffc79ce37e6fbda0dabc65f15dd7215
commit 953af8bd9ffc79ce37e6fbd
Revision: 24340
Author: dslo...@chromium.org
Date: Tue Sep 30 18:12:22 2014 UTC
Log: Desugar 'super(..)' into 'super.constructor(...)'
R=a...@chromium.org, ma...@chromium.org
BUG=v8:3330
LOG=N
Review URL: https://codereview.chromium.org/615043002
https://code.google.com/p/v8/source/de
https://codereview.chromium.org/610323004/diff/1/src/compiler/arm64/instruction-selector-arm64-unittest.cc
File src/compiler/arm64/instruction-selector-arm64-unittest.cc (right):
https://codereview.chromium.org/610323004/diff/1/src/compiler/arm64/instruction-selector-arm64-unittest.cc#newcode398
Could you please take a look? Thanks :)
https://codereview.chromium.org/553413002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this grou
Revision: 24339
Author: akos.pa...@imgtec.com
Date: Tue Sep 30 16:46:41 2014 UTC
Log: Tagging version 3.29.93.1
https://code.google.com/p/v8/source/detail?r=24339
Added:
/tags/3.29.93.1
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You r
Revision: 24338
Author: akos.pa...@imgtec.com
Date: Tue Sep 30 16:46:20 2014 UTC
Log: Version 3.29.93.1 (merged r24284)
MIPS: Stores and compound assignments for named super properties.
BUG=v8:3330
LOG=N
R=machenb...@chromium.org
Review URL: https://codereview.chromium.org/614093002
Committed patchset #1 (id:1) manually as 24338 (tree was closed).
https://codereview.chromium.org/614093002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To
LGTM, please add an OWNER
https://codereview.chromium.org/553413002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop rec
On 2014/09/30 16:41:12, wingo wrote:
One nit -- can you recheck that tests pass after fixing?
https://codereview.chromium.org/553413002/diff/80001/src/macros.py
File src/macros.py (right):
https://codereview.chromium.org/553413002/diff/80001/src/macros.py#newcode170
src/macros.py:170: macro
One nit -- can you recheck that tests pass after fixing?
https://codereview.chromium.org/553413002/diff/80001/src/macros.py
File src/macros.py (right):
https://codereview.chromium.org/553413002/diff/80001/src/macros.py#newcode170
src/macros.py:170: macro SHOULD_CREATE_WRAPPER(functionName, rece
Uploaded new patch. PTAL.
On 2014/09/30 16:01:36, wingo wrote:
Some comments.
https://codereview.chromium.org/553413002/diff/60001/src/harmony-array.js
File src/harmony-array.js (right):
https://codereview.chromium.org/553413002/diff/60001/src/harmony-array.js#newcode30
src/harmony-array.j
On 2014/09/30 15:56:49, akos.palfi.imgtec wrote:
PTAL.
lgtm
https://codereview.chromium.org/614093002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To uns
Reviewers: rossberg,
Description:
Refine expression typing, esp. by propagating range information.
R=rossb...@chromium.org
BUG=
Please review this at https://codereview.chromium.org/618803003/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+619, -164 lines):
Reviewers: titzer,
Description:
Add support for uint64 compares to TurboFan.
R=tit...@chromium.org
TEST=compiler-unittests/MachineOperatorTest
Please review this at https://codereview.chromium.org/615083002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+48, -
LGTM
It is unclear if we want to support free standing super( outside a syntactic
constructor but lets do this for now.
https://codereview.chromium.org/615043002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you a
Code-wise lgtm, but I haven't been following ES6 classes impl overall, so
somebody else should probably also review.
https://codereview.chromium.org/615043002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are s
LGTM
https://codereview.chromium.org/613283002/diff/1/test/mjsunit/es6/symbols.js
File test/mjsunit/es6/symbols.js (right):
https://codereview.chromium.org/613283002/diff/1/test/mjsunit/es6/symbols.js#newcode505
test/mjsunit/es6/symbols.js:505: // Object.getOwnPropertySymbols() does
not throw w
Some comments.
https://codereview.chromium.org/553413002/diff/60001/src/harmony-array.js
File src/harmony-array.js (right):
https://codereview.chromium.org/553413002/diff/60001/src/harmony-array.js#newcode30
src/harmony-array.js:30: thisArg = %GetDefaultthisArg(predicate) ||
thisArg;
Typo. Did
PTAL.
https://codereview.chromium.org/614093002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from i
Reviewers: Michael Achenbach,
Description:
Version 3.29.93.1 (merged r24284)
MIPS: Stores and compound assignments for named super properties.
BUG=v8:3330
LOG=N
R=machenb...@chromium.org
Please review this at https://codereview.chromium.org/614093002/
SVN Base: https://v8.googlecode.com/svn/t
lgtm! Nice cleanup
https://codereview.chromium.org/614083002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving
Revision: 24337
Author: yang...@chromium.org
Date: Tue Sep 30 15:40:08 2014 UTC
Log: Remove stray edits in r24335.
TBR=aand...@chromium.org
Review URL: https://codereview.chromium.org/615053002
https://code.google.com/p/v8/source/detail?r=24337
Modified:
/branches/bleeding_edge/src/
Committed patchset #1 (id:1) manually as 24337 (presubmit successful).
https://codereview.chromium.org/615053002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
Reviewers: aandrey,
Description:
Remove stray edits in r24335.
TBR=aand...@chromium.org
Please review this at https://codereview.chromium.org/615053002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+0, -4 lines):
M src/bootstrapper.cc
M src/contexts.h
I
LGTM
https://codereview.chromium.org/607503004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it
Revision: 24336
Author: dslo...@chromium.org
Date: Tue Sep 30 15:30:10 2014 UTC
Log: Fix style nits in test
R=a...@chromium.org
Review URL: https://codereview.chromium.org/613253002
https://code.google.com/p/v8/source/detail?r=24336
Modified:
/branches/bleeding_edge/test/mjsunit/har
Revision: 24335
Author: yang...@chromium.org
Date: Tue Sep 30 15:29:08 2014 UTC
Log: Introduce PromiseRejectCallback.
R=aand...@chromium.org, yu...@chromium.org, rossb...@chromium.org
API=v8::Isolate::SetPromiseRejectCallback, v8::Promise::HasHandler
LOG=Y
BUG=v8:3093
Review URL: http
Committed patchset #1 (id:1) manually as 24336 (presubmit successful).
https://codereview.chromium.org/613253002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
Comment #62 on issue 3093 by bugdro...@chromium.org: Debugging promises
https://code.google.com/p/v8/issues/detail?id=3093#c62
The following revision refers to this bug:
https://chromium.googlesource.com/v8/v8.git/+/e68e62c8917405e33155965303bb263fae68fcb0
commit e68e62c8917405e33155965303
Committed patchset #7 (id:110001) manually as 24335 (presubmit successful).
https://codereview.chromium.org/600723005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" g
Reviewers: Dmitry Lomov (chromium),
Description:
Use symbols instead of hidden properties for i18n markers.
Also refactor symbols in the root list.
R=dslo...@chromium.org
Please review this at https://codereview.chromium.org/614083002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding
LGTM
https://codereview.chromium.org/613253002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it
On 2014/09/30 13:52:17, arv wrote:
https://codereview.chromium.org/618643003/diff/1/test/mjsunit/harmony/super.js
File test/mjsunit/harmony/super.js (right):
https://codereview.chromium.org/618643003/diff/1/test/mjsunit/harmony/super.js#newcode126
test/mjsunit/harmony/super.js:126: x : "x fro
Reviewers: arv,
Message:
PTAL
Description:
Fix style nits in test
R=a...@chromium.org
Please review this at https://codereview.chromium.org/613253002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+6, -6 lines):
M test/mjsunit/harmony/super.js
Index: test
Updates:
Status: Fixed
Owner: a...@chromium.org
Comment #5 on issue 3490 by a...@chromium.org: New sampler API
https://code.google.com/p/v8/issues/detail?id=3490
(No comment was entered for this change.)
--
You received this message because this project is configured to send all
Reviewers: arv, marja,
Message:
PTAL
Description:
Desugar 'super(..)' into 'super.constructor(...)'
R=a...@chromium.org,ma...@chromium.org
BUG=v8:3330
LOG=N
Please review this at https://codereview.chromium.org/615043002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affecte
Committed patchset #7 (id:120001) manually as 24334 (presubmit successful).
https://codereview.chromium.org/607503004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" g
Revision: 24334
Author: yang...@chromium.org
Date: Tue Sep 30 15:07:21 2014 UTC
Log: Add a fast case for one-element arrays in ArrayJoin
This case handles all one-element arrays that were not handled by
_FastOneByteArrayJoin
BUG=
R=yang...@chromium.org
Review URL: https://coderevi
On 2014/09/30 14:49:53, fmeawad-cr wrote:
> I was able to observe the 30% improvement, but not the 10x improvement
you
wrote
> about later. Is there something I'm missing?
Have you switched the "new Array(...).join('')" to "[...].join('')"
PTAL.
https://codereview.chromium.org/607503
still lgtm
https://codereview.chromium.org/600723005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails f
Comment #3 on issue 3603 by havard.e...@gmail.com: 4 tests in
test/mjsunit/math-pow.js need updating to C99-spec'ed results
https://code.google.com/p/v8/issues/detail?id=3603
For lack of quickly finding a better place, I came up with this (untested):
--- src/math.js.orig2014-08-21 07:04:
PTAL.
https://codereview.chromium.org/607503004/diff/80001/src/array.js
File src/array.js (right):
https://codereview.chromium.org/607503004/diff/80001/src/array.js#newcode386
src/array.js:386: if (IS_NUMBER(e)) return %_NumberToString(e);
On 2014/09/30 14:49:52, fmeawad-cr wrote:
On 2014/09/3
On 2014/09/30 14:55:15, aandrey wrote:
https://codereview.chromium.org/600723005/diff/90001/src/debug.cc
File src/debug.cc (right):
https://codereview.chromium.org/600723005/diff/90001/src/debug.cc#newcode2503
src/debug.cc:2503: Handle promise =
isolate_->GetPromiseOnStackOnThrow();
revert
T
Revision: 24333
Author: ish...@chromium.org
Date: Tue Sep 30 14:54:14 2014 UTC
Log: Hydrogenize (and share) part of StoreTransition handler as a
StoreTransitionStub and StoreField handler simplification.
R=yang...@chromium.org
Review URL: https://codereview.chromium.org/609463003
h
https://codereview.chromium.org/609463003/diff/20001/src/code-stubs.h
File src/code-stubs.h (right):
https://codereview.chromium.org/609463003/diff/20001/src/code-stubs.h#newcode86
src/code-stubs.h:86: V(StoreTransition)\
On 2014/09/30 11:56:53, Yang wrote:
alpha-sort.
https://codereview.chromium.org/600723005/diff/90001/src/debug.cc
File src/debug.cc (right):
https://codereview.chromium.org/600723005/diff/90001/src/debug.cc#newcode2503
src/debug.cc:2503: Handle promise =
isolate_->GetPromiseOnStackOnThrow();
revert
https://codereview.chromium.org/600723005/
Committed patchset #4 (id:80001) manually as 24333 (presubmit successful).
https://codereview.chromium.org/609463003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" gr
Reviewers: Michael Starzinger, titzer, Benedikt Meurer,
Message:
On 2014/09/26 10:43:41, titzer wrote:
On 2014/08/29 07:23:42, rossberg wrote:
>
https://codereview.chromium.org/509343002/diff/1/src/compiler/generic-node-inl.h
> File src/compiler/generic-node-inl.h (right):
>
>
https://coder
On 2014/09/30 14:43:27, aandrey wrote:
https://codereview.chromium.org/600723005/diff/40002/src/debug.cc
File src/debug.cc (right):
https://codereview.chromium.org/600723005/diff/40002/src/debug.cc#newcode2523
src/debug.cc:2523: OnException(value, false, promise);
But we should also call
JSO
I was able to observe the 30% improvement, but not the 10x improvement
you
wrote
about later. Is there something I'm missing?
Have you switched the "new Array(...).join('')" to "[...].join('')"
PTAL.
https://codereview.chromium.org/607503004/diff/80001/src/array.js
File src/array.js (rig
https://codereview.chromium.org/600723005/diff/40002/src/debug.cc
File src/debug.cc (right):
https://codereview.chromium.org/600723005/diff/40002/src/debug.cc#newcode2523
src/debug.cc:2523: OnException(value, false, promise);
But we should also call
JSObject::SetProperty(Handle::cast(promise) he
Status: New
Owner:
New issue 3604 by havard.e...@gmail.com: Tests calling sem_destroy() on
semaphore with waiters
https://code.google.com/p/v8/issues/detail?id=3604
I've on and off been toying with v8 and porting it to NetBSD.
Most of the self-tests succeed, but a few fail for various
re
Committed patchset #1 (id:1) manually as 24332 (presubmit successful).
https://codereview.chromium.org/615013002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
Revision: 24332
Author: balazs.kilv...@imgtec.com
Date: Tue Sep 30 14:37:59 2014 UTC
Log: MIPS: Replace OStream with std::ostream.
Port r24319 (b4a085f)
BUG=
R=akos.pa...@imgtec.com
Review URL: https://codereview.chromium.org/615013002
https://code.google.com/p/v8/source/detail?r=243
lgtm
https://codereview.chromium.org/615013002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it
Comment #2 on issue 3603 by havard.e...@gmail.com: 4 tests in
test/mjsunit/math-pow.js need updating to C99-spec'ed results
https://code.google.com/p/v8/issues/detail?id=3603
Hmm, so this means that the ECMA spec was written with the old IEEE standard
in mind, and that on C99 systems one need
Addressed/replied to comments.
https://codereview.chromium.org/600723005/diff/40001/src/debug.cc
File src/debug.cc (right):
https://codereview.chromium.org/600723005/diff/40001/src/debug.cc#newcode2516
src/debug.cc:2516: OnException(value, false, promise);
On 2014/09/30 14:08:24, aandrey wrote:
Reviewers: danno, Benedikt Meurer, paul.l..., gergely.kis.imgtec,
akos.palfi.imgtec, dusmil.imgtec,
Description:
MIPS: Replace OStream with std::ostream.
Port r24319 (b4a085f)
BUG=
Please review this at https://codereview.chromium.org/615013002/
SVN Base: https://v8.googlecode.com/svn/branc
lgtm
https://codereview.chromium.org/612423002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/600723005/diff/40001/src/debug.cc
File src/debug.cc (right):
https://codereview.chromium.org/600723005/diff/40001/src/debug.cc#newcode2516
src/debug.cc:2516: OnException(value, false, promise);
I think we should move to here:
JSObject::SetProperty(jsprom
LGTM
https://codereview.chromium.org/618643003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it
https://codereview.chromium.org/618643003/diff/1/test/mjsunit/harmony/super.js
File test/mjsunit/harmony/super.js (right):
https://codereview.chromium.org/618643003/diff/1/test/mjsunit/harmony/super.js#newcode126
test/mjsunit/harmony/super.js:126: x : "x from Base"
stick to '
https://codereview
Reviewers: jarin,
Message:
PTAL.
Description:
Fix Hydrogen's BuildStore()
BUG=chromium:417508
Please review this at https://codereview.chromium.org/612423002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+42, -11 lines):
M src/hydrogen.cc
A test/mjsunit/
Status: New
Owner:
New issue 3603 by havard.e...@gmail.com: 4 tests in
test/mjsunit/math-pow.js need updating to C99-spec'ed results
https://code.google.com/p/v8/issues/detail?id=3603
According to sources elsewhere, the expected result for these 4 tests
should be updated:
assertEquals
Updates:
Status: Invalid
Comment #1 on issue 3603 by svenpa...@chromium.org: 4 tests in
test/mjsunit/math-pow.js need updating to C99-spec'ed results
https://code.google.com/p/v8/issues/detail?id=3603
The ECMA spec is quite explicit about those cases (see "15.8.2.13 pow (x,
y)"):
On 2014/09/26 12:46:12, mvstanton wrote:
Hi Yang here is the string handler cl.
* Some assembly code just had to move into a stub
* The StringCharAtGenerator needed another option (it can eliminate
instance
type check in the handler)
* Some deft changes in the MISS handler
* Had to adjust h
Revision: 24331
Author: dslo...@chromium.org
Date: Tue Sep 30 13:19:47 2014 UTC
Log: Implement data property creation for assignments to super.x.
R=rossb...@chromium.org, a...@chromium.org
BUG=v8:3330
LOG=N
Review URL: https://codereview.chromium.org/618643003
https://code.google.com/
lgtm
https://codereview.chromium.org/600723005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
PTAL at patch 6. This reuses the remote branch info that we know from
earlier in
the script. So, no need to add logic for retrieving this. The svn tag
workflow
also needed this.
https://codereview.chromium.org/607893004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.
Updates:
Status: Accepted
Comment #6 on issue 3443 by math...@qiwi.be:
Object.getOwnProperty[Symbols,Names] called on non-object
https://code.google.com/p/v8/issues/detail?id=3443
(No comment was entered for this change.)
--
You received this message because this project is configure
Comment #5 on issue 3443 by caitpott...@gmail.com:
Object.getOwnProperty[Symbols,Names] called on non-object
https://code.google.com/p/v8/issues/detail?id=3443
So, that CL only fixed Object.keys(), getOwnPropertyNames/Symbols would
still be broken
--
You received this message because this
Committed patchset #1 (id:1) manually as 24331 (presubmit successful).
https://codereview.chromium.org/618643003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
Comment #21 on issue 3330 by bugdro...@chromium.org: Implement ES6 classes
https://code.google.com/p/v8/issues/detail?id=3330#c21
The following revision refers to this bug:
https://chromium.googlesource.com/v8/v8.git/+/b43ebcd800dc8ba53308eafcbc2fe6d26aa653f1
commit b43ebcd800dc8ba53308eaf
Committed patchset #4 (id:60001) manually as 24330 (presubmit successful).
https://codereview.chromium.org/618703002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" gr
Revision: 24330
Author: machenb...@chromium.org
Date: Tue Sep 30 13:12:44 2014 UTC
Log: Fix svn tags in release scripts.
Rebase the local branch after committing so that git svn
tag works.
Some of these changes need to be ported to git in
https://codereview.chromium.org/607893004/
On 2014/09/30 12:41:47, yurys wrote:
https://codereview.chromium.org/600723005/diff/20001/include/v8.h
File include/v8.h (right):
https://codereview.chromium.org/600723005/diff/20001/include/v8.h#newcode2859
include/v8.h:2859: bool HasRejectHandler();
Would it make sense to rename this method
lgtm
https://codereview.chromium.org/618643003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/618703002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
Reviewers: Michael Starzinger,
Message:
PTAL
Description:
[turbofan] Add BoundsCheckMode to ElementAccess.
This is currently only used for StoreElement. LoadElement will be
updated to make use of that in a follow-up CL (depends on additional
control input for loads first).
TEST=cctest,mjsunit
Reviewers: tandrii, Jakob,
Message:
PTAL
Description:
Fix svn tags in release scripts.
Rebase the local branch after committing so that git svn
tag works.
Some of these changes need to be ported to git in
https://codereview.chromium.org/607893004/
BUG=chromium:410721,v8:3601
LOG=n
TEST=script
Revision: 24329
Author: bmeu...@chromium.org
Date: Tue Sep 30 12:49:25 2014 UTC
Log: More follow-up fixes to r24322.
TBR=svenpa...@chromium.org
Review URL: https://codereview.chromium.org/616853002
https://code.google.com/p/v8/source/detail?r=24329
Modified:
/branches/bleeding_edge/
Reviewers: Sven Panne,
Message:
Committed patchset #1 (id:1) manually as 24329.
Description:
More follow-up fixes to r24322.
TBR=svenpa...@chromium.org
Committed: https://code.google.com/p/v8/source/detail?r=24329
Please review this at https://codereview.chromium.org/616853002/
SVN Base: htt
(see the bug for more information)
https://codereview.chromium.org/619633002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and
Reviewers: jochen (slow for reviews),
Message:
jochen, ptal.
Description:
Defensive programming for Parser::ParseOnBackground.
Apparently it sometimes happens that log_ is NULL in
Parser::SkipLazyFunctionBody in the branch which uses it. It should be
impossible: ParseOnBackground sets log_ corr
https://codereview.chromium.org/600723005/diff/20001/include/v8.h
File include/v8.h (right):
https://codereview.chromium.org/600723005/diff/20001/include/v8.h#newcode2859
include/v8.h:2859: bool HasRejectHandler();
Would it make sense to rename this method to HasDerivedPromise or
HasHandler to b
1 - 100 of 196 matches
Mail list logo
