[v8-dev] [turbofan] Minor cleanups to lowering of typed array loads/stores. (issue 680063004 by bmeu...@chromium.org)

Reviewers: dcarney, Message: PTAL Description: [turbofan] Minor cleanups to lowering of typed array loads/stores. TEST=unittests Please review this at https://codereview.chromium.org/680063004/ Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge Affected files (+21, -61 lines):

[v8-dev] Re: [turbofan] Minor cleanups to lowering of typed array loads/stores. (issue 680063004 by bmeu...@chromium.org)

lgtm https://codereview.chromium.org/680063004/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails from

Re: [v8-dev] RE: Revert Limit the number of transitions allowed per hidden class. Due to crashes in ClearMapTransi... (issue 661583004 by verwa...@chromium.org)

Hi Kevin, I added you as a reviewer to the reland CL: https://codereview.chromium.org/676393002/ Regards, Igor Sheludko On Tue, Oct 28, 2014 at 2:03 AM, 'McCormick, Kevin' via v8-dev v8-dev@googlegroups.com wrote: ishell, verwaest: Thanks for catching and reverting this one. If possible,

[v8-dev] Re: [turbofan] Minor cleanups to lowering of typed array loads/stores. (issue 680063004 by bmeu...@chromium.org)

Committed patchset #2 (id:20001) manually as 24917 (presubmit successful). https://codereview.chromium.org/680063004/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev

[v8-dev] [v8] r24917 committed - [turbofan] Minor cleanups to lowering of typed array loads/stores....

Revision: 24917 Author: bmeu...@chromium.org Date: Tue Oct 28 08:28:36 2014 UTC Log: [turbofan] Minor cleanups to lowering of typed array loads/stores. TEST=unittests R=dcar...@chromium.org Review URL: https://codereview.chromium.org/680063004

[v8-dev] [turbofan] Turn slow case for stack check into deferred code. (issue 687473002 by bmeu...@chromium.org)

Reviewers: dcarney, Message: PTAL Description: [turbofan] Turn slow case for stack check into deferred code. Please review this at https://codereview.chromium.org/687473002/ Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge Affected files (+6, -7 lines): M

[v8-dev] Re: [turbofan] Turn slow case for stack check into deferred code. (issue 687473002 by bmeu...@chromium.org)

lgtm https://codereview.chromium.org/687473002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails from

[v8-dev] [turbofan] Improve typed lowering for JSToBoolean. (issue 681223002 by bmeu...@chromium.org)

Reviewers: dcarney, Message: PTAL Description: [turbofan] Improve typed lowering for JSToBoolean. - JSToBoolean(x:string) = BooleanNot(NumberEqual(x.length, #0)) - JSToBoolean(phi(x1,...,xn):primitive) = phi(JSToBoolean(x1),...,JSToBoolean(xn))

[v8-dev] Re: Allow duplicate property names in classes (issue 677953004 by a...@chromium.org)

lgtm % https://codereview.chromium.org/677953004/diff/1/src/preparser.h File src/preparser.h (right): https://codereview.chromium.org/677953004/diff/1/src/preparser.h#newcode1973 src/preparser.h:1973: if (*has_seen_constructor) { It's not trivial to see that has_seen_constructor cannot be NULL

[v8-dev] Move AST node counting to post-pass (issue 683023002 by wi...@igalia.com)

Reviewers: *Michael Starzinger, Sven Panne, Message: PTAL; this is the patch from yesterday with a couple of modifications mentioned in the comments below. https://codereview.chromium.org/683023002/diff/20001/src/compiler.cc File src/compiler.cc (right):

[v8-dev] Re: [turbofan] Improve typed lowering for JSToBoolean. (issue 681223002 by bmeu...@chromium.org)

lgtm https://codereview.chromium.org/681223002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Fix ASAN warning. (issue 683033002 by mvstan...@chromium.org)

Reviewers: Igor Sheludko, Message: Darn buffer.dispose()... Description: Fix ASAN warning. BUG= TBR=ish...@chromium.org Please review this at https://codereview.chromium.org/683033002/ Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge Affected files (+1, -0 lines): M

[v8-dev] [v8] r24918 committed - [turbofan] Turn slow case for stack check into deferred code....

Revision: 24918 Author: bmeu...@chromium.org Date: Tue Oct 28 08:33:03 2014 UTC Log: [turbofan] Turn slow case for stack check into deferred code. R=dcar...@chromium.org Review URL: https://codereview.chromium.org/687473002 https://code.google.com/p/v8/source/detail?r=24918

[v8-dev] Re: [turbofan] Turn slow case for stack check into deferred code. (issue 687473002 by bmeu...@chromium.org)

Committed patchset #1 (id:1) manually as 24918 (presubmit successful). https://codereview.chromium.org/687473002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group.

[v8-dev] Re: [turbofan] Improve typed lowering for JSToBoolean. (issue 681223002 by bmeu...@chromium.org)

Committed patchset #1 (id:1) manually as 24919 (presubmit successful). https://codereview.chromium.org/681223002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group.

[v8-dev] Re: Fix ASAN warning. (issue 683033002 by mvstan...@chromium.org)

Committed patchset #1 (id:1) manually as 24920 (presubmit successful). https://codereview.chromium.org/683033002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group.

[v8-dev] [v8] r24919 committed - [turbofan] Improve typed lowering for JSToBoolean....

Revision: 24919 Author: bmeu...@chromium.org Date: Tue Oct 28 08:33:52 2014 UTC Log: [turbofan] Improve typed lowering for JSToBoolean. - JSToBoolean(x:string) = BooleanNot(NumberEqual(x.length, #0)) - JSToBoolean(phi(x1,...,xn):primitive) = phi(JSToBoolean(x1),...,JSToBoolean(xn))

[v8-dev] [v8] r24920 committed - Fix ASAN warning....

Revision: 24920 Author: mvstan...@chromium.org Date: Tue Oct 28 08:34:11 2014 UTC Log: Fix ASAN warning. BUG= TBR=ish...@chromium.org Review URL: https://codereview.chromium.org/683033002 https://code.google.com/p/v8/source/detail?r=24920 Modified:

[v8-dev] Re: ES6: Array.prototype.slice and friends should use ToLength instead of ToUint32 (issue 553623004 by dp...@igalia.com)

I think at this point LGTM, you need higher review powers :) Adding adamk to Cc as he has been working in this area recently. https://codereview.chromium.org/553623004/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message

[v8-dev] Re: move functions in v8::V8 that should be on v8::Isolate (issue 652193006 by dcar...@chromium.org)

rubberstamp lgtm https://codereview.chromium.org/652193006/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving

[v8-dev] [v8] r24921 committed - move functions in v8::V8 that should be on v8::Isolate...

Revision: 24921 Author: dcar...@chromium.org Date: Tue Oct 28 08:43:15 2014 UTC Log: move functions in v8::V8 that should be on v8::Isolate R=ma...@chromium.org, svenpa...@chromium.org BUG= Review URL: https://codereview.chromium.org/652193006

[v8-dev] Re: move functions in v8::V8 that should be on v8::Isolate (issue 652193006 by dcar...@chromium.org)

Committed patchset #3 (id:40001) manually as 24921 (presubmit successful). https://codereview.chromium.org/652193006/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev

[v8-dev] Re: Windows: use SystemTimeToTzSpecificLocalTime instead of localtime_s. (issue 654843012 by u...@chromium.org)

Redirecting to Yang. https://codereview.chromium.org/654843012/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving

[v8-dev] Re: Windows: use SystemTimeToTzSpecificLocalTime instead of localtime_s. (issue 654843012 by u...@chromium.org)

LGTM. Let's watch out for performance numbers. https://codereview.chromium.org/654843012/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from

[v8-dev] [v8] r24922 committed - Windows: use SystemTimeToTzSpecificLocalTime instead of localtime_s....

Revision: 24922 Author: u...@chromium.org Date: Tue Oct 28 08:55:28 2014 UTC Log: Windows: use SystemTimeToTzSpecificLocalTime instead of localtime_s. The localtime_s function produces incorrect results for russian time zone. BUG=chromium:417640 LOG=Y R=yang...@chromium.org

[v8-dev] Re: Disable OOL constant pool for Arm. (issue 663333005 by rmcil...@chromium.org)

lgtm https://codereview.chromium.org/66005/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails from it,

[v8-dev] Re: Windows: use SystemTimeToTzSpecificLocalTime instead of localtime_s. (issue 654843012 by u...@chromium.org)

Committed patchset #1 (id:1) manually as 24922 (presubmit successful). https://codereview.chromium.org/654843012/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group.

[v8-dev] Prevent recursion in the debug event listener. (issue 684573005 by yang...@chromium.org)

Reviewers: ulan, Description: Prevent recursion in the debug event listener. R=u...@chromium.org BUG=chromium:409614 LOG=N Please review this at https://codereview.chromium.org/684573005/ Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge Affected files (+38, -0 lines): M

[v8-dev] Re: Prevent recursion in the debug event listener. (issue 684573005 by yang...@chromium.org)

lgtm https://codereview.chromium.org/684573005/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: Fix for the cctest compilation issue on Mac after r24911. (issue 667153005 by ish...@chromium.org)

thank you! LGTM. https://codereview.chromium.org/667153005/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving

[v8-dev] Re: ES6: Array.prototype.slice and friends should use ToLength instead of ToUint32 (issue 553623004 by dp...@igalia.com)

Sorry to pass the buck, but I don't have OWNERS authority myself. +rossberg, you reviewed and landed ToLength(). https://codereview.chromium.org/553623004/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are

[v8-dev] Re: Issue 3652 in v8: Sourcemap'd stacktraces

Updates: Cc: vse...@chromium.org serg...@chromium.org Comment #1 on issue 3652 by aand...@chromium.org: Sourcemap'd stacktraces https://code.google.com/p/v8/issues/detail?id=3652 (No comment was entered for this change.) -- You received this message because this project is configured

[v8-dev] Issue 3655 in v8: Classes: Make sure a getter for prototype works as expected

Status: Assigned Owner: a...@chromium.org CC: dslo...@chromium.org Labels: Type-Bug Priority-Medium Harmony New issue 3655 by a...@chromium.org: Classes: Make sure a getter for prototype works as expected https://code.google.com/p/v8/issues/detail?id=3655 function f() {} var B = f.bind();

[v8-dev] Re: Allow duplicate property names in classes (issue 677953004 by a...@chromium.org)

Thanks https://codereview.chromium.org/677953004/diff/1/src/preparser.h File src/preparser.h (right): https://codereview.chromium.org/677953004/diff/1/src/preparser.h#newcode1973 src/preparser.h:1973: if (*has_seen_constructor) { On 2014/10/28 08:30:22, marja wrote: It's not trivial to see

[v8-dev] Re: Switch schedule early phase to use forward propagation. (issue 655833005 by mstarzin...@chromium.org)

https://codereview.chromium.org/655833005/diff/1/src/compiler/scheduler.cc File src/compiler/scheduler.cc (right): https://codereview.chromium.org/655833005/diff/1/src/compiler/scheduler.cc#newcode960 src/compiler/scheduler.cc:960: // Run the schedule late algorithm on a set of fixed root

[v8-dev] Re: Switch schedule early phase to use forward propagation. (issue 655833005 by mstarzin...@chromium.org)

Committed patchset #2 (id:20001) manually as 24923 (presubmit successful). https://codereview.chromium.org/655833005/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev

[v8-dev] [v8] r24923 committed - Switch schedule early phase to use forward propagation....

Revision: 24923 Author: mstarzin...@chromium.org Date: Tue Oct 28 09:34:35 2014 UTC Log: Switch schedule early phase to use forward propagation. R=ja...@chromium.org Review URL: https://codereview.chromium.org/655833005 https://code.google.com/p/v8/source/detail?r=24923 Modified:

[v8-dev] Re: Use shared function info for eval cache key. (issue 678843004 by yang...@chromium.org)

lgtm, thanks for fixing this. https://codereview.chromium.org/678843004/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop

[v8-dev] Re: Use shared function info for eval cache key. (issue 678843004 by yang...@chromium.org)

lgtm, thanks for fixing this. https://codereview.chromium.org/678843004/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop

[v8-dev] Re: Classes: Add basic support for properties (issue 680993003 by a...@chromium.org)

PTAL https://codereview.chromium.org/680993003/diff/1/src/arm/full-codegen-arm.cc File src/arm/full-codegen-arm.cc (right): https://codereview.chromium.org/680993003/diff/1/src/arm/full-codegen-arm.cc#newcode2516 src/arm/full-codegen-arm.cc:2516: __ push(scratch); On 2014/10/27 21:37:13,

[v8-dev] [v8] r24924 committed - Prevent recursion in the debug event listener....

Revision: 24924 Author: yang...@chromium.org Date: Tue Oct 28 09:44:16 2014 UTC Log: Prevent recursion in the debug event listener. R=u...@chromium.org BUG=chromium:409614 LOG=N Review URL: https://codereview.chromium.org/684573005 https://code.google.com/p/v8/source/detail?r=24924

[v8-dev] Re: Prevent recursion in the debug event listener. (issue 684573005 by yang...@chromium.org)

Committed patchset #1 (id:1) manually as 24924 (presubmit successful). https://codereview.chromium.org/684573005/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group.

[v8-dev] Make floating merges respected minimum RPO of coupled pihs. (issue 682983003 by mstarzin...@chromium.org)

Reviewers: *jarin, Benedikt Meurer, Message: Jaro: PTAL / Benedikt: FYI Description: Make floating merges respected minimum RPO of coupled pihs. R=ja...@chromium.org TEST=cctest/test-scheduler/LoopedFloatingDiamond Please review this at https://codereview.chromium.org/682983003/ Base URL:

[v8-dev] [v8] r24925 committed - Version 3.30.20 (based on bleeding_edge revision r24916)...

Revision: 24925 Author: machenb...@chromium.org Date: Tue Oct 28 09:48:49 2014 UTC Log: Version 3.30.20 (based on bleeding_edge revision r24916) Performance and stability improvements on all platforms. https://code.google.com/p/v8/source/detail?r=24925 Modified: /trunk/ChangeLog

[v8-dev] [turbofan] Work-around stack overflow in zlib. (issue 678323002 by bmeu...@chromium.org)

Reviewers: dcarney, Description: [turbofan] Work-around stack overflow in zlib. TBR=dcar...@chromium.org Please review this at https://codereview.chromium.org/678323002/ Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge Affected files (+13, -3 lines): M

[v8-dev] [v8] r24926 committed - [turbofan] Work-around stack overflow in zlib....

Revision: 24926 Author: bmeu...@chromium.org Date: Tue Oct 28 09:54:00 2014 UTC Log: [turbofan] Work-around stack overflow in zlib. TBR=dcar...@chromium.org Review URL: https://codereview.chromium.org/678323002 https://code.google.com/p/v8/source/detail?r=24926 Modified:

[v8-dev] Re: [turbofan] Work-around stack overflow in zlib. (issue 678323002 by bmeu...@chromium.org)

Committed patchset #1 (id:1) manually as 24926 (presubmit successful). https://codereview.chromium.org/678323002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group.

[v8-dev] Re: [turbofan] Add deopt for %StringMatch (issue 639763004 by ja...@chromium.org)

LGTM. https://codereview.chromium.org/639763004/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: Use shared function info for eval cache key. (issue 678843004 by yang...@chromium.org)

Committed patchset #1 (id:1) manually as 24927 (presubmit successful). https://codereview.chromium.org/678843004/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group.

[v8-dev] [v8] r24927 committed - Use shared function info for eval cache key....

Revision: 24927 Author: yang...@chromium.org Date: Tue Oct 28 10:00:37 2014 UTC Log: Use shared function info for eval cache key. R=verwa...@chromium.org Review URL: https://codereview.chromium.org/678843004 https://code.google.com/p/v8/source/detail?r=24927 Added:

[v8-dev] [v8] r24928 committed - Edited wiki page Testing through web user interface.

Revision: 24928 Author: ma...@chromium.org Date: Tue Oct 28 10:11:13 2014 UTC Log: Edited wiki page Testing through web user interface. https://code.google.com/p/v8/source/detail?r=24928 Modified: /wiki/Testing.wiki === --- /wiki/Testing.wiki Thu

[v8-dev] [v8] r24929 committed - Edited wiki page Testing through web user interface.

Revision: 24929 Author: ma...@chromium.org Date: Tue Oct 28 10:12:05 2014 UTC Log: Edited wiki page Testing through web user interface. https://code.google.com/p/v8/source/detail?r=24929 Modified: /wiki/Testing.wiki === --- /wiki/Testing.wiki Tue

[v8-dev] Improve branch creation in release scripts. (issue 680173003 by machenb...@chromium.org)

Reviewers: tandrii, Message: PTAL Description: Improve branch creation in release scripts. Use 'git new-branch' for creating new branches. BUG=410721 Please review this at https://codereview.chromium.org/680173003/ Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge Affected

[v8-dev] Re: Classes: Add basic support for properties (issue 680993003 by a...@chromium.org)

lgtm https://codereview.chromium.org/680993003/diff/1/src/arm/full-codegen-arm.cc File src/arm/full-codegen-arm.cc (right): https://codereview.chromium.org/680993003/diff/1/src/arm/full-codegen-arm.cc#newcode2516 src/arm/full-codegen-arm.cc:2516: __ push(scratch); On 2014/10/28 09:42:00, arv

[v8-dev] Re: Improve branch creation in release scripts. (issue 680173003 by machenb...@chromium.org)

lgtm https://codereview.chromium.org/680173003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: Make floating merges respected minimum RPO of coupled pihs. (issue 682983003 by mstarzin...@chromium.org)

lgtm https://codereview.chromium.org/682983003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: Inlining builtin functions when inlining cumulative nodes size exceeds (issue 561103002 by sw0524....@samsung.com)

Dear, I didn't know that this issue was closed. Is there anything that I have to do about these patch or any reason to be closed? I am just wondering the consistence of builtin function inlining. The previous comment in InliningAstSize is that Always inline buitins marked for

[v8-dev] Re: Introduce FeedbackNexus for vector-based ics. (issue 680883004 by mvstan...@chromium.org)

lgtm with nits: https://codereview.chromium.org/680883004/diff/40001/src/ic/ic.cc File src/ic/ic.cc (right): https://codereview.chromium.org/680883004/diff/40001/src/ic/ic.cc#newcode545 src/ic/ic.cc:545: reinterpret_castCallICNexus*(nexus)); static_cast?

[v8-dev] Re: Move AST node counting to post-pass (issue 683023002 by wi...@igalia.com)

LGTM (mostly rubber-stamped, only reviewed the marked changes). https://codereview.chromium.org/683023002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To

[v8-dev] Re: Revert [turbofan] Merge GenericNode with Node. (issue 684693002 by ja...@chromium.org)

LGTM (rubber-stamped). https://codereview.chromium.org/684693002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop

[v8-dev] Add ARMv8 detection. (issue 678313002 by sigu...@chromium.org)

Reviewers: ulan, Rodolph Perfetta (ARM), Message: PTAL. This is the first approach to detecting ARMv8. I don't have hardware here to validate that it actually works. Description: Add ARMv8 detection. R=u...@chromium.org Please review this at https://codereview.chromium.org/678313002/ Base

[v8-dev] Re: Add ARMv8 detection. (issue 678313002 by sigu...@chromium.org)

On 2014/10/28 11:24:52, sigurds wrote: PTAL. This is the first approach to detecting ARMv8. I don't have hardware here to validate that it actually works. I have hardware, will validate. https://codereview.chromium.org/678313002/ -- -- v8-dev mailing list v8-dev@googlegroups.com

[v8-dev] [v8] r24930 committed - Make floating merges respected minimum RPO of coupled phis....

Revision: 24930 Author: mstarzin...@chromium.org Date: Tue Oct 28 11:38:22 2014 UTC Log: Make floating merges respected minimum RPO of coupled phis. R=bmeu...@chromium.org, ja...@chromium.org TEST=cctest/test-scheduler/LoopedFloatingDiamond Review URL:

[v8-dev] Re: Make floating merges respected minimum RPO of coupled pihs. (issue 682983003 by mstarzin...@chromium.org)

Committed patchset #1 (id:1) manually as 24930 (presubmit successful). https://codereview.chromium.org/682983003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group.

[v8-dev] Re: Issue 1972 in v8: Incorrect treatment of unicode escapes in keywords

Comment #10 on issue 1972 by ma...@chromium.org: Incorrect treatment of unicode escapes in keywords https://code.google.com/p/v8/issues/detail?id=1972 ATM the spec draft also says: The ReservedWord definitions are specified as literal sequences of specific SourceCharacter elements. A code

[v8-dev] Removed non-existent files from gyp and GN builds. (issue 682793005 by mvstan...@chromium.org)

Reviewers: Yang, Message: Hi Yang, just a tiny thing I noticed building on windows. PTAL, thx, --Michael Description: Removed non-existent files from gyp and GN builds. Please review this at https://codereview.chromium.org/682793005/ Base URL:

[v8-dev] Re: Issue 1972 in v8: Incorrect treatment of unicode escapes in keywords

Comment #11 on issue 1972 by ma...@chromium.org: Incorrect treatment of unicode escapes in keywords https://code.google.com/p/v8/issues/detail?id=1972 Err, meant to say: Project Member Reported by rossb...@chromium.org, Feb 24, 2012 The spec is not particularly clear on this, but I

[v8-dev] Re: Issue 1972 in v8: Incorrect treatment of unicode escapes in keywords

Comment #12 on issue 1972 by ma...@chromium.org: Incorrect treatment of unicode escapes in keywords https://code.google.com/p/v8/issues/detail?id=1972 Err, meant to say: So... based on this, I *don't* think v\u0061r x = 0 eval(v\\u0061r y = 1) should be *legal*. -- You received this

[v8-dev] Re: Removed non-existent files from gyp and GN builds. (issue 682793005 by mvstan...@chromium.org)

On 2014/10/28 11:44:26, mvstanton wrote: Hi Yang, just a tiny thing I noticed building on windows. PTAL, thx, --Michael lgtm. https://codereview.chromium.org/682793005/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message

[v8-dev] [turbofan] Reduce (x K) K to x K. (issue 685713002 by bmeu...@chromium.org)

Reviewers: dcarney, Description: [turbofan] Reduce (x K) K to x K. TEST=unittests R=dcar...@chromium.org Please review this at https://codereview.chromium.org/685713002/ Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge Affected files (+40, -0 lines): M

[v8-dev] Re: [turbofan] Reduce (x K) K to x K. (issue 685713002 by bmeu...@chromium.org)

lgtm https://codereview.chromium.org/685713002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails from

[v8-dev] [v8] r24931 committed - [turbofan] Reduce (x K) K to x K....

Revision: 24931 Author: bmeu...@chromium.org Date: Tue Oct 28 11:57:20 2014 UTC Log: [turbofan] Reduce (x K) K to x K. TEST=unittests R=dcar...@chromium.org Review URL: https://codereview.chromium.org/685713002 https://code.google.com/p/v8/source/detail?r=24931 Modified:

[v8-dev] Re: [turbofan] Reduce (x K) K to x K. (issue 685713002 by bmeu...@chromium.org)

Committed patchset #1 (id:1) manually as 24931 (tree was closed). https://codereview.chromium.org/685713002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To

[v8-dev] Re: Issue 3652 in v8: Sourcemap'd stacktraces

Comment #2 on issue 3652 by vse...@chromium.org: Sourcemap'd stacktraces https://code.google.com/p/v8/issues/detail?id=3652 I don't really understand what you mean. Could you please share some more details on your use case? -- You received this message because this project is configured to

[v8-dev] Re: Get stack trace for uncaught exceptions/promise rejections from the simple stack when available. (issue 674423002 by aand...@chromium.org)

LGTM with comments. https://codereview.chromium.org/674423002/diff/1/src/isolate.cc File src/isolate.cc (right): https://codereview.chromium.org/674423002/diff/1/src/isolate.cc#newcode452 src/isolate.cc:452: error_object, stack_trace_for_uncaught_exceptions_frame_limit_, There is no need to

[v8-dev] Re: Removed non-existent files from gyp and GN builds. (issue 682793005 by mvstan...@chromium.org)

Committed patchset #1 (id:1) manually as 24932 (presubmit successful). https://codereview.chromium.org/682793005/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group.

[v8-dev] [v8] r24932 committed - Removed non-existent files from gyp and GN builds....

Revision: 24932 Author: mvstan...@chromium.org Date: Tue Oct 28 12:09:48 2014 UTC Log: Removed non-existent files from gyp and GN builds. R=yang...@chromium.org Review URL: https://codereview.chromium.org/682793005 https://code.google.com/p/v8/source/detail?r=24932 Modified:

[v8-dev] Silence control reducer tracing a bit. (issue 687553002 by mstarzin...@chromium.org)

Reviewers: titzer, Description: Silence control reducer tracing a bit. R=tit...@chromium.org Please review this at https://codereview.chromium.org/687553002/ Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge Affected files (+5, -3 lines): M src/compiler/control-reducer.cc M

[v8-dev] Re: Issue 1972 in v8: Incorrect treatment of unicode escapes in keywords

Comment #13 on issue 1972 by rossb...@chromium.org: Incorrect treatment of unicode escapes in keywords https://code.google.com/p/v8/issues/detail?id=1972 Agreed. ES6 seems to be clear on v\u0061r x = 0// illegal var v\u0061r = 0 // legal -- You received this message because this

[v8-dev] Re: Silence control reducer tracing a bit. (issue 687553002 by mstarzin...@chromium.org)

https://codereview.chromium.org/687553002/diff/1/src/flag-definitions.h File src/flag-definitions.h (right): https://codereview.chromium.org/687553002/diff/1/src/flag-definitions.h#newcode358 src/flag-definitions.h:358: DEFINE_BOOL(trace_turbo_control_reducer, false, trace_turbo_reduction ?

[v8-dev] [turbofan] Complete support for integer division/modulus in simplified lowering. (issue 681133004 by bmeu...@chromium.org)

Reviewers: dcarney, Description: [turbofan] Complete support for integer division/modulus in simplified lowering. Also add backend flags that tell whether integer division/modulus is generally safe, i.e. does not trap on overflow or divide by zero. TEST=unittests R=dcar...@chromium.org

[v8-dev] Re: Allow duplicate property names in classes (issue 677953004 by a...@chromium.org)

Committed patchset #2 (id:20001) manually as 24933 (presubmit successful). https://codereview.chromium.org/677953004/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev

[v8-dev] [v8] r24933 committed - Allow duplicate property names in classes...

Revision: 24933 Author: a...@chromium.org Date: Tue Oct 28 12:23:26 2014 UTC Log: Allow duplicate property names in classes ES6 no longer makes duplicate properties an error. However, we continue to treat duplicate properties in strict mode object literals as errors. With this change

[v8-dev] Re: Add ARMv8 detection. (issue 678313002 by sigu...@chromium.org)

On 2014/10/28 11:33:37, ulan wrote: On 2014/10/28 11:24:52, sigurds wrote: PTAL. This is the first approach to detecting ARMv8. I don't have hardware here to validate that it actually works. I have hardware, will validate. I tested that it enables ARMv8 on Nexus 9 and doesn't enable on

[v8-dev] Re: Issue 3570 in v8: Classes: Handle duplicate constructors correctly

Comment #2 on issue 3570 by bugdro...@chromium.org: Classes: Handle duplicate constructors correctly https://code.google.com/p/v8/issues/detail?id=3570#c2 The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/47e7f3f73d453dd76e4a29e35fa1fbe39fd4f114

[v8-dev] Re: Issue 3570 in v8: Classes: Handle duplicate constructors correctly

Comment #3 on issue 3570 by bugdro...@chromium.org: Classes: Handle duplicate constructors correctly https://code.google.com/p/v8/issues/detail?id=3570#c3 The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/a13e2298e20976fc2e2a76eaba97a81f6e88aab7

[v8-dev] Re: Issue 3570 in v8: Classes: Handle duplicate constructors correctly

Updates: Status: Fixed Comment #4 on issue 3570 by a...@chromium.org: Classes: Handle duplicate constructors correctly https://code.google.com/p/v8/issues/detail?id=3570 (No comment was entered for this change.) -- You received this message because this project is configured to send

[v8-dev] Re: [turbofan] Complete support for integer division/modulus in simplified lowering. (issue 681133004 by bmeu...@chromium.org)

PTAL https://codereview.chromium.org/681133004/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails from it,

[v8-dev] Re: Silence control reducer tracing a bit. (issue 687553002 by mstarzin...@chromium.org)

https://codereview.chromium.org/687553002/diff/1/src/flag-definitions.h File src/flag-definitions.h (right): https://codereview.chromium.org/687553002/diff/1/src/flag-definitions.h#newcode358 src/flag-definitions.h:358: DEFINE_BOOL(trace_turbo_control_reducer, false, On 2014/10/28 12:16:34,

[v8-dev] Re: [turbofan] Complete support for integer division/modulus in simplified lowering. (issue 681133004 by bmeu...@chromium.org)

lgtm https://codereview.chromium.org/681133004/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: Classes: Add basic support for properties (issue 680993003 by a...@chromium.org)

Committed patchset #3 (id:40001) manually as 24934 (presubmit successful). https://codereview.chromium.org/680993003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev

[v8-dev] [v8] r24934 committed - Classes: Add basic support for properties...

Revision: 24934 Author: a...@chromium.org Date: Tue Oct 28 12:43:05 2014 UTC Log: Classes: Add basic support for properties This adds the properties to the prototype and the constructor. BUG=v8:3330 LOG=Y R=dslo...@chromium.org Review URL: https://codereview.chromium.org/680993003

[v8-dev] Re: Issue 3330 in v8: Implement ES6 classes

Comment #48 on issue 3330 by bugdro...@chromium.org: Implement ES6 classes https://code.google.com/p/v8/issues/detail?id=3330#c48 The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/1881cee6911df4dc4908118da6a76d08e78f682e commit

[v8-dev] Re: Silence control reducer tracing a bit. (issue 687553002 by mstarzin...@chromium.org)

lgtm https://codereview.chromium.org/687553002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails from

[v8-dev] [turbofan] LoadElement should not have a control input. (issue 685723002 by bmeu...@chromium.org)

Reviewers: dcarney, Description: [turbofan] LoadElement should not have a control input. TEST=unittests R=dcar...@chromium.org Please review this at https://codereview.chromium.org/685723002/ Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge Affected files (+27, -39 lines): M

[v8-dev] Re: [turbofan] LoadElement should not have a control input. (issue 685723002 by bmeu...@chromium.org)

PTAL https://codereview.chromium.org/685723002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails from it,

[v8-dev] Re: Issue 3330 in v8: Implement ES6 classes

Comment #47 on issue 3330 by bugdro...@chromium.org: Implement ES6 classes https://code.google.com/p/v8/issues/detail?id=3330#c47 The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/499e5e961a8dd36cce9d0cd6397c378857f5ea29 commit

[v8-dev] Re: Add floor, ceil, round (truncate) instructions for ia32, x64 (if SSE4.1) and (issue 677433002 by sigu...@chromium.org)

Added ARMv8 32bit support (turbofan). Depends on https://codereview.chromium.org/682643002/ and https://codereview.chromium.org/678313002/ https://codereview.chromium.org/677433002/diff/110025/src/compiler/arm/instruction-selector-arm.cc File src/compiler/arm/instruction-selector-arm.cc

[v8-dev] Re: [turbofan] LoadElement should not have a control input. (issue 685723002 by bmeu...@chromium.org)

lgtm https://codereview.chromium.org/685723002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: [turbofan] LoadElement should not have a control input. (issue 685723002 by bmeu...@chromium.org)

Committed patchset #1 (id:1) manually as 24935 (presubmit successful). https://codereview.chromium.org/685723002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group.

  1   2   3   >