LGTM
Unfortunately, GetRange is not really monotone, so I removed the test.
The counterexample is Range(1, 2) = SignedSmall Union Range(1e+10, inf),
but
Range(1, 2) =/= Range(1e+10, inf).
IIUC, this one would also be fixed if we treated number bitsets as proper
ranges. Because then
I have fixed the nits and added owners, PTAL.
https://codereview.chromium.org/660863003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this
No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/699603003/1
https://codereview.chromium.org/699603003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed
Reviewers: Hannes Payer,
Description:
Revert Increase the target new space size to the max new space size
TBR=hpa...@chromium.org
BUG=v8:3626
LOG=n
Please review this at https://codereview.chromium.org/724543003/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files
Comment #8 on issue 3626 by bugdro...@chromium.org: start with a large heap
reservation and shrink if it's not utilized
https://code.google.com/p/v8/issues/detail?id=3626#c8
The following revision refers to this bug:
Committed patchset #1 (id:1) manually as
07b0a2a1013302801a49c53f143a71ff67e8f88b (presubmit successful).
https://codereview.chromium.org/724543003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed
lgtm
https://codereview.chromium.org/724643002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Comment #6 on issue 3689 by bugdro...@chromium.org: Code serialization is
broken if code embeds a global symbol.
https://code.google.com/p/v8/issues/detail?id=3689#c6
The following revision refers to this bug:
Committed patchset #3 (id:40001) manually as
b96309b776e4d10b6d8eeea7b5951422ee732c19 (presubmit successful).
https://codereview.chromium.org/722723002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
Updates:
Status: Fixed
Comment #7 on issue 3689 by yang...@chromium.org: Code serialization is
broken if code embeds a global symbol.
https://code.google.com/p/v8/issues/detail?id=3689
(No comment was entered for this change.)
--
You received this message because this project is
Committed patchset #3 (id:40001) manually as
2d075e22985f69d775f2a47a77b37e4babb19ffd (presubmit successful).
https://codereview.chromium.org/723023002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
https://codereview.chromium.org/700753003/diff/240001/test/unittests/compiler/register-allocator-unittest.cc
File test/unittests/compiler/register-allocator-unittest.cc (right):
Reviewers: jarin,
Description:
Enable harmony tests for TurboFan that now pass.
R=ja...@chromium.org
TEST=mjsunit/harmony
Please review this at https://codereview.chromium.org/723983002/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+0, -7 lines):
M
Reviewers: tandrii,
Message:
Committed patchset #1 (id:1) manually as
6a06348bb7457d4957549a44111de07b2f646446 (presubmit successful).
Description:
Fix landing candidate pushes.
BUG=chromium:410721
LOG=n
TBR=tand...@chromium.org
TEST=script_test.py
Committed:
Reviewers: Benedikt Meurer,
Message:
On 2014/11/13 09:22:05, Benedikt Meurer wrote:
https://codereview.chromium.org/700753003/diff/240001/test/unittests/compiler/register-allocator-unittest.cc
File test/unittests/compiler/register-allocator-unittest.cc (right):
Updates:
Status: Fixed
Comment #6 on issue 3681 by mvstan...@chromium.org: mjsunit/json2 in 64
bits debug mode slowed down from 6s to 4m25s
https://code.google.com/p/v8/issues/detail?id=3681
(No comment was entered for this change.)
--
You received this message because this project
lgtm
https://codereview.chromium.org/723983002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/700753003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Updates:
Status: Verified
Comment #7 on issue 3681 by machenb...@chromium.org: mjsunit/json2 in 64
bits debug mode slowed down from 6s to 4m25s
https://code.google.com/p/v8/issues/detail?id=3681
(No comment was entered for this change.)
--
You received this message because this
Committed patchset #6 (id:120001) manually as
6d99e6701aa261c843391bc75654d3cda76ed499 (presubmit successful).
https://codereview.chromium.org/668143003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
On 2014/11/13 09:34:46, wingo wrote:
Committed patchset #6 (id:120001) manually as
6d99e6701aa261c843391bc75654d3cda76ed499 (presubmit successful).
Er, I thought we switched to git already as my git cl dcommit wasn't
working,
so i did a git cl land and it claimed to work, but it hasn't hit
lgtm
https://codereview.chromium.org/717093002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from it,
Committed patchset #1 (id:1) manually as
2f09dcbd20730f8df1ff3dec126bb1b2133da7dd (presubmit successful).
https://codereview.chromium.org/723983002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed
On 2014/11/13 09:41:48, wingo (chromium) wrote:
On 2014/11/13 09:34:46, wingo wrote:
Committed patchset #6 (id:120001) manually as
6d99e6701aa261c843391bc75654d3cda76ed499 (presubmit successful).
Er, I thought we switched to git already as my git cl dcommit wasn't
working,
so i did a git
Reviewers: jarin,
Description:
Enable breakpoint tests that now pass in TurboFan.
R=ja...@chromium.org
TEST=cctest/test-debug
Please review this at https://codereview.chromium.org/726453004/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+8, -40 lines):
M
Committed patchset #6 (id:120001) manually as
910711a16963aebccef59a2f6bf8c7371d985596 (presubmit successful).
https://codereview.chromium.org/668143003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
PTAL
https://codereview.chromium.org/715313003/diff/1/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/715313003/diff/1/src/objects.cc#newcode2480
src/objects.cc:2480: old_map-transitions()-IsSimpleTransition())) {
On 2014/11/12 22:52:48, Toon Verwaest wrote:
What
https://codereview.chromium.org/706263002/diff/60001/src/scanner.cc
File src/scanner.cc (right):
https://codereview.chromium.org/706263002/diff/60001/src/scanner.cc#newcode908
src/scanner.cc:908: if (c0_ != 'u') return false;
On 2014/11/13 03:21:42, caitp wrote:
Will cause `var \x` to look
I'll split this CL up, since the regexp escape handling is more complicated
(requires checking that we have the 'u' flag). So in the first part I'll
only
add the non-regexp \u{} cases behind a --harmony-unicode-escapes flag.
https://codereview.chromium.org/706263002/
--
--
v8-dev mailing
On 2014/11/13 10:07:57, marja wrote:
I'll split this CL up, since the regexp escape handling is more
complicated
(requires checking that we have the 'u' flag). So in the first part I'll
only
add the non-regexp \u{} cases behind a --harmony-unicode-escapes flag.
Sounds good. Nit:
lgtm
https://codereview.chromium.org/660863003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Reviewers: dcarney,
Description:
[turbofan] Smartify the GraphReducer.
Don't use the generic algorithm, but instead start going into the
direction of ControlReducer, using a stack plus a revisit queue to
not miss any more possibilities for reductions anymore.
TEST=cctest,unittests
PTAL
https://codereview.chromium.org/726513002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from it,
lgtm
https://codereview.chromium.org/715313003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/726513002/diff/1/src/zone-containers.h
File src/zone-containers.h (right):
https://codereview.chromium.org/726513002/diff/1/src/zone-containers.h#newcode52
src/zone-containers.h:52: ZoneDeque(int size, Zone* zone)
i really think we should be taking
lgtm
https://codereview.chromium.org/726453004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
On 2014/10/30 13:08:43, mvstanton wrote:
Respecting the master ordering, it LGTM.
thanks!
Cheers. I've rebased the patch and will wait for a chromium roll on the
previous one before landing. Sven if you prefer to review as well that is
of
course welcome :)
caitp, should we land this now?
https://codereview.chromium.org/663683006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and
Committed patchset #5 (id:80001) manually as
9e0865069fa53678d24def0f1e7828b5391f11d2 (presubmit successful).
https://codereview.chromium.org/717093002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
https://codereview.chromium.org/726513002/diff/1/src/zone-containers.h
File src/zone-containers.h (right):
https://codereview.chromium.org/726513002/diff/1/src/zone-containers.h#newcode52
src/zone-containers.h:52: ZoneDeque(int size, Zone* zone)
Ups that was dead code anyway.
Committed patchset #1 (id:1) manually as
d7169a7311e6763252dc18f85576cda4d4e587a2 (presubmit successful).
https://codereview.chromium.org/726453004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed
Committed patchset #2 (id:40001) manually as
bc8c41c08d64f5d051ae82db54d59ae2a167f430 (presubmit successful).
https://codereview.chromium.org/715313003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
Comment #2 on issue 3687 by bugdro...@chromium.org: Crash in
GeneralizeRepresentation
https://code.google.com/p/v8/issues/detail?id=3687#c2
The following revision refers to this bug:
https://chromium.googlesource.com/v8/v8.git/+/bc8c41c08d64f5d051ae82db54d59ae2a167f430
commit
Updates:
Status: Fixed
Comment #3 on issue 3687 by ish...@chromium.org: Crash in
GeneralizeRepresentation
https://code.google.com/p/v8/issues/detail?id=3687
(No comment was entered for this change.)
--
You received this message because this project is configured to send all
issue
https://codereview.chromium.org/722793005/diff/1/src/ast.h
File src/ast.h (right):
https://codereview.chromium.org/722793005/diff/1/src/ast.h#newcode2675
src/ast.h:2675: VariableProxy* proxy() const { return proxy_; }
Nit: rename proxy = class_variable_proxy (also field)
Proxy is way
Comment #5 on issue 3578 by bugdro...@chromium.org: Implement ES6 typed
array methods: forEach, every, fill, indexOf, join...
https://code.google.com/p/v8/issues/detail?id=3578#c5
The following revision refers to this bug:
Landed as ddcd08b1d1c07bf0a9c0d619068f0225972bf3c6.
https://codereview.chromium.org/660863003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe
Committed patchset #4 (id:60001) manually as
f047507370634155113d78685372630a230613cf (tree was closed).
https://codereview.chromium.org/726513002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed
I split the first part off of this CL, ptal here:
https://codereview.chromium.org/716423002/
(My intention was to do all the things you pointed out; except the ones
related
to regexps.)
https://codereview.chromium.org/706263002/diff/20001/src/scanner.cc
File src/scanner.cc (right):
Reviewers: arv, rossberg, caitp, mathias,
Message:
ptal
Description:
ES6 unicode extensions, part 1.
Allows \u{x} in variable names and string literals (not yet in regexps).
Everything's behind the --harmony-unicode flag.
BUG=
Please review this at
Reviewers: vogelheim,
Description:
Soft fail for invalid cache data.
API=ScriptCompiler::CachedData::rejected
LOG=Y
R=vogelh...@chromium.org
Please review this at https://codereview.chromium.org/724023002/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+99, -44
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/721113003/1
https://codereview.chromium.org/721113003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed
No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.
Reviewers: Michael Achenbach,
Message:
lgtm
Description:
Whitespace change to test the CQ.
BUG=
Please review this at https://codereview.chromium.org/721113003/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+1, -1 lines):
M tools/whitespace.txt
Index:
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/721113003/1
https://codereview.chromium.org/721113003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed
Comment #1 on issue 3694 by yang...@chromium.org: Segmentation fault in
CopyCharsUnsigned() with g++ 4.9.2
https://code.google.com/p/v8/issues/detail?id=3694
Do you have a test case?
Byte-for-byte copy seems wrong, since we may be converting a one-byte
string to a two-byte string here.
https://codereview.chromium.org/724023002/diff/1/src/api.cc
File src/api.cc (right):
https://codereview.chromium.org/724023002/diff/1/src/api.cc#newcode1759
src/api.cc:1759: source-cached_data-rejected = (script_data == NULL);
I find this a bit weird...
- I expected ..-rejected to be set at
https://codereview.chromium.org/724023002/diff/1/src/api.cc
File src/api.cc (right):
https://codereview.chromium.org/724023002/diff/1/src/api.cc#newcode1759
src/api.cc:1759: source-cached_data-rejected = (script_data == NULL);
If ScriptData is the internal structure (vs CachedData as an API
On 2014/11/13 13:03:01, vogelheim wrote:
https://codereview.chromium.org/724023002/diff/1/src/api.cc
File src/api.cc (right):
https://codereview.chromium.org/724023002/diff/1/src/api.cc#newcode1759
src/api.cc:1759: source-cached_data-rejected = (script_data == NULL);
If ScriptData is the
Reviewers: jarin,
Message:
ptal
Description:
[turbofan] put gaps before instructions
R=ja...@chromium.org
BUG=
Please review this at https://codereview.chromium.org/710323002/
Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+48, -70 lines):
M
On 2014/11/13 13:04:19, Yang wrote:
On 2014/11/13 13:03:01, vogelheim wrote:
https://codereview.chromium.org/724023002/diff/1/src/api.cc
File src/api.cc (right):
https://codereview.chromium.org/724023002/diff/1/src/api.cc#newcode1759
src/api.cc:1759: source-cached_data-rejected =
Failed to apply the patch.
https://codereview.chromium.org/721113003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop
Failed to apply the patch.
https://codereview.chromium.org/721113003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop
Comment #2 on issue 3694 by i...@bnoordhuis.nl: Segmentation fault in
CopyCharsUnsigned() with g++ 4.9.2
https://code.google.com/p/v8/issues/detail?id=3694
Do you have a test case?
Not at hand. If it helps, it's when node.js calls into
v8::String::NewFromTwoByte() with an odd (as it:
lgtm
https://codereview.chromium.org/725503003/diff/1/tools/push-to-trunk/push_to_trunk.py
File tools/push-to-trunk/push_to_trunk.py (left):
https://codereview.chromium.org/725503003/diff/1/tools/push-to-trunk/push_to_trunk.py#oldcode57
tools/push-to-trunk/push_to_trunk.py:57:
Reviewers: Toon Verwaest,
Message:
PTAL
Description:
Revert TransitionArray now uses is_data_property, name, attributes tuple
as a
key, which allows to have several entries for the same property name.
Revert Fix for an assertion failure in Map::FindTransitionToField(...).
Appeared after
rubberstamp lgtm
https://codereview.chromium.org/722873004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving
Reviewers: jochen (slow),
Message:
PTAL
Description:
Reland r24737 Read object pointer atomically while updating slots
Crashes were fixed by r24914.
BUG=chromium:427746
LOG=N
Please review this at https://codereview.chromium.org/726543003/
Base URL:
lgtm
https://codereview.chromium.org/724023002/diff/20001/test/cctest/test-api.cc
File test/cctest/test-api.cc (right):
https://codereview.chromium.org/724023002/diff/20001/test/cctest/test-api.cc#newcode24223
test/cctest/test-api.cc:24223: CHECK(cached_data-rejected);
Maybe there should
Reviewers: Igor Sheludko,
Message:
PTAL
Description:
Install the constructor property on custom prototype before optimizing it
as a
prototype
BUG=
Please review this at https://codereview.chromium.org/725593002/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files
Reviewers: Benedikt Meurer,
Description:
Revert [turbofan] Smartify the GraphReducer.
This reverts commit f04750737063 due to mjsunit/numops-fuzz-part2 hitting an
assertion in the ARM assembler.
TBR=bmeu...@chromium.org
TEST=mjsunit/numops-fuzz-part2
Please review this at
Committed patchset #1 (id:1) manually as
78332973e2995f0162107b9afe3cb2430ad17ab5 (tree was closed).
https://codereview.chromium.org/724053002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to
lgtm
https://codereview.chromium.org/725593002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Committed patchset #1 (id:1) manually as
c8e5a1add7b0b3184db92135a0b8ace065ecc24d (presubmit successful).
https://codereview.chromium.org/725593002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/721113003/1
https://codereview.chromium.org/721113003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed
Committed patchset #1 (id:1)
https://codereview.chromium.org/721113003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop
Committed patchset #1 (id:1)
https://codereview.chromium.org/721113003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop
lgtm (rubber stamp for cq testing)
https://codereview.chromium.org/726543003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/726543003/1
https://codereview.chromium.org/726543003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed
Committed patchset #1 (id:1)
https://codereview.chromium.org/726543003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop
Committed patchset #1 (id:1)
https://codereview.chromium.org/726543003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop
On 2014/11/13 10:48:20, marja wrote:
caitp, should we land this now?
I made some last minute adjustments to the way they're scanned (in order to
improve error reporting), but tests are still passing and I haven't been
able to
get it to break doing manual fuzzing, but there is an automated
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/725613002/ by machenb...@chromium.org.
The reason for reverting is: Test CQ.
https://codereview.chromium.org/721113003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/725613002/1
https://codereview.chromium.org/725613002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed
Reviewers: tandrii,
Message:
Created Revert of Whitespace change to test the CQ.
Description:
Revert of Whitespace change to test the CQ. (patchset #1 id:1 of
https://codereview.chromium.org/721113003/)
Reason for revert:
Test CQ
Original issue's description:
Whitespace change to test the
Committed patchset #1 (id:1)
https://codereview.chromium.org/725613002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop
Failed to apply the patch.
https://codereview.chromium.org/725613002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop
On 2014/11/13 14:57:05, caitp wrote:
On 2014/11/13 10:48:20, marja wrote:
caitp, should we land this now?
I made some last minute adjustments to the way they're scanned (in order
to
improve error reporting), but tests are still passing and I haven't been
able
to
get it to break doing
lgtm
lgtm
https://codereview.chromium.org/716423002/diff/40001/src/scanner.cc
File src/scanner.cc (right):
https://codereview.chromium.org/716423002/diff/40001/src/scanner.cc#newcode83
src/scanner.cc:83: if (x max_value) return -1;
I don't think this should block landing this, but I think it
lgtm
lgtm
https://codereview.chromium.org/716423002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails
On 2014/11/13 15:04:03, marja wrote:
Btw, I would've wanted to have a look at your latest edits, but the latest
patch
sets seem to be a rebase plus your edits, which makes the delta between
patch
sets feature not useful for this. :( In the future, pls upload rebases as
separate patch sets
Reviewers: Hannes Payer,
Description:
Fix dumping of counters in d8.
R=hpa...@chromium.org
Please review this at https://codereview.chromium.org/721193002/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+1, -2 lines):
M src/d8.cc
Index: src/d8.cc
diff --git
lgtm
https://codereview.chromium.org/721193002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
(Thanks for having a look)
https://codereview.chromium.org/716423002/diff/40001/test/cctest/test-parsing.cc
File test/cctest/test-parsing.cc (right):
https://codereview.chromium.org/716423002/diff/40001/test/cctest/test-parsing.cc#newcode4322
test/cctest/test-parsing.cc:4322: var foob\\u{c481r
Reviewers: mvstanton,
Description:
PropertyAccessCompiler should always emit reloc info for external
references.
R=mvstan...@chromium.org
Please review this at https://codereview.chromium.org/727483002/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+4, -1
On 2014/11/13 15:25:52, Yang wrote:
When v8 x64 is compiled without snapshot, LoadIC_Miss is created during
runtime,
and does not include reloc info for external references.
Serializing/deserializing that creates a LoadIC_Miss that embeds runtime
function addresses that may be out of date.
On 2014/11/13 15:18:05, marja wrote:
(Thanks for having a look)
https://codereview.chromium.org/716423002/diff/40001/test/cctest/test-parsing.cc
File test/cctest/test-parsing.cc (right):
https://codereview.chromium.org/716423002/diff/40001/test/cctest/test-parsing.cc#newcode4322
Committed patchset #1 (id:1) manually as
2e38f3391116d87ec3745982b24a0279dcefe2d7 (presubmit successful).
https://codereview.chromium.org/722873004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed
lgtm
https://codereview.chromium.org/727483002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
1 - 100 of 150 matches
Mail list logo
