LGTM with one last comment on test.
https://codereview.chromium.org/1153373003/diff/160001/test/cctest/test-heap.cc
File test/cctest/test-heap.cc (right):
https://codereview.chromium.org/1153373003/diff/160001/test/cctest/test-heap.cc#newcode248
test/cctest/test-heap.cc:248:
https://codereview.chromium.org/1162503002/diff/11/src/runtime/runtime-atomics.cc
File src/runtime/runtime-atomics.cc (right):
https://codereview.chromium.org/1162503002/diff/11/src/runtime/runtime-atomics.cc#newcode176
src/runtime/runtime-atomics.cc:176: } // anonymous namespace
On
Reviewers: rossberg, arv,
Message:
PTAL
Description:
[strong] Refactor ObjectStrength into a replacement for strong boolean args
Boolean is_strong parameters have begun to proliferate across areas where
strong mode semantics are different. This CL repurposes the existing
ObjectStrength enum as
Try jobs failed on following builders:
linux_blink_rel on tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/64792)
https://codereview.chromium.org/1153263004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
lgtm
I've uploaded a fix for the blink tests in
https://codereview.chromium.org/1154523007/
https://codereview.chromium.org/1153263004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the
On 2015/06/03 17:02:50, rmcilroy wrote:
On 2015/06/03 16:50:41, mtbrandyberry wrote:
On 2015/06/03 15:54:32, rmcilroy wrote:
On 2015/06/03 15:44:26, mtbrandyberry wrote:
On 2015/06/03 03:02:50, commit-bot: I haz the power wrote:
Patchset 1 (id:??) landed as
PTAL
https://codereview.chromium.org/1153373003/diff/140001/src/factory.h
File src/factory.h (right):
https://codereview.chromium.org/1153373003/diff/140001/src/factory.h#newcode355
src/factory.h:355: HandleFloat32x4 NewFloat32x4(double w, double x,
double y, double z,
On 2015/06/03 13:27:15,
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1153373003/220001
https://codereview.chromium.org/1153373003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
Status: Untriaged
Owner:
New issue 4162 by Arnavion: Promise constructor's resolve does not handle
thenables correctly
https://code.google.com/p/v8/issues/detail?id=4162
https://people.mozilla.org/~jorendorff/es6-draft.html#sec-promise-resolve-functions
states
that when resolving a
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1153263004/1
https://codereview.chromium.org/1153263004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
Try jobs failed on following builders:
v8_linux64_avx2_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel/builds/1023)
https://codereview.chromium.org/1154103005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
Comment #15 on issue 4124 by bugdro...@chromium.org: Implement SIMD.js
https://code.google.com/p/v8/issues/detail?id=4124#c15
The following revision refers to this bug:
https://chromium.googlesource.com/v8/v8.git/+/f9dd3446da82fbbf20c344ceb6a87be2c11f5759
commit
Committed patchset #10 (id:220001)
https://codereview.chromium.org/1153373003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and
Patchset 10 (id:??) landed as
https://crrev.com/f9dd3446da82fbbf20c344ceb6a87be2c11f5759
Cr-Commit-Position: refs/heads/master@{#28797}
https://codereview.chromium.org/1153373003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
Reviewers: adamk, wingo,
Message:
PTAL
Description:
Refactor lexical home object binding
Before this we had 3 super related lexical bindings that got injected
into method bodies: .home_object, .this_function, and new.target.
With this change we get rid of the .home_object one in favor of
LGTM
https://codereview.chromium.org/1163043003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1153263004/1
https://codereview.chromium.org/1153263004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
I should say this lgtm as-is, if we decide to do something different in
AstValueFactory that can easily be done in a followup.
https://codereview.chromium.org/1154103005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message
https://codereview.chromium.org/1153373003/diff/160001/test/cctest/test-heap.cc
File test/cctest/test-heap.cc (right):
https://codereview.chromium.org/1153373003/diff/160001/test/cctest/test-heap.cc#newcode248
test/cctest/test-heap.cc:248: CHECK(std::isnan(float32x4-get_lane(2)));
On 2015/06/03
Looks fine except for what's going on in ast-value-factory. I don't recall
the
decision around adding NewSymbol(some_string). Was there a reason not to
add
new AstValue::Type values?
https://codereview.chromium.org/1154103005/diff/1/src/ast-value-factory.cc
File src/ast-value-factory.cc
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1154103005/1
https://codereview.chromium.org/1154103005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
Reviewers: Sven Panne, Benedikt Meurer, adamk,
Message:
Even more of the these silly sign errors with gcc. PTAL.
Description:
Fix more -Wsign-compare bugs with GCC 4.9.2.
BUG=
Please review this at https://codereview.chromium.org/1167613004/
Base URL:
Try jobs failed on following builders:
linux_blink_rel on tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/64894)
https://codereview.chromium.org/1153263004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
I managed to reproduce this locally.
It might be related to https://code.google.com/p/v8/issues/detail?id=3815
And it definitely seems unrelated to typed arrays, so if you modify the
test to
avoid using a property whose key is NaN you should be good.
Comment #4 on issue 4134 by bugdro...@chromium.org: remove internal usage
of APIs that are marked as V8_DEPRECATE_SOON
https://code.google.com/p/v8/issues/detail?id=4134#c4
The following revision refers to this bug:
Committed patchset #3 (id:40001)
https://codereview.chromium.org/1162363005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and
Patchset 3 (id:??) landed as
https://crrev.com/696184a0477054897aec76946f3715682451ac5c
Cr-Commit-Position: refs/heads/master@{#28783}
https://codereview.chromium.org/1162363005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
yeah, closing this cl
https://codereview.chromium.org/1160143004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop
On 2015/06/03 08:26:06, Michael Starzinger wrote:
On 2015/06/03 08:03:04, rossberg wrote:
On 2015/06/03 07:54:53, Michael Starzinger wrote:
On 2015/06/03 06:28:44, rossberg wrote:
Does this also work correctly if the (direct, sloppy) eval contains
a
'var'
declaration?
() =
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1146063006/40001
https://codereview.chromium.org/1146063006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
Committed patchset #4 (id:60001)
https://codereview.chromium.org/1149293005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and
Patchset 4 (id:??) landed as
https://crrev.com/d903c5c0e55f7e3707bcc4390555bac21956c896
Cr-Commit-Position: refs/heads/master@{#28785}
https://codereview.chromium.org/1149293005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
Reviewers: jochen,
Message:
PTAL
Description:
Fixed memory-leak in d8. It did not clean evaluation context used for
executing
shell commands.
BUG=chromium:493284
LOG=N
Please review this at https://codereview.chromium.org/1147343004/
Base URL:
lgtm
https://codereview.chromium.org/1147343004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Committed patchset #1 (id:1)
https://codereview.chromium.org/1150853009/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop
lgtm
https://codereview.chromium.org/1170433002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1170433002/20001
https://codereview.chromium.org/1170433002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
Patchset 1 (id:??) landed as
https://crrev.com/a961d6c0146e3ee4bb8a4baa50ca475b56239bc5
Cr-Commit-Position: refs/heads/master@{#28786}
https://codereview.chromium.org/1150853009/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1147343004/40001
https://codereview.chromium.org/1147343004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
Reviewers: Jakob,
Message:
ptal
Description:
Add ARM64 suppport to grokdump.py
Constants are taken from
chromium/src/google_breakpad/common/minidump_cpu_arm64.h
BUG=
Please review this at https://codereview.chromium.org/1149293005/
Base URL:
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1149293005/60001
https://codereview.chromium.org/1149293005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
On 2015/06/03 10:41:49, Jakob wrote:
Awesome, thank you very much! LGTM with a nit.
https://codereview.chromium.org/1149293005/diff/20001/tools/grokdump.py
File tools/grokdump.py (right):
https://codereview.chromium.org/1149293005/diff/20001/tools/grokdump.py#newcode3188
lgtm with question
https://codereview.chromium.org/1157843006/diff/20001/src/api.cc
File src/api.cc (right):
https://codereview.chromium.org/1157843006/diff/20001/src/api.cc#newcode6276
src/api.cc:6276: int length = size * 2;
can this overflow?
https://codereview.chromium.org/1157843006/
--
lgtm
https://codereview.chromium.org/1155723005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1155723005/1
https://codereview.chromium.org/1155723005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
Reviewers: jarin,
Description:
[x64] Smi zero can be used as an immediate.
R=ja...@chromium.org
Please review this at https://codereview.chromium.org/1150853009/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+10, -1 lines):
M
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1150853009/1
https://codereview.chromium.org/1150853009/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
https://codereview.chromium.org/1155493007/diff/1/test/js-perf-test/Exceptions/try-catch.js
File test/js-perf-test/Exceptions/try-catch.js (right):
https://codereview.chromium.org/1155493007/diff/1/test/js-perf-test/Exceptions/try-catch.js#newcode5
test/js-perf-test/Exceptions/try-catch.js:5:
Updates:
Status: Fixed
Comment #8 on issue 4019 by habl...@chromium.org: SIGILL on ARM Raspberry
Pi v1 with Math.exp(-0.5)
https://code.google.com/p/v8/issues/detail?id=4019
(No comment was entered for this change.)
--
You received this message because this project is configured to
lgtm, please add a more descriptive title and description to the cl
https://codereview.chromium.org/1159153003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
Patchset 3 (id:??) landed as
https://crrev.com/68beef53c36d8640b453da4169548cbbd61c91a9
Cr-Commit-Position: refs/heads/master@{#28788}
https://codereview.chromium.org/1146063006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
Committed patchset #3 (id:40001)
https://codereview.chromium.org/1146063006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and
On 2015/06/03 06:17:13, Hannes Payer wrote:
On 2015/06/03 06:16:52, Hannes Payer wrote:
hi bill, what the question?
what's
the heap/gc part looks good
https://codereview.chromium.org/1153373003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
https://codereview.chromium.org/1161603006/diff/80001/src/heap/heap.cc
File src/heap/heap.cc (right):
https://codereview.chromium.org/1161603006/diff/80001/src/heap/heap.cc#newcode1262
src/heap/heap.cc:1262:
FragmentationOfCompactedSpacesInPercent(total_committed);
Can we have a separate
On 2015/06/03 06:28:44, rossberg wrote:
Does this also work correctly if the (direct, sloppy) eval contains
a 'var'
declaration?
() = eval(var x = 666), x
should return 666. Wouldn't the x still go to the wrong context, or am I
misunderstanding the CL?
Just to clarify, did you mean
Committed patchset #1 (id:1)
https://codereview.chromium.org/1155723005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop
Patchset 1 (id:??) landed as
https://crrev.com/92834f2b418be5003988dc34540d34339e5ad218
Cr-Commit-Position: refs/heads/master@{#28784}
https://codereview.chromium.org/1155723005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
Reviewers: arv, Michael Starzinger,
Description:
Micro benchmark for Try-Catch-Finally
BUG=v8:4131
LOG=n
Please review this at https://codereview.chromium.org/1155493007/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+120, -2 lines):
A +
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1162363005/40001
https://codereview.chromium.org/1162363005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
Reviewers: Hannes Payer,
Message:
PTAL. In the next CL I will remove long_idle_notification handling when
transitioning to reduce memory mode.
https://codereview.chromium.org/1159153003/diff/1/src/heap/heap.cc
File src/heap/heap.cc (left):
lgtm
https://codereview.chromium.org/1150853009/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Patchset 2 (id:??) landed as
https://crrev.com/daba339a84c75f5edac6f60eb079b563970260b9
Cr-Commit-Position: refs/heads/master@{#28787}
https://codereview.chromium.org/1170433002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
Updates:
Labels: Area-Compiler
Comment #2 on issue 4160 by habl...@chromium.org: Out of sync context/scope
chains for arrow function calling eval
https://code.google.com/p/v8/issues/detail?id=4160
(No comment was entered for this change.)
--
You received this message because this
Committed patchset #2 (id:20001)
https://codereview.chromium.org/1170433002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1155493007/20001
https://codereview.chromium.org/1155493007/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
lgtm
https://codereview.chromium.org/1167813003/diff/1/src/ia32/lithium-codegen-ia32.cc
File src/ia32/lithium-codegen-ia32.cc (left):
https://codereview.chromium.org/1167813003/diff/1/src/ia32/lithium-codegen-ia32.cc#oldcode1793
src/ia32/lithium-codegen-ia32.cc:1793: Label runtime, done;
https://codereview.chromium.org/1162363005/diff/1/tools/gyp/v8.gyp
File tools/gyp/v8.gyp (right):
https://codereview.chromium.org/1162363005/diff/1/tools/gyp/v8.gyp#newcode369
tools/gyp/v8.gyp:369: 'V8_IMMINENT_DEPRECATION_WARNINGS',
Some compilers still have issues with this, it seems.
On 2015/06/03 07:54:53, Michael Starzinger wrote:
On 2015/06/03 06:28:44, rossberg wrote:
Does this also work correctly if the (direct, sloppy) eval contains
a 'var'
declaration?
() = eval(var x = 666), x
should return 666. Wouldn't the x still go to the wrong context, or am I
ptal
https://codereview.chromium.org/1162363005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Nit addressed, thanks.
https://codereview.chromium.org/1167813003/diff/1/src/ia32/lithium-codegen-ia32.cc
File src/ia32/lithium-codegen-ia32.cc (left):
https://codereview.chromium.org/1167813003/diff/1/src/ia32/lithium-codegen-ia32.cc#oldcode1793
src/ia32/lithium-codegen-ia32.cc:1793: Label
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1167813003/40001
https://codereview.chromium.org/1167813003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
On 2015/06/03 at 08:03:52, jochen wrote:
ptal
meh, gcc still doesn't like it :-/
https://codereview.chromium.org/1162363005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups
lgtm
Some nitpicks. But if the compilers are happy, I'm too. :)
https://codereview.chromium.org/1162363005/diff/20001/src/accessors.cc
File src/accessors.cc (right):
https://codereview.chromium.org/1162363005/diff/20001/src/accessors.cc#newcode1416
src/accessors.cc:1416: }
I don't think I
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1144393003/1
https://codereview.chromium.org/1144393003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
Patchset 3 (id:??) landed as
https://crrev.com/e4782a9b468258344d512a5f7dadbf1584928849
Cr-Commit-Position: refs/heads/master@{#28782}
https://codereview.chromium.org/1167813003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
Hey Jaro,
This is the quick fix for JSModulus. Please take a look.
Thanks,
Benedikt
https://codereview.chromium.org/1170433002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google
LGTM, thanks. I updated the description
https://codereview.chromium.org/1158623003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this
Committed patchset #1 (id:1)
https://codereview.chromium.org/1157053007/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop
Patchset 1 (id:??) landed as
https://crrev.com/251816ab5a2719c5da635107556e1a9a6668b0f7
Cr-Commit-Position: refs/heads/master@{#28779}
https://codereview.chromium.org/1157053007/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
https://codereview.chromium.org/1162363005/diff/20001/src/accessors.cc
File src/accessors.cc (right):
https://codereview.chromium.org/1162363005/diff/20001/src/accessors.cc#newcode1416
src/accessors.cc:1416: }
On 2015/06/03 at 08:23:13, vogelheim wrote:
I don't think I understand the logic
On 2015/06/03 06:16:52, Hannes Payer wrote:
hi bill, what the question?
what's
https://codereview.chromium.org/1153373003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups
在 2015年4月21日星期二 UTC+8上午11:41:21，Wenwei Peng写道：
Title: The core of the core of the big data solutions -- Map
Author: pengwenwei
Email: wenwei19710430
Language:c++
Platform:Windows, linux
Technology: Perfect hash algorithm
Level: Advanced
Description: Map
Patchset 1 (id:??) landed as
https://crrev.com/525955037a371d366a63e5b959a9dba2eba9225e
Cr-Commit-Position: refs/heads/master@{#28781}
https://codereview.chromium.org/1151993005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
https://codereview.chromium.org/1136223004/diff/160001/src/deoptimizer.cc
File src/deoptimizer.cc (right):
https://codereview.chromium.org/1136223004/diff/160001/src/deoptimizer.cc#newcode780
src/deoptimizer.cc:780: int frame_index = static_castint(i);
On 2015/06/03 04:02:17, Benedikt Meurer
Does this also work correctly if the (direct, sloppy) eval contains a 'var'
declaration?
() = eval(var x = 666), x
should return 666. Wouldn't the x still go to the wrong context, or am I
misunderstanding the CL?
https://codereview.chromium.org/1146063006/
--
--
v8-dev mailing list
Reviewers: vogelheim,
Description:
Remove usage of to-be-deprecated APIs from v8 core
Also turn on the macro to disable to-be-deprecated APIs for core
BUG=v8:4134
R=vogelh...@chromium.org
LOG=n
Please review this at https://codereview.chromium.org/1162363005/
Base URL:
Committed patchset #3 (id:40001)
https://codereview.chromium.org/1167813003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and
https://codereview.chromium.org/1155543003/diff/20001/src/compiler/js-typed-lowering.cc
File src/compiler/js-typed-lowering.cc (right):
https://codereview.chromium.org/1155543003/diff/20001/src/compiler/js-typed-lowering.cc#newcode1003
src/compiler/js-typed-lowering.cc:1003: Node* check =
OWNER's rubberstamp LGTM.
https://codereview.chromium.org/1156023010/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1158623003/1
https://codereview.chromium.org/1158623003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1157053007/1
https://codereview.chromium.org/1157053007/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
lgtm
https://codereview.chromium.org/1157053007/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Reviewers: Jakob,
Description:
[date] Refactor the %_DateField intrinsic to be optimizable.
Previously the %_DateField intrinsic would also check the object and
throw an exception if you happen to pass something that is not a valid
JSDate, which (a) violates our policy for instrinsics and (b)
Patchset 1 (id:??) landed as
https://crrev.com/0962f980a21629bbe5a58bb9817fb0f99662bac8
Cr-Commit-Position: refs/heads/master@{#28778}
https://codereview.chromium.org/1158623003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
Hey Jakob,
This is the CL I mentioned to cleanup the date checking. Please take a look.
Thanks,
Benedikt
https://codereview.chromium.org/1167813003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
Committed patchset #1 (id:1)
https://codereview.chromium.org/1158623003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop
Committed patchset #1 (id:1)
https://codereview.chromium.org/1144393003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop
Patchset 1 (id:??) landed as
https://crrev.com/1d1df96d2349a2e2089c00bbf0190318b0a84579
Cr-Commit-Position: refs/heads/master@{#28780}
https://codereview.chromium.org/1144393003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
Comment #32 on issue 3996 by bugdro...@chromium.org: Improve typed array
performance
https://code.google.com/p/v8/issues/detail?id=3996#c32
The following revision refers to this bug:
https://chromium.googlesource.com/v8/v8.git/+/1d1df96d2349a2e2089c00bbf0190318b0a84579
commit
On 2015/06/03 08:03:04, rossberg wrote:
On 2015/06/03 07:54:53, Michael Starzinger wrote:
On 2015/06/03 06:28:44, rossberg wrote:
Does this also work correctly if the (direct, sloppy) eval contains a
'var'
declaration?
() = eval(var x = 666), x
should return 666. Wouldn't the x
1 - 100 of 191 matches
Mail list logo
