Reviewers: jarin, binji,
Message:
FYI: Fails sometimes in isolates, debug mode:
http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20debug%20-%20isolates/builds/3860
Test: mjsunit/regress/regress-4279 (flaky in a repeated run)
Flags: --stress-opt --always-opt
Command: out/Debug/d8
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1233603002/1
https://codereview.chromium.org/1233603002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
lgtm
https://codereview.chromium.org/1222093007/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
https://codereview.chromium.org/1221433021/diff/1/src/base/smart-pointers.h
File src/base/smart-pointers.h (right):
https://codereview.chromium.org/1221433021/diff/1/src/base/smart-pointers.h#newcode90
src/base/smart-pointers.h:90: namespace internal {
On 2015/07/08 at 14:30:58, rmcilroy wrote:
Patchset 2 (id:??) landed as
https://crrev.com/e50c861b099b3bd3e1174b5f2843567620cc6842
Cr-Commit-Position: refs/heads/master@{#29562}
https://codereview.chromium.org/1213623020/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
Comment #6 on issue 4269 by bugdro...@chromium.org: Debug break points
should not be implemented by patching ICs
https://code.google.com/p/v8/issues/detail?id=4269#c6
The following revision refers to this bug:
Committed patchset #4 (id:60001)
https://codereview.chromium.org/1222093007/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1213623020/20001
https://codereview.chromium.org/1213623020/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
lgtm
https://codereview.chromium.org/1229233002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1222093007/60001
https://codereview.chromium.org/1222093007/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
Comment #4 on issue 4279 by bugdro...@chromium.org: Check failed: 0 ==
result in v8::base::DestroyNativeHandle
https://code.google.com/p/v8/issues/detail?id=4279#c4
The following revision refers to this bug:
Patchset 1 (id:??) landed as
https://crrev.com/6d12699ab443048cf6a0f84726ea4072f55eb6b5
Cr-Commit-Position: refs/heads/master@{#29560}
https://codereview.chromium.org/1233603002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
Committed patchset #1 (id:1)
https://codereview.chromium.org/1233603002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop
Patchset 4 (id:??) landed as
https://crrev.com/8965b683ce39bc3c24ed2466d189323d81a70852
Cr-Commit-Position: refs/heads/master@{#29561}
https://codereview.chromium.org/1222093007/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
Committed patchset #2 (id:20001)
https://codereview.chromium.org/1213623020/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and
Reviewers: jochen,
Description:
Disable handle zapping on 4.5 branch
BUG=chromium:318206
LOG=n
TBR=joc...@chromium.org
Please review this at https://codereview.chromium.org/1229243002/
Base URL: https://chromium.googlesource.com/v8/v8.git@4.5
Affected files (+1, -1 lines):
M
lgtm
https://codereview.chromium.org/1229243002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1229243002/1
https://codereview.chromium.org/1229243002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
CLs for remote refs other than refs/pending/heads/master must contain
NOTRY=true
and NOPRESUBMIT=true in order for the CQ to process them
https://codereview.chromium.org/1229243002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
https://codereview.chromium.org/1229243002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from it, send
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1229243002/1
https://codereview.chromium.org/1229243002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
Committed patchset #1 (id:1)
https://codereview.chromium.org/1229243002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop
Reviewers: jochen,
Message:
PTAL
Description:
Disable the pending task if the memory reducer is teared down.
BUG=chromium:508584
LOG=NO
Please review this at https://codereview.chromium.org/1230163002/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+24, -5
lgtm
https://codereview.chromium.org/1230163002/diff/20001/src/heap/memory-reducer.cc
File src/heap/memory-reducer.cc (right):
https://codereview.chromium.org/1230163002/diff/20001/src/heap/memory-reducer.cc#newcode183
src/heap/memory-reducer.cc:183: pending_task_ = NULL;
nullptr here and
Thanks, landing
https://codereview.chromium.org/1230163002/diff/20001/src/heap/memory-reducer.cc
File src/heap/memory-reducer.cc (right):
https://codereview.chromium.org/1230163002/diff/20001/src/heap/memory-reducer.cc#newcode183
src/heap/memory-reducer.cc:183: pending_task_ = NULL;
On
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1230163002/60001
https://codereview.chromium.org/1230163002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
Try jobs failed on following builders:
v8_mac_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel/builds/7579)
(exceeded global retry quota)
https://codereview.chromium.org/1230163002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
Reviewers: Hablich,
Description:
Version 4.4.63.17 (cherry-pick)
Merged b199bcdd47ae97ec116b430e34ab42001c8f04c0
unicode-decoder: fix out-of-band write in utf16
BUG=v8:4274,chromium:508540
LOG=N
TBR=habl...@chromium.org
Please review this at https://codereview.chromium.org/1227203010/
Base
Committed patchset #1 (id:1) manually as
2ff0170e04da446b8f077bc7beea115b9152a2ca.
https://codereview.chromium.org/1227203010/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups
Reviewers: Hablich,
Description:
Version 4.3.61.37 (cherry-pick)
Merged b199bcdd47ae97ec116b430e34ab42001c8f04c0
unicode-decoder: fix out-of-band write in utf16
BUG=v8:4274
LOG=N
R=habl...@chromium.org
Please review this at https://codereview.chromium.org/1229143005/
Base URL:
Updates:
Status: Available
Cc: joc...@chromium.org
Labels: Area-Runtime Type-Bug Priority-Medium
Comment #1 on issue 4290 by habl...@chromium.org: Could not clear cache
while using c++ api
https://code.google.com/p/v8/issues/detail?id=4290
(No comment was entered for
Committed patchset #1 (id:1) manually as
26730ac43a9953551907d735b5328cd92fa17568.
https://codereview.chromium.org/1229143005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups
Updates:
Status: Assigned
Owner: paul.l...@imgtec.com
Cc: verwa...@chromium.org u...@chromium.org joc...@chromium.org
Labels: HW-ARM Type-Bug Priority-Medium Area-Runtime
Comment #1 on issue 4286 by habl...@chromium.org: Check failed: index = 0
index
can you add message queue pumping to the other binaries as well please (d8,
unittests, tools/parser-shell and the stuff in samples/)
https://codereview.chromium.org/1209403005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message
serializer part lgtm with comments.
https://codereview.chromium.org/1213203007/diff/280001/src/snapshot/serialize.cc
File src/snapshot/serialize.cc (right):
https://codereview.chromium.org/1213203007/diff/280001/src/snapshot/serialize.cc#newcode1194
src/snapshot/serialize.cc:1194: case
Reviewers: Hablich,
Description:
Version 4.4.63.16 (cherry-pick)
Merged 8c298c79c2eff50b1d3809a5f72ed7d3679c47a4
Move compatible receiver check from CompileHandler to UpdateCaches
BUG=chromium:505374
LOG=N
TBR=habl...@chromium.org
Please review this at
Committed patchset #1 (id:1) manually as
3bf7258ec1f9806f59465aa9e0bf5c8760e98063.
https://codereview.chromium.org/1233453004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups
Reviewers: Hablich,
Description:
Version 4.3.61.38 (cherry-pick)
Merged 8c298c79c2eff50b1d3809a5f72ed7d3679c47a4
Move compatible receiver check from CompileHandler to UpdateCaches
BUG=chromium:505374
LOG=N
TBR=habl...@chromium.org
Please review this at
Committed patchset #1 (id:1) manually as
d6135556c6ae59796f572c54ab4fdcd533c992f9.
https://codereview.chromium.org/1233593002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups
Comment #2 on issue 4286 by alexand...@opera.com: Check failed: index = 0
index NumAllocatableRegisters()
https://code.google.com/p/v8/issues/detail?id=4286
This problem has been already reported as
https://code.google.com/p/v8/issues/detail?id=4280#c2
and fixed by
Reviewers: ,
Message:
This problem has been already reported as
https://code.google.com/p/v8/issues/detail?id=4280#c2
and fixed by https://codereview.chromium.org/1230473006
So this can be closed as duplicate.
Description:
Fix max number of allocatable registers in
Updates:
Status: Assigned
Comment #5 on issue 4279 by machenb...@chromium.org: Check failed: 0 ==
result in v8::base::DestroyNativeHandle
https://code.google.com/p/v8/issues/detail?id=4279
Also fails in isolates, release:
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1230163002/80001
https://codereview.chromium.org/1230163002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
Reviewers: jarin, binji,
Message:
Also fails in release mode:
http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20isolates/builds/4409
Description:
[Sheriff] Skip worker test.
BUG=v8:4279
LOG=n
NOTRY=true
TBR=ja...@chromium.org
Please review this at
Updates:
Owner: little...@chromium.org
Cc: rossb...@chromium.org
Comment by rossb...@chromium.org:
(No comment was entered for this change.)
Affected issues:
issue 4001: Number/Boolean.prototype should be an ordinary object
http://code.google.com/p/v8/issues/detail?id=4001
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1235493005/1
https://codereview.chromium.org/1235493005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
Reviewers: Benedikt Meurer, arv,
Message:
Architecture ports are still in the works, but feel free to shoot comments
my
way already.
Benedikt: PTAL.
Arv: FYI.
Description:
Cleanup Generate_JSConstructStubHelper a bit.
R=bmeu...@chromium.org
Please review this at
Try jobs failed on following builders:
v8_linux_chromium_gn_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_chromium_gn_rel/builds/5950)
(exceeded global retry quota)
https://codereview.chromium.org/1230163002/
--
--
v8-dev mailing list
Comment #6 on issue 4279 by bugdro...@chromium.org: Check failed: 0 ==
result in v8::base::DestroyNativeHandle
https://code.google.com/p/v8/issues/detail?id=4279#c6
The following revision refers to this bug:
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1229233002/1
https://codereview.chromium.org/1229233002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
Updates:
Owner: ad...@chromium.org
Comment #3 on issue 3698 by rossb...@chromium.org: Improve parse error
message for missing name in FunctionDeclaration
https://code.google.com/p/v8/issues/detail?id=3698
(No comment was entered for this change.)
--
You received this message because
Comment #2 on issue 4154 by verwa...@chromium.org: Array.prototype.reverse
should throw if property is non writable.
https://code.google.com/p/v8/issues/detail?id=4154
Indeed. This now throws after my fix.
--
You received this message because this project is configured to send all
issue
Patchset 1 (id:??) landed as
https://crrev.com/dcb4498ce7059f6b7046b077d364ab4977783b90
Cr-Commit-Position: refs/heads/master@{#29563}
https://codereview.chromium.org/1235493005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
Updates:
Status: Assigned
Owner: little...@chromium.org
Comment #6 on issue 4034 by rossb...@chromium.org: There should only be
one %ThrowTypeError% function
https://code.google.com/p/v8/issues/detail?id=4034
(No comment was entered for this change.)
--
You received this
Committed patchset #1 (id:1)
https://codereview.chromium.org/1235493005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1230163002/80001
https://codereview.chromium.org/1230163002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
Updates:
Status: Fixed
Mergedinto:
Comment #3 on issue 4154 by verwa...@chromium.org: Array.prototype.reverse
should throw if property is non writable.
https://code.google.com/p/v8/issues/detail?id=4154
Although no, this was already fixed with my LookupIterator changes.
Patchset 1 (id:??) landed as
https://crrev.com/331b87e222e852eb29eb70ff3d6e5942a983c940
Cr-Commit-Position: refs/heads/master@{#29564}
https://codereview.chromium.org/1229233002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
Committed patchset #1 (id:1)
https://codereview.chromium.org/1229233002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop
Updates:
Cc: u...@chromium.org joc...@chromium.org
Comment #3 on issue 4280 by jkumme...@chromium.org: Ignition interpreter
tracking bug
https://code.google.com/p/v8/issues/detail?id=4280
Issue 4286 has been merged into this issue.
--
You received this message because this project
Updates:
Status: Duplicate
Owner: ---
Labels: -Area-Runtime Area-Compiler
Mergedinto: 4280
Comment #3 on issue 4286 by jkumme...@chromium.org: Check failed: index =
0 index NumAllocatableRegisters()
https://code.google.com/p/v8/issues/detail?id=4286
(No
Committed patchset #3 (id:40001) manually as
8627394738adf4d6837b4d80d86ccd54c494f74d.
https://codereview.chromium.org/1214503009/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google
Reviewers: jochen,
Description:
Fixes the parser-shell by adding a dependency to StartupDataUtil.
Please review this at https://codereview.chromium.org/1230173002/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+9, -0 lines):
M tools/parser-shell.cc
M
lgtm
https://codereview.chromium.org/1230173002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Please update all the other calls to JSReceiver::SetElement() and
JSObject::SetElement() with calls to Object::SetElement.
lgtm once the comments are addressed.
https://codereview.chromium.org/1221303019/diff/50001/src/lookup.cc
File src/lookup.cc (right):
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1230173002/1
https://codereview.chromium.org/1230173002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
Reviewers: jochen,
Message:
PTAL. Rolling clang including some fix attempts for new clang warnings, see:
https://codereview.chromium.org/1232043002/
Description:
Update V8 DEPS.
Rolling v8/tools/clang to 58128abd44c22255def1163d30bc9bb2cc85e15c
Original CL:
lgtm
https://codereview.chromium.org/1232583002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Committed patchset #5 (id:80001)
https://codereview.chromium.org/1230163002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and
Patchset 5 (id:??) landed as
https://crrev.com/a5616e5d4bd6e867f59c1f819b20c536f1e2432c
Cr-Commit-Position: refs/heads/master@{#29565}
https://codereview.chromium.org/1230163002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
Reviewers: Michael Starzinger,
Message:
Please take a look.
The motivation for this change is so that we can add more reloc info modes.
Which is so that we can add a reloc info mode for generator continuations.
Which is so that we can translate non-debug full code PC into debug full
code PC
Patchset 1 (id:??) landed as
https://crrev.com/40b64652f9e4601dc79242239093b4bd834a584b
Cr-Commit-Position: refs/heads/master@{#29569}
https://codereview.chromium.org/1235573002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
Committed patchset #1 (id:1)
https://codereview.chromium.org/1235573002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop
Reviewers: rossberg,
Description:
Version 4.5.103.1 (cherry-pick)
Merged 4a4d83683dff9d2fc6bd17aa1f10d6104077467d
[es6] unship harmony_rest_parameters
BUG=chromium:508074
LOG=N
R=rossb...@chromium.org
Please review this at https://codereview.chromium.org/1227863004/
Base URL:
lgtm
https://codereview.chromium.org/1215273003/diff/40001/tools/run_perf.py
File tools/run_perf.py (right):
https://codereview.chromium.org/1215273003/diff/40001/tools/run_perf.py#newcode229
tools/run_perf.py:229: def Unchain(iterable):
This function is usually called 'unzip' as it inverts
lgtm
https://codereview.chromium.org/1229673005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/1226103002/diff/40001/src/preparser.h
File src/preparser.h (right):
https://codereview.chromium.org/1226103002/diff/40001/src/preparser.h#newcode3769
src/preparser.h:3769: if (is_strict(language_mode()) ||
allow_harmony_sloppy()) {
On 2015/07/08 23:42:13,
@Mips folks: Please add ports for this. The new clang version treats shift
left
of negative signed integers as an error.
https://codereview.chromium.org/1232583002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1230183002/40001
https://codereview.chromium.org/1230183002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
lgtm
https://codereview.chromium.org/1209403005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Committed patchset #1 (id:1)
https://codereview.chromium.org/1234553002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop
Patchset 1 (id:??) landed as
https://crrev.com/0b3d6f7a7dfaf645a4aba7e4fbb03da7b1ad2a7a
Cr-Commit-Position: refs/heads/master@{#29570}
https://codereview.chromium.org/1234553002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
Reviewers: tandrii(chromium), ulan,
Message:
PTAL
https://codereview.chromium.org/1215273003/diff/40001/tools/unittests/run_perf_test.py
File tools/unittests/run_perf_test.py (left):
https://codereview.chromium.org/1215273003/diff/40001/tools/unittests/run_perf_test.py#oldcode414
Committed patchset #1 (id:1)
https://codereview.chromium.org/1227863004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1227863004/1
https://codereview.chromium.org/1227863004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
lgtm
https://codereview.chromium.org/1234553002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Updates:
Status: Fixed
Comment #5 on issue 4273 by habl...@chromium.org: Unsound TurboFan OSR
https://code.google.com/p/v8/issues/detail?id=4273
Fixed. This is also included in 4.5. btw.
--
You received this message because this project is configured to send all
issue notifications
On 2015/07/10 at 08:18:57, yangguo wrote:
serializer part lgtm with comments.
https://codereview.chromium.org/1213203007/diff/280001/src/snapshot/serialize.cc
File src/snapshot/serialize.cc (right):
LGTM, thanks
https://codereview.chromium.org/1227863004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails
Reviewers: Michael Achenbach, vogelheim,
Message:
PTAL
Description:
Updated version to 4.6
BUG=
TBR=machenb...@chromium.org,vogelh...@chromium.org
NOTRY=true
Please review this at https://codereview.chromium.org/1235573002/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
https://codereview.chromium.org/1215273003/diff/40001/tools/run_perf.py
File tools/run_perf.py (right):
https://codereview.chromium.org/1215273003/diff/40001/tools/run_perf.py#newcode229
tools/run_perf.py:229: def Unchain(iterable):
On 2015/07/10 10:54:16, ulan wrote:
This function is usually
https://codereview.chromium.org/1226103002/diff/40001/src/preparser.h
File src/preparser.h (right):
https://codereview.chromium.org/1226103002/diff/40001/src/preparser.h#newcode3769
src/preparser.h:3769: if (is_strict(language_mode()) ||
allow_harmony_sloppy()) {
On 2015/07/10 12:13:17,
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1215273003/60001
https://codereview.chromium.org/1215273003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
Reviewers: Igor Sheludko,
Message:
ptal
Description:
Reload the map of typed arrays after performing ToNumber.
BUG=chromium:507980
LOG=n
Please review this at https://codereview.chromium.org/1234553002/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+22, -5
Reviewers: Jakob,
Message:
PTAL
Description:
[arm64] Fixed unnecessary environment assignment to lithium instruction.
BUG=chromium:490021
LOG=N
Please review this at https://codereview.chromium.org/1235563002/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+5,
Comment #7 on issue 4177 by verwa...@chromium.org: Arguments object
property descriptor errors
https://code.google.com/p/v8/issues/detail?id=4177
I don't think this has ever worked. When I moved the code I only saw the
creation of the alias on reconfigure. Set itself always just wrote into
LGTM.
https://codereview.chromium.org/1230183002/diff/1/src/assembler.cc
File src/assembler.cc (left):
https://codereview.chromium.org/1230183002/diff/1/src/assembler.cc#oldcode287
src/assembler.cc:287: // pc-jump (variable length):
Should we preserve the description of the variable
Looking almost good. Sorry I overlooked the missing SameValue[Zero]
adaptation
earlier.
https://codereview.chromium.org/1219943002/diff/210001/test/mjsunit/harmony/reflect-apply.js
File test/mjsunit/harmony/reflect-apply.js (right):
LGTM modulo comment
https://codereview.chromium.org/1234433002/diff/20001/test/mjsunit/harmony/block-function-sloppy.js
File test/mjsunit/harmony/block-function-sloppy.js (right):
https://codereview.chromium.org/1234433002/diff/20001/test/mjsunit/harmony/block-function-sloppy.js#newcode30
Committed patchset #2 (id:20001)
https://codereview.chromium.org/1229673005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and
1 - 100 of 263 matches
Mail list logo
