LGTM
To maintain some symmetry, we should also unship spread calls (now that both
rest and spread arrays are gone). Can you include that in this CL?
Also, please retitle the CL to Unship for clarity.
https://codereview.chromium.org/1230773005/
--
--
v8-dev mailing list
Reviewers: Jakob,
Message:
ptal.
Hopefully the try-jobs cycle green now ...
Description:
Remove temporary hack re deleting hidden properties
BUG=
Please review this at https://codereview.chromium.org/123002/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files
Committed patchset #4 (id:50001)
https://codereview.chromium.org/1235603002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1235603002/50001
https://codereview.chromium.org/1235603002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
LGTM, just one nit:
Left Simd tests in reflect-apply.js, since it's also in tests/harmony.
Yes. However, the reflect tests will eventually be promoted to es6/, while
SIMD
would move somewhere else. (Maybe this is not the ideal structure moving
forward, but let's keep it for now.)
With an all-can-read property you can still return whatever you want for
iframes
that don't have access. See
Reviewers: Jakob,
Message:
ptal
Description:
Remove map-copying for global objects. This was an old (broken) requirement
that
has been fixed for a while.
BUG=
Please review this at https://codereview.chromium.org/1235113002/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
lgtm
https://codereview.chromium.org/1235983002/diff/1/src/compiler/ast-graph-builder.cc
File src/compiler/ast-graph-builder.cc (right):
https://codereview.chromium.org/1235983002/diff/1/src/compiler/ast-graph-builder.cc#newcode1649
src/compiler/ast-graph-builder.cc:1649: // TODO(conradw):
https://codereview.chromium.org/1240463002/diff/1/src/scopes.cc
File src/scopes.cc (right):
https://codereview.chromium.org/1240463002/diff/1/src/scopes.cc#newcode1369
src/scopes.cc:1369:
outer_scope()-DeclarationScope()-AllocateStackSlot(var);
On 2015/07/13 16:00:51, caitp wrote:
Won't
But obviously it's still visibly different from what Boris suggests, given
that
the property is there.
As I've suggested in another thread, we *could* use all-can-read
interceptors to
achieve both all-can-read and absent, but that's kinda ugly ... We could
support
invisible all-can-read
Status: Untriaged
Owner:
New issue 4299 by rain1...@gmail.com: extremely poor performance when deal
with many object with different keys
https://code.google.com/p/v8/issues/detail?id=4299
tested in nodejs v0.12
for(var i=0; i10; i++){
var obj = {};
obj[Math.random()] = true;
}
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/123002/20001
https://codereview.chromium.org/123002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
Committed patchset #1 (id:1)
https://codereview.chromium.org/1235113002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop
Patchset 1 (id:??) landed as
https://crrev.com/0cfb44e27d35334ffbb71410beecf16132d4e225
Cr-Commit-Position: refs/heads/master@{#29640}
https://codereview.chromium.org/1235113002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
Patchset 1 (id:??) landed as
https://crrev.com/0b6af2c4150bfb0f50d369c463ed9cb35fd3e940
Cr-Commit-Position: refs/heads/master@{#29642}
https://codereview.chromium.org/1228923003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
Committed patchset #1 (id:1)
https://codereview.chromium.org/1237013002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1241613003/20001
https://codereview.chromium.org/1241613003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
https://codereview.chromium.org/1221433021/diff/50001/BUILD.gn
File BUILD.gn (right):
https://codereview.chromium.org/1221433021/diff/50001/BUILD.gn#newcode1479
BUILD.gn:1479: src/hase/smart-pointers.h,
s/hase/base
I'll upload a patch and back-merge to the roll.
Committed patchset #1 (id:1) manually as
8f06fc455c3c895179d08fddd3e1a09865499524.
https://codereview.chromium.org/1233093002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups
Committed patchset #1 (id:1) manually as
c5e3a96b83741115bf25847ed23bc20f0daf55f7.
https://codereview.chromium.org/1228353003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups
lgtm
https://codereview.chromium.org/1228803005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Reviewers: Benedikt Meurer,
Description:
[turbofan] Build graphs for super constructor calls.
This adapts JSCallConstruct nodes to represent both, ordinary 'new'
constructor calls as well as 'super' constructor calls. Note that we
still bailout for super calls for now.
R=bmeu...@chromium.org
lgtm
https://codereview.chromium.org/1233073003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Comment #53 on issue 4137 by bugdro...@chromium.org: Support elements in
the LookupIterator
https://code.google.com/p/v8/issues/detail?id=4137#c53
The following revision refers to this bug:
https://chromium.googlesource.com/v8/v8.git/+/170896e6bff8773895e10b68d8f28c10e46ac46f
commit
Committed patchset #1 (id:1)
https://codereview.chromium.org/1234573003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop
Patchset 1 (id:??) landed as
https://crrev.com/33593da46c7716820c19d99868fdafd25251c08a
Cr-Commit-Position: refs/heads/master@{#29637}
https://codereview.chromium.org/1234573003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
Committed patchset #1 (id:1)
https://codereview.chromium.org/1228353004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop
lgtm
https://codereview.chromium.org/1228353003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Patchset 2 (id:??) landed as
https://crrev.com/b204a91033e42842da4d7504a8be5531ea6210ed
Cr-Commit-Position: refs/heads/master@{#29639}
https://codereview.chromium.org/123002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
Committed patchset #2 (id:20001)
https://codereview.chromium.org/123002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1228923003/20001
https://codereview.chromium.org/1228923003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
lgtm
https://codereview.chromium.org/1232383003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1237013002/1
https://codereview.chromium.org/1237013002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
lgtm
https://codereview.chromium.org/1228923003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1233033004/1
https://codereview.chromium.org/1233033004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
Committed patchset #1 (id:1)
https://codereview.chromium.org/1233033004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop
Patchset 1 (id:??) landed as
https://crrev.com/f3b843bb98e1cf0383f0410bfa274d159f242936
Cr-Commit-Position: refs/heads/master@{#29644}
https://codereview.chromium.org/1233033004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1238533003/40001
https://codereview.chromium.org/1238533003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
Patchset 3 (id:??) landed as
https://crrev.com/170896e6bff8773895e10b68d8f28c10e46ac46f
Cr-Commit-Position: refs/heads/master@{#29645}
https://codereview.chromium.org/1238533003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
Committed patchset #3 (id:40001)
https://codereview.chromium.org/1238533003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and
Reviewers: Hablich,
Description:
Version 4.6.3.1 (cherry-pick)
Merged 33593da46c7716820c19d99868fdafd25251c08a
[Sheriff] Fix gn build.
TBR=habl...@chromium.org
BUG=
Please review this at https://codereview.chromium.org/1233093002/
Base URL: https://chromium.googlesource.com/v8/v8.git@4.6.3
looks good
https://codereview.chromium.org/1234833003/diff/20001/src/ia32/assembler-ia32-inl.h
File src/ia32/assembler-ia32-inl.h (right):
https://codereview.chromium.org/1234833003/diff/20001/src/ia32/assembler-ia32-inl.h#newcode78
src/ia32/assembler-ia32-inl.h:78: return;
I think it is
Reviewers: Igor Sheludko,
Message:
ptal
Description:
Replace Set*Callback with TransitionToAccessorPair
BUG=v8:4137
LOG=n
Please review this at https://codereview.chromium.org/1228803005/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+24, -85 lines):
M
lgtm
https://codereview.chromium.org/1230403003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Committed patchset #1 (id:1)
https://codereview.chromium.org/1232383003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop
Patchset 1 (id:??) landed as
https://crrev.com/4fc51603b775c99a633a70a93cee1f592854927a
Cr-Commit-Position: refs/heads/master@{#29643}
https://codereview.chromium.org/1237013002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
lgtm
https://codereview.chromium.org/1238533003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/1234023003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/1235113002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/1237013002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1232383003/1
https://codereview.chromium.org/1232383003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
Reviewers: Igor Sheludko,
Message:
ptal
Description:
Remove duplicate flattening. Defining accessors doesn't call out, so don't
assert that the context doesn't change.
BUG=v8:4137
LOG=n
Please review this at https://codereview.chromium.org/1233073003/
Base URL:
Reviewers: Hablich,
Description:
Version 4.6.4.1 (cherry-pick)
Merged 33593da46c7716820c19d99868fdafd25251c08a
[Sheriff] Fix gn build.
TBR=habl...@chromium.org
BUG=
Please review this at https://codereview.chromium.org/1229733004/
Base URL: https://chromium.googlesource.com/v8/v8.git@4.6.4
Updates:
Status: PendingFurtherInfo
Cc: habl...@chromium.org
Labels: Type-FeatureRequest Performance Priority-Medium Area-Compiler
Comment #2 on issue 4299 by habl...@chromium.org: extremely poor
performance when deal with many object with different keys
Reviewers: Igor Sheludko,
Message:
ptal
Description:
Properly handle missing from normalized stores with keys convertible to
array
indices
BUG=chromium:509961
LOG=n
Please review this at https://codereview.chromium.org/1241613003/
Base URL:
Committed patchset #1 (id:1) manually as
30a56da82c085689fddbc21e2124670451862509.
https://codereview.chromium.org/1229733004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1228353004/1
https://codereview.chromium.org/1228353004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
Reviewers: Michael Starzinger,
Description:
Fix test case for crbug/507070.
--debug-code causes full-codegen on arm64 to emit different number
of calls, which confuses the debugger when on-stack replacing code
with recompiled debug version on-stack.
BUG=chromium:507070
Reviewers: jochen, rmcilroy, Hablich,
Message:
TBR
Description:
[Sheriff] Fix gn build.
TBR=joc...@chromium.org, rmcil...@chromium.org, habl...@chromium.org
NOTRY=true
Please review this at https://codereview.chromium.org/1234573003/
Base URL:
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1234573003/1
https://codereview.chromium.org/1234573003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
lgtm
https://codereview.chromium.org/1234573003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Patchset 1 (id:??) landed as
https://crrev.com/541aa57718ecdd0ff192e89e76c5140cd2ad2a5d
Cr-Commit-Position: refs/heads/master@{#29638}
https://codereview.chromium.org/1228353004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
lgtm
https://codereview.chromium.org/123002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1235113002/1
https://codereview.chromium.org/1235113002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
lgtm
https://codereview.chromium.org/1233033004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
https://codereview.chromium.org/1221433021/diff/50001/BUILD.gn
File BUILD.gn (right):
https://codereview.chromium.org/1221433021/diff/50001/BUILD.gn#newcode1479
BUILD.gn:1479: src/hase/smart-pointers.h,
On 2015/07/14 08:35:35, Michael Achenbach wrote:
s/hase/base
I'll upload a patch and
Reviewers: Igor Sheludko,
Message:
ptal
api accessors (AccessorInfo) still needs to be migrated entirely, so for now
I'll have to keep Set*Callback.
Description:
Use the LookupIterator to transition to elements accessors
BUG=v8:4137
LOG=n
Please review this at
Committed patchset #1 (id:20001)
https://codereview.chromium.org/1228923003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and
Patchset 1 (id:??) landed as
https://crrev.com/5c95669436ca59479b404f5519bee65fe0658ad6
Cr-Commit-Position: refs/heads/master@{#29641}
https://codereview.chromium.org/1232383003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
Comment #1 on issue 4299 by verwa...@chromium.org: extremely poor
performance when deal with many object with different keys
https://code.google.com/p/v8/issues/detail?id=4299
What about using new Map rather than {}?
--
You received this message because this project is configured to send
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1228803005/1
https://codereview.chromium.org/1228803005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
lgtm
https://codereview.chromium.org/1241613003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/1229733004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Committed patchset #2 (id:20001)
https://codereview.chromium.org/1235983002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and
Comment #59 on issue 3956 by bugdro...@chromium.org: Implement strong mode
https://code.google.com/p/v8/issues/detail?id=3956#c59
The following revision refers to this bug:
https://chromium.googlesource.com/v8/v8.git/+/f996793ec0be128599988671825f469eaf82
commit
Patchset 2 (id:??) landed as
https://crrev.com/f996793ec0be128599988671825f469eaf82
Cr-Commit-Position: refs/heads/master@{#29646}
https://codereview.chromium.org/1235983002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
Reviewers: mvstanton,
Message:
Note that this only contains the ARM port, but I wanted to get your general
opinion on this early, before doing the ports.
Description:
Switch CallConstructStub to take new.target in register.
This changes the calling convention of the CallConstructStub to take
Comment #3 on issue 4299 by rain1...@gmail.com: extremely poor performance
when deal with many object with different keys
https://code.google.com/p/v8/issues/detail?id=4299
using 'new Map' is not work.
use 'obj={k:1}; delete obj.k' can do the trick,
however, if we want to parse data from
Paul, could you help me with the MIPS/MIPS64 ports?
https://codereview.chromium.org/1234833003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe
https://codereview.chromium.org/1235983002/diff/1/src/compiler/ast-graph-builder.cc
File src/compiler/ast-graph-builder.cc (right):
https://codereview.chromium.org/1235983002/diff/1/src/compiler/ast-graph-builder.cc#newcode1649
src/compiler/ast-graph-builder.cc:1649: // TODO(conradw): It would
Comment #54 on issue 4137 by bugdro...@chromium.org: Support elements in
the LookupIterator
https://code.google.com/p/v8/issues/detail?id=4137#c54
The following revision refers to this bug:
https://chromium.googlesource.com/v8/v8.git/+/103675d68b77c125580f74b2dd12951127f4bc99
commit
Patchset 1 (id:??) landed as
https://crrev.com/103675d68b77c125580f74b2dd12951127f4bc99
Cr-Commit-Position: refs/heads/master@{#29649}
https://codereview.chromium.org/1228803005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
Status: Untriaged
Owner:
New issue 4300 by frank.br...@rz.uni-regensburg.de: One-line summary
https://code.google.com/p/v8/issues/detail?id=4300
Version: v0.12.0
OS: opensuse, cygwin, debian, I beliefe any
Architecture: x64
I discovered a numerical error in V8 with node and posted it on
lgtm
https://codereview.chromium.org/1237753004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Reviewers: Igor Sheludko,
Message:
ptal. I'll only land if the bots cycle green.
SetAccessor is internal, and could be done with defineProperty which
reconfigures rather than setting, so it would ignore readonly...
Description:
Allow setting accessor infos over read-only but configurable
Patchset 2 (id:??) landed as
https://crrev.com/9cf1c58145403ba63b7546dd3eff7ef80649acea
Cr-Commit-Position: refs/heads/master@{#29647}
https://codereview.chromium.org/1234023003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
Committed patchset #2 (id:20001)
https://codereview.chromium.org/1234023003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and
Reviewers: danno, Michael Achenbach, Sven Panne, Jakob, paul.l...,
dusmil.imgtec, akos.palfi.imgtec,
Message:
We would like to use Xcode/mac for development. V8-team reviewers, please
take a
look. These changes have got lgtm in
https://codereview.chromium.org/1133163005/#ps160001
but were
LGTM
https://codereview.chromium.org/1237753004/diff/1/build/standalone.gypi
File build/standalone.gypi (right):
https://codereview.chromium.org/1237753004/diff/1/build/standalone.gypi#newcode795
build/standalone.gypi:795: ]
nit: trailing ',' for consistency
Patchset 2 (id:??) landed as
https://crrev.com/5f24690384284a2d24cd3974de491e49bdec077f
Cr-Commit-Position: refs/heads/master@{#29648}
https://codereview.chromium.org/1241613003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
Committed patchset #2 (id:20001)
https://codereview.chromium.org/1241613003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and
Committed patchset #1 (id:1)
https://codereview.chromium.org/1228803005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop
https://codereview.chromium.org/1234833003/diff/20001/src/ia32/assembler-ia32-inl.h
File src/ia32/assembler-ia32-inl.h (right):
https://codereview.chromium.org/1234833003/diff/20001/src/ia32/assembler-ia32-inl.h#newcode78
src/ia32/assembler-ia32-inl.h:78: return;
On 2015/07/14 09:12:45, ulan
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1234023003/20001
https://codereview.chromium.org/1234023003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1235983002/20001
https://codereview.chromium.org/1235983002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
LGTM (rubber-stamped).
https://codereview.chromium.org/1228353004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop
Updates:
Labels: Area-Infrastructure
Comment #1 on issue 4301 by habl...@chromium.org: Fix race in
merge_to_branch for simultaneous merge processes
https://code.google.com/p/v8/issues/detail?id=4301
Opt-in for the workaround. This problem does not occur that often to invest
more
On 2015/07/14 13:55:42, Igor Sheludko wrote:
PTAL
For some reason this updated test now fails the same way on x64.optdebug
(only):
#
# Fatal error in ../src/debug.cc, line 228
# Check failed: code()-has_debug_break_slots().
#
https://codereview.chromium.org/1231893007/
--
--
v8-dev
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1236523004/60001
https://codereview.chromium.org/1236523004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
Patchset 3 (id:??) landed as
https://crrev.com/bf61b05b3ef55a668bef405563032d88e2ce1002
Cr-Commit-Position: refs/heads/master@{#29651}
https://codereview.chromium.org/1236523004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
1 - 100 of 263 matches
Mail list logo
