Reviewers: Michael Starzinger,
Description:
[turbofan] Gracefully handle missing info()-context() in
CodeGenerator::IsMaterializableFromFrame()
R=mstarzin...@chromium.org
BUG=
Please review this at https://codereview.chromium.org/1292233004/
Base URL:
On 2015/08/13 15:21:52, jochen (ooo) wrote:
lgtm so far
Will commit.
The rebase + back-and-forth with 'all platforms' makes this look a bit odd,
but
the only change versus the lgtm-ed Patch Set 1 is a one-line change in
startup-data-util.cc.
Also, this should revert cleanly (discussed w/
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1292053002/11
View timeline at
https://chromium-cq-status.appspot.com/patch-timeline/1292053002/11
https://codereview.chromium.org/1292053002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1292533003/1
View timeline at
https://chromium-cq-status.appspot.com/patch-timeline/1292533003/1
https://codereview.chromium.org/1292533003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
On 2015/08/13 14:57:36, Jakob wrote:
LGTM
https://codereview.chromium.org/1292533003/diff/1/src/debug/debug.cc
File src/debug/debug.cc (right):
https://codereview.chromium.org/1292533003/diff/1/src/debug/debug.cc#newcode1959
src/debug/debug.cc:1959: HandleObject argv[] =
Patchset 1 (id:??) landed as
https://crrev.com/c47d9d07e7facd49e828be1c38f0e53bd61f0d1c
Cr-Commit-Position: refs/heads/master@{#30170}
https://codereview.chromium.org/1292533003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
Committed patchset #1 (id:1)
https://codereview.chromium.org/1292533003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop
On 2015/08/14 05:06:34, Benedikt Meurer wrote:
On 2015/08/13 18:04:50, adamk wrote:
The CL description says this builtin is useless, but the fast path for
arrays
was added as a fix for a performance bug:
https://code.google.com/p/v8/issues/detail?id=3701
If this removal is part of a broader
lgtm with small nit
https://codereview.chromium.org/1289603002/diff/140001/src/snapshot/serialize.h
File src/snapshot/serialize.h (right):
https://codereview.chromium.org/1289603002/diff/140001/src/snapshot/serialize.h#newcode404
src/snapshot/serialize.h:404: static const int kVariableRepeat =
On 2015/08/13 18:35:43, domenic wrote:
On 2015/08/13 at 12:35:31, yangguo wrote:
LGTM, but it would be very nice if we had a test case for experimental
extras
as well.
Test added. Looks like it won't let me run tryjobs until the previous
patch
lands though.
still lgtm.
https://codereview.chromium.org/1288413002/diff/1/src/heap/mark-compact.h
File src/heap/mark-compact.h (right):
https://codereview.chromium.org/1288413002/diff/1/src/heap/mark-compact.h#newcode208
src/heap/mark-compact.h:208: void DecrementLiveBytes(HeapObject*
object);
On 2015/08/14 05:05:48,
Reviewers: Hannes Payer,
Message:
It's dead, Jim!
Description:
[heap] Get rid of unused regexp includes.
BUG=
Please review this at https://codereview.chromium.org/1290403002/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+0, -17 lines):
M src/heap/heap.cc
On 2015/08/14 13:09:14, Hannes Payer wrote:
On 2015/08/14 12:44:36, Michael Lippautz wrote:
lgtm, I like it. Let's wait for Hannes.
https://codereview.chromium.org/1293773002/diff/20001/src/heap/mark-compact-inl.h
File src/heap/mark-compact-inl.h (right):
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1293793002/20001
View timeline at
https://chromium-cq-status.appspot.com/patch-timeline/1293793002/20001
https://codereview.chromium.org/1293793002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
https://codereview.chromium.org/1293773002/diff/20001/src/heap/mark-compact-inl.h
File src/heap/mark-compact-inl.h (right):
https://codereview.chromium.org/1293773002/diff/20001/src/heap/mark-compact-inl.h#newcode26
src/heap/mark-compact-inl.h:26: void
Committed patchset #2 (id:20001)
https://codereview.chromium.org/1293793002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and
Patchset 2 (id:??) landed as
https://crrev.com/0c5fbd393e05da87688bdf2ab429254e5023a73f
Cr-Commit-Position: refs/heads/master@{#30178}
https://codereview.chromium.org/1293793002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
Reviewers: Benedikt Meurer, Jarin, titzer,
Message:
PTAL, I think it's ready to go
Description:
[turbofan]: Unify referencing of stack slots
Previously, it was not possible to specify StackSlotOperands for all
slots in both the caller and callee stacks. Specifically, the region
of the callee's
On 2015/08/14 13:59:24, Michael Starzinger wrote:
lgtm.
https://codereview.chromium.org/1294783002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
https://codereview.chromium.org/1293773002/diff/20001/src/heap/mark-compact-inl.h
File src/heap/mark-compact-inl.h (right):
https://codereview.chromium.org/1293773002/diff/20001/src/heap/mark-compact-inl.h#newcode26
src/heap/mark-compact-inl.h:26: void
Reviewers: Jakob,
Description:
Clean up native context slots and add new ones.
Newly added native context slots are used to avoid accessing
the js builtins object to get native functions.
R=jkumme...@chromium.org
Please review this at https://codereview.chromium.org/1294583006/
Base URL:
Reviewers: Yang,
Description:
Remove grab-bag includes of v8.h from regexp engine.
R=yang...@chromium.org
Please review this at https://codereview.chromium.org/1294783002/
Base URL:
https://chromium.googlesource.com/v8/v8.git@local_cleanup-includes-ic
Affected files (+11, -31 lines):
M
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1292743002/1
View timeline at
https://chromium-cq-status.appspot.com/patch-timeline/1292743002/1
https://codereview.chromium.org/1292743002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
lgtm
https://codereview.chromium.org/1292743002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Reviewers: Jakob,
Description:
No longer use js builtins object as receiver for calls into JS.
This is no longer necessary. Everything the callee needs should
be in its context chain.
R=jkumme...@chromium.org
Please review this at https://codereview.chromium.org/1289203003/
Base URL:
lgtm
https://codereview.chromium.org/1288413002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Patchset 2 (id:??) landed as
https://crrev.com/16f96fde6b935c5f9a9d031f5df9809a814242ce
Cr-Commit-Position: refs/heads/master@{#30171}
https://codereview.chromium.org/1288413002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
Committed patchset #2 (id:20001)
https://codereview.chromium.org/1288413002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and
Looks great to me (once tests are added). Maybe let Michael have a look too?
For tests, how about adding a cctest (we probably do this as a unittests)
which
compiles JS source and checks if the resulting bytecode is as expected?
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1288413002/20001
View timeline at
https://chromium-cq-status.appspot.com/patch-timeline/1288413002/20001
https://codereview.chromium.org/1288413002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
Reviewers: Yang,
Description:
Remove grab-bag includes of v8.h from several files.
R=yang...@chromium.org
Please review this at https://codereview.chromium.org/1297583002/
Base URL:
https://chromium.googlesource.com/v8/v8.git@local_cleanup-includes-heap-1
Affected files (+64, -53 lines):
On 2015/08/14 08:51:21, Michael Starzinger wrote:
lgtm.
https://codereview.chromium.org/1297583002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Thanks for the review. Comments addressed, PTAL.
https://codereview.chromium.org/1289863003/diff/20001/src/compiler/interpreter-assembler.h
File src/compiler/interpreter-assembler.h (right):
https://codereview.chromium.org/1289863003/diff/20001/src/compiler/interpreter-assembler.h#newcode40
Reviewers: Michael Starzinger, oth,
Message:
Michael, Orion, could you take a look please? Thanks.
Description:
[Interpreter] Add implementations for load immediate bytecodes.
Adds implementations and tests for the following bytecodes:
- LdaZero
- LdaSmi8
- LdaUndefined
- LdaNull
-
lgtm
https://codereview.chromium.org/1294583006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1292743002/1
View timeline at
https://chromium-cq-status.appspot.com/patch-timeline/1292743002/1
https://codereview.chromium.org/1292743002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
Patchset 1 (id:??) landed as
https://crrev.com/9da3ab661fe7190fcb99bd99db30cf95913d3659
Cr-Commit-Position: refs/heads/master@{#30179}
https://codereview.chromium.org/1292743002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1294783002/1
View timeline at
https://chromium-cq-status.appspot.com/patch-timeline/1294783002/1
https://codereview.chromium.org/1294783002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
lgtm
https://codereview.chromium.org/1209223005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Committed patchset #1 (id:1)
https://codereview.chromium.org/1292743002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop
Try jobs failed on following builders:
v8_presubmit on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/4924)
https://codereview.chromium.org/1292743002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1294583006/1
View timeline at
https://chromium-cq-status.appspot.com/patch-timeline/1294583006/1
https://codereview.chromium.org/1294583006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
Updates:
Status: WontFix
Owner: ad...@chromium.org
Labels: Area-Compiler
Comment #3 on issue 3260 by ad...@chromium.org: Promote Typed Array
elements as native registers
https://code.google.com/p/v8/issues/detail?id=3260
I don't think this is something we want to do
Patchset 1 (id:??) landed as
https://crrev.com/2421f9c39b82e4324e11e58c9ff7f159766a565b
Cr-Commit-Position: refs/heads/master@{#30180}
https://codereview.chromium.org/1294783002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
Committed patchset #1 (id:1)
https://codereview.chromium.org/1294783002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop
https://codereview.chromium.org/1274453002/diff/1/src/heap/spaces.cc
File src/heap/spaces.cc (right):
https://codereview.chromium.org/1274453002/diff/1/src/heap/spaces.cc#newcode1410
src/heap/spaces.cc:1410:
heap()-incremental_marking()-Step(bytes_allocated,
On 2015/08/14 05:26:30, Hannes Payer
Updates:
Cc: -da...@chromium.org
Labels: Area-Language
Comment #9 on issue 705 by ad...@chromium.org: Non-enumerable property
fails to shadow inherited enumerable property from for-in
https://code.google.com/p/v8/issues/detail?id=705
(No comment was entered for this change.)
Updates:
Status: Available
Owner: ---
Labels: Area-Language Type-Bug Priority-Medium
Comment #5 on issue 3738 by ad...@chromium.org: Inconsistent rounding in
float parser
https://code.google.com/p/v8/issues/detail?id=3738
(No comment was entered for this change.)
--
Reviewers: Hannes Payer,
Message:
Hannes: could you please take a look, thanks.
Description:
[Interpreter] Move interpreter initialization until after snapshot
deserialization.
The interpreter needs to be initialized after the snapshot has been
deserialized.
BUG=v8:4280
LOG=N
Please review
Committed patchset #1 (id:1)
https://codereview.chromium.org/1294583006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop
Patchset 1 (id:??) landed as
https://crrev.com/e4c286900e29647f5ac3cd49d63d06bbfb98d078
Cr-Commit-Position: refs/heads/master@{#30181}
https://codereview.chromium.org/1294583006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1290963005/1
View timeline at
https://chromium-cq-status.appspot.com/patch-timeline/1290963005/1
https://codereview.chromium.org/1290963005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
Updates:
Status: Available
Owner: ---
Labels: Area-Language Performance Priority-Low
Comment #2 on issue 3533 by ad...@chromium.org: DataView methods are 40X
slower than corresponding TypedArray methods
https://code.google.com/p/v8/issues/detail?id=3533
(No comment
Try jobs failed on following builders:
v8_linux64_avx2_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel/builds/3287)
v8_linux_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel/builds/8572)
On 2015/08/14 at 19:28:17, commit-bot wrote:
Try jobs failed on following builders:
v8_linux64_avx2_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel/builds/3287)
v8_linux_rel on tryserver.v8 (JOB_FAILED,
Comment #5 on issue 4099 by little...@chromium.org: run-tests.py doesn't
work with goma/ninja builds
https://code.google.com/p/v8/issues/detail?id=4099
domenic, how did you build it? With that gm command, I get something in the
right directory, and then I don't even have to use the
On 2015/08/14 19:33:57, domenic wrote:
On 2015/08/14 at 19:28:17, commit-bot wrote:
Try jobs failed on following builders:
v8_linux64_avx2_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel/builds/3287)
v8_linux_rel on tryserver.v8
Reviewers: adamk,
Message:
This is currently more of an RFC because of the indeterminate performance
impact. It should not be merged before the 46 branch.
Description:
Sloppy-mode let parsing
This patch makes 'let' a contextual keyword in both strict and sloppy mode.
It behaves as a keyword
Patchset 9 (id:??) landed as
https://crrev.com/46d342523e39173b064870d89c68f6b90b0175fb
Cr-Commit-Position: refs/heads/master@{#30183}
https://codereview.chromium.org/1289603002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
Committed patchset #9 (id:170001)
https://codereview.chromium.org/1289603002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and
Updates:
Status: Fixed
Comment #3 on issue 4370 by ad...@chromium.org: Assignment to new.target
should be an early error
https://code.google.com/p/v8/issues/detail?id=4370
(No comment was entered for this change.)
--
You received this message because this project is configured to
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1284413002/40001
View timeline at
https://chromium-cq-status.appspot.com/patch-timeline/1284413002/40001
https://codereview.chromium.org/1284413002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
Updates:
Owner: joc...@chromium.org
Comment #4 on issue 2670 by ad...@chromium.org: Performance issue with
JavaScript ArrayBuffer in comparison to FireFox IE
https://code.google.com/p/v8/issues/detail?id=2670
Jochen recently did a bunch of work on TypedArray optimizations, this
Comment #51 on issue 90 by do.wer...@gmail.com: V8 doesn't stable sort
https://code.google.com/p/v8/issues/detail?id=90
#50: Oh cmon, are we at this silly net - reality - comparisonlevel now?
Pleas don't.
Or, in your words: I always used a knive THIS way and I saw in every other
family, a
LGTM. Thanks!
https://codereview.chromium.org/1286143009/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving
Updates:
Status: WontFix
Owner: ad...@chromium.org
Comment #3 on issue 2768 by ad...@chromium.org: SIGFPE (div by zero) when
running --log_gc --heap_stats
https://code.google.com/p/v8/issues/detail?id=2768
Closing, assuming this was fixed years ago. Feel free to reopen if
Updates:
Status: Available
Owner: ---
Labels: Debugger Area-Runtime
Comment #3 on issue 2495 by ad...@chromium.org: Incorrect function names on
certain stack traces
https://code.google.com/p/v8/issues/detail?id=2495
(No comment was entered for this change.)
--
You
Comment #4 on issue 4099 by dome...@chromium.org: run-tests.py doesn't work
with goma/ninja builds
https://code.google.com/p/v8/issues/detail?id=4099
I'm still confused how this is supposed to work:
$ tools/run-tests.py --arch-and-mode=x64.debug --buildbot
Running tests for x64.debug
Updates:
Status: WontFix
Owner: ad...@chromium.org
Cc: rossb...@chromium.org
Comment #8 on issue 838 by ad...@chromium.org: Function [[Call]] should
return Reference Type
https://code.google.com/p/v8/issues/detail?id=838
We won't ever make calls assignable, but we
Comment #50 on issue 90 by juli1.ha...@gmail.com: V8 doesn't stable sort
https://code.google.com/p/v8/issues/detail?id=90
#48 performance is the disadvantage. As the number of items in the array
grows, stable sorts perform worst and worst for a variety of reasons, from
algorithm complexity
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1289603002/170001
View timeline at
https://chromium-cq-status.appspot.com/patch-timeline/1289603002/170001
https://codereview.chromium.org/1289603002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
Comment #2 on issue 4370 by bugdro...@chromium.org: Assignment to
new.target should be an early error
https://code.google.com/p/v8/issues/detail?id=4370#c2
The following revision refers to this bug:
https://chromium.googlesource.com/v8/v8.git/+/ef52836cd8c1340cf0c5054560fc936d6de1d25e
Reviewers: adamk, rossberg,
Message:
Hi, PTAL, I wanted to take on a smaller bug since it's been a few weeks.
Going to add a 2nd patch shortly to address the self-review I've done
https://codereview.chromium.org/1292393002/diff/1/src/preparser.h
File src/preparser.h (right):
Updates:
Status: Fixed
Owner: ad...@chromium.org
Comment #3 on issue 1714 by ad...@chromium.org: Early ReferenceErrors on
assignments to non-reference LHSs
https://code.google.com/p/v8/issues/detail?id=1714
V8 gives early errors for the following cases:
- Assignment
- Prefix
Comment #22 on issue 3453 by bugdro...@chromium.org: endless map growth
with --perf-basic-prof
https://code.google.com/p/v8/issues/detail?id=3453#c22
The following revision refers to this bug:
https://chromium.googlesource.com/v8/v8.git/+/9da3ab661fe7190fcb99bd99db30cf95913d3659
commit
Looking good, especially like that the ugliness is mostly contained in the
Scanner. Mostly naming concerns below.
https://codereview.chromium.org/1295883002/diff/60001/src/preparser.h
File src/preparser.h (right):
Actually, the performance runs didn't show a big regression: On
v8_linux64_haswell_perf_try, CodeLoad was up 0.1, and on
v8_linux32_perf_try,
CodeLoad was down just 0.4%. However, these tests seem to be very volatile.
Does
anyone have an idea for getting more reliable results before
https://codereview.chromium.org/1295883002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from it, send
Comment #4 on issue 3773 by jin...@google.com: V8 is not
-fsanitize=float-cast-overflow clean
https://code.google.com/p/v8/issues/detail?id=3773
Find a float-cast-overflow failure in src/conversions-inl.h,
src/conversions.h:
56: inline int FastD2I(double x) {
57: return
Reviewers: danno,
Description:
Update BitField3 type in gen-postmortem-metadata.py
Since https://codereview.chromium.org/272163002, BitField3 is a raw
uint32 field, and not a SMI anymore.
Update tools/gen-postmortem-metadata.py so that post-mortem tools can
work with versions of V8 that
Comment #52 on issue 90 by myf...@gmail.com: V8 doesn't stable sort
https://code.google.com/p/v8/issues/detail?id=90
Speaking in programming parables, you make a function that reads input and
returns output. Function that does not read anything but its input,
especially does nothing random
Try jobs failed on following builders:
v8_linux_arm64_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel/builds/8594)
https://codereview.chromium.org/1292393002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
On 2015/08/15 02:48:35, caitp wrote:
On 2015/08/15 02:23:14, commit-bot: I haz the power wrote:
Try jobs failed on following builders:
v8_linux_arm64_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel/builds/8594)
The weird thing with
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1292393002/20001
View timeline at
https://chromium-cq-status.appspot.com/patch-timeline/1292393002/20001
https://codereview.chromium.org/1292393002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
lgtm
https://codereview.chromium.org/1292393002/diff/1/src/preparser.h
File src/preparser.h (right):
https://codereview.chromium.org/1292393002/diff/1/src/preparser.h#newcode3982
src/preparser.h:3982: : this-NewThrowSyntaxError(message, pos);
On 2015/08/14 17:06:17, caitp wrote:
I'm not
On 2015/08/15 01:06:15, adamk wrote:
lgtm
https://codereview.chromium.org/1292393002/diff/1/src/preparser.h
File src/preparser.h (right):
https://codereview.chromium.org/1292393002/diff/1/src/preparser.h#newcode3982
src/preparser.h:3982: : this-NewThrowSyntaxError(message, pos);
On
Status: Assigned
Owner: ad...@chromium.org
Labels: Type-Bug Priority-Low Harmony Area-Language
New issue 4373 by ad...@chromium.org: Non-reference expression on left-hand
side in for loop initializer should be a SyntaxError
https://code.google.com/p/v8/issues/detail?id=4373
V8 treats it as a
Patchset 1 (id:??) landed as
https://crrev.com/5d0e3b8b94316d0971f50552b77c38b9d60fa22f
Cr-Commit-Position: refs/heads/master@{#30182}
https://codereview.chromium.org/1290963005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
Committed patchset #1 (id:1)
https://codereview.chromium.org/1290963005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop
https://codereview.chromium.org/1292233004/diff/1/src/compiler/code-generator.cc
File src/compiler/code-generator.cc (right):
https://codereview.chromium.org/1292233004/diff/1/src/compiler/code-generator.cc#newcode535
src/compiler/code-generator.cc:535: if (!info()-parse_info()) return;
//
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1293493003/1
View timeline at
https://chromium-cq-status.appspot.com/patch-timeline/1293493003/1
https://codereview.chromium.org/1293493003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
lgtm
https://codereview.chromium.org/1293493003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Patchset 4 (id:??) landed as
https://crrev.com/c69e2eae548d4a68bb1b91032e9825709155a8c5
Cr-Commit-Position: refs/heads/master@{#30174}
https://codereview.chromium.org/1292053002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
On 2015/08/14 11:52:38, Michael Starzinger wrote:
https://codereview.chromium.org/1292233004/diff/1/src/compiler/code-generator.cc
File src/compiler/code-generator.cc (right):
https://codereview.chromium.org/1292233004/diff/1/src/compiler/code-generator.cc#newcode535
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1290393002/1
View timeline at
https://chromium-cq-status.appspot.com/patch-timeline/1290393002/1
https://codereview.chromium.org/1290393002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
On 2015/08/14 12:41:33, Jakob wrote:
As discussed.
For the Scripts' weak fixed array, it shouldn't matter when we clear
them; I
moved clearing those as well for consistency.
lgtm.
https://codereview.chromium.org/1290393002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
lgtm, I like it. Let's wait for Hannes.
https://codereview.chromium.org/1293773002/diff/20001/src/heap/mark-compact-inl.h
File src/heap/mark-compact-inl.h (right):
https://codereview.chromium.org/1293773002/diff/20001/src/heap/mark-compact-inl.h#newcode26
src/heap/mark-compact-inl.h:26: void
Reviewers: epertoso, jochen (ooo),
Description:
Default-enable external startup snapshot for, like, everywhere.
BUG=
Please review this at https://codereview.chromium.org/1209223005/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+1, -6 lines):
M
Reviewers: Jakob,
Description:
Remove grab-bag includes of v8.h from IC subsystem.
R=jkumme...@chromium.org
Please review this at https://codereview.chromium.org/1293793002/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+5, -95 lines):
M
LGTM!
https://codereview.chromium.org/1293793002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
1 - 100 of 123 matches
Mail list logo
