compile times from 1-2 hours to 10-15 minutes
> from clean.
>
> Let me know if you need some help with this.
>
> Kind regards,
>
> Graeme
>
> On 19 Sep 2024, at 18:02, Erik Corry wrote:
>
> Hi
>
> The compile times are killing me.
>
> Does anyone have g
edit a .h file.
--
Erik Corry
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups
"v8-dev" group.
To unsubscribe from this group and stop receiving emails from it,
Hi
Do people work on the same gerrit cl from multiple machines? I tried git
cl checkout but it doesn't work.
eg. for https://chromium-review.googlesource.com/c/v8/v8/+/5797602
$ cat ../.gclient
solutions = [
{
"name": "v8",
"url": "https://chromium.googlesource.com/v8/v8.git";,
"d
Yes. We plan to put in asserts to prevent it being used for pointer types.
On 4 December 2015 at 15:30, Jochen Eisinger wrote:
> thanks for the heads-up.
>
> Did you keep the bit_casts in fletch for non-pointer types?
>
> On Thu, Dec 3, 2015 at 2:34 PM 'Erik Corry&#x
Slava points out that I am writing about use of bit_cast for pointer types
(eg casting an Object** to a Class**), but ignoring the other use of
bit_cast (eg casting a float to a uint32_t). It's only the pointer types
that are problematic, I think.
On 3 December 2015 at 13:37, Erik Corry
e regression on Linux, but not on Mac and Windows
where I think it already is the default.
--
Erik Corry
Google Denmark ApS
Frederiksborggade 20B, 1 sal
1360 København K
Denmark
CVR nr. 28 86 69 84
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You
ts is
LoadCurrentCharacterUnchecked, which generates:
addiu t7, t2, cp_offset
addut5, t6, t7
lbu t3, 0(t5)
This should just be
addu t5, t6, t2
lbu t3, cp_offset(t5)
Probably fixing this won't be enough to let MIPS pass the test though.
There's other stuff going on there that I haven't
Reviewers: Yang,
Description:
Reland II of 'Optimize trivial regexp disjunctions' CL 1176453002
R=yang...@chromium.org
BUG=
Please review this at https://codereview.chromium.org/1180433003/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+251, -8 lines):
M src/a
Reviewers: Yang,
Description:
Reland of 'Optimize trivial regexp disjunctions' CL 1176453002
Original code review: https://codereview.chromium.org/1176453002/
TBR=yang...@chromium.org
BUG=chromium:482998
LOG=n
Please review this at https://codereview.chromium.org/1174713002/
Base URL: https:/
Reviewers: Yang,
Description:
Optimize trivial regexp disjunctions
R=yang...@chromium.org
BUG=chromium:482998
LOG=n
Please review this at https://codereview.chromium.org/1176453002/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+235, -4 lines):
M src/ast.h
M
LGTM
https://codereview.chromium.org/1147503002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from i
https://codereview.chromium.org/1147503002/diff/11/src/heap/spaces.cc
File src/heap/spaces.cc (right):
https://codereview.chromium.org/1147503002/diff/11/src/heap/spaces.cc#newcode659
src/heap/spaces.cc:659: commit_size > CodePageAreaSize()) {
The commit_size includes the CodePageGuardSt
On 2015/06/01 15:52:40, ulan wrote:
wow, lgtm.
After you removed the wrapping of tests and undefs, does this CL still
help
with
concatenation?
For now I will just not concatenate the affected files. It's quite hard to
automate namespace stuff. One unexpected thing I found was that this
https://codereview.chromium.org/1163803002/diff/1/src/background-parsing-task.cc
File src/background-parsing-task.cc (right):
https://codereview.chromium.org/1163803002/diff/1/src/background-parsing-task.cc#newcode75
src/background-parsing-task.cc:75: } // namespace v8
On 2015/06/01 13:08:24, u
Reviewers: Hannes Payer,
Description:
Tiny fix to grokdump heap stats printer
R=hpa...@chromium.org
BUG=
Please review this at https://codereview.chromium.org/1164693002/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+1, -1 lines):
M tools/grokdump.py
Index:
One solution would be to get large objects from the reserved code area, but
continue to get normal code pages from unreserved memory. Then you are not
imposing a 256Mbyte code limit on the platform, but only a 256Mbyte limit on
large code objects (> 1Mbyte).
https://codereview.chromium.org/11475
Reviewers: ulan,
Description:
Cosmetic changes to tests to make it easier to concatenate them.
When compiling on a laptop I like to concatenate the small test files.
This makes a big difference to compile times. These changes make that
easier.
R=u...@chromium.org
BUG=
Please review this at htt
Reviewers: Hannes Payer, szager1,
Description:
Remove spurious prints from GC logging
R=hpa...@chromium.org, sza...@chromium.org
BUG=
Please review this at https://codereview.chromium.org/1149413003/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+1, -1 lines):
Only large objects can span a 256Mbyte boundary, so an alternative
implementation would fix large-object allocation to reject allocations that
span
such a boundary. In this scenario you would not need to reserve code space
up
front and there would be n 256Mbyte limit on code size?
https://co
Reviewers: Hannes Payer,
Description:
Even without --trace-gc dump the last few GC messages on OOM
If we crash V8 due to out-of-memory then we print the last 3 GCs on
stdout as we crash. Also records the last 3 GCs on the stack so that
it will be part of the minidump.
R=hpa...@chromium.org
BUG=
Reviewers: ulan,
Description:
grokdump.py - some support for on-stack HeapStats
R=u...@chromium.org
BUG=
Please review this at https://codereview.chromium.org/1142343009/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+22, -4 lines):
M tools/grokdump.py
Index
Committed patchset #1 (id:1) manually as
85e92361bb42b9076ebdcb1c005fce9242bc5fe6.
https://codereview.chromium.org/1163563002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v
Reviewers: Hannes Payer,
Description:
Version 4.3.61.27 (cherry-pick)
Merged 49fdc5323
Be sure to abort incremental GC when trying to reserve space
R=hpa...@chromium.org
BUG=
Please review this at https://codereview.chromium.org/1163563002/
Base URL: https://chromium.googlesource.com/v8/v8.g
Committed patchset #1 (id:1) manually as
17db4ce193547f334c6cc63e27e1f9a0b434fcb7.
https://codereview.chromium.org/1157393002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v
Reviewers: Yang,
Description:
Version 4.3.61.26 (cherry-pick)
Merged 5a93a3304
Reland: Fix JSON parser Handle leak (previous CL 1041483004)
BUG=472504,v8:3976
LOG=N
R=yang...@chromium.org
Please review this at https://codereview.chromium.org/1157393002/
Base URL: https://chromium.googlesourc
Reviewers: Yang,
Description:
Version 4.3.61.26 (cherry-pick)
Merged 5a93a3304
Reland: Fix JSON parser Handle leak (previous CL 1041483004)
BUG=472504,v8:3976
LOG=N
R=yang...@chromium.org
Please review this at https://codereview.chromium.org/1159063003/
Base URL: https://chromium.googlesourc
Reviewers: Hannes Payer,
Description:
grokdump.py: work around int size limits on xrange
R=hpa...@chromium.org
BUG=
Please review this at https://codereview.chromium.org/1158933007/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+23, -15 lines):
M tools/grokdum
Reviewers: adamk, Toon Verwaest,
Description:
Random hashes with a more cache-friendly distribution
R=ad...@chromium.org, verwa...@chromium.org
BUG=
Please review this at https://codereview.chromium.org/1158083002/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+
Reviewers: adamk, Toon Verwaest,
Description:
Speed up object-keyed Map and Set by giving out sequential hash codes
R=ad...@chromium.org, verwa...@chromium.org
BUG=
Please review this at https://codereview.chromium.org/1157073002/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
A
https://codereview.chromium.org/1149863005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, sen
This changes global variables into variables in functions. I know we have
some
optimization for functions in globals that don't change. Do we lose some
optimizations by making them into outer-scope variables?
https://codereview.chromium.org/1154483002/
--
--
v8-dev mailing list
v8-dev@google
object-observe.js (right):
https://codereview.chromium.org/1149863005/diff/40001/src/object-observe.js#newcode210
src/object-observe.js:210: return
%WeakCollectionGet(GetObservationStateJS().objectInfoMap, object,
$gethash(object));
On 2015/05/21 20:19:02, Erik Corry wrote:
On 2015/05/21 19:11:32, adamk wrote:
>
https://codereview.chromium.org/1149863005/diff/40001/src/collection.js
File src/collection.js (left):
https://codereview.chromium.org/1149863005/diff/40001/src/collection.js#oldcode26
src/collection.js:26: for (var entry = HashToEntry(table, hash,
numBuckets);
On 2015/05/21 19:11:32, adamk wrot
Reviewers: adamk, toon_chromium.org,
Description:
Move hash code from hidden string to a private symbol
R=ad...@chromium.org, t...@chromium.org
BUG=
Please review this at https://codereview.chromium.org/1149863005/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+
Reviewers: Toon Verwaest,
Description:
Regularize namespace closing curlies
R=verwa...@chromium.org
BUG=
Please review this at https://codereview.chromium.org/1143133002/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+67, -67 lines):
M src/compiler/ast-loop-as
On 2015/05/15 16:13:34, Jakob wrote:
I don't remember the specifics; this is the CL that introduced that line:
https://codereview.chromium.org/70233010
This just happens to be the boundary between intptr_t and int64_t worlds.
On
32-bit platforms, we need to guard against overflow there. Why d
Reviewers: Dmitry Lomov (chromium),
Description:
Adjust benchmark framework to avoid spending 50% of time on 'new Date'
R=dslo...@chromium.org
BUG=
Please review this at https://codereview.chromium.org/1133843007/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+6
lgtm
https://codereview.chromium.org/1140693003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
https://codereview.chromium.org/1138643003/diff/1/src/heap/gc-idle-time-handler.cc
File src/heap/gc-idle-time-handler.cc (right):
https://codereview.chromium.org/1138643003/diff/1/src/heap/gc-idle-time-handler.cc#newcode141
src/heap/gc-idle-time-handler.cc:141: // The allocated new space limit
t
lgtm
https://codereview.chromium.org/1138643003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
https://codereview.chromium.org/1142493002/diff/1/src/collection.js
File src/collection.js (right):
https://codereview.chromium.org/1142493002/diff/1/src/collection.js#newcode85
src/collection.js:85: if (IS_SPEC_OBJECT(key)) {
On 2015/05/14 15:01:27, adamk wrote:
You might need a TODO here for
Surely it always caused a map transition. How else can you add the hidden
property?
The change was to make an already existing test pass, but I can add another.
https://codereview.chromium.org/1142493002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
--
On my microbenchmark this doubles the speed of common operations on ES6
Map. I
think it's a simplification too.
Before (times in ms):
Read 514
Update 1083
Set/delete 2075
After:
Read 231
Update 484
Set/delete 1619
The microbenchmark:
function MyKey() {
this.x = "foo";
}
function setu
Previous version at https://codereview.chromium.org/1134743002/ would:
* Reserve and commit 256k at start.
* Try to increase reservation and commit to up to 4MBytes when GCing.
* Uncommit and unreserve everything after GC <-- this was dumb
New tactic.
* Reserve 4Mbytes from start and never chan
New attempt at https://codereview.chromium.org/1133153003
https://codereview.chromium.org/1134743002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubsc
Moving everything to C++ would be one option, but not something I am
planning to
work on.
https://codereview.chromium.org/1137683003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google
I promise that nothing in Blink will depend on the new value. V8 already
has
some values here (3, 4, 5 and 6) that Blink knows nothing about, and that
works
now. It used to be the case that Blink was anal about it, but not recently.
https://codereview.chromium.org/1125383007/diff/1/src/hea
Unfortunately the crashes are still there and I can see why. This patch
does
not go far enough. Although we reserve some space already at startup we
unreserve it after each GC (in UncommitMarkingDeque) and then it can
potentially
fail at the next GC.
https://codereview.chromium.org/1134743
This is in Canary 2396
It is referenced from
https://code.google.com/p/chromium/issues/detail?id=486005
https://codereview.chromium.org/1105293004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed
This is part of canary 2397
https://codereview.chromium.org/1134743002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop
This is part of canary 2395
https://codereview.chromium.org/1124553007/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop
Argh! Wrong user. Moved to https://codereview.chromium.org/1134743002
https://codereview.chromium.org/1131893002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" grou
lgtm
https://codereview.chromium.org/1105293004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
Shouldn't you also fix the assert so it is before checking for emptiness?
https://codereview.chromium.org/1127113002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" gr
can_start_incremental_marking is false.
On 2015/05/06 09:47:19, ulan wrote:
On 2015/05/05 21:38:52, Erik Corry wrote:
> This contradiction indicates to me that
can_start_incremental_marking is
> misnamed.
Is should_start_incremental_marking better? I can rename it in a
separate CL.
Yes, we can do i
LGTM, if you have considered the things in comment 25 and a few missed
comments
futher up.
https://codereview.chromium.org/1105693002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google
https://codereview.chromium.org/1105293004/diff/11/src/heap/gc-idle-time-handler.cc
File src/heap/gc-idle-time-handler.cc (right):
https://codereview.chromium.org/1105293004/diff/11/src/heap/gc-idle-time-handler.cc#newcode198
src/heap/gc-idle-time-handler.cc:198: // In kReduceLatency mod
dev@googlegroups.com
> http://groups.google.com/group/v8-dev
> ---You received this message because you are subscribed to the Google
> Groups "v8-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to v8-dev+unsubscr...@googlegr
On 2015/04/29 03:43:10, Benedikt Meurer wrote:
On 2015/04/27 07:57:51, titzer wrote:
>
https://codereview.chromium.org/1105693002/diff/1/src/heap/identity-map.h
> File src/heap/identity-map.h (right):
>
>
https://codereview.chromium.org/1105693002/diff/1/src/heap/identity-map.h#newcode68
> s
I'm warming to this change/coming to terms with its inevitability.
Some non-blocking comments to consider.
* Please reconsider the 4x growth factor. It's caused by the resizing
heuristic
which is an unusual feature.
* Currently you can have a resize during a rehash. You should either be
s
My mistake. I had missed that the Rehash takes place on the compiler thread
after a failed lookup. Tricky!
https://codereview.chromium.org/1105693002/diff/60001/src/heap/heap.cc
File src/heap/heap.cc (right):
https://codereview.chromium.org/1105693002/diff/60001/src/heap/heap.cc#newcode5034
s
lgtm
https://codereview.chromium.org/1109133002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
https://codereview.chromium.org/1105693002/diff/60001/src/heap/identity-map.h
File src/heap/identity-map.h (right):
https://codereview.chromium.org/1105693002/diff/60001/src/heap/identity-map.h#newcode88
src/heap/identity-map.h:88: *(reinterpret_cast(GetEntry(key))) =
value;
This assignment take
lgtm
https://codereview.chromium.org/1108133003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
right):
https://codereview.chromium.org/1105693002/diff/20001/src/heap/identity-map.cc#newcode72
src/heap/identity-map.cc:72: Resize(); // Should only have to resize
once, since we grow 4x.
On 2015/04/27 16:32:50, titzer wrote:
On 2015/04/27 15:39:13, Erik Corry wrote:
> That's very agg
I'm going to stop here and ask a more fundamental question: We already have
HashTable from objects.h. Can't we add rehashing-on-GC to that instead of
adding code to the code base?
This implementation increases the number of roots, potentially quite a lot,
thus
making our atomic pauses at the s
lgtm
https://codereview.chromium.org/1107483003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
LGTM
https://codereview.chromium.org/1090963002/diff/20001/src/heap/gc-idle-time-handler.h
File src/heap/gc-idle-time-handler.h (right):
https://codereview.chromium.org/1090963002/diff/20001/src/heap/gc-idle-time-handler.h#newcode126
src/heap/gc-idle-time-handler.h:126: static const size_t
kMax
https://codereview.chromium.org/1081253005/diff/1/src/heap/incremental-marking.h
File src/heap/incremental-marking.h (right):
https://codereview.chromium.org/1081253005/diff/1/src/heap/incremental-marking.h#newcode106
src/heap/incremental-marking.h:106: static const intptr_t
kMarkingSpeedAccelle
https://codereview.chromium.org/996983003/diff/120001/src/heap/incremental-marking.h
File src/heap/incremental-marking.h (right):
https://codereview.chromium.org/996983003/diff/120001/src/heap/incremental-marking.h#newcode98
src/heap/incremental-marking.h:98: static const intptr_t
kAllocatedThre
I'm a bit late here, but:
https://codereview.chromium.org/1029093002/diff/140001/src/arm/code-stubs-arm.cc
File src/arm/code-stubs-arm.cc (right):
https://codereview.chromium.org/1029093002/diff/140001/src/arm/code-stubs-arm.cc#newcode2377
src/arm/code-stubs-arm.cc:2377: // Arguments register m
https://codereview.chromium.org/1049383004/diff/1/src/isolate.h
File src/isolate.h (right):
https://codereview.chromium.org/1049383004/diff/1/src/isolate.h#newcode990
src/isolate.h:990: return snapshot_blob_ != NULL &&
snapshot_blob_->raw_size != 0;
On 2015/04/01 17:02:13, vogelheim wrote:
When
chromium.org/1042483002/
>
> --
> --
> v8-dev mailing list
> v8-dev@googlegroups.com
> http://groups.google.com/group/v8-dev
> ---You received this message because you are subscribed to the Google Groups
> "v8-dev" group.
> To unsubscribe from this group and stop
lgtm
https://codereview.chromium.org/1034403002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
https://codereview.chromium.org/1034403002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, sen
The description looks wrong. These are synchronized operations, not atomic
ones.
https://codereview.chromium.org/1034163002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v
LGTM
https://codereview.chromium.org/998253006/diff/11/test/cctest/test-api.cc
File test/cctest/test-api.cc (right):
https://codereview.chromium.org/998253006/diff/11/test/cctest/test-api.cc#newcode3200
test/cctest/test-api.cc:3200: CHECK_EQ(initial_handle_count,
global_handles->global
lgtm
https://codereview.chromium.org/1020803004/diff/60001/src/hydrogen.cc
File src/hydrogen.cc (right):
https://codereview.chromium.org/1020803004/diff/60001/src/hydrogen.cc#newcode8652
src/hydrogen.cc:8652:
top_info()->closure()->context()->native_context()) {
You have this several places.
https://codereview.chromium.org/1020803004/diff/20001/src/ic/stub-cache.cc
File src/ic/stub-cache.cc (right):
https://codereview.chromium.org/1020803004/diff/20001/src/ic/stub-cache.cc#newcode120
src/ic/stub-cache.cc:120: if (entry(primary_, offset) == &primary_[i]) {
Apart from avoiding leaks t
https://codereview.chromium.org/998253006/diff/60001/include/v8-util.h
File include/v8-util.h (right):
https://codereview.chromium.org/998253006/diff/60001/include/v8-util.h#newcode328
include/v8-util.h:328: p.Reset();
Why do we have to create a Global, then immediately reset it?
https://codere
https://codereview.chromium.org/1026113004/diff/60001/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/1026113004/diff/60001/src/objects.cc#newcode8299
src/objects.cc:8299: length = array->Length();
Missing DCHECK from the single-argument version.
Did you try just doi
lgtm
https://codereview.chromium.org/1010363005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
https://codereview.chromium.org/1010363005/diff/140001/src/heap/mark-compact.h
File src/heap/mark-compact.h (right):
https://codereview.chromium.org/1010363005/diff/140001/src/heap/mark-compact.h#newcode366
src/heap/mark-compact.h:366: static void RemoveInvalidSlots(Heap* heap,
SlotsBuffer* buff
https://codereview.chromium.org/1026283004/diff/1/test/cctest/test-api.cc
File test/cctest/test-api.cc (right):
https://codereview.chromium.org/1026283004/diff/1/test/cctest/test-api.cc#newcode3244
test/cctest/test-api.cc:3244: CHECK_EQ(IntKeyToVoidPointer(key),
info.GetInternalField1());
The te
It's a good simplification.
We have 3 triggers for a GC when this lands:
IncrementalMarking: kActivationThreshold: 8Mbytes promoted
GCIdleTimeHandler: KIdleScavengeThreshold: 5 new-space GCs
Heap::OldGenerationAllocationLimit: Growth of 1.1x to 4x depending on
handles
freed at last GC.
LGTM
I think we'll take another look at it Monday.
One idea is to add up the unutilized idle times and use those to measure how
much time has gone. That way any test that controls the idle notifications
is
still deterministic on varying devices and system loads.
I'd like to get rid of the idea of
In terms of testability it's not great to add more time-based decision
making.
It would be good to get to a place where the test harness could call the
idle
API and there was no other time based decision making.
https://codereview.chromium.org/1023153002/diff/80001/src/heap/gc-idle-time-hand
https://codereview.chromium.org/1024823002/diff/20001/src/heap/mark-compact.cc
File src/heap/mark-compact.cc (right):
https://codereview.chromium.org/1024823002/diff/20001/src/heap/mark-compact.cc#newcode648
src/heap/mark-compact.cc:648: static const int
kMaxMaxEvacuationCandidates = 1;
On 2
res have been lost like
tears in the rain.
--
Erik Corry
Google UK Limited Registered Office: Belgrave House, 76 Buckingham
Palace Road, London SW1W 9TQ Registered in England Number: 3977902
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You rec
lgtm
https://codereview.chromium.org/1023673003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
https://codereview.chromium.org/1019243002/diff/1/src/heap/heap.h
File src/heap/heap.h (right):
https://codereview.chromium.org/1019243002/diff/1/src/heap/heap.h#newcode57
src/heap/heap.h:57: V(Map, cons_one_byte_string_map,
ConsOneByteStringMap) \
If these are frequent in
lgtm
https://codereview.chromium.org/1018283002/diff/20001/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/1018283002/diff/20001/src/objects.cc#newcode1703
src/objects.cc:1703: if (type->IsClass()) return
Map::WeakCellForMap(type->AsClass()->Map());
You could asser
lgtm
https://codereview.chromium.org/1005183006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
Looks basically sound
https://codereview.chromium.org/1005183006/diff/1/src/serialize.cc
File src/serialize.cc (right):
https://codereview.chromium.org/1005183006/diff/1/src/serialize.cc#newcode1875
src/serialize.cc:1875: DCHECK(code_object_);
I don't think you are allowed to use implicit bool
lgtm
https://codereview.chromium.org/989153003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
LGTM!
https://codereview.chromium.org/985453003/diff/150001/src/heap/mark-compact.cc
File src/heap/mark-compact.cc (right):
https://codereview.chromium.org/985453003/diff/150001/src/heap/mark-compact.cc#newcode3113
src/heap/mark-compact.cc:3113: // If the slot is within the first found
object i
https://codereview.chromium.org/985453003/diff/80001/src/heap/mark-compact.cc
File src/heap/mark-compact.cc (right):
https://codereview.chromium.org/985453003/diff/80001/src/heap/mark-compact.cc#newcode3095
src/heap/mark-compact.cc:3095: // Find the first live object in the
cell.
Shouldn't this
https://codereview.chromium.org/985453003/diff/80001/src/heap/mark-compact.cc
File src/heap/mark-compact.cc (right):
https://codereview.chromium.org/985453003/diff/80001/src/heap/mark-compact.cc#newcode3076
src/heap/mark-compact.cc:3076: start_index--;
If start_index was zero, it goes negative h
lgtm
https://codereview.chromium.org/974353002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
LGTM, but
This is going to be very hard to debug if someone adds an external reference
like the counter, which can be either present or absent depending on
configuration. You fixed that one in the CL, but when new ones arise, it
will
silently wire up all the external references after the extra
1 - 100 of 2581 matches
Mail list logo
