Lgtm with a couple of nits:
https://codereview.chromium.org/1316213008/diff/160001/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/1316213008/diff/160001/src/objects.cc#newcode6610
src/objects.cc:6610: int KeyAccumulator::GetLength() { return length_; }
Please move t
Cool stuff! Mostly nits:
https://codereview.chromium.org/1316213008/diff/80001/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/1316213008/diff/80001/src/objects.cc#newcode6492
src/objects.cc:6492: int KeyAccumulator::GetLength() { return length_; }
I think it's bette
Please also add tests for this functionality.
https://codereview.chromium.org/1239803004/diff/20001/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/1239803004/diff/20001/src/objects.cc#newcode2367
src/objects.cc:2367: if (!prev_object->IsUndefined()) {
How about addi
lgtm with nits:
https://codereview.chromium.org/1330483003/diff/21/src/bootstrapper.cc
File src/bootstrapper.cc (right):
https://codereview.chromium.org/1330483003/diff/21/src/bootstrapper.cc#newcode2341
src/bootstrapper.cc:2341: // Make sure that Function.prototype.call
appears to be c
Reviewers: Jakob,
Message:
PTAL, on arm64 the MacroAssembler happened to be 560 bytes.
Description:
[arm] Decrease the size of the assembler class by allocating buffers of
pending
constants on the heap.
BUG=chromium:521828
LOG=N
Please review this at https://codereview.chromium.org/13108630
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1307863007/ by ish...@chromium.org.
The reason for reverting is: Static assert failed on ARM64.
https://codereview.chromium.org/1309903009/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://gro
Reviewers: Jakob,
Message:
Created Revert of [arm] Decrease the size of the assembler class by
allocating
buffers of pending constants on the he...
Description:
Revert of [arm] Decrease the size of the assembler class by allocating
buffers
of pending constants on the he... (patchset #2 id:
Reviewers: Jakob,
Message:
PTAL
Description:
Ensure we have some space on the stack for compilation.
BUG=chromium:527345, chromium:522289
LOG=N
Please review this at https://codereview.chromium.org/1323243005/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+5, -
Reviewers: Jakob,
Message:
PTAL
Description:
[arm] Decrease the size of the assembler class by allocating buffers of
pending
constants on the heap.
BUG=chromium:521828
LOG=N
Please review this at https://codereview.chromium.org/1309903009/
Base URL: https://chromium.googlesource.com/v8/v8.
lgtm
https://codereview.chromium.org/1317053006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
https://codereview.chromium.org/1317053006/diff/40001/src/elements.cc
File src/elements.cc (right):
https://codereview.chromium.org/1317053006/diff/40001/src/elements.cc#newcode1317
src/elements.cc:1317: if (len == 0) {
ArrayPop already handles this case. Maybe this should be a DCHECK
instead?
lgtm
https://codereview.chromium.org/1314503003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
lgtm with nits:
https://codereview.chromium.org/1322803002/diff/21/src/objects.h
File src/objects.h (right):
https://codereview.chromium.org/1322803002/diff/21/src/objects.h#newcode2394
src/objects.h:2394: inline void SetValue(uint32_t index, Object* value);
Do we still need this method
lgtm with a nit.
https://codereview.chromium.org/1326483002/diff/20001/src/ic/handler-compiler.cc
File src/ic/handler-compiler.cc (right):
https://codereview.chromium.org/1326483002/diff/20001/src/ic/handler-compiler.cc#newcode513
src/ic/handler-compiler.cc:513: bool need_save_restore =
As disc
Reviewers: Benedikt Meurer,
Message:
PTAL
Description:
[arm64] Don't try convert binary operation to shifted form when both
operands
are the same.
BUG=chromium:523307
LOG=N
Please review this at https://codereview.chromium.org/1304923003/
Base URL: https://chromium.googlesource.com/v8/v8.g
I finished the mips ports and simplified the full-codegen changes.
https://codereview.chromium.org/1317383002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
T
lgtm
https://codereview.chromium.org/1325483002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/1319423003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
https://codereview.chromium.org/1325483002/diff/20001/src/builtins.cc
File src/builtins.cc (right):
https://codereview.chromium.org/1325483002/diff/20001/src/builtins.cc#newcode393
src/builtins.cc:393: if (result->IsTheHole()) {
I think hole handling should be in elements.cc and it's only necess
lgtm
https://codereview.chromium.org/1321773002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
Thanks a lot! Meet the working version.
https://codereview.chromium.org/1317383002/diff/60001/src/full-codegen/arm/full-codegen-arm.cc
File src/full-codegen/arm/full-codegen-arm.cc (right):
https://codereview.chromium.org/1317383002/diff/60001/src/full-codegen/arm/full-codegen-arm.cc#newcode247
https://codereview.chromium.org/1321773002/diff/60001/src/builtins.cc
File src/builtins.cc (left):
https://codereview.chromium.org/1321773002/diff/60001/src/builtins.cc#oldcode294
src/builtins.cc:294:
Spurious change.
https://codereview.chromium.org/1321773002/diff/60001/src/builtins.cc
File sr
Reviewers: Jarin,
Message:
PTAL. This CL has some issues on arm ports which don't look related. I'm
investigating now.
Description:
Crankshaft is now able to compile top level code even if there is a
ScriptContext.
This CL introduces HPrologue instruction which does the context allocation
wor
On 2015/08/28 13:13:24, commit-bot: I haz the power wrote:
Patchset 3 (id:??) landed as
https://crrev.com/dd0cde0e4872655a376f7aba7d0ba6251a343a88
Cr-Commit-Position: refs/heads/master@{#30444}
It looks like you committed something completely different than I lgtmed :)
I
mean the REBASE thin
lgtm
https://codereview.chromium.org/1308073010/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
https://codereview.chromium.org/1308073010/diff/20001/src/ic/ic.cc
File src/ic/ic.cc (right):
https://codereview.chromium.org/1308073010/diff/20001/src/ic/ic.cc#newcode2166
src/ic/ic.cc:2166: if (object->IsJSObject()) {
You need all these only if use_ic is true.
https://codereview.chromium.org/
lgtm
https://codereview.chromium.org/1312953002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/1313383005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
https://codereview.chromium.org/1313383005/diff/1/src/heap/mark-compact.cc
File src/heap/mark-compact.cc (right):
https://codereview.chromium.org/1313383005/diff/1/src/heap/mark-compact.cc#newcode4510
src/heap/mark-compact.cc:4510: (object->IsHeapObject() &&
heap->InNewSpace(object)) ||
You can
https://codereview.chromium.org/1313383005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, sen
Reviewers: mvstanton,
Message:
PTAL
Description:
Do not inline array resize operations for outdated prototype maps.
BUG=chromium:523213
LOG=N
Please review this at https://codereview.chromium.org/1313303002/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+16, -1
lgtm
https://codereview.chromium.org/1259963002/diff/1/src/runtime/runtime-object.cc
File src/runtime/runtime-object.cc (right):
https://codereview.chromium.org/1259963002/diff/1/src/runtime/runtime-object.cc#newcode460
src/runtime/runtime-object.cc:460:
RUNTIME_FUNCTION(Runtime_LoadGlobalVia
lgtm
https://codereview.chromium.org/1255133002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
sgtm for b), but I'm not sure about a) because it could cause penalties for
loading from variables that are read-only fields (see
https://codereview.chromium.org/1259853002/ )
Anyway, I would prefer to have two separate CLs for easy reverting. ))
https://codereview.chromium.org/1250413002/dif
Reviewers: Benedikt Meurer,
Message:
PTAL & CQ.
We forgot add a cell validity check in StoreGlobalViaContext. I also wrote a
test which caught a couple of issues in our new system and even one issue in
Crankshaft. So now it is clear that loads and stores require different
cells if
we don't wa
On 2015/07/24 13:42:33, balazs.kilvady wrote:
We are working on fixing the MIPS ports.
We already fixed them: https://codereview.chromium.org/1257603004/
https://codereview.chromium.org/1238143002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
Yo
lgtm
https://codereview.chromium.org/1257603004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
DBC about mips ports:
https://codereview.chromium.org/1238143002/diff/11/src/mips/code-stubs-mips.cc
File src/mips/code-stubs-mips.cc (right):
https://codereview.chromium.org/1238143002/diff/11/src/mips/code-stubs-mips.cc#newcode5288
src/mips/code-stubs-mips.cc:5288: __ Addu(at, at, Ope
On 2015/07/24 08:45:21, Benedikt Meurer wrote:
Hey MIPS people,
Can you look into the failures? As far as I can tell, we need at least
diff --git a/src/mips/code-stubs-mips.cc b/src/mips/code-stubs-mips.cc
index 272feda..352289a 100644
--- a/src/mips/code-stubs-mips.cc
+++ b/src/mips/code-s
lgtm
https://codereview.chromium.org/1254723004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
Reviewers: Yang,
Message:
PTAL
Description:
Speedup some slow running stack-overflow tests.
BUG=chromium:505007
LOG=N
Please review this at https://codereview.chromium.org/1238273003/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+11, -2 lines):
M test/mjsuni
https://codereview.chromium.org/1238143002/diff/20001/src/x64/code-stubs-x64.cc
File src/x64/code-stubs-x64.cc (right):
https://codereview.chromium.org/1238143002/diff/20001/src/x64/code-stubs-x64.cc#newcode5169
src/x64/code-stubs-x64.cc:5169: __ j(equal, &fast_case);
On 2015/07/19 20:29:29, Igo
https://codereview.chromium.org/1228113008/diff/40001/src/hydrogen-instructions.h
File src/hydrogen-instructions.h (right):
https://codereview.chromium.org/1228113008/diff/40001/src/hydrogen-instructions.h#newcode5453
src/hydrogen-instructions.h:5453: Handle, int, int);
On 2015/07/19 10:34:53, J
One more comment.
https://codereview.chromium.org/1238143002/diff/20001/src/x64/code-stubs-x64.cc
File src/x64/code-stubs-x64.cc (right):
https://codereview.chromium.org/1238143002/diff/20001/src/x64/code-stubs-x64.cc#newcode5169
src/x64/code-stubs-x64.cc:5169: __ j(equal, &fast_case);
I think
Reviewers: Benedikt Meurer, Jakob,
Message:
Jakob or Benedikt, PTAL and CQ
Description:
Crankshaft part of the 'loads and stores to global vars through property
cell
shortcuts' feature.
BUG=chromium:510738
LOG=N
Please review this at https://codereview.chromium.org/1228113008/
Base URL: ht
LGTM with nits for patch set 2. Thanks for improving this!
Please land this after https://codereview.chromium.org/1228113008/ which
will
require rebasing.
https://codereview.chromium.org/1238143002/diff/20001/src/compiler/js-generic-lowering.cc
File src/compiler/js-generic-lowering.cc (right)
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1238163002/ by ish...@chromium.org.
The reason for reverting is: chromium:510738, chromium:510911.
https://codereview.chromium.org/1237043006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://grou
Reviewers: Toon Verwaest,
Message:
Created Revert of Reland "Enable loads and stores to global vars through
property cell shortcuts installed into paren...
Description:
Revert of Reland "Enable loads and stores to global vars through property
cell
shortcuts installed into paren... (patchset #
lgtm with suggestion:
https://codereview.chromium.org/1241883002/diff/1/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/1241883002/diff/1/src/objects.cc#newcode5536
src/objects.cc:5536: length == 0 ?
isolate->factory()->empty_slow_element_dictionary()
Probably it wou
Reviewers: Toon Verwaest,
Message:
PTAL
Description:
Fix broken Variable::IsGlobalObjectProperty() after
https://codereview.chromium.org/1218783005
Please review this at https://codereview.chromium.org/1228373011/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+3
lgtm
https://codereview.chromium.org/1228113003/diff/80001/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/1228113003/diff/80001/src/objects.cc#newcode5624
src/objects.cc:5624: Handle
dictionary(object->element_dictionary());
We don't need a handle here.
https://c
https://codereview.chromium.org/1228113003/diff/60001/test/mjsunit/element-read-only.js
File test/mjsunit/element-read-only.js (right):
https://codereview.chromium.org/1228113003/diff/60001/test/mjsunit/element-read-only.js#newcode38
test/mjsunit/element-read-only.js:38: var proto = {3: 100};
Ma
https://codereview.chromium.org/1228113003/diff/20001/src/elements.cc
File src/elements.cc (right):
https://codereview.chromium.org/1228113003/diff/20001/src/elements.cc#newcode1655
src/elements.cc:1655: JSObject::RequireSlowElements(object, arguments);
Why not "if (attributes != NONE)" here?
h
lgtm
https://codereview.chromium.org/1237953002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
Reviewers: Toon Verwaest,
Message:
PTAL, 2nd attempt.
Description:
Reland "Enable loads and stores to global vars through property cell
shortcuts
installed into parent script context."
Please review this at https://codereview.chromium.org/1237043006/
Base URL: https://chromium.googlesource.
On 2015/07/14 14:53:19, Yang wrote:
On 2015/07/14 14:48:45, Igor Sheludko wrote:
> On 2015/07/14 13:55:42, Igor Sheludko wrote:
> > PTAL
>
> For some reason this updated test now fails the same way on x64.optdebug
(only):
>
> #
> # Fatal error in ../src/debug.cc, line 228
> # Check failed: code()
lgtm
https://codereview.chromium.org/1228373004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
On 2015/07/14 13:55:42, Igor Sheludko wrote:
PTAL
For some reason this updated test now fails the same way on x64.optdebug
(only):
#
# Fatal error in ../src/debug.cc, line 228
# Check failed: code()->has_debug_break_slots().
#
https://codereview.chromium.org/1231893007/
--
--
v8-dev mail
On 2015/07/14 14:28:46, Igor Sheludko wrote:
PTAL
This CL fixes layout tests and the serialization test.
debug-script-breakpoint.js failure will be addressed in a different CL:
https://codereview.chromium.org/1231893007
https://codereview.chromium.org/1236523004/
--
--
v8-dev mailing list
v8
Reviewers: Toon Verwaest,
Message:
PTAL
Description:
Follow-up for "Enable loads and stores to global vars through property cell
shortcuts installed into parent script context."
Please review this at https://codereview.chromium.org/1236523004/
Base URL: https://chromium.googlesource.com/v8/v8.
Reviewers: Yang,
Message:
PTAL
Description:
Debugger test updated to avoid setting breakpoints into random native
scripts.
Please review this at https://codereview.chromium.org/1231893007/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+48, -44 lines):
M tes
lgtm
https://codereview.chromium.org/1241613003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/1228803005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/1233073003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/1238533003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/1228393005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/1238463002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
Thanks! Landing...
https://codereview.chromium.org/1227893005/diff/80001/src/ic/ic.cc
File src/ic/ic.cc (right):
https://codereview.chromium.org/1227893005/diff/80001/src/ic/ic.cc#newcode3024
src/ic/ic.cc:3024: return ThrowReferenceError(isolate, &it);
On 2015/07/13 12:56:03, Toon Verwaest wrot
Now INSIDE_TYPEOF is used really from Typeof.
https://codereview.chromium.org/1227893005/diff/40001/src/ic/ic.cc
File src/ic/ic.cc (right):
https://codereview.chromium.org/1227893005/diff/40001/src/ic/ic.cc#newcode738
src/ic/ic.cc:738: if (it.IsFound() || typeof_mode() == INSIDE_TYPEOF) {
On 20
lgtm
https://codereview.chromium.org/1232823002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
Reviewers: Toon Verwaest,
Message:
PTAL
Description:
Enable loads and stores to global vars through property cell shortcuts
installed
into parent script context.
Please review this at https://codereview.chromium.org/1237603002/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
A
Thanks! Landing...
https://codereview.chromium.org/1224793002/diff/80001/src/code-stubs-hydrogen.cc
File src/code-stubs-hydrogen.cc (right):
https://codereview.chromium.org/1224793002/diff/80001/src/code-stubs-hydrogen.cc#newcode1721
src/code-stubs-hydrogen.cc:1721:
static_cast(PropertyCellType
lgtm
https://codereview.chromium.org/1225213008/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/1233493007/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/1230213002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/1232083003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
lgtm with nits:
https://codereview.chromium.org/1232463005/diff/1/src/elements.cc
File src/elements.cc (right):
https://codereview.chromium.org/1232463005/diff/1/src/elements.cc#newcode1552
src/elements.cc:1552: return
ArgumentsAccessor::GetDetailsImpl(arguments, entry);
While you are here, ple
Reviewers: Jakob,
Message:
PTAL
Description:
[arm64] Fixed unnecessary environment assignment to lithium instruction.
BUG=chromium:490021
LOG=N
Please review this at https://codereview.chromium.org/1235563002/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+5, -
lgtm
https://codereview.chromium.org/1234553002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
Please update all the other calls to JSReceiver::SetElement() and
JSObject::SetElement() with calls to Object::SetElement.
lgtm once the comments are addressed.
https://codereview.chromium.org/1221303019/diff/50001/src/lookup.cc
File src/lookup.cc (right):
https://codereview.chromium.org/12213
Reviewers: Toon Verwaest,
Message:
PTAL
Description:
TypeofMode replaces TypeofState and ContextualMode.
NON_CONTEXTUAL -> INSIDE_TYPEOF
CONTEXTUAL -> NOT_INSIDE_TYPEOF
Please review this at https://codereview.chromium.org/1227893005/
Base URL: https://chromium.googlesource.com/v8/v8.git@mast
lgtm
https://codereview.chromium.org/1215023016/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/1214673007/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
The trybots failed because of
https://code.google.com/p/chromium/issues/detail?id=508074
https://codereview.chromium.org/1224793002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Gro
Reviewers: rossberg,
Message:
PTAL
Description:
Disable harmony/arrow-rest-params test to unblock landing of another CL.
BUG=chromium:508074
LOG=N
Please review this at https://codereview.chromium.org/1217493005/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+3
Addressed comments
https://codereview.chromium.org/1215463012/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving
lgtm
https://codereview.chromium.org/1224853003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
Reviewers: Toon Verwaest,
Message:
PTAL non-TF part (I'll ask TF team to review TF part later)
Description:
Loads and stores to global vars are now made via property cell shortcuts
installed into parent script context.
This CL also adds hydrogen stubs for global loads and global stores,
full-co
lgtm
https://codereview.chromium.org/1218663009/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/1218663009/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
Reviewers: Jakob,
Message:
PTAL
Description:
Use FullCodeGenerator::EmitVariableLoad() where possible to avoid code
duplication.
Please review this at https://codereview.chromium.org/103007/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+243, -455 lines):
lgtm with nits:
https://codereview.chromium.org/1224643004/diff/20001/src/elements.cc
File src/elements.cc (right):
https://codereview.chromium.org/1224643004/diff/20001/src/elements.cc#newcode890
src/elements.cc:890: for (int i = 0; i < capacity; i++) {
i -> entry?
https://codereview.chromium
Reviewers: Yang,
Message:
PTAL
Description:
Fixed a couple of proxies-related unhandled exceptions.
BUG=chromium:506956, chromium:505907
LOG=N
Please review this at https://codereview.chromium.org/1215463012/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+17, -
lgtm
https://codereview.chromium.org/1221363002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/1214373005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/1218813012/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from i
lgtm with suggestions:
https://codereview.chromium.org/1218813012/diff/60001/src/elements.cc
File src/elements.cc (right):
https://codereview.chromium.org/1218813012/diff/60001/src/elements.cc#newcode1002
src/elements.cc:1002: if (obj->elements() != *store) {
It looks like you can do the same t
lgtm
https://codereview.chromium.org/1218403002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
lgtm with a nit and suggestion:
https://codereview.chromium.org/1218403002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and s
lgtm with a nit and suggestion:
https://codereview.chromium.org/1218403002/diff/1/src/api-natives.cc
File src/api-natives.cc (right):
https://codereview.chromium.org/1218403002/diff/1/src/api-natives.cc#newcode150
src/api-natives.cc:150: PropertyKind kind = length == 3 ? kData :
kAccessor;
Inst
1 - 100 of 1174 matches
Mail list logo
