https://codereview.chromium.org/924453002/diff/60001/src/zone.cc
File src/zone.cc (right):
https://codereview.chromium.org/924453002/diff/60001/src/zone.cc#newcode108
src/zone.cc:108: if (limit_ < position_ + size_with_redzone) {
This is not just a cosmetic change! The addition can overflow
On 2015/10/23 00:24:11, Nico (vacation Fri Oct 23) wrote:
Zombie review comment! Can you expand on the "as discussed" bit a bit? The
BUG=
line is just some generic tracking bug, and the CL description doesn't
really
say what's happening here. I think it was because bool bitfields are
src/full-codegen/* LGTM.
https://codereview.chromium.org/1202173002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop
A few more minor comments. LGTM if you address those.
I've also updated the CL description to reflect the new approach.
https://codereview.chromium.org/1313493005/diff/60001/src/accessors.cc
File src/accessors.cc (right):
The original code is broken. Instead of making it worse (uglier, hackier,
more
brittle), let's fix it properly. Here's an example demonstrating failure:
var a = new Uint8Array(4);
Object.defineProperty(a, "length", {get: function() { return "blah"; }});
function getlength(x) { return x.length;
lgtm
https://codereview.chromium.org/1329793003/diff/20001/src/hydrogen.cc
File src/hydrogen.cc (right):
https://codereview.chromium.org/1329793003/diff/20001/src/hydrogen.cc#newcode7447
src/hydrogen.cc:7447: if (*map !=
isolate()->get_initial_js_array_map(map->elements_kind())) {
Isn't this
LGTM with nits.
Doing the !IS_UNDEFINED check at callsites is rather sad. It would be nice
if
$toInteger took care of that without deopting; but changing that might be
more
involved as it might have unexpected side effects.
https://codereview.chromium.org/1324353002/diff/20001/src/string.js
File src/string.js (right):
https://codereview.chromium.org/1324353002/diff/20001/src/string.js#newcode1041
src/string.js:1041: return true;
On 2015/09/08 07:27:58, Dan Ehrenberg wrote:
There's some code duplication between
LGTM.
Yang, is more caching something we want strategically? I wouldn't be
surprised
if this cache were a benchmark-specific hack that we'd rather get rid of.
If you
don't like this change, feel free to revert it.
https://codereview.chromium.org/1308373005/
--
--
v8-dev mailing list
src/ic/* LGTM, love it!
https://codereview.chromium.org/1332563003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop
lgtm
https://codereview.chromium.org/1313353006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails
lgtm
https://codereview.chromium.org/1324803003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails
-danno +ulan for src/heap/ OWNERS approval. (Changes look fine, you can
rubberstamp.)
https://codereview.chromium.org/1323313003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google
lgtm
https://codereview.chromium.org/1321993004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails
https://codereview.chromium.org/1324803003/diff/1/src/string-search.h
File src/string-search.h (right):
https://codereview.chromium.org/1324803003/diff/1/src/string-search.h#newcode214
src/string-search.h:214: Max(static_cast(pattern_first_char &
0xFF),
Why this change? "... & 0xFF" gives the
A lot faster since the low byte can be 0 and faster to search highest
value
byte
But that depends on the input, right? For maximum speed you want to search
for
the most *unique* byte in the string, but you can't determine that without
analyzing the string first. It's easy to construct
lgtm
https://codereview.chromium.org/1322693004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails
Reviewers: Benedikt Meurer,
Message:
PTAL.
https://codereview.chromium.org/1302313013/diff/1/src/types.cc
File src/types.cc (right):
https://codereview.chromium.org/1302313013/diff/1/src/types.cc#newcode293
src/types.cc:293: case FIXED_##TYPE##_ARRAY_TYPE:
clang-format insists on this
Thanks, LGTM.
https://codereview.chromium.org/1303033012/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving
Reviewers: ulan,
Message:
As discussed.
Description:
Isolate::PrintStack: restore default verbose object printing
Please review this at https://codereview.chromium.org/1311123005/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+2, -2 lines):
M src/heap/heap.cc
LGTM, but I'd prefer if vogelheim@ could take a look too.
https://codereview.chromium.org/1315173007/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To
Ack, LGTM.
Karl, the workflow for relanding is:
(1) upload the original patch as a new codereview issue (either from a new
local
git branch, or after "git cl issue 0" to reset the associated review), issue
description along the lines of: """
Reland 'Speedup string search for two byte strings'
LGTM with nits.
https://codereview.chromium.org/1309903009/diff/1/src/arm/assembler-arm.cc
File src/arm/assembler-arm.cc (right):
https://codereview.chromium.org/1309903009/diff/1/src/arm/assembler-arm.cc#newcode3678
src/arm/assembler-arm.cc:3678: // Inline buffer is over, switch to
Looks good.
You can run the fuzzer locally: make x64.debug && tools/fuzz-harness.sh
out/x64.debug/d8
We seem to have an MSan try bot, but the link to start a job on it
disappeared
when I triggered the CQ dry run. Hopefully it'll reappear when the dry run's
finished.
lgtm
https://codereview.chromium.org/1310863005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails
lgtm
https://codereview.chromium.org/1324453007/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails
ACK. However, note that creating a substring causes an allocation, which
isn't
100% ideal either. That said, incremental improvement is fine, and if we
want
even more speed in the future we can always think about further
optimizations
(like implementing substring comparisons in the
lgtm
https://codereview.chromium.org/1323243005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails
lgtm
https://codereview.chromium.org/1319123004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails
lgtm
https://codereview.chromium.org/1322843005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails
lgtm
https://codereview.chromium.org/1328603003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails
https://codereview.chromium.org/1303033012/diff/1/src/string-search.h
File src/string-search.h (left):
https://codereview.chromium.org/1303033012/diff/1/src/string-search.h#oldcode196
src/string-search.h:196:
nit: keep this line
LGTM with comments.
https://codereview.chromium.org/1318933004/diff/1/tools/tickprocessor.js
File tools/tickprocessor.js (right):
https://codereview.chromium.org/1318933004/diff/1/tools/tickprocessor.js#newcode461
tools/tickprocessor.js:461: var printAllTicks = this.printSummary_ ==
undefined
Looks good. Some comments.
https://codereview.chromium.org/1328603003/diff/40001/src/ast.cc
File src/ast.cc (right):
https://codereview.chromium.org/1328603003/diff/40001/src/ast.cc#newcode353
src/ast.cc:353: if (saw_computed_name &&
This is surprising: having seen a computed name previously
LGTM with nits.
https://codereview.chromium.org/1307943013/diff/1/src/arm/lithium-codegen-arm.cc
File src/arm/lithium-codegen-arm.cc (left):
https://codereview.chromium.org/1307943013/diff/1/src/arm/lithium-codegen-arm.cc#oldcode2643
src/arm/lithium-codegen-arm.cc:2643: __ b(gt, is_false);
For
From a stylistic point of view, this shouldn't just expose and call a
helper in
a completely unrelated class that happens to do something similar. Instead,
as
the condition becomes more complex, it should create its own helper
function to
clearly formulate the predicate, something like
lgtm
https://codereview.chromium.org/1302803003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/1294543006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Reviewers: cbruni,
Message:
Please take a look, and CQ it if you like it.
Description:
[API] Check for NULL external data pointer in ArrayBuffer::New()
Embedders must not provide invalid pointers for external backing stores.
BUG=chromium:522128
LOG=n
R=cbr...@chromium.org
Please review this
lgtm
https://codereview.chromium.org/1293273005/diff/1/PRESUBMIT.py
File PRESUBMIT.py (right):
https://codereview.chromium.org/1293273005/diff/1/PRESUBMIT.py#newcode145
PRESUBMIT.py:145: Attempts to prevent inclusion in inline headers
into normal header
s/ in / of /?
lgtm
https://codereview.chromium.org/1301533002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/1287023002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Reviewers: Michael Starzinger,
Message:
PTAL.
Description:
[test] Remove FLAG_always_opt special case in NotifyDeoptimized
Always unlink optimized code on deopt, even when FLAG_always_opt is present,
because assumptions that the code made could have become invalid.
BUG=v8:4375
LOG=n
lgtm
https://codereview.chromium.org/1286343004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/1294583006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/1293493003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
LGTM!
https://codereview.chromium.org/1293793002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Reviewers: Yang,
Message:
As discussed.
For the Scripts' weak fixed array, it shouldn't matter when we clear them; I
moved clearing those as well for consistency.
Description:
[serializer] Move WeakFixedArray compaction to separate heap walk phase
This avoids discovering and compacting the
lgtm
https://codereview.chromium.org/1290963005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/1289203003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
LGTM
https://codereview.chromium.org/1292533003/diff/1/src/debug/debug.cc
File src/debug/debug.cc (right):
https://codereview.chromium.org/1292533003/diff/1/src/debug/debug.cc#newcode1959
src/debug/debug.cc:1959: HandleObject argv[] =
{Script::GetWrapper(script)};
nit: we like spaces inside {}
lgtm
https://codereview.chromium.org/1285543002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
LGTM with nits.
https://codereview.chromium.org/1282793002/diff/1/src/debug/mirrors.js
File src/debug/mirrors.js (right):
https://codereview.chromium.org/1282793002/diff/1/src/debug/mirrors.js#newcode20
src/debug/mirrors.js:20: // - ValueMirror
nit: meaningful indentation got lost here
Frankly, I don't quite see why we need this, as the existing output conveys
the
same information:
[00:00|% 0|+ 0|- 0]: Done
But if you like that more explicit warning, fine, LGTM.
https://codereview.chromium.org/1281313004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
Adam, as I wrote, landing this is fine with me.
Caitlin, you want cctest/test-parsing/* (or cctest
or cctest/test-pars* or
...) now. Matching has been made exact, as opposed to implicitly
prefix-based.
The intention is that when you have tests foo and foobar, there's
should be
a way to
On 2015/08/11 15:31:02, caitp wrote:
Thanks for the info --- When did this change?
https://codereview.chromium.org/1251363002
https://codereview.chromium.org/1281313004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message
LGTM with comments that you have addressed already :-)
https://codereview.chromium.org/1276533003/diff/1/src/arm/builtins-arm.cc
File src/arm/builtins-arm.cc (right):
https://codereview.chromium.org/1276533003/diff/1/src/arm/builtins-arm.cc#newcode446
src/arm/builtins-arm.cc:446:
LGTM, let's hope the bots have no objections.
https://codereview.chromium.org/1278353002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from
LGTM with a nit.
https://codereview.chromium.org/1281833002/diff/20001/src/messages.cc
File src/messages.cc (right):
https://codereview.chromium.org/1281833002/diff/20001/src/messages.cc#newcode396
src/messages.cc:396: // internally created error object, use that
messingage property. Otherwise
lgtm
https://codereview.chromium.org/1284673002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Reviewers: Yang,
Description:
Fasterify ICSlotCache
Use a hash map instead of a list for faster lookups.
BUG=chromium:517406
LOG=n
R=yang...@chromium.org
Please review this at https://codereview.chromium.org/1279763006/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected
Thanks for the comments. I've templatized the compaction method. CQ it if
you
like it; otherwise I'd be happy to iterate.
https://codereview.chromium.org/1276353004/diff/1/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/1276353004/diff/1/src/objects.cc#newcode7971
The following script generates a test case that on my machine takes 3s
before
this CL and 270ms after:
var result = [(function foo() {];
for (var i = 0; i 10; i++) {
result.push( typeof x + i + ;);
}
result.push(})(););
print(result.join(\n));
Yang, I needed a workaround in the serializer to make sure
remembered-slot-updating on compaction doesn't happen too late. Is patch
set 3
acceptable, or should we do that differently? Is there maybe a pass over the
heap before actual serialization that could take care of WeakFixedArray
Looks good. I have a couple of nits, and one high-level comment:
IIUC, this doesn't distinguish between getters and data properties. So if
you
had this:
var error = /* some internally thrown error */
delete error.message;
error.__proto__ = {message: My message};
error.toString();
then
lgtm
https://codereview.chromium.org/1283513003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/1279613005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Reviewers: Yang,
Description:
[IC] Make SeededNumberDictionary::UpdateMaxNumberKey prototype aware
Only walk the heap clearing KeyedStoreICs when the dictionary in question
belongs to an object that's used as a prototype.
This is a temporary mitigation until we have a way to clear such ICs
lgtm
https://codereview.chromium.org/1276853002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
So this didn't go well at all. The commit description is wrong (this is
4.5.103.20 now), and there is no tag (presumably because the script tried to
create the .15 tag which existed already).
When backmerge script runs are outdated (because other merges went in in the
meantime), they must be
Reviewers: Yang,
Description:
Fasterify JSObject::UnregisterPrototypeUser
When a (prototype) map registers as a user of its own prototype, it now
remembers the index in that prototype's registry where it is listed.
This remembered index is used on un-registration to find the right slot to
LGTM!111eleven
https://codereview.chromium.org/1281453003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop
Reviewers: Yang,
Description:
Fix off-by-one in Array.concat's max index check
The maximum valid index is strictly smaller than the maximum valid length.
BUG=chromium:516592
LOG=y
R=yang...@chromium.org
Please review this at https://codereview.chromium.org/1278703003/
Base URL:
lgtm
https://codereview.chromium.org/1265243003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
LGTM with nits.
https://codereview.chromium.org/1252913007/diff/1/src/gdb-jit.cc
File src/gdb-jit.cc (right):
https://codereview.chromium.org/1252913007/diff/1/src/gdb-jit.cc#newcode396
src/gdb-jit.cc:396:
nit: why this change?
LGTM. I can haz regression test?
https://codereview.chromium.org/1261453004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and
On 2015/08/03 16:07:21, jochen wrote:
On 2015/08/03 at 16:06:00, jkummerow wrote:
LGTM. I can haz regression test?
i tried, but it's more or less invisible. the array buffer is neutered
one way
or another, we don't have a good way to catch the write :-/
Hm, good point. OK then, let's
LGTM with a few more minor comments.
https://codereview.chromium.org/1260283002/diff/180001/src/elements.cc
File src/elements.cc (right):
https://codereview.chromium.org/1260283002/diff/180001/src/elements.cc#newcode1180
src/elements.cc:1180: // to_add is 0 and new_length = elms_len, so
Reviewers: Benedikt Meurer,
Description:
Version 4.4.63.26
[crankshaft] Fix wrong bailout points in for-in loop body.
This is a manual port of https://codereview.chromium.org/1183683004, which
fixed
the same issue on the 4.5 branch.
BUG=chromium:514268
LOG=n
R=bmeu...@chromium.org
Please
rubberstamp LGTM
https://codereview.chromium.org/1265923002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving
https://codereview.chromium.org/1260283002/diff/140001/src/builtins.cc
File src/builtins.cc (right):
https://codereview.chromium.org/1260283002/diff/140001/src/builtins.cc#newcode332
src/builtins.cc:332: int new_length = accessor-Push(array, elms_obj,
args[0], 1, to_add,
If you pass in args[1]
lgtm
https://codereview.chromium.org/1258193003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
LGTM.
Thankfully the STATIC_ASSERT on the next line says that this change is
safe :-)
https://codereview.chromium.org/1265663002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google
Reviewers: Igor Sheludko, v8-mips-ports_googlegroups.com, Paul Lind,
Benedikt Meurer,
Message:
Created Revert of Reland^2 Enable loads and stores to global vars through
property cell shortcuts installed into par...
Description:
Revert of Reland^2 Enable loads and stores to global vars through
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1260423002/ by jkumme...@chromium.org.
The reason for reverting is: Suspected to cause Canary crashes.
https://codereview.chromium.org/1254723004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
lgtm
https://codereview.chromium.org/1268463002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/1262113002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
https://codereview.chromium.org/1268463002/ should fix those failures,
let's try
CQing again...
https://codereview.chromium.org/1260423002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the
LGTM. Please sort the list alphabetically.
https://codereview.chromium.org/1259013002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this
Reviewers: ulan,
Message:
PTAL.
https://codereview.chromium.org/1263543004/diff/1/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/1263543004/diff/1/src/objects.cc#newcode4659
src/objects.cc:4659: if (maybe_old_prototype-IsJSObject()) {
This if-block is new; the
Yes, I like this approach much better. LGTM.
What's up with the v8_linux_rel bot? Looks like it doesn't have test262-es6.
https://codereview.chromium.org/1245623005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because
lgtm
https://codereview.chromium.org/1262613002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
LGTM with a nit.
https://codereview.chromium.org/1255883002/diff/1/src/ic/ia32/ic-ia32.cc
File src/ic/ia32/ic-ia32.cc (right):
https://codereview.chromium.org/1255883002/diff/1/src/ic/ia32/ic-ia32.cc#newcode763
src/ic/ia32/ic-ia32.cc:763: __ push(receiver); // which contains the
return
Patch set 3 LGTM with a new nit.
https://codereview.chromium.org/1255883002/diff/60001/src/arm/macro-assembler-arm.h
File src/arm/macro-assembler-arm.h (right):
https://codereview.chromium.org/1255883002/diff/60001/src/arm/macro-assembler-arm.h#newcode380
src/arm/macro-assembler-arm.h:380:
This feels like a *lot* of complexity. Dynamically selected callables that
return callables that return iterables? At the very least, I'd like some
more
descriptive naming, to make it easier to understand what's going on, see
comments below.
Wouldn't the following design simplify things:
-
LGTM! Thanks for fixing this; this has been on my to-do list for a long
time.
https://codereview.chromium.org/1251363002/diff/1/tools/testrunner/local/testsuite.py
File tools/testrunner/local/testsuite.py (right):
LGTM
https://codereview.chromium.org/1248443003/diff/1/src/full-codegen/full-codegen.h
File src/full-codegen/full-codegen.h (right):
https://codereview.chromium.org/1248443003/diff/1/src/full-codegen/full-codegen.h#newcode5
src/full-codegen/full-codegen.h:5: #ifndef V8_FULL_CODEGEN_H_
nit:
Yay! But I'd like to harden this a bit if possible. Field sharing is
dangerous
business.
https://codereview.chromium.org/1252473002/diff/1/src/objects-inl.h
File src/objects-inl.h (right):
https://codereview.chromium.org/1252473002/diff/1/src/objects-inl.h#newcode5479
src/objects-inl.h:5479:
lgtm
https://codereview.chromium.org/1248973002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/1242293004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
1 - 100 of 4129 matches
Mail list logo
