Patchset 7 (id:??) landed as
https://crrev.com/a56f537381ddfb8f89394880e1f0fa63a17cd510
Cr-Commit-Position: refs/heads/master@{#30281}
https://codereview.chromium.org/1301183002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this messag
Committed patchset #7 (id:120001)
https://codereview.chromium.org/1301183002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1301183002/120001
View timeline at
https://chromium-cq-status.appspot.com/patch-timeline/1301183002/120001
https://codereview.chromium.org/1301183002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
On 2015/08/21 05:26:43, Benedikt Meurer wrote:
LGTM.
One question: While we are changing the heap testing stuff, can we
migrate the
tests to unittests using GoogleTest?
Thought about it but didn't dare to touch and convert the tests (yet). I
will
have a look at some point though.
https
LGTM.
One question: While we are changing the heap testing stuff, can we migrate
the
tests to unittests using GoogleTest?
https://codereview.chromium.org/1301183002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because
https://codereview.chromium.org/1301183002/diff/11/src/heap/heap.cc
File src/heap/heap.cc (right):
https://codereview.chromium.org/1301183002/diff/11/src/heap/heap.cc#newcode797
src/heap/heap.cc:797: void Heap::CollectAllGarbage(int flags, const
char* gc_reason,
On 2015/08/20 16:28:29, H
https://codereview.chromium.org/1301183002/diff/11/src/heap/heap.cc
File src/heap/heap.cc (right):
https://codereview.chromium.org/1301183002/diff/11/src/heap/heap.cc#newcode797
src/heap/heap.cc:797: void Heap::CollectAllGarbage(int flags, const
char* gc_reason,
On 2015/08/20 16:28:29, H
lgtm, nits attached
https://codereview.chromium.org/1301183002/diff/11/src/heap/heap.cc
File src/heap/heap.cc (right):
https://codereview.chromium.org/1301183002/diff/11/src/heap/heap.cc#newcode797
src/heap/heap.cc:797: void Heap::CollectAllGarbage(int flags, const
char* gc_reason,
We s
https://codereview.chromium.org/1301183002/diff/80001/test/cctest/test-heap.cc
File test/cctest/test-heap.cc (right):
https://codereview.chromium.org/1301183002/diff/80001/test/cctest/test-heap.cc#newcode2814
test/cctest/test-heap.cc:2814: CHECK_EQ(true, heap->current_gc_flags() &
Heap::kReduceM
LGTM from my end.
https://codereview.chromium.org/1301183002/diff/40001/src/heap/incremental-marking.cc
File src/heap/incremental-marking.cc (right):
https://codereview.chromium.org/1301183002/diff/40001/src/heap/incremental-marking.cc#newcode490
src/heap/incremental-marking.cc:490: StartMarkin
https://codereview.chromium.org/1301183002/diff/40001/src/heap/heap.h
File src/heap/heap.h (right):
https://codereview.chromium.org/1301183002/diff/40001/src/heap/heap.h#newcode28
src/heap/heap.h:28: class HeapTester;
On 2015/08/20 13:33:37, Michael Starzinger wrote:
nit: No need for forward de
Looking good. I like it.
https://codereview.chromium.org/1301183002/diff/40001/src/heap/heap.h
File src/heap/heap.h (right):
https://codereview.chromium.org/1301183002/diff/40001/src/heap/heap.h#newcode28
src/heap/heap.h:28: class HeapTester;
nit: No need for forward declare, friend declaration
See previous message :)
https://codereview.chromium.org/1301183002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop rece
13 matches
Mail list logo
