Committed patchset #6 manually as r16608 (presubmit successful).
https://codereview.chromium.org/23464022/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To un
On 2013/09/10 06:09:56, Sven Panne wrote:
LGTM with a nit.
https://codereview.chromium.org/23464022/diff/21001/include/v8.h
File include/v8.h (right):
https://codereview.chromium.org/23464022/diff/21001/include/v8.h#newcode3816
include/v8.h:3816: Maybe is_memory_constrained() { return
is_me
LGTM with a nit.
https://codereview.chromium.org/23464022/diff/21001/include/v8.h
File include/v8.h (right):
https://codereview.chromium.org/23464022/diff/21001/include/v8.h#newcode3816
include/v8.h:3816: Maybe is_memory_constrained() { return
is_memory_constrained_; }
Missing const.
https://c
Updated to use the Maybe template. PTAL.
https://codereview.chromium.org/23464022/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this gro
On 2013/09/06 09:35:56, Sven Panne wrote:
My gut feeling is that one should thread the isLowEndDevice info through
Blink,
so that both the main thread and the workers know what they should
create. It
is
Blink after all which creates Isolates (or for the main thread: which
should
create it i
My gut feeling is that one should thread the isLowEndDevice info through
Blink,
so that both the main thread and the workers know what they should create.
It is
Blink after all which creates Isolates (or for the main thread: which should
create it in the future), so it should get everything it
On 2013/09/06 07:38:00, Sven Panne wrote:
On 2013/09/05 18:29:59, rmcilroy wrote:
> Sorry, I think we are misunderstanding. There is still only a single
> ResourceConstraint (which is in-effect immutable and is treated as an
argument
> object). There is no intention that if the embedder chang
On 2013/09/05 18:29:59, rmcilroy wrote:
Sorry, I think we are misunderstanding. There is still only a single
ResourceConstraint (which is in-effect immutable and is treated as an
argument
object). There is no intention that if the embedder changes the
ResourceConstraint object after they hav
On 2013/09/05 17:28:37, Sven Panne wrote:
On 2013/09/05 15:36:39, rmcilroy wrote:
> Thanks Sven. I've had to slightly change the API to take a pointer to a
boolean
> so that the setResourceConstraints will not re-set
is_memory_constrained if
the
> ResourceConstraint being passed didn't have a
On 2013/09/05 15:36:39, rmcilroy wrote:
Thanks Sven. I've had to slightly change the API to take a pointer to a
boolean
so that the setResourceConstraints will not re-set is_memory_constrained
if
the
ResourceConstraint being passed didn't have a call to
set_memory_constrained
(e.g., treat
On 2013/09/05 08:49:45, Sven Panne wrote:
LGTM if there is no veto from Michael. I think the right way to proceed
is to
use the new predicate for a few low-memory-device CLs and perhaps
refactor the
external API a bit if possible. I am not 100% happy with the introduction
of
magic flags, bu
LGTM if there is no veto from Michael. I think the right way to proceed is
to
use the new predicate for a few low-memory-device CLs and perhaps refactor
the
external API a bit if possible. I am not 100% happy with the introduction of
magic flags, but currently I don't know a better alternative
https://codereview.chromium.org/23464022/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send
Thanks Sven and tfarina.
Sure thing, as I mentioned in the initial message,
https://codereview.chromium.org/23480031/ shows the first intended use of
this
flag. I envisage quite a few more, for example, reducing the amount of code
inlining, changing the parameters which decide between expandin
Adding Michael, we talked about this yesterday. In general this looks OK,
but it
is of course only the threading of a flag. It would be nice to see a CL
building
on this one where the new predicate is actually used (plus some hints where
it
might be used, too).
The change as it is isolates
https://codereview.chromium.org/23464022/diff/1/src/isolate.h
File src/isolate.h (right):
https://codereview.chromium.org/23464022/diff/1/src/isolate.h#newcode1141
src/isolate.h:1141: bool isMemoryConstrained() {
I believe this should be is_memory_constrained()
https://codereview.chromium.org/2
16 matches
Mail list logo
