LGTM
https://codereview.chromium.org/1181903003/diff/80001/src/typedarray.js
File src/typedarray.js (right):
https://codereview.chromium.org/1181903003/diff/80001/src/typedarray.js#newcode138
src/typedarray.js:138: var newIterable = {__proto__: null};
var newIterable = {
__proto__: null,
Patchset 6 (id:??) landed as
https://crrev.com/40420f67e7fb029a1379882f95023afaa19fa7a0
Cr-Commit-Position: refs/heads/master@{#29031}
https://codereview.chromium.org/1181903003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
Committed patchset #6 (id:11)
https://codereview.chromium.org/1181903003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1181903003/11
https://codereview.chromium.org/1181903003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
https://codereview.chromium.org/1181903003/diff/80001/src/typedarray.js
File src/typedarray.js (right):
https://codereview.chromium.org/1181903003/diff/80001/src/typedarray.js#newcode138
src/typedarray.js:138: var newIterable = {__proto__: null};
On 2015/06/15 15:53:19, arv wrote:
This
On Jun 15, 2015 11:14 AM, little...@chromium.org wrote:
https://codereview.chromium.org/1181903003/diff/80001/src/typedarray.js
File src/typedarray.js (right):
https://codereview.chromium.org/1181903003/diff/80001/src/typedarray.js#newcode138
src/typedarray.js:138: var newIterable =
https://codereview.chromium.org/1181903003/diff/20001/src/typedarray.js
File src/typedarray.js (right):
https://codereview.chromium.org/1181903003/diff/20001/src/typedarray.js#newcode139
src/typedarray.js:139: while (!current.done) {
The main benefit of using for-of is that you get everything
https://codereview.chromium.org/1181903003/diff/60001/src/typedarray.js
File src/typedarray.js (right):
https://codereview.chromium.org/1181903003/diff/60001/src/typedarray.js#newcode139
src/typedarray.js:139: newIterable[symbolIterator] = function() { return
iterator; };
On 2015/06/13
https://codereview.chromium.org/1181903003/diff/60001/src/typedarray.js
File src/typedarray.js (right):
https://codereview.chromium.org/1181903003/diff/60001/src/typedarray.js#newcode139
src/typedarray.js:139: newIterable[symbolIterator] = function() { return
iterator; };
Sadly this will fail
https://codereview.chromium.org/1181903003/diff/60001/src/typedarray.js
File src/typedarray.js (right):
https://codereview.chromium.org/1181903003/diff/60001/src/typedarray.js#newcode139
src/typedarray.js:139: newIterable[symbolIterator] = function() { return
iterator; };
On 2015/06/13
https://codereview.chromium.org/1181903003/diff/40001/src/typedarray.js
File src/typedarray.js (right):
https://codereview.chromium.org/1181903003/diff/40001/src/typedarray.js#newcode140
src/typedarray.js:140: if (!IS_OBJECT(current)) {
On 2015/06/12 18:06:45, adamk wrote:
I think you want
https://codereview.chromium.org/1181903003/diff/60001/src/typedarray.js
File src/typedarray.js (right):
https://codereview.chromium.org/1181903003/diff/60001/src/typedarray.js#newcode139
src/typedarray.js:139: newIterable[symbolIterator] = function() { return
iterator; };
On 2015/06/13
Good catch, thanks
https://codereview.chromium.org/1181903003/diff/20001/src/typedarray.js
File src/typedarray.js (right):
https://codereview.chromium.org/1181903003/diff/20001/src/typedarray.js#newcode140
src/typedarray.js:140: list.push(current.value);
On 2015/06/12 02:47:21, caitp wrote:
https://codereview.chromium.org/1181903003/diff/40001/src/typedarray.js
File src/typedarray.js (right):
https://codereview.chromium.org/1181903003/diff/40001/src/typedarray.js#newcode140
src/typedarray.js:140: if (!IS_OBJECT(current)) {
I think you want IS_SPEC_OBJECT here.
The proper tests
https://codereview.chromium.org/1181903003/diff/1/src/typedarray.js
File src/typedarray.js (right):
https://codereview.chromium.org/1181903003/diff/1/src/typedarray.js#newcode154
src/typedarray.js:154: // twice. Currently, that's fine, but it'll be
observable with proxies.
Proxies aren't
Fixed the issue in the new version.
https://codereview.chromium.org/1181903003/diff/1/src/typedarray.js
File src/typedarray.js (right):
https://codereview.chromium.org/1181903003/diff/1/src/typedarray.js#newcode154
src/typedarray.js:154: // twice. Currently, that's fine, but it'll be
16 matches
Mail list logo
