[v8-dev] Re: Take into account freed global handles and fragmentation when computing heap growing factor. (issue 1161603006 by u...@chromium.org)

2015-06-02 Thread hpayer
https://codereview.chromium.org/1161603006/diff/80001/src/heap/heap.cc File src/heap/heap.cc (right): https://codereview.chromium.org/1161603006/diff/80001/src/heap/heap.cc#newcode1262 src/heap/heap.cc:1262: FragmentationOfCompactedSpacesInPercent(&total_committed); Can we have a separate functi

[v8-dev] Re: Take into account freed global handles and fragmentation when computing heap growing factor. (issue 1161603006 by u...@chromium.org)

2015-06-02 Thread ulan
https://codereview.chromium.org/1161603006/diff/20001/src/heap/heap.cc File src/heap/heap.cc (right): https://codereview.chromium.org/1161603006/diff/20001/src/heap/heap.cc#newcode1294 src/heap/heap.cc:1294: fragmentation_percent >= kLowFragmentationPercent; On 2015/06/02 08:23:00, Hannes Payer

[v8-dev] Re: Take into account freed global handles and fragmentation when computing heap growing factor. (issue 1161603006 by u...@chromium.org)

2015-06-02 Thread hpayer
nice! https://codereview.chromium.org/1161603006/diff/20001/src/heap/heap.cc File src/heap/heap.cc (right): https://codereview.chromium.org/1161603006/diff/20001/src/heap/heap.cc#newcode1294 src/heap/heap.cc:1294: fragmentation_percent >= kLowFragmentationPercent; Can we move this code into a f