[v8-dev] Re: Vector ICs: The Oracle needs to report feedback for the count op. (issue 1321993004 by mvstan...@chromium.org)

Patchset 8 (id:??) landed as https://crrev.com/752b0308df72461bfeb644bf6dd8dd331fcdb722 Cr-Commit-Position: refs/heads/master@{#30686} https://codereview.chromium.org/1321993004/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this messag

[v8-dev] Re: Vector ICs: The Oracle needs to report feedback for the count op. (issue 1321993004 by mvstan...@chromium.org)

Committed patchset #8 (id:140001) https://codereview.chromium.org/1321993004/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and

[v8-dev] Re: Vector ICs: The Oracle needs to report feedback for the count op. (issue 1321993004 by mvstan...@chromium.org)

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1321993004/140001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1321993004/140001 https://codereview.chromium.org/1321993004/ -- -- v8-dev mailing list v8-dev@googlegroups.com

[v8-dev] Re: Vector ICs: The Oracle needs to report feedback for the count op. (issue 1321993004 by mvstan...@chromium.org)

lgtm https://codereview.chromium.org/1321993004/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: Vector ICs: The Oracle needs to report feedback for the count op. (issue 1321993004 by mvstan...@chromium.org)

Hi guys, Addressed Michi's comments, did ports, fixed a bug. Thanks much, --Michael https://codereview.chromium.org/1321993004/diff/40001/src/ast.h File src/ast.h (right): https://codereview.chromium.org/1321993004/diff/40001/src/ast.h#newcode1429 src/ast.h:1429: int ic_slot_count_; On 2015/09/

[v8-dev] Re: Vector ICs: The Oracle needs to report feedback for the count op. (issue 1321993004 by mvstan...@chromium.org)

LGTM on TurboFan, only nits, didn't look at the rest. https://codereview.chromium.org/1321993004/diff/60001/src/ast.h File src/ast.h (right): https://codereview.chromium.org/1321993004/diff/60001/src/ast.h#newcode1510 src/ast.h:1510: // Expression* setter; nit: Still look like a left-over. htt

[v8-dev] Re: Vector ICs: The Oracle needs to report feedback for the count op. (issue 1321993004 by mvstan...@chromium.org)

Reviewers: Michael Starzinger, Jakob, Message: Hi Michi, hi Jakob, PTAL. Jakob - General Michi - Turbofan Thanks, --Michael Description: Vector ICs: The Oracle needs to report feedback for the object literals and the count operation. The refactoring is because it's awkward and error-prone