Igor Lvovsky has posted comments on this change.
Change subject: [WIP] BZ#788640 - Refactor Pool.deleteImage()
..
Patch Set 6: I would prefer that you didn't submit this
(5 inline comments)
looks fine, just minor comments.
sho
Dan Kenigsberg has posted comments on this change.
Change subject: Introduce API getBalloonInfo and setBalloonTarget
..
Patch Set 3: (1 inline comment)
File vdsm/vm.py
Line 9
Dan Kenigsberg has posted comments on this change.
Change subject: Introduce API getBalloonInfo and setBalloonTarget
..
Patch Set 4: I would prefer that you didn't submit this
--
To view, visit http://gerrit.ovirt.org/3669
To u
Igor Lvovsky has posted comments on this change.
Change subject: [WIP] BZ#788640 - Check move image conditions from SD data.
..
Patch Set 6: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.
Igor Lvovsky has posted comments on this change.
Change subject: [WIP] BZ#788640 - Template relink refactored.
..
Patch Set 6: I would prefer that you didn't submit this
(1 inline comment)
only minor 'oop' issue
.
Igor Lvovsky has posted comments on this change.
Change subject: [WIP] BZ#688640 - Remove subChainSizeCalc() and getSubChain().
Remove getAllChildrenList().
..
Patch Set 6: I would prefer that you didn't submit this
(4 inline
Oved Ourfali has posted comments on this change.
Change subject: Added gluster support into vds bootstrap.
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/3351
To unsubs
Lee Yarwood has posted comments on this change.
Change subject: Correct spmprotect.sh to log the sdUUID to spm-lock.log.
..
Patch Set 1:
I'd be happy to leave this correction to the original authors if you'd like to
keep git b
Dan Kenigsberg has posted comments on this change.
Change subject: Correct spmprotect.sh to log the sdUUID to spm-lock.log.
..
Patch Set 1:
note to self: never try to joke in Gerrit. it does not come through.
--
To view, visit
Wenchao Xia has posted comments on this change.
Change subject: Skip parted-utils test if pyparted is not installed.
..
Patch Set 3: Verified; Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovir
Dan Kenigsberg has posted comments on this change.
Change subject: Skip parted-utils test if pyparted is not installed.
..
--
To view, visit http://gerrit.ovirt.org/3853
To unsubscribe, visit http://gerrit.ovirt.org/settings
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Skip parted-utils test if pyparted is not installed.
..
Skip parted-utils test if pyparted is not installed.
At building time, if pyparted is not ins
Dan Kenigsberg has posted comments on this change.
Change subject: workaround pipe and thread issue in python
..
Patch Set 8: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/3638
To unsubscribe, visit http:
Mark Wu has uploaded a new change for review.
Change subject: Fix "unknown device" issue for balloon device
..
Fix "unknown device" issue for balloon device
The balloon device's 'alias' property should be updated in function
_ge
Mark Wu has posted comments on this change.
Change subject: Fix "unknown device" issue for balloon device
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/3901
To unsubscribe, visit http://gerrit.ovirt.org/set
Mark Wu has posted comments on this change.
Change subject: Fix "unknown device" issue for balloon device
..
--
To view, visit http://gerrit.ovirt.org/3901
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-Message
Mark Wu has posted comments on this change.
Change subject: Split xmlrpc server into its own rpm
..
Patch Set 1: (1 inline comment)
File vdsm/clientIF.py
Line 118:
It could
ShaoHe Feng has posted comments on this change.
Change subject: rest-api: Add the basic server infrastructure
..
--
To view, visit http://gerrit.ovirt.org/2021
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-Mes
Bala.FA has posted comments on this change.
Change subject: Added gluster support into vds bootstrap.
..
Patch Set 2: (1 inline comment)
File vds_bootstrap/vds_bootstrap.py
L
Dan Kenigsberg has submitted this change and it was merged.
Change subject: add for in hackVdsmModule - taken from Adam Litke
..
add for in hackVdsmModule - taken from Adam Litke
Change-Id: I76afb4360cb5288b9cfc3cd3dcc05502c8
Dan Kenigsberg has posted comments on this change.
Change subject: add for in hackVdsmModule - taken from Adam Litke
..
Patch Set 1: Looks good to me, approved
no clue regarding mod.vdscli=None, but let us push this asap, lack
Dan Kenigsberg has posted comments on this change.
Change subject: vm payload: add file injection to vm
..
Patch Set 22: (1 inline comment)
File vdsm/mkimage.py
Line 108:
Dan Kenigsberg has posted comments on this change.
Change subject: vm payload: add file injection to vm
..
Patch Set 23: Looks good to me, but someone else must approve
(2 inline comments)
if this patch is verified, we can tak
Adam Litke has uploaded a new change for review.
Change subject: build: Add an option to skip unit tests
..
build: Add an option to skip unit tests
During development it is common to rebuid vdsm many times. In that case it
is v
Dan Kenigsberg has posted comments on this change.
Change subject: build: Add an option to skip unit tests
..
Patch Set 1:
is it any better than
make NOSE_EXCLUDE=.* rpm ?
--
To view, visit http://gerrit.ovirt.org/3906
To un
ShaoHe Feng has posted comments on this change.
Change subject: build: Add an option to skip unit tests
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/3906
To unsubscri
Dan Kenigsberg has posted comments on this change.
Change subject: replace ifconfig cmdline with ethtool and sysfs in netinfo
..
Patch Set 8: I would prefer that you didn't submit this
(1 inline comment)
..
Deepak C Shetty has posted comments on this change.
Change subject: [WIP] Added getStorageDevices verb.
..
Patch Set 1:
Hello Bala,
1) Can you provide a usecase/scenario where this verb will be used in order to
better underst
ShaoHe Feng has posted comments on this change.
Change subject: rest-api: Add unit tests
..
Patch Set 1: Fails
(2 inline comments)
build error when pyflakes check
File test
Adam Litke has posted comments on this change.
Change subject: rest-api: Add unit tests
..
Patch Set 1: I would prefer that you didn't submit this
(2 inline comments)
Needs update to a new version.
...
Adam Litke has posted comments on this change.
Change subject: build: Add an option to skip unit tests
..
Patch Set 1:
Dan, I suppose it has the same effect. Was not aware of this trick with nose.
--
To view, visit http://ger
Shahar Havivi has posted comments on this change.
Change subject: vm payload: add file injection to vm
..
Patch Set 23: (2 inline comments)
File vdsm/mkimage.py
Line 29: from
ShaoHe Feng has uploaded a new change for review.
Change subject: when build vdsm, run_tests.sh runs two times it take a long
time, remove the "make check" in vdsm.spec.in
..
when build vdsm, run_tests.sh runs two times
it take
ShaoHe Feng has posted comments on this change.
Change subject: when build vdsm, run_tests.sh runs two times it take a long
time, remove the "make check" in vdsm.spec.in
..
Patch Set 1:
should I remove the "make check" from au
Dan Kenigsberg has posted comments on this change.
Change subject: vm payload: add file injection to vm
..
Patch Set 24: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/2321
To unsubscr
Mark Wu has posted comments on this change.
Change subject: Fix "unknown device" issue for balloon device
..
Patch Set 1:
Igor,
I am going to send a patch to enable balloon device by default. That means it
will make use of the
Douglas Schilling Landgraf has posted comments on this change.
Change subject: BZ#815825: Do not overwrite cacert.pem
..
Patch Set 1: (1 inline comment)
Commit Message
Line 1
Douglas Schilling Landgraf has posted comments on this change.
Change subject: BZ#815825: Do not overwrite cacert.pem
..
Patch Set 2:
> also, there is another caller to nodeCleanup: vdsm-> config -node-config.
> does the same
Wenchao Xia has posted comments on this change.
Change subject: build: Add an option to skip unit tests
..
Patch Set 1:
It have the same effect, but I think we need document it to let user know.
Maybe add a line in README or a
Hello Ayal Baron, Timothy Asir, Saggi Mizrahi, Federico Simoncelli, Dan
Kenigsberg,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/3908
to review the following change.
Change subject: Added @logDecorator to getMdDeviceUuidMap() in
supervdsmServer.py
..
Lei Li has posted comments on this change.
Change subject: workaround pipe and thread issue in python
..
Patch Set 8: Verified; Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/3638
To u
41 matches
Mail list logo
