Eduardo has posted comments on this change.
Change subject: BZ#784931 - Restore SD.validate() semantics.
..
Patch Set 2: (1 inline comment)
File vdsm/storage/blockSD.py
Line
Mark Wu has posted comments on this change.
Change subject: Fix "unknown device" issue for balloon device
..
Patch Set 2: Verified
Without this fix, the balloon device is recognized as an unknown device when it
parse underlyin
Laszlo Hornyak has posted comments on this change.
Change subject: CpuPinning (#514657)
..
Patch Set 2: (1 inline comment)
Commit Message
Line 5: CommitDate: 2012-06-04 17:20
Laszlo Hornyak has posted comments on this change.
Change subject: CpuPinning for vdsClient (#514657)
..
Patch Set 1: (2 inline comments)
Commit Message
Line 5: CommitDate: 2
Mark Wu has abandoned this change.
Change subject: Introduce a singleton decorator
..
Patch Set 2: Abandoned
Singleton is going to be dropped, so it doesn't make sense to introduce a
generic utility for it.
--
To view, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Fix "unknown device" issue for balloon device
..
Fix "unknown device" issue for balloon device
The balloon device's 'alias' property should be updated
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: clean PEP 8 problems in vdsm/clientIF.py
..
Patch Set 1: (3 inline comments)
File vdsm/clientIF
Dan Kenigsberg has posted comments on this change.
Change subject: CpuPinning for vdsClient (#514657)
..
Patch Set 1: Do not submit
please abandon this. master branch is unused in this downstream gerrit.
--
To view, visit http
Dan Kenigsberg has posted comments on this change.
Change subject: CpuPinning (#514657)
..
Patch Set 2: Do not submit
please abandon this. master branch is unused in this downstream gerrit.
--
To view, visit http://gerrit.user
Lei Li has posted comments on this change.
Change subject: Add passwd command to vdsm-tool
..
Patch Set 7: (2 inline comments)
File vdsm-tool/passwd.py
Line 41: r
Laszlo Hornyak has abandoned this change.
Change subject: CpuPinning (#514657)
..
Patch Set 2: Abandoned
--
To view, visit http://gerrit.usersys.redhat.com/1311
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
G
Laszlo Hornyak has abandoned this change.
Change subject: CpuPinning for vdsClient (#514657)
..
Patch Set 1: Abandoned
--
To view, visit http://gerrit.usersys.redhat.com/1312
To unsubscribe, visit http://gerrit.usersys.redhat.c
Lei Li has posted comments on this change.
Change subject: Replace username and file location for SASL by constants
..
Patch Set 2: (1 inline comment)
File vdsm/constants.py.
Gal Hammer has posted comments on this change.
Change subject: BZ#737104 Disallow cross-vendor virtualization.
..
Patch Set 2: (4 inline comments)
Commit Message
Line 8:
Don
Yair Zaslavsky has uploaded a new change for review.
Change subject: Change storageServer to parse some params as strings
..
Change storageServer to parse some params as strings
engine is sending the connection information as a
Yair Zaslavsky has posted comments on this change.
Change subject: Change storageServer to parse some params as strings
..
Patch Set 1: Verified
Verified.
Used engine in order to add NFS storage domain, passed it version 3, ret
Dan Kenigsberg has posted comments on this change.
Change subject: BZ#737104 Disallow cross-vendor virtualization.
..
Patch Set 4: Looks good to me, approved
Thanks!
Please verify this on Intel and AMD hosts.
--
To view, visit
Dan Kenigsberg has posted comments on this change.
Change subject: Replace username and file location for SASL by constants
..
Patch Set 3: I would prefer that you didn't submit this
(1 inline comment)
Federico Simoncelli has posted comments on this change.
Change subject: BZ#784931 - Restore SD.validate() semantics.
..
Patch Set 2: (1 inline comment)
File vdsm/storage/bloc
Lei Li has posted comments on this change.
Change subject: Replace username and file location for SASL by constants
..
Patch Set 3: (1 inline comment)
File vdsm/constants.py.
Federico Simoncelli has uploaded a new change for review.
Change subject: Add the hostId parameter to reconstructMaster
..
Add the hostId parameter to reconstructMaster
Signed-off-by: Federico Simoncelli
Change-Id: If665af4ed8b
Federico Simoncelli has posted comments on this change.
Change subject: Fix attachSD and masterMigrate for domain version 3
..
Patch Set 9: (2 inline comments)
File vdsm/stor
Mark Wu has uploaded a new change for review.
Change subject: Add a VDSM verb to change MOM policy
..
Add a VDSM verb to change MOM policy
Change-Id: I9f4293b3c6669db91b9c8d6212b01a06ee40ab02
Signed-off-by: Mark Wu
---
M vdsm/A
Mark Wu has uploaded a new change for review.
Change subject: Add a MOM functional test case for KSM
..
Add a MOM functional test case for KSM
Change-Id: Ibeda253c8395a68d98171fad1e6bdbb5a55c3555
Signed-off-by: Mark Wu
---
A te
Laszlo Hornyak has uploaded a new change for review.
Change subject: Better documentation for cpuPinning
..
Better documentation for cpuPinning
Replaces the documentation text with something more helpful with a link
to the full
Shu Ming has posted comments on this change.
Change subject: API: Add formal definition for disk types
..
Patch Set 3:
Adam, could you please explain why you think the API.Image is the right class
to expose the Disktype enum c
Federico Simoncelli has posted comments on this change.
Change subject: Related to BZ#784931 - Removing the unused useCache parameter.
..
Patch Set 1: I would prefer that you didn't submit this
Make sure to rebase and resolve c
Federico Simoncelli has posted comments on this change.
Change subject: Related to BZ#784931 - Removing the unused useCache parameter.
..
Patch Set 1: No score
I just successfully cherry-picked it. I thought we were both removi
Dan Kenigsberg has posted comments on this change.
Change subject: Replace username and file location for SASL by constants
..
Patch Set 4: Looks good to me, approved
Yeah, pushing from a wrong branch may happen.. Thanks.
--
T
Dan Kenigsberg has posted comments on this change.
Change subject: Add passwd command to vdsm-tool
..
Patch Set 9: I would prefer that you didn't submit this
(2 inline comments)
Dan Kenigsberg has posted comments on this change.
Change subject: Change storageServer to parse some params as strings
..
Patch Set 1: Looks good to me, but someone else must approve
yeah, I'm aware that Engine has long-standi
Yair Zaslavsky has posted comments on this change.
Change subject: Change storageServer to parse some params as strings
..
Patch Set 1:
Dan - I totally agree with you here.
Engine should support using a map (using Java terms he
ShaoHe Feng has posted comments on this change.
Change subject: Add a MOM functional test case for KSM
..
Patch Set 1: (1 inline comment)
File tests/functional/momTests.py
Li
Douglas Schilling Landgraf has posted comments on this change.
Change subject: Make safer to get vdsm section version in configuration files
..
Patch Set 1: I would prefer that you didn't submit this
Hi Wenyi, thanks for your p
Wenyi Gao has posted comments on this change.
Change subject: Make safer to get vdsm section version in configuration files
..
Patch Set 1: No score
Hi Douglas, thanks for your comments. Currently, the version number is 4.9.6.
Lei Li has posted comments on this change.
Change subject: Add passwd command to vdsm-tool
..
Patch Set 9: (2 inline comments)
File vdsm-tool/passwd.py
Line 38: r
ShaoHe Feng has posted comments on this change.
Change subject: Add passwd command to vdsm-tool
..
Patch Set 9: Fails; I would prefer that you didn't submit this
(2 inline comments)
test, after subprocess.Popen with close_fds=
ShaoHe Feng has posted comments on this change.
Change subject: Close and remove the temporary file before raising a exception
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovir
Wenchao Xia has posted comments on this change.
Change subject: add arguments parser to testrunner
..
Patch Set 3:
comment for visibility.
--
To view, visit http://gerrit.ovirt.org/4730
To unsubscribe, visit http://gerrit.ovir
Wenchao Xia has posted comments on this change.
Change subject: adjust betterPopenTest.py
..
Patch Set 2:
comment for visibility.
--
To view, visit http://gerrit.ovirt.org/4585
To unsubscribe, visit http://gerrit.ovirt.org/set
Wenchao Xia has posted comments on this change.
Change subject: Close and remove the temporary file before raising a exception
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovir
Wenchao Xia has posted comments on this change.
Change subject: Replace username and file location for SASL by constants
..
Patch Set 4: Looks good to me, but someone else must approve
good, I do not need to search the vdsm Pro
Lei Li has posted comments on this change.
Change subject: Add passwd command to vdsm-tool
..
Patch Set 9: (2 inline comments)
File vdsm-tool/passwd.py
Line 35: f = o
43 matches
Mail list logo
