Eduardo has posted comments on this change. Change subject: BZ#784931 - Restore SD.validate() semantics. ......................................................................
Patch Set 2: (1 inline comment) .................................................... File vdsm/storage/blockSD.py Line 752: lvm.chkVG(self.sdUUID) I agree with you and you already know what is my opinion about functions named validate.* or check,*. But this particular validate() means test the SD without caches, intermediate layers, etc. In general should be removed but we can change the return exception (interface) by now. Please look at the disconnectPool function, it catches exceptions on validate but not after. -- To view, visit http://gerrit.ovirt.org/4955 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I423777deafc4e1d9186054ec33f2744712065512 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Eduardo <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Igor Lvovsky <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
