Royce Lv has posted comments on this change.
Change subject: force reload udev rules to avoid LUN device permission error
..
Patch Set 1:
Eduardo,Thanks for reviewing, but it seems our men are differen;)
From my man:
udevadm c
Zhou Zheng Sheng has uploaded a new change for review.
Change subject: extract a method for appending a child node with a text node to
self.dom in libvirtvm.py
..
extract a method for appending a child node with a text node to s
Zhou Zheng Sheng has uploaded a new change for review.
Change subject: rename xml.dom.minidom.parseString to _domParseStr in libvirtvm
..
rename xml.dom.minidom.parseString to _domParseStr in libvirtvm
The old name is too long a
Dan Kenigsberg has submitted this change and it was merged.
Change subject: deployUtil: avoid garbage character in auth key file
..
deployUtil: avoid garbage character in auth key file
If we fail to get file '/engine.ssh.key.tx
Dan Kenigsberg has posted comments on this change.
Change subject: tests: add testcases for mkimage
..
Patch Set 3: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6761
To unsubscribe, visit http://gerrit.o
Dan Kenigsberg has submitted this change and it was merged.
Change subject: tests: add testcases for mkimage
..
tests: add testcases for mkimage
Added testcases for functions _decodeFilesIntoDir, mkFloppyFs,
mkIsoFs and removeF
Xu He Jie has posted comments on this change.
Change subject: tests: add testcases for mkimage
..
Patch Set 3: Verified; Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/6761
To unsubscr
Mark Wu has uploaded a new change for review.
Change subject: configNetworkTests: Fix wrong key for interface of bridgeless
network
..
configNetworkTests: Fix wrong key for interface of bridgeless network
It breaks build with t
Bing Bu Cao has posted comments on this change.
Change subject: Add a channel in vdsm for introducing qemu-ga
..
Patch Set 14: Verified
Here is the qemu commamd line when start a vm using vdsm:
/usr/bin/qemu-kvm -S -M pc-0.14
Xu He Jie has posted comments on this change.
Change subject: Related to BZ#843387 - Payload should set volPath or raise.
..
Patch Set 2: I would prefer that you didn't submit this
(1 inline comment)
..
Jarod.w has posted comments on this change.
Change subject: deployUtil: avoid garbage character in auth key file
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/6755
To unsubscribe, visit http://gerrit.ovirt.
Saggi Mizrahi has uploaded a new change for review.
Change subject: (Schema) Replace FloatStr with float
..
(Schema) Replace FloatStr with float
Change-Id: I3c01ac527d34419e698123bfecca4ff86eca5450
Signed-off-by: Saggi Mizrahi
Saggi Mizrahi has uploaded a new change for review.
Change subject: (Schema) Minor corrections for IscsiPortal
..
(Schema) Minor corrections for IscsiPortal
Change-Id: I92b4a49190fddb2c04989787f7468b15bff0f0ef
Signed-off-by: Sag
Saggi Mizrahi has uploaded a new change for review.
Change subject: (Schema) Remove varius bool versions, final API will just use
boolean values
..
(Schema) Remove varius bool versions, final API will just use boolean values
Ch
Saggi Mizrahi has uploaded a new change for review.
Change subject: (Schema) Replace IntStr with proper integer types
..
(Schema) Replace IntStr with proper integer types
Change-Id: I147c1ec2743ce3d4758103415f201370441b6e22
Sign
Saggi Mizrahi has uploaded a new change for review.
Change subject: (Schema) Change BlockDevicePathInfo so that it needs one less
redundant enum
..
(Schema) Change BlockDevicePathInfo so that it needs one less redundant enum
Ch
Saggi Mizrahi has uploaded a new change for review.
Change subject: (Schema) Remove deprecated network API functinos
..
(Schema) Remove deprecated network API functinos
Change-Id: Ic12b90643e4f657510128f58fa16da19df8c8aca
Signed
Saggi Mizrahi has uploaded a new change for review.
Change subject: (Schema) Remove HexStr alias
..
(Schema) Remove HexStr alias
Most languages have their own way of representing hexadecimal literals.
This will make sure we don'
Dan Kenigsberg has uploaded a new change for review.
Change subject: configNetworkTests: test new "iface" API
..
configNetworkTests: test new "iface" API
commit 1cb43db326c8 has incurred a change in the reported attributes per
n
Dan Kenigsberg has posted comments on this change.
Change subject: Change source of CPU sockets/cores to libvirt and add
cpuThreads.
..
Patch Set 9: (1 inline comment)
File
Dan Kenigsberg has posted comments on this change.
Change subject: Add a channel in vdsm for introducing qemu-ga
..
Patch Set 13: No score
--
To view, visit http://gerrit.ovirt.org/5640
To unsubscribe, visit http://gerrit.ovirt
Dan Kenigsberg has posted comments on this change.
Change subject: MOM Integration
..
Patch Set 15: Looks good to me, but someone else must approve
(2 inline comments)
this patch has waited long enough.
..
Dan Kenigsberg has submitted this change and it was merged.
Change subject: with exceptions some variables could be uninitialised - now
initialised to None
..
with exceptions some variables could be uninitialised - now initiali
Dan Kenigsberg has posted comments on this change.
Change subject: with exceptions some variables could be uninitialised - now
initialised to None
..
Patch Set 1: Verified; Looks good to me, approved
Thanks, I'll take this pat
Dan Kenigsberg has posted comments on this change.
Change subject: BZ#841863 Change exception thrown by the fileUtils module
..
Patch Set 3:
Alon, Asaf: please tick v+1 if this solves your issues.
--
To view, visit http://gerr
Dan Kenigsberg has posted comments on this change.
Change subject: Added tests for _addNetworkValidation and helpers.
..
Patch Set 7: Looks good to me, approved
Thanks!
--
To view, visit http://gerrit.ovirt.org/6198
To unsubsc
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Added tests for _addNetworkValidation and helpers.
..
Added tests for _addNetworkValidation and helpers.
Helpers are: validateVlanId, validateBondingNa
Saggi Mizrahi has abandoned this change.
Change subject: Integrate deathSignal with remoteFileHandler
..
Patch Set 3: Abandoned
--
To view, visit http://gerrit.ovirt.org/6243
To unsubscribe, visit http://gerrit.ovirt.org/settin
Dan Kenigsberg has posted comments on this change.
Change subject: tests: add testcases for mkimage
..
Patch Set 3: Verified; Looks good to me, but someone else must approve
Thanks, I thinks it's fine now, but I'd like to let o
Saggi Mizrahi has posted comments on this change.
Change subject: BZ#844656 Release the _syncroot lock during _findDomain
..
Patch Set 3: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org
Alon Bar-Lev has posted comments on this change.
Change subject: build: use architecture independent location of site-packages
if possible
..
Patch Set 4:
Dan, as we discussed.
This is a solution for now... we left with the s
Alon Bar-Lev has restored this change.
Change subject: build: use architecture independent location of site-packages
if possible
..
Patch Set 3: Restored
Not splitting better* into own packages for now.
--
To view, visit http
Dan Kenigsberg has posted comments on this change.
Change subject: Implement RLock in betterThreading
..
Patch Set 1: I would prefer that you didn't submit this
oh, so it's a true bug, which is a fact that should be noted in th
Federico Simoncelli has posted comments on this change.
Change subject: Implement RLock in betterThreading
..
Patch Set 1:
> looks cool, but don't we want a test for the new object?
We do.
> are we aware of a specific usecase
Federico Simoncelli has posted comments on this change.
Change subject: [WIP] BZ#844656 Release the lock during _findDomain
..
Patch Set 2: (2 inline comments)
File vdsm/stor
Saggi Mizrahi has posted comments on this change.
Change subject: [WIP] BZ#844656 Release the lock during _findDomain
..
Patch Set 2: I would prefer that you didn't submit this
(2 inline comments)
I've put my version of the lo
Dan Kenigsberg has posted comments on this change.
Change subject: Implement RLock in betterThreading
..
Patch Set 1:
looks cool, but don't we want a test for the new object? and a word on why this
is useful to us wouldn't har
Saggi Mizrahi has posted comments on this change.
Change subject: Implement RLock in betterThreading
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/6832
To unsubscribe,
Federico Simoncelli has uploaded a new change for review.
Change subject: Implement RLock in betterThreading
..
Implement RLock in betterThreading
Signed-off-by: Federico Simoncelli
Change-Id: I697b69fb24b4d741f37d9448295c8bb6a
Dan Kenigsberg has posted comments on this change.
Change subject: BZ#844347 - Prepare conf files for all interfaces before ifup
..
Patch Set 3: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6826
To unsub
Dan Kenigsberg has submitted this change and it was merged.
Change subject: BZ#844347 - Prepare conf files for all interfaces before ifup
..
BZ#844347 - Prepare conf files for all interfaces before ifup
Change-Id: I0ec769e371e0
Igor Lvovsky has posted comments on this change.
Change subject: BZ#844347 - Prepare conf files for all interfaces before ifup
..
Patch Set 3: Verified
--
To view, visit http://gerrit.ovirt.org/6826
To unsubscribe, visit http:/
Dan Kenigsberg has posted comments on this change.
Change subject: BZ#844347 - Prepare conf files for all interfaces before ifup
..
Patch Set 2: I would prefer that you didn't submit this
(1 inline comment)
more of a question
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Don't set BRIDGE in nic's conf files if it part of the bond
..
Don't set BRIDGE in nic's conf files if it part of the bond
Change-Id: Idd6eead286fe4ec0
Dan Kenigsberg has posted comments on this change.
Change subject: Don't set BRIDGE in nic's conf files if it part of the bond
..
Patch Set 1: Looks good to me, approved
yep, that's a recent ugly regression.
--
To view, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Related to BZ#844347 - Keep bond mode after change network on
top of it
..
Related to BZ#844347 - Keep bond mode after change network on top of it
Ass
Dan Kenigsberg has posted comments on this change.
Change subject: Related to BZ#844347 - Keep bond mode after change network on
top of it
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/68
Igor Lvovsky has posted comments on this change.
Change subject: BZ#844347 - Prepare conf files for all interfaces before ifup
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/6826
To unsubscribe, visit http:/
Igor Lvovsky has posted comments on this change.
Change subject: Don't set BRIDGE in nic's conf files if it part of the bond
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/6825
To unsubscribe, visit http://g
Igor Lvovsky has posted comments on this change.
Change subject: Related to BZ#844347 - Keep bond mode after change network on
top of it
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/6805
To unsubscribe, v
Igor Lvovsky has uploaded a new change for review.
Change subject: Don't set BRIDGE in nic's conf files if it part of the bond
..
Don't set BRIDGE in nic's conf files if it part of the bond
Change-Id: Idd6eead286fe4ec00a668c75c4
Igor Lvovsky has uploaded a new change for review.
Change subject: BZ#844347 - Prepare conf files for all interfaces before ifup
..
BZ#844347 - Prepare conf files for all interfaces before ifup
Change-Id: I0ec769e371e01eed240d80
Peter V. Saveliev has uploaded a new change for review.
Change subject: migrateStatus() progress report
..
migrateStatus() progress report
The percentage is based on libvirt dataTotal and dataProcessed
fields of the virDomainJob
Federico Simoncelli has posted comments on this change.
Change subject: [WIP] BZ#844656 Release the lock during _findDomain
..
Patch Set 1: (1 inline comment)
File vdsm/stora
Dan Kenigsberg has submitted this change and it was merged.
Change subject: report network's underlying device as "iface"
..
report network's underlying device as "iface"
ovirt-engine-3.1 expects to see "interface" for bridgele
Dan Kenigsberg has posted comments on this change.
Change subject: report network's underlying device as "iface"
..
Patch Set 3: Verified
--
To view, visit http://gerrit.ovirt.org/6806
To unsubscribe, visit http://gerrit.ovirt.
Xu He Jie has posted comments on this change.
Change subject: BZ#843387 - prepareVolumePath() should set volPath or raise on
any input.
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://g
Federico Simoncelli has uploaded a new change for review.
Change subject: [WIP] BZ#844656 Release the lock during _findDomain
..
[WIP] BZ#844656 Release the lock during _findDomain
Signed-off-by: Federico Simoncelli
Change-Id:
Shahar Havivi has posted comments on this change.
Change subject: with exceptions some variables could be uninitialised - now
initialised to None
..
Patch Set 1: No score; Looks good to me, but someone else must approve
--
To
Gal Hammer has posted comments on this change.
Change subject: Related to BZ#843387 - Payload should set volPath or raise.
..
Patch Set 2: Looks good to me, but someone else must approve
I think that the try's else is redundant
Igor Lvovsky has posted comments on this change.
Change subject: report network's underlying device as "iface"
..
Patch Set 3: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6806
To unsubscribe, visit http
Dan Kenigsberg has posted comments on this change.
Change subject: Related to BZ#844347 - Keep bond mode after change network on
top of it
..
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
good by
Moti Asayag has posted comments on this change.
Change subject: report network's underlying device as "iface"
..
Patch Set 2: Verified
Verified on rhel6.3:
iface attribute added to network devices and reports the correct netwo
Igor Lvovsky has posted comments on this change.
Change subject: report network's underlying device as "iface"
..
Patch Set 2: I would prefer that you didn't submit this
You missed several usages of 'interface'.
I found two, bu
Dan Kenigsberg has posted comments on this change.
Change subject: tests: add testcases for mkimage
..
Patch Set 2: Verified; I would prefer that you didn't submit this
(1 inline comment)
thanks, this looks much better.
.
Eduardo has posted comments on this change.
Change subject: force reload udev rules to avoid LUN device permission error
..
Patch Set 1: I would prefer that you didn't submit this
(2 inline comments)
Reloading the udev rules i
Antoni Segura Puimedon has posted comments on this change.
Change subject: Related to BZ#844347 - Keep bond mode after change network on
top of it
..
Patch Set 1: (1 inline comment)
Dan Kenigsberg has submitted this change and it was merged.
Change subject: BZ#844294 Add requiresMailbox to StorageDomain
..
BZ#844294 Add requiresMailbox to StorageDomain
Since commit 942c2dc the storage domain objects are al
Haim Ateya has posted comments on this change.
Change subject: BZ#844294 Add requiresMailbox to StorageDomain
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/6754
To unsubscribe, visit http://gerrit.ovirt.org
Dan Kenigsberg has uploaded a new change for review.
Change subject: report network's underlying device as "iface"
..
report network's underlying device as "iface"
ovirt-engine-3.1 expects to see "interface" for bridgeless netwo
Federico Simoncelli has posted comments on this change.
Change subject: BZ#844656 Respawn the domain monitor when needed
..
Patch Set 3: I would prefer that you didn't submit this
(1 inline comment)
...
Gal Hammer has posted comments on this change.
Change subject: Related to BZ#843387 - Payload should set volPath or raise.
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.or
Gal Hammer has posted comments on this change.
Change subject: BZ#843387 - prepareVolumePath() should set volPath or raise on
any input.
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://
Allon Mureinik has posted comments on this change.
Change subject: BZ#843387 - prepareVolumePath() should set volPath or raise on
any input.
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit htt
Federico Simoncelli has posted comments on this change.
Change subject: BZ#841863 Change exception thrown by the fileUtils module
..
Patch Set 3: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6463
To unsu
Igor Lvovsky has posted comments on this change.
Change subject: Related to BZ#844347 - Keep bond mode after change network on
top of it
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/6805
To unsubscribe, v
Igor Lvovsky has uploaded a new change for review.
Change subject: Related to BZ#844347 - Keep bond mode after change network on
top of it
..
Related to BZ#844347 - Keep bond mode after change network on top of it
Assume we hav
Eduardo has uploaded a new change for review.
Change subject: Related to BZ#843387 - Payload should set volPath or raise.
..
Related to BZ#843387 - Payload should set volPath or raise.
Change-Id: I0d5b36a88752ad2191226191c9502c1
78 matches
Mail list logo
