Change in vdsm[master]: Fix the check to convert block domains V0 to tag metadata

oVirt Jenkins CI Server has posted comments on this change. Change subject: Fix the check to convert block domains V0 to tag metadata .. Patch Set 1: Build Successful http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/794/ :

Change in vdsm[master]: Fix the check to convert block domains V0 to tag metadata

Federico Simoncelli has uploaded a new change for review. Change subject: Fix the check to convert block domains V0 to tag metadata .. Fix the check to convert block domains V0 to tag metadata In this patch: * fix the check to d

Change in vdsm[master]: tc: avoid adding non-existing devices to filter

Antoni Segura Puimedon has posted comments on this change. Change subject: tc: avoid adding non-existing devices to filter .. Patch Set 2: Looks good to me, but someone else must approve Agreed. It removes part of the risk. --

Change in vdsm[master]: schema: Rename Global class to Host

Dan Kenigsberg has posted comments on this change. Change subject: schema: Rename Global class to Host .. Patch Set 7: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/7010 To unsubscrib

Change in vdsm[master]: Remove superfluous macros in the specfile

Douglas Schilling Landgraf has posted comments on this change. Change subject: Remove superfluous macros in the specfile .. Patch Set 1: Verified; Looks good to me, but someone else must approve -- To view, visit http://gerrit.

Change in vdsm[master]: Fix some PEP8 violations in vm.py so the pep8 tool would sto...

Dan Kenigsberg has posted comments on this change. Change subject: Fix some PEP8 violations in vm.py so the pep8 tool would stop complaining .. Patch Set 2: I would prefer that you didn't submit this (2 inline comments) .

Change in vdsm[master]: Move fenceNode out of API.py

Dan Kenigsberg has posted comments on this change. Change subject: Move fenceNode out of API.py .. Patch Set 7: I would prefer that you didn't submit this (1 inline comment)

Change in vdsm[master]: Move fencing logic out of API.py

Dan Kenigsberg has posted comments on this change. Change subject: Move fencing logic out of API.py .. Patch Set 6: I would prefer that you didn't submit this (1 inline comment) I wish I had a unit test for API.Global.fenceAge

Change in vdsm[master]: Remove redundant indirection for getting vm status

Dan Kenigsberg has submitted this change and it was merged. Change subject: Remove redundant indirection for getting vm status .. Remove redundant indirection for getting vm status Change-Id: I789155bb2dc1b7df911c949c08567c8f34

Change in vdsm[master]: Remove redundant indirection for getting vm status

Dan Kenigsberg has posted comments on this change. Change subject: Remove redundant indirection for getting vm status .. Patch Set 3: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7421 To unsubs

Change in vdsm[master]: Make libvirtvm.py PEP8 compliant

Dan Kenigsberg has posted comments on this change. Change subject: Make libvirtvm.py PEP8 compliant .. Patch Set 2: Do not submit I believe this issue has been solved by http://gerrit.ovirt.org/6561 . Please abandon. -- To vi

Change in vdsm[master]: Remove superfluous macros in the specfile

Dan Kenigsberg has posted comments on this change. Change subject: Remove superfluous macros in the specfile .. Patch Set 1: Looks good to me, but someone else must approve making so many files owned by vdsm:kvm is a bug, with

Change in vdsm[master]: Remove superfluous macros in the specfile

oVirt Jenkins CI Server has posted comments on this change. Change subject: Remove superfluous macros in the specfile .. Patch Set 1: Build Successful http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/793/ : SUCCESS -- To

Change in vdsm[master]: Remove superfluous macros in the specfile

Federico Simoncelli has uploaded a new change for review. Change subject: Remove superfluous macros in the specfile .. Remove superfluous macros in the specfile In this patch: * remove the redundant %attr macros for the vdsm hoo

Change in vdsm[master]: Support for GLUSTERFS_DOMAIN

Federico Simoncelli has posted comments on this change. Change subject: Support for GLUSTERFS_DOMAIN .. Patch Set 6: I would prefer that you didn't submit this (1 inline comment) ...

Change in vdsm[master]: bootstrap: node id: consider bonding MAC addresses as well

Barak Azulay has posted comments on this change. Change subject: bootstrap: node id: consider bonding MAC addresses as well .. Patch Set 3: 1 - only caps.py uses the utils.getHostUUID and I'm almost certain the engine does not

Change in vdsm[master]: Move load_needed_modules to vdsm-tool

Wenyi Gao has posted comments on this change. Change subject: Move load_needed_modules to vdsm-tool .. Patch Set 5: No score (1 inline comment) File vdsm-tool/load_needed_mo

Change in vdsm[master]: vdsmd always restarts libvirtd upon start-up

Dan Kenigsberg has posted comments on this change. Change subject: vdsmd always restarts libvirtd upon start-up .. Patch Set 17: Looks good to me, approved Yaniv, I wanted to verify your patch, but I cannot reproduce the bug ev

Change in vdsm[master]: vdsmd always restarts libvirtd upon start-up

Dan Kenigsberg has submitted this change and it was merged. Change subject: vdsmd always restarts libvirtd upon start-up .. vdsmd always restarts libvirtd upon start-up Bug-Id: https://bugzilla.redhat.com/734847 When starting

Change in vdsm[master]: bootstrap: node id: consider bonding MAC addresses as well

Dan Kenigsberg has posted comments on this change. Change subject: bootstrap: node id: consider bonding MAC addresses as well .. Patch Set 3: Ahhh, I should not have taken this patch. We are stupid enough to have a competing i

Change in vdsm[master]: tc: unsetPortMirroring: deleting a target twice is fine

Antoni Segura Puimedon has posted comments on this change. Change subject: tc: unsetPortMirroring: deleting a target twice is fine .. Patch Set 1: Looks good to me, but someone else must approve -- To view, visit http://gerrit.

Change in vdsm[master]: momTest: improve test's error reports

Dan Kenigsberg has submitted this change and it was merged. Change subject: momTest: improve test's error reports .. momTest: improve test's error reports The test is skipped if MOM is not installed on host. Also, the returned

Change in vdsm[master]: momTest: improve test's error reports

Dan Kenigsberg has posted comments on this change. Change subject: momTest: improve test's error reports .. Patch Set 2: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7571 To unsubscribe, visit

Change in vdsm[master]: vdsmd always restarts libvirtd upon start-up

oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsmd always restarts libvirtd upon start-up .. Patch Set 17: Build Successful http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/792/ : SUCCESS --

Change in vdsm[master]: vdsmd always restarts libvirtd upon start-up

Yaniv Bronhaim has posted comments on this change. Change subject: vdsmd always restarts libvirtd upon start-up .. Patch Set 17: Verified -- To view, visit http://gerrit.ovirt.org/7331 To unsubscribe, visit http://gerrit.ovirt.

Change in vdsm[master]: libvirtvm: (un)setPortMirroring when hot(un)plugging

Antoni Segura Puimedon has posted comments on this change. Change subject: libvirtvm: (un)setPortMirroring when hot(un)plugging .. Patch Set 6: Looks good to me, but someone else must approve Continues to look good to me as it

Change in vdsm[master]: Move load_needed_modules to vdsm-tool

Dan Kenigsberg has posted comments on this change. Change subject: Move load_needed_modules to vdsm-tool .. Patch Set 5: I would prefer that you didn't submit this (4 inline comments) ..

Change in vdsm[master]: Add a basic xmlrpc functional test

Dan Kenigsberg has submitted this change and it was merged. Change subject: Add a basic xmlrpc functional test .. Add a basic xmlrpc functional test Change-Id: I6ab2ac67717339cac697df4b507e65cf0a4a8f19 Signed-off-by: Dan Kenigs

Change in vdsm[master]: Add a basic xmlrpc functional test

Dan Kenigsberg has posted comments on this change. Change subject: Add a basic xmlrpc functional test .. Patch Set 3: Looks good to me, approved Thanks, Zhou! -- To view, visit http://gerrit.ovirt.org/5788 To unsubscribe, visi

Change in vdsm[master]: Added _execGlusterXml()

Dan Kenigsberg has posted comments on this change. Change subject: Added _execGlusterXml() .. Patch Set 7: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6999 To unsubscribe, visit http://gerrit.ovirt.org/

Change in vdsm[master]: Added gluster tag support in getAllTasks()

oVirt Jenkins CI Server has posted comments on this change. Change subject: Added gluster tag support in getAllTasks() .. Patch Set 2: Build Successful http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/791/ : SUCCESS -- To

Change in vdsm[master]: Added glusterVolumeStatus verb

oVirt Jenkins CI Server has posted comments on this change. Change subject: Added glusterVolumeStatus verb .. Patch Set 7: Build Successful http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/790/ : SUCCESS -- To view, visit

Change in vdsm[master]: glusterHostsList verb returns local hostname as IP address o...

oVirt Jenkins CI Server has posted comments on this change. Change subject: glusterHostsList verb returns local hostname as IP address or FQDN .. Patch Set 2: Build Successful http://jenkins.ovirt.info/job/patch_vdsm_unit_te

Change in vdsm[master]: Added _execGlusterXml()

oVirt Jenkins CI Server has posted comments on this change. Change subject: Added _execGlusterXml() .. Patch Set 7: Build Successful http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/788/ : SUCCESS -- To view, visit http:/

Change in vdsm[master]: Added _execGlusterXml()

Bala.FA has posted comments on this change. Change subject: Added _execGlusterXml() .. Patch Set 6: (3 inline comments) File vdsm/gluster/cli.py Line 72: rc, out, err = u