Ayal Baron has posted comments on this change.
Change subject: Revert "hsm: always check validateNotSPM when disconnecting
from a pool"
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13926
Ayal Baron has posted comments on this change.
Change subject: Stop spm if refresh fail on bad parameters.
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13930
To unsubscribe, visit http://
Dan Kenigsberg has posted comments on this change.
Change subject: libvirt exception should be caught only in libvirtconnection
..
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
Timothy Asir has posted comments on this change.
Change subject: gluster: move exportToSupervdsm at module level
..
Patch Set 14: (1 inline comment)
File vdsm/gluster/__init_
oVirt Jenkins CI Server has posted comments on this change.
Change subject: WIP vm payload: cloud-init - multiple files, custom volume label
..
Patch Set 1: Fails
Build Failed
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/209
Greg Padgett has uploaded a new change for review.
Change subject: WIP vm payload: cloud-init - multiple files, custom volume label
..
WIP vm payload: cloud-init - multiple files, custom volume label
Changes required for cloud-i
oVirt Jenkins CI Server has posted comments on this change.
Change subject: WIP vm payload: cloud-init - multiple files, custom volume label
..
Patch Set 1:
Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2092/ (1/2
oVirt Jenkins CI Server has posted comments on this change.
Change subject: WIP vm payload: cloud-init - multiple files, custom volume label
..
Patch Set 1:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2152
Dan Kenigsberg has posted comments on this change.
Change subject: Added unit test libvirtvmTests.py:TestLibvirtvm.testBuildCmdLine
..
Patch Set 5: (1 inline comment)
File te
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Makefile.am: ignore false positive pyflakes lvm.py
..
Makefile.am: ignore false positive pyflakes lvm.py
Temporary workaround.
Change-Id: Id8cdeb0c28c
Dan Kenigsberg has submitted this change and it was merged.
Change subject: stats: report the domain version
..
stats: report the domain version
Given that some features are available only since a specific domain
version (e.g.
Dan Kenigsberg has posted comments on this change.
Change subject: stats: report the domain version
..
Patch Set 7: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13620
To unsubscribe, visit http://gerrit.
Allon Mureinik has posted comments on this change.
Change subject: stats: report the domain version
..
Patch Set 7: Looks good to me, but someone else must approve
@Federico - I'm guessing this will be followed by an engine pat
Vinzenz Feenstra has posted comments on this change.
Change subject: Added unit test libvirtvmTests.py:TestLibvirtvm.testBuildCmdLine
..
Patch Set 5: (1 inline comment)
File
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Adding utils package to outOfProcess and remoteFileHandler
..
Adding utils package to outOfProcess and remoteFileHandler
As part of http://gerrit.ovirt
oVirt Jenkins CI Server has posted comments on this change.
Change subject: libvirt exception should be caught only in libvirtconnection
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2091/ : S
Yaniv Bronhaim has uploaded a new change for review.
Change subject: libvirt exception should be caught only in libvirtconnection
..
libvirt exception should be caught only in libvirtconnection
All libvirt calls from vdsm should
oVirt Jenkins CI Server has posted comments on this change.
Change subject: libvirt exception should be caught only in libvirtconnection
..
Patch Set 1:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2151/ (1
oVirt Jenkins CI Server has posted comments on this change.
Change subject: libvirt exception should be caught only in libvirtconnection
..
Patch Set 1:
Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2091/ (2/2)
-
Yaniv Bronhaim has posted comments on this change.
Change subject: Adding utils package to outOfProcess and remoteFileHandler
..
Patch Set 5:
why don't you like it ? what do you suggest? not to use utils with oop ? moving
util
Yaniv Bronhaim has posted comments on this change.
Change subject: Adding utils package to outOfProcess and remoteFileHandler
..
Patch Set 5: Verified
--
To view, visit http://gerrit.ovirt.org/14325
To unsubscribe, visit http:/
Dan Kenigsberg has posted comments on this change.
Change subject: Added unit test libvirtvmTests.py:TestLibvirtvm.testBuildCmdLine
..
Patch Set 5: I would prefer that you didn't submit this
(6 inline comments)
(Partial review
Dan Kenigsberg has posted comments on this change.
Change subject: storage.misc: Move execCmd and its dependencies to vdsm.utils
..
Patch Set 1:
Ping. Thanks for fixing logskip! Now a rebase is required.
--
To view, visit http
Dan Kenigsberg has posted comments on this change.
Change subject: Adding utils package to outOfProcess and remoteFileHandler
..
Patch Set 5: Looks good to me, approved
I cannot say that I like it, but I suppose we should unbre
Dan Kenigsberg has posted comments on this change.
Change subject: fix pep8 err
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14340
To unsubscribe, visit http://gerrit.ovirt.org/settings
Dan Kenigsberg has submitted this change and it was merged.
Change subject: fix pep8 err
..
fix pep8 err
Change-Id: Ib502fd06e46ae9f754f2f0247a64140624eac2af
Signed-off-by: Yaniv Bronhaim
---
M vdsm/configNetwork.py
1 file cha
oVirt Jenkins CI Server has posted comments on this change.
Change subject: NetReload: netmodels for addNetwork
..
Patch Set 4:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2090/ : SUCCESS
http://jenkins.ov
oVirt Jenkins CI Server has posted comments on this change.
Change subject: NetReload: netmodels for addNetwork
..
Patch Set 4:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2150/ (2/2)
--
To view, visit ht
oVirt Jenkins CI Server has posted comments on this change.
Change subject: NetReload: netmodels for addNetwork
..
Patch Set 4:
Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2090/ (1/2)
--
To view, visit http://g
Antoni Segura Puimedon has posted comments on this change.
Change subject: NetReload: netmodels for addNetwork
..
Patch Set 3: Fails; I would prefer that you didn't submit this
(1 inline comment)
Discovered issue not covered b
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Adding utils package to outOfProcess and remoteFileHandler
..
Patch Set 5:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2089/ : SUC
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Adding utils package to outOfProcess and remoteFileHandler
..
Patch Set 5:
Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2089/ (1/2)
--
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Adding utils package to outOfProcess and remoteFileHandler
..
Patch Set 5:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2149/ (2/2
Dan Kenigsberg has submitted this change and it was merged.
Change subject: cleanup: inline STRG_*SCSI_* macros
..
cleanup: inline STRG_*SCSI_* macros
They are used only once; their name is less clear than their content.
Chang
Dan Kenigsberg has posted comments on this change.
Change subject: cleanup: inline STRG_*SCSI_* macros
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14256
To unsubscribe, visit h
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Adding utils package to outOfProcess and remoteFileHandler
..
Patch Set 4:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2088/ : SUC
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Adding utils package to outOfProcess and remoteFileHandler
..
Patch Set 4:
Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2088/ (2/2)
--
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Adding utils package to outOfProcess and remoteFileHandler
..
Patch Set 4:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2148/ (1/2
Yaniv Bronhaim has posted comments on this change.
Change subject: Adding utils package to outOfProcess and remoteFileHandler
..
Patch Set 3: (1 inline comment)
File vdsm/sto
Kiril Nesenko has posted comments on this change.
Change subject: fix pep8 err
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/14340
To unsubscribe, visit http://gerrit.
Yaniv Bronhaim has posted comments on this change.
Change subject: fix pep8 err
..
Patch Set 2: Verified
Sorry to miss that, honestly I ran make check and verified that it passes,
probably my host had old pep8 instance. Now it
oVirt Jenkins CI Server has posted comments on this change.
Change subject: fix pep8 err
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2087/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_unit_t
oVirt Jenkins CI Server has posted comments on this change.
Change subject: fix pep8 err
..
Patch Set 2:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2147/ (2/2)
--
To view, visit http://gerrit.ovirt.org/1
oVirt Jenkins CI Server has posted comments on this change.
Change subject: fix pep8 err
..
Patch Set 2:
Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2087/ (1/2)
--
To view, visit http://gerrit.ovirt.org/14340
T
oVirt Jenkins CI Server has posted comments on this change.
Change subject: cleanup: inline STRG_*SCSI_* macros
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2086/ : SUCCESS
http://jenkins.ov
oVirt Jenkins CI Server has posted comments on this change.
Change subject: cleanup: inline STRG_*SCSI_* macros
..
Patch Set 2:
Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2086/ (1/2)
--
To view, visit http://g
oVirt Jenkins CI Server has posted comments on this change.
Change subject: cleanup: inline STRG_*SCSI_* macros
..
Patch Set 2:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2146/ (2/2)
--
To view, visit ht
Antoni Segura Puimedon has posted comments on this change.
Change subject: NetReload: netmodels for addNetwork
..
Patch Set 3: (2 inline comments)
File lib/vdsm/netinfo.py
Li
Dan Kenigsberg has posted comments on this change.
Change subject: Adding utils package to outOfProcess and remoteFileHandler
..
Patch Set 3: I would prefer that you didn't submit this
(2 inline comments)
.
Antoni Segura Puimedon has posted comments on this change.
Change subject: NetReload: netmodels for addNetwork
..
Patch Set 3:
Note the bad omen of the patch having +666 lines :-)
--
To view, visit http://gerrit.ovirt.org/1430
oVirt Jenkins CI Server has posted comments on this change.
Change subject: NetReload: netmodels for addNetwork
..
Patch Set 3:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2085/ : SUCCESS
http://jenkins.ov
Antoni Segura Puimedon has posted comments on this change.
Change subject: NetReload: netmodels for addNetwork
..
Patch Set 3: Verified
--
To view, visit http://gerrit.ovirt.org/14303
To unsubscribe, visit http://gerrit.ovirt.o
oVirt Jenkins CI Server has posted comments on this change.
Change subject: NetReload: netmodels for addNetwork
..
Patch Set 3:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2145/ (1/2)
--
To view, visit ht
oVirt Jenkins CI Server has posted comments on this change.
Change subject: NetReload: netmodels for addNetwork
..
Patch Set 3:
Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2085/ (2/2)
--
To view, visit http://g
Dan Kenigsberg has posted comments on this change.
Change subject: fix pep8 err
..
Patch Set 1: Fails; I would prefer that you didn't submit this
vdsm/configNetwork.py:563:58: E121 continuation line indentation is not a
multip
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Added setupNetworks command to vdsClient
..
Patch Set 3:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2084/ : SUCCESS
http://jenki
Petr Sebek has posted comments on this change.
Change subject: Added setupNetworks command to vdsClient
..
Patch Set 3:
Fixed ineffective command to adding connectivityCheckout=False as default.
Example of Usage:
vdsClient 0 s
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Added setupNetworks command to vdsClient
..
Patch Set 3:
Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2084/ (2/2)
--
To view, visit htt
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Added setupNetworks command to vdsClient
..
Patch Set 3:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2144/ (1/2)
--
To view, vis
oVirt Jenkins CI Server has posted comments on this change.
Change subject: fix pep8 err
..
Patch Set 1: Fails
Build Failed
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2083/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_unit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: fix pep8 err
..
Patch Set 1: No score
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2143/ (2/2)
--
To view, visit http://gerrit.ov
oVirt Jenkins CI Server has posted comments on this change.
Change subject: fix pep8 err
..
Patch Set 1: Fails
Build Failed
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2083/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_unit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: fix pep8 err
..
Patch Set 1: No score
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2142/ (2/2)
--
To view, visit http://gerrit.ov
oVirt Jenkins CI Server has posted comments on this change.
Change subject: fix pep8 err
..
Patch Set 1: Fails
Build Failed
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2083/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_unit
You're right. http://gerrit.ovirt.org/14340 fixed it. Thanks.
Regards,
Yaniv Bronhaim.
- Original Message -
> From: "Dan Kenigsberg"
> To: "Ewoud Kohl van Wijngaarden"
> Cc: vdsm-patches@lists.fedorahosted.org, "Kiril Nesenko"
> Sent: Tuesday, April 30, 2013 11:54:47 AM
> Subject: Re:
Yaniv Bronhaim has posted comments on this change.
Change subject: fix pep8 err
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/14340
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType
oVirt Jenkins CI Server has posted comments on this change.
Change subject: fix pep8 err
..
Patch Set 1:
Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2083/ (2/2)
--
To view, visit http://gerrit.ovirt.org/14340
T
Yaniv Bronhaim has uploaded a new change for review.
Change subject: fix pep8 err
..
fix pep8 err
Change-Id: Ib502fd06e46ae9f754f2f0247a64140624eac2af
Signed-off-by: Yaniv Bronhaim
---
M vdsm/configNetwork.py
1 file changed, 2
oVirt Jenkins CI Server has posted comments on this change.
Change subject: fix pep8 err
..
Patch Set 1:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2141/ (1/2)
--
To view, visit http://gerrit.ovirt.org/1
On Mon, Apr 29, 2013 at 06:13:38PM +0200, Ewoud Kohl van Wijngaarden wrote:
> On Mon, Apr 29, 2013 at 11:02:43AM -0400, Kiril Nesenko wrote:
> >
> > - Original Message -
> > > From: "Ewoud Kohl van Wijngaarden"
> > > To: "David Caro"
> > > Cc: "Kiril Nesenko" , "Dan Kenigsberg"
> > > ,
- Original Message -
> From: "Yaniv Bronheim"
> To: "Kiril Nesenko"
> Cc: "Dan Kenigsberg" , "Ewoud Kohl van Wijngaarden"
> ,
> vdsm-patches@lists.fedorahosted.org
> Sent: Tuesday, April 30, 2013 11:41:40 AM
> Subject: Re: vdsm does not build on fedora17
>
> the version is alright and
the version is alright and the error seems meaningful if the spaces are not
there
what branch of vdsm do you run there?
- Original Message -
> From: "Kiril Nesenko"
> To: "Dan Kenigsberg"
> Cc: "Ewoud Kohl van Wijngaarden" ,
> vdsm-patches@lists.fedorahosted.org
> Sent: Tuesday, Apri
Yaniv Bronhaim has posted comments on this change.
Change subject: Makefile.am: ignore false positive pyflakes lvm.py
..
Patch Set 1: No score
The code there can be confusing and risky, and its not a case of:
if *:
a = 1
el
- Original Message -
> From: "Ewoud Kohl van Wijngaarden"
> To: "Kiril Nesenko"
> Cc: "David Caro" , "Dan Kenigsberg" ,
> vdsm-patches@lists.fedorahosted.org,
> "Mark Wu"
> Sent: Monday, April 29, 2013 7:13:38 PM
> Subject: Re: vdsm does not build on fedora17
>
> On Mon, Apr 29, 2013
Giuseppe Vallarelli has posted comments on this change.
Change subject: WIP test: regression test to catch cross imports.
..
Patch Set 4:
As proof of this test catching cross imports and showing the offending one, you
can add
75 matches
Mail list logo
