Dan Kenigsberg has posted comments on this change.
Change subject: libvirt configure: use "ed" instead of "sed --copy -i"
..
Patch Set 2:
(1 comment)
File lib/vdsm/tool/libv
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Make hsm.getVolumesList() pool independent.
..
Patch Set 7:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/3883/ : SUCCESS
htt
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Avoid redundant check for volume create rollback.
..
Patch Set 3:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/3882/ : SUCCES
oVirt Jenkins CI Server has posted comments on this change.
Change subject: New getChildrenList implementation.
..
Patch Set 6:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/3881/ : SUCCESS
http://jenk
Zhou Zheng Sheng has posted comments on this change.
Change subject: Refactored xmlrpcTests to allow for more complex tests using
running VM
..
Patch Set 3: Code-Review-1
(5 comments)
Nice patch, you make the generated initra
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Avoid redundant volume produces.
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/3880/ : SUCCESS
http://jenkins
Eduardo has uploaded a new change for review.
Change subject: Avoid redundant volume produces.
..
Avoid redundant volume produces.
Add sd.getVolumePath() returns the volume path without produce it.
Deprecating hsm.getVolumePath
Giuseppe Vallarelli has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 15:
(6 comments)
Generally it looks good, I appreciate your good will of adding docstrings you
might think to
Yaniv Bronhaim has posted comments on this change.
Change subject: Handling signals interrupts, using pidofproc and prevent lock
over systemd
..
Patch Set 6:
[1]http://gerrit.ovirt.org/#/c/15578 already rebased over the lockin
Alon Bar-Lev has posted comments on this change.
Change subject: Handling signals interrupts, using pidofproc and prevent lock
over systemd
..
Patch Set 6:
I do not think so as the systemd and sysv executing different scripts.
Yaniv Bronhaim has posted comments on this change.
Change subject: Handling signals interrupts, using pidofproc and prevent lock
over systemd
..
Patch Set 6:
This treatment will be needed to be handled also after merging the a
Alon Bar-Lev has posted comments on this change.
Change subject: Handling signals interrupts, using pidofproc and prevent lock
over systemd
..
Patch Set 6:
This is helpless race... better to merge[1] and continue from there.
Yaniv Bronhaim has posted comments on this change.
Change subject: Handling signals interrupts, using pidofproc and prevent lock
over systemd
..
Patch Set 6: Verified+1
(2 comments)
This patch is followed to http://gerrit.ovi
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Handling signals interrupts, using pidofproc and prevent lock
over systemd
..
Patch Set 6:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_t
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Handling signals interrupts, using pidofproc and prevent lock
over systemd
..
Patch Set 5:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_t
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Handling signals interrupts, using pidofproc and prevent lock
over systemd
..
Patch Set 4:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_t
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Handling signals interrupts during start and stop and using
pidofproc
..
Patch Set 3:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_
oVirt Jenkins CI Server has posted comments on this change.
Change subject: jsonrpc: Add SSL support to asyncore transport
..
Patch Set 7: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/3875/ : FA
oVirt Jenkins CI Server has posted comments on this change.
Change subject: jsonrpc: Make proton reactor client capable as well
..
Patch Set 15:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/3874/ : SUC
oVirt Jenkins CI Server has posted comments on this change.
Change subject: java_bindings: SSL support
..
Patch Set 8: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/3873/ : FAILURE
http://jenkin
oVirt Jenkins CI Server has posted comments on this change.
Change subject: java_binding: Simplify bindings by using object mappers
..
Patch Set 5: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/3
oVirt Jenkins CI Server has posted comments on this change.
Change subject: java_bindings: Minor imporovements
..
Patch Set 11: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/3871/ : FAILURE
http
oVirt Jenkins CI Server has posted comments on this change.
Change subject: java_bindings: Add function overloads
..
Patch Set 9: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/3869/ : FAILURE
ht
Ohad Basan has posted comments on this change.
Change subject: Handling signals interrupts during start and stop and using
pidofproc
..
Patch Set 3:
(1 comment)
File vdsm/v
oVirt Jenkins CI Server has posted comments on this change.
Change subject: jsonrpc: Fix race in AsynChat
..
Patch Set 8:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/3870/ : SUCCESS
http://jenkins.ov
oVirt Jenkins CI Server has posted comments on this change.
Change subject: jsonrpc: Change base class invoke semantics
..
Patch Set 8:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/3868/ : SUCCESS
htt
oVirt Jenkins CI Server has posted comments on this change.
Change subject: jsonrpc: Introduce the definitive JsonRpcClient
..
Patch Set 15: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/3867/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: java_bindings: Java client
..
Patch Set 19: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/3866/ : FAILURE
http://jenki
oVirt Jenkins CI Server has posted comments on this change.
Change subject: [WIP] Java_Bindings: Create a spec file
..
Patch Set 2: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/3865/ : FAILURE
Eduardo has posted comments on this change.
Change subject: Rename *Volume.extend method to *Volume.enlarge
..
Patch Set 1:
The function is really enlarging. And a re aa lot of extend calls all over the
code. Needed for clarit
Yaniv Bronhaim has posted comments on this change.
Change subject: Handling signals interrupts during start
..
Patch Set 2: Verified+1
--
To view, visit http://gerrit.ovirt.org/17926
To unsubscribe, visit http://gerrit.ovirt.o
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Refactored xmlrpcTests to allow for more complex tests using
running VM
..
Patch Set 3:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_test
Martin Polednik has posted comments on this change.
Change subject: Refactored xmlrpcTests to allow for more complex tests using
running VM
..
Patch Set 3:
Tried to implement most of the suggestions as they seem to make sense,
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Introduce lvm short filters.
..
Patch Set 1: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/3863/ : FAILURE
http://jenk
oVirt Jenkins CI Server has posted comments on this change.
Change subject: multipath.getMPDevNamesIter() return /dev/mapper.
..
Patch Set 1: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/3862/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Normalize lvm._buildFilter().
..
Patch Set 1: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/3861/ : FAILURE
http://jen
Eduardo has uploaded a new change for review.
Change subject: multipath.getMPDevNamesIter() return /dev/mapper.
..
multipath.getMPDevNamesIter() return /dev/mapper.
multipath names return the /dev/mapper part of the path for
con
Eduardo has uploaded a new change for review.
Change subject: Introduce lvm short filters.
..
Introduce lvm short filters.
lvm commands that operate in a known VG can use the known pvs for
filter.
Change-Id: I26f3a7c712b6d7009f
Eduardo has uploaded a new change for review.
Change subject: Normalize lvm._buildFilter().
..
Normalize lvm._buildFilter().
Change-Id: I2c0a5c61ba6754db996b2c88b32bedee852df22f
Signed-off-by: Eduardo
---
M vdsm/storage/lvm.py
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Handling signals interrupts during start
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/3860/ : SUCCESS
http:/
Federico Simoncelli has submitted this change and it was merged.
Change subject: Fix stale call to deactivateVolumes().
..
Fix stale call to deactivateVolumes().
Calling deactivateImage() is correct due to the one volume (no
te
Federico Simoncelli has posted comments on this change.
Change subject: Fix stale call to deactivateVolumes().
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/17734
To unsubscribe, visit http://gerrit.ovir
Federico Simoncelli has submitted this change and it was merged.
Change subject: Only remove dhcp source routing if the removal reason is "STOP"
..
Only remove dhcp source routing if the removal reason is "STOP"
If the reason i
Federico Simoncelli has posted comments on this change.
Change subject: Only remove dhcp source routing if the removal reason is "STOP"
..
Patch Set 1: Code-Review+2
same as master
--
To view, visit http://gerrit.ovirt.org/17
Assaf Muller has posted comments on this change.
Change subject: Only remove dhcp source routing if the removal reason is "STOP"
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/17963
To unsubscribe, visit
Hello Saggi Mizrahi, Federico Simoncelli, Antoni Segura Puimedon,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/17963
to review the following change.
Change subject: Only remove dhcp source routing if the removal reason is "STOP"
...
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Only remove dhcp source routing if the removal reason is "STOP"
..
Patch Set 3:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/
Federico Simoncelli has submitted this change and it was merged.
Change subject: Only remove dhcp source routing if the removal reason is "STOP"
..
Only remove dhcp source routing if the removal reason is "STOP"
If the reason i
Federico Simoncelli has posted comments on this change.
Change subject: Only remove dhcp source routing if the removal reason is "STOP"
..
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/17961
To unsubscri
Antoni Segura Puimedon has posted comments on this change.
Change subject: Only remove dhcp source routing if the removal reason is "STOP"
..
Patch Set 3: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/17961
To unsubs
oVirt Jenkins CI Server has posted comments on this change.
Change subject: [WIP]gluster: Get size information of a gluster volume
..
Patch Set 3: Code-Review-1
Build Unstable
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerr
Assaf Muller has posted comments on this change.
Change subject: Only remove dhcp source routing if the removal reason is "STOP"
..
Patch Set 3: Verified+1
--
To view, visit http://gerrit.ovirt.org/17961
To unsubscribe, visit
Saggi Mizrahi has posted comments on this change.
Change subject: Only remove dhcp source routing if the removal reason is "STOP"
..
Patch Set 3: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/17961
To unsubscribe, vi
Saggi Mizrahi has posted comments on this change.
Change subject: Only remove dhcp source routing if the removal reason is "STOP"
..
Patch Set 2: Code-Review-1
--
To view, visit http://gerrit.ovirt.org/17961
To unsubscribe, vi
Assaf Muller has posted comments on this change.
Change subject: Only remove dhcp source routing if the removal reason is "STOP"
..
Patch Set 2: Verified+1
--
To view, visit http://gerrit.ovirt.org/17961
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Only remove dhcp source routing if the removal reason is "STOP"
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: [WIP]gluster: Get size information of a gluster volume
..
Patch Set 2: Code-Review-1
Build Unstable
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerr
Antoni Segura Puimedon has posted comments on this change.
Change subject: Only remove dhcp source routing if the removal reason is "STOP"
..
Patch Set 2: Code-Review+1
Thanks Assaf! Such a small nice change ;-)
--
To view, v
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Only remove dhcp source routing if the removal reason is "STOP"
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/
Assaf Muller has posted comments on this change.
Change subject: Only remove dhcp source routing if the removal reason is "STOP"
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/17961
To unsubscribe, visit
Assaf Muller has uploaded a new change for review.
Change subject: Only remove dhcp source routing if the removal reason is "STOP"
..
Only remove dhcp source routing if the removal reason is "STOP"
If the reason is FAIL then the
Antoni Segura Puimedon has posted comments on this change.
Change subject: hooks: macbind - This hook support binding specified mac
address to custom/other bridge than the currently defined bridge in ovirt. This
hook is also capable of binding a mac address to openvswitch bridge.
...
Alon Bar-Lev has posted comments on this change.
Change subject: vdsmd and supervdsmd: extract common init tasks and add init
adapter
..
Patch Set 13:
(1 comment)
File vdsm
Assaf Muller has abandoned this change.
Change subject: Only remove source routing if the ip configuration is down
..
Abandoned
Another approach is needed... This one is raceful.
--
To view, visit http://gerrit.ovirt.org/1795
Saggi Mizrahi has posted comments on this change.
Change subject: vdsmd and supervdsmd: extract common init tasks and add init
adapter
..
Patch Set 13: Code-Review-1
(2 comments)
Minor complaints, great job overall!
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm: new parameter 'protected' for vm creation
..
Patch Set 4: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/3854/ : FAI
Antoni Segura Puimedon has posted comments on this change.
Change subject: vdsmd and supervdsmd: extract common init tasks and add init
adapter
..
Patch Set 13: Code-Review-1
(4 comments)
-1 for visibility. Thanks a lot for t
Assaf Muller has posted comments on this change.
Change subject: Only remove source routing if the ip configuration is down
..
Patch Set 1: Verified-1
Solution is raceful. I'll look into alternative solutions.
--
To view, vis
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm: new parameter 'protected' for vm creation
..
Patch Set 3: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/3853/ : FAI
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 15:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/3852/ : SUCCESS
http://jenkins.
Martin Betak has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 15: Verified+1
--
To view, visit http://gerrit.ovirt.org/15829
To unsubscribe, visit http://gerrit.ovirt.org/settings
Zhou Zheng Sheng has posted comments on this change.
Change subject: Refactored xmlrpcTests to allow for more complex tests using
running VM
..
Patch Set 2: Code-Review-1
(5 comments)
Test runs successfully on my laptop.
Ple
Federico Simoncelli has posted comments on this change.
Change subject: Management network is now kept in main routing table
..
Patch Set 2: Code-Review+2
Same as master
--
To view, visit http://gerrit.ovirt.org/17844
To unsu
Federico Simoncelli has submitted this change and it was merged.
Change subject: Management network is now kept in main routing table
..
Management network is now kept in main routing table
Only the management network should ad
Saggi Mizrahi has posted comments on this change.
Change subject: Only remove source routing if the ip configuration is down
..
Patch Set 1: Code-Review-1
(2 comments)
File
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Only remove source routing if the ip configuration is down
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/3851/
Assaf Muller has posted comments on this change.
Change subject: Only remove source routing if the ip configuration is down
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/17950
To unsubscribe, visit http:
Assaf Muller has uploaded a new change for review.
Change subject: Only remove source routing if the ip configuration is down
..
Only remove source routing if the ip configuration is down
Bug-Url: https://bugzilla.redhat.com/sho
Sandro Bonazzola has posted comments on this change.
Change subject: vdsmd and supervdsmd: extract common init tasks and add init
adapter
..
Patch Set 13:
(2 comments)
File
Antoni Segura Puimedon has posted comments on this change.
Change subject: libvirt configure: use "ed" instead of "sed --copy -i"
..
Patch Set 2: Code-Review+1
I can accept going to ed and in the future use a better system.
--
80 matches
Mail list logo
