Assaf Muller has posted comments on this change.
Change subject: macspoof hooks: new hook script to enable macspoof filtering
per vnic.
..
Patch Set 7:
Ok but be sure to have a giant comment in the source file saying that this
Alon Bar-Lev has posted comments on this change.
Change subject: Add vdsm upstart jobs
..
Patch Set 2:
(1 comment)
File vdsm/vdsmd.upstart.in
Line 10: nice -20
Line 11: resp
Alon Bar-Lev has posted comments on this change.
Change subject: vdsmd and supervdsmd: extract common init tasks and add init
adapter
..
Patch Set 17: Code-Review+1
(1 comment)
Minor comment... my usual :)
..
Zhou Zheng Sheng has posted comments on this change.
Change subject: Add vdsm upstart jobs
..
Patch Set 2:
(1 comment)
File vdsm/vdsmd.upstart.in
Line 10: nice -20
Line 11:
Zhou Zheng Sheng has posted comments on this change.
Change subject: Refactored xmlrpcTests to allow for more complex tests using
running VM
..
Patch Set 7: Code-Review+1
(1 comment)
..
Mark Wu has posted comments on this change.
Change subject: mom: add mom balloon functional tests for running vms
..
Patch Set 10:
(3 comments)
File tests/functional/momTest
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Add vlanid to vlans information
..
Patch Set 4:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/3943/ : SUCCESS
http://jenkins.
Amador Pahim has posted comments on this change.
Change subject: Add vlanid to vlans information
..
Patch Set 4: Verified+1
--
To view, visit http://gerrit.ovirt.org/18148
To unsubscribe, visit http://gerrit.ovirt.org/settings
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Add vlanid to vlans information
..
Patch Set 3:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/3942/ : SUCCESS
http://jenkins.
Amador Pahim has posted comments on this change.
Change subject: Add vlanid to vlans information
..
Patch Set 3: Verified+1
--
To view, visit http://gerrit.ovirt.org/18148
To unsubscribe, visit http://gerrit.ovirt.org/settings
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Introducing hidden_vlans configurable
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/3941/ : SUCCESS
http://je
Amador Pahim has posted comments on this change.
Change subject: Introducing hidden_vlans configurable
..
Patch Set 2: Verified+1
--
To view, visit http://gerrit.ovirt.org/18082
To unsubscribe, visit http://gerrit.ovirt.org/se
Antoni Segura Puimedon has posted comments on this change.
Change subject: Functional Tests [1/3]: Added module for dummy nics
..
Patch Set 1:
(1 comment)
File tests/functio
Antoni Segura Puimedon has posted comments on this change.
Change subject: vdsmd and supervdsmd: extract common init tasks and add init
adapter
..
Patch Set 17: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/15578
To
Antoni Segura Puimedon has posted comments on this change.
Change subject: Introducing hidden_vlans configurable
..
Patch Set 1: Code-Review-1
(1 comment)
File lib/vdsm/neti
Antoni Segura Puimedon has posted comments on this change.
Change subject: Add vlanid to vlans information
..
Patch Set 2: Code-Review-1
(2 comments)
Thanks a lot for the patch Amador.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Don't down bonds and nics when adding vlan or resizing
..
Patch Set 10:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/3940/ :
Antoni Segura Puimedon has posted comments on this change.
Change subject: Don't down bonds and nics when adding vlan or resizing
..
Patch Set 10: Verified+1
Cosmetic changes, copying verification score.
--
To view, visit htt
Antoni Segura Puimedon has posted comments on this change.
Change subject: Don't down bonds and nics when adding vlan or resizing
..
Patch Set 9:
(4 comments)
File lib/vdsm/
Giuseppe Vallarelli has posted comments on this change.
Change subject: Unified network persistence [3/3] - Restore network
configuration
..
Patch Set 2: Code-Review-1
(2 comments)
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Add vlanid to vlans information
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/3939/ : SUCCESS
http://jenkins.
Giuseppe Vallarelli has posted comments on this change.
Change subject: Unified network persistence [1/3] - Save running config
..
Patch Set 13: Code-Review-1
(4 comments)
See comments.
...
Amador Pahim has posted comments on this change.
Change subject: Add vlanid to vlans information
..
Patch Set 2: Verified+1
--
To view, visit http://gerrit.ovirt.org/18148
To unsubscribe, visit http://gerrit.ovirt.org/settings
Giuseppe Vallarelli has posted comments on this change.
Change subject: Don't down bonds and nics when adding vlan or resizing
..
Patch Set 9: Code-Review-1
(5 comments)
Very minor refinements.
...
Amador Pahim has posted comments on this change.
Change subject: Add vlanid to vlans information
..
Patch Set 1: Verified-1
Sending a new Patch Set.
--
To view, visit http://gerrit.ovirt.org/18148
To unsubscribe, visit http:/
Giuseppe Vallarelli has posted comments on this change.
Change subject: macspoof hooks: new hook script to enable macspoof filtering
per vnic.
..
Patch Set 7:
Hi Assaf thanks for feedback. My understanding is that the hook scr
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Add vlanid to vlans information
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/3938/ : SUCCESS
http://jenkins.
Amador Pahim has uploaded a new change for review.
Change subject: Add vlanid to vlans information
..
Add vlanid to vlans information
Currently vdsm does not report vlan id as an idependent field. ovirt-engine
is deducting vlan
Assaf Muller has posted comments on this change.
Change subject: Don't down bonds and nics when adding vlan or resizing
..
Patch Set 9: Code-Review+1
Much clearer now, thanks :)
--
To view, visit http://gerrit.ovirt.org/17491
Assaf Muller has posted comments on this change.
Change subject: macspoof hooks: new hook script to enable macspoof filtering
per vnic.
..
Patch Set 7:
Giuseppe - Regarding code reuse, how about this:
In /usr/libexec/vdsm:
b
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: rename supervdsmServer.py to supervdsmServer and add
environment file
..
Patch Set 7:
(1 comment)
...
Yaniv Bronhaim has posted comments on this change.
Change subject: packaging: rename supervdsmServer.py to supervdsmServer and add
environment file
..
Patch Set 7:
(1 comment)
.
Yaniv Bronhaim has posted comments on this change.
Change subject: vdsmd and supervdsmd: extract common init tasks and add init
adapter
..
Patch Set 17: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/15578
To unsubsc
Mark Wu has posted comments on this change.
Change subject: mom: add mom balloon functional tests for running vms
..
Patch Set 10: Code-Review-1
(4 comments)
File tests/func
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Introducing hidden_vlans configurable
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/3937/ : SUCCESS
http://je
Amador Pahim has posted comments on this change.
Change subject: Introducing hidden_vlans configurable
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/18082
To unsubscribe, visit http://gerrit.ovirt.org/se
Amador Pahim has uploaded a new change for review.
Change subject: Introducing hidden_vlans configurable
..
Introducing hidden_vlans configurable
Change-Id: Id4340936fb998c5ab9ee46e16a16ae15461176f2
Bug-Url: https://bugzilla.red
Sandro Bonazzola has posted comments on this change.
Change subject: One shot prepare.
..
Patch Set 10:
Any chance to have this patch queue merged soon?
--
To view, visit http://gerrit.ovirt.org/4220
To unsubscribe, visit htt
Sandro Bonazzola has posted comments on this change.
Change subject: vm: new parameter 'protected' for vm creation
..
Patch Set 4:
Any chance to have this patch queue merged soon?
--
To view, visit http://gerrit.ovirt.org/177
Michal Skrivanek has posted comments on this change.
Change subject: [WIP] vm: cleanup of vm.py
..
Patch Set 5:
(1 comment)
File vdsm/vm.py
Line 2832: # saving w
Martin Polednik has posted comments on this change.
Change subject: Refactored xmlrpcTests to allow for more complex tests using
running VM
..
Patch Set 7:
This implementation is most versatile in allowing specification of exp
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Refactored xmlrpcTests to allow for more complex tests using
running VM
..
Patch Set 7:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_test
oVirt Jenkins CI Server has posted comments on this change.
Change subject: [WIP] vm: cleanup of vm.py
..
Patch Set 5:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/3935/ : SUCCESS
http://jenkins.ovirt
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Refactored xmlrpcTests to allow for more complex tests using
running VM
..
Patch Set 6: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_un
oVirt Jenkins CI Server has posted comments on this change.
Change subject: storage: kill ongoing operations on exit
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/3933/ : SUCCESS
http:/
Federico Simoncelli has uploaded a new change for review.
Change subject: storage: kill ongoing operations on exit
..
storage: kill ongoing operations on exit
Some storage operations must be forcibly interrupted when the vdsm
(p
oVirt Jenkins CI Server has posted comments on this change.
Change subject: [WIP] vm: cleanup of vm.py
..
Patch Set 3:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/3931/ : SUCCESS
http://jenkins.ovirt
oVirt Jenkins CI Server has posted comments on this change.
Change subject: [WIP] vm: cleanup of vm.py
..
Patch Set 4: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/3932/ : FAILURE
http://jenkin
Alon Bar-Lev has posted comments on this change.
Change subject: Add vdsm upstart jobs
..
Patch Set 2:
(1 comment)
File vdsm/vdsmd.upstart.in
Line 10: nice -20
Line 11: resp
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsmd and supervdsmd: extract common init tasks and add init
adapter
..
Patch Set 17:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_
Zhou Zheng Sheng has posted comments on this change.
Change subject: packaging: rename supervdsmServer.py to supervdsmServer and add
environment file
..
Patch Set 7: Verified+1
--
To view, visit http://gerrit.ovirt.org/17100
Zhou Zheng Sheng has posted comments on this change.
Change subject: vdsmd and supervdsmd: extract common init tasks and add init
adapter
..
Patch Set 17: Verified+1
--
To view, visit http://gerrit.ovirt.org/15578
To unsubscr
oVirt Jenkins CI Server has posted comments on this change.
Change subject: packaging: rename supervdsmServer.py to supervdsmServer and add
environment file
..
Patch Set 7:
Build Successful
http://jenkins.ovirt.org/job/vdsm_
Zhou Zheng Sheng has posted comments on this change.
Change subject: Packageing: Move SystemD and SysVInit files to respective
sub-dirs
..
Patch Set 2: Verified+1
--
To view, visit http://gerrit.ovirt.org/18067
To unsubscribe
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Packageing: Move SystemD and SysVInit files to respective
sub-dirs
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_ger
Zhou Zheng Sheng has posted comments on this change.
Change subject: vdsmd and supervdsmd: extract common init tasks and add init
adapter
..
Patch Set 16: Verified+1
In the new patch set, I move all reconfigure related code to
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsmd and supervdsmd: extract common init tasks and add init
adapter
..
Patch Set 16:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_
Deepak C Shetty has abandoned this change.
Change subject: vdsm.spec: BZ 988299: Fix GlusterFS RPM dep to support
GlusterFS SD
..
Abandoned
This didnt land in ovirt-3.3 branch as i expected.
Since this change is already sent t
Michal Skrivanek has posted comments on this change.
Change subject: [WIP] vm: cleanup of vm.py
..
Patch Set 2: Code-Review-1
need to support 3.0
pls address just the smartcard and buildConfDevices
--
To view, visit http://ge
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm.spec: BZ 988299: Fix GlusterFS RPM dep to support
GlusterFS SD
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_ge
oVirt Jenkins CI Server has posted comments on this change.
Change subject: [WIP] vm: cleanup of vm.py
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/3925/ : SUCCESS
http://jenkins.ovirt
Deepak C Shetty has posted comments on this change.
Change subject: vdsm.spec: BZ 988299: Fix GlusterFS RPM dep to support
GlusterFS SD
..
Patch Set 1: Verified+1
Verified on F19
FYI: This patch same as master branch patch @
Zhou Zheng Sheng has posted comments on this change.
Change subject: vdsmd and supervdsmd: extract common init tasks and add init
adapter
..
Patch Set 14:
(1 comment)
File
Deepak C Shetty has uploaded a new change for review.
Change subject: vdsm.spec: BZ 988299: Fix GlusterFS RPM dep to support
GlusterFS SD
..
vdsm.spec: BZ 988299: Fix GlusterFS RPM dep to support GlusterFS SD
This patch fixes t
Zhou Zheng Sheng has posted comments on this change.
Change subject: Refactored xmlrpcTests to allow for more complex tests using
running VM
..
Patch Set 5: Verified+1
In vdsm there is code to monitor VMs and their related sto
Zhou Zheng Sheng has posted comments on this change.
Change subject: packaging: rename supervdsmServer.py to supervdsmServer and add
environment file
..
Patch Set 6: Verified+1
The parent is changed, so this one is rebased and
Zhou Zheng Sheng has posted comments on this change.
Change subject: Add vdsm upstart jobs
..
Patch Set 3: Verified+1
I write a patch to move init related files to /init. This patch rebases to the
that one and moves Upstart re
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsmd and supervdsmd: extract common init tasks and add init
adapter
..
Patch Set 15:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Packageing: Move SystemD and SysVInit files to respective
sub-dirs
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_ger
Zhou Zheng Sheng has posted comments on this change.
Change subject: Packageing: Move SystemD and SysVInit files to respective
sub-dirs
..
Patch Set 1: Verified+1
Test on Fedora, RHEL and Ubuntu.
--
To view, visit http://ger
oVirt Jenkins CI Server has posted comments on this change.
Change subject: packaging: rename supervdsmServer.py to supervdsmServer and add
environment file
..
Patch Set 6:
Build Successful
http://jenkins.ovirt.org/job/vdsm_
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Add vdsm upstart jobs
..
Patch Set 3:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/3922/ : SUCCESS
http://jenkins.ovirt.org/
Zhou Zheng Sheng has uploaded a new change for review.
Change subject: Packageing: Move SystemD and SysVInit files to respective
sub-dirs
..
Packageing: Move SystemD and SysVInit files to respective sub-dirs
A new dir /init is
oVirt Jenkins CI Server has posted comments on this change.
Change subject: java_bindings: SSL support
..
Patch Set 9:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/3919/ : SUCCESS
http://jenkins.ovirt
oVirt Jenkins CI Server has posted comments on this change.
Change subject: jsonrpc: Add SSL support to asyncore transport
..
Patch Set 8: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/3920/ : FA
oVirt Jenkins CI Server has posted comments on this change.
Change subject: java_binding: Simplify bindings by using object mappers
..
Patch Set 6:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/3918/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: jsonrpc: Fix race in AsynChat
..
Patch Set 9: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/3917/ : FAILURE
http://jen
oVirt Jenkins CI Server has posted comments on this change.
Change subject: jsonrpc: Change base class invoke semantics
..
Patch Set 9: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/3916/ : FAILU
oVirt Jenkins CI Server has posted comments on this change.
Change subject: [WIP] Java_Bindings: Create a spec file
..
Patch Set 3:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/3915/ : SUCCESS
http://
Giuseppe Vallarelli has posted comments on this change.
Change subject: tests: setupNetworks add net bond breaking and resizing.
..
Patch Set 4:
Hi Mark I know that there's a little bit of duplication, however extracting the
c
Yaniv Bronhaim has posted comments on this change.
Change subject: vdsmd and supervdsmd: extract common init tasks and add init
adapter
..
Patch Set 14:
(1 comment)
File vd
Mark Wu has posted comments on this change.
Change subject: tests: setupNetworks add net bond breaking and resizing.
..
Patch Set 4: Code-Review-1
all the three new added test cases have the code of create network over bond
de
oVirt Jenkins CI Server has posted comments on this change.
Change subject: [WIP] vdsmapi schema fixes
..
Patch Set 3:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/3914/ : SUCCESS
http://jenkins.ovirt
Martin Polednik has posted comments on this change.
Change subject: Refactored xmlrpcTests to allow for more complex tests using
running VM
..
Patch Set 5:
Current version doesn't wait for the VM at all - are there any cases,
oVirt Jenkins CI Server has posted comments on this change.
Change subject: [WIP] vdsmapi schema fixes
..
Patch Set 2: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/3913/ : FAILURE
http://jenkin
oVirt Jenkins CI Server has posted comments on this change.
Change subject: tests: setupNetworks convertVlanNetBridgeness, Mtus
..
Patch Set 3:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/3912/ : SUCC
Giuseppe Vallarelli has posted comments on this change.
Change subject: tests: setupNetworks convertVlanNetBridgeness, Mtus
..
Patch Set 3: Verified+1
Rebased.
--
To view, visit http://gerrit.ovirt.org/17866
To unsubscribe, v
Mark Wu has posted comments on this change.
Change subject: tests: bondHwAddress, safeNetworkConfig, volatileConfig
..
Patch Set 3: Code-Review-1
(5 comments)
File tests/fun
Giuseppe Vallarelli has posted comments on this change.
Change subject: Functional Tests [2/3]: Added ipwrapper.ruleExists+routeExists
..
Patch Set 1:
(1 comment)
Added a comment for cleaning up added rules/routes.
..
Zhou Zheng Sheng has posted comments on this change.
Change subject: Add vdsm upstart jobs
..
Patch Set 2:
(2 comments)
Thanks Antoni and Alon. I'm working on a new patch to move systemd, sysvinit
and upstart files to respect
oVirt Jenkins CI Server has posted comments on this change.
Change subject: [WIP] vdsmapi schema: optional/required parameter fixes
..
Patch Set 1: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/3
Martin Polednik has uploaded a new change for review.
Change subject: [WIP] vdsmapi schema: optional/required parameter fixes
..
[WIP] vdsmapi schema: optional/required parameter fixes
Change-Id: Ia4f9e123da73b0a326ce0762702e5ab
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Don't down bonds and nics when adding vlan or resizing
..
Patch Set 9:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/3910/ : S
Antoni Segura Puimedon has posted comments on this change.
Change subject: Don't down bonds and nics when adding vlan or resizing
..
Patch Set 8:
(1 comment)
File vdsm/netmo
Antoni Segura Puimedon has posted comments on this change.
Change subject: Don't down bonds and nics when adding vlan or resizing
..
Patch Set 9: Verified+1
Only added a comment as asked in amuller's review. Keep the verified s
95 matches
Mail list logo
