Ayal Baron has posted comments on this change.
Change subject: sp: remove unused scsiFencing parameter
..
Patch Set 7: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/21555
To unsubscribe, visit http://gerrit.ovirt.org
Ayal Baron has posted comments on this change.
Change subject: sp: remove unused recoveryMode from spmStart
..
Patch Set 7: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/21556
To unsubscribe, visit http://gerrit.ovir
Ayal Baron has posted comments on this change.
Change subject: sp: split metadata transaction in createMaster
..
Patch Set 2:
(3 comments)
Commit Message
Line 21: The two si
Vered Volansky has posted comments on this change.
Change subject: sp: split metadata transaction in createMaster
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/22418
To unsubscribe, visit http://gerri
Dan Kenigsberg has posted comments on this change.
Change subject: netconf: Add config option for network configurator
..
Patch Set 12: Verified+1
--
To view, visit http://gerrit.ovirt.org/18210
To unsubscribe, visit http://ge
Dan Kenigsberg has posted comments on this change.
Change subject: netconf: Add dhcp support for iproute2 configurator
..
Patch Set 12: Verified+1
--
To view, visit http://gerrit.ovirt.org/15492
To unsubscribe, visit http://ge
Nir Soffer has posted comments on this change.
Change subject: link monitor: do not leave stray `ip monitor` behind
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/22667
To unsubscribe, visit http://ger
Dan Kenigsberg has posted comments on this change.
Change subject: link monitor: do not leave stray `ip monitor` behind
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/22667
To unsubscribe, visit http://ge
Dan Kenigsberg has posted comments on this change.
Change subject: tests: janitorial: cleanup temporary directories
..
Patch Set 4: Code-Review+1
(1 comment)
File tests/hook
Antoni Segura Puimedon has posted comments on this change.
Change subject: setupNetworks: support networks with no underlying NIC
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/22595
To unsubscribe, vi
Dan Kenigsberg has posted comments on this change.
Change subject: sourceRouteThread: log unhandled exceptions
..
Patch Set 2:
How have we missed that?
--
To view, visit http://gerrit.ovirt.org/22670
To unsubscribe, visit htt
Dan Kenigsberg has posted comments on this change.
Change subject: sourceRouteThread: log unhandled exceptions
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/22670
To unsubscribe, visit http://gerrit.o
oVirt Jenkins CI Server has posted comments on this change.
Change subject: sp: split metadata transaction in createMaster
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6245/ : SUCCESS
http:/
Federico Simoncelli has posted comments on this change.
Change subject: sp: split metadata transaction in createMaster
..
Patch Set 2: -Code-Review
--
To view, visit http://gerrit.ovirt.org/22418
To unsubscribe, visit http://g
Nir Soffer has posted comments on this change.
Change subject: sourceRouteThread: log unhandled exceptions
..
Patch Set 2:
Low hanging fruit.
--
To view, visit http://gerrit.ovirt.org/22670
To unsubscribe, visit http://gerrit
Nir Soffer has posted comments on this change.
Change subject: sourceRouteThread: log unhandled exceptions
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/22670
To unsubscribe, visit http://gerrit.ovirt
oVirt Jenkins CI Server has posted comments on this change.
Change subject: sourceRouteThread: log unhandled exceptions
..
Patch Set 2: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6244/ : SUCCESS
ht
oVirt Jenkins CI Server has posted comments on this change.
Change subject: sourceRouteThread: log unhandled exceptions
..
Patch Set 1: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6243/ : SUCCESS
ht
Dan Kenigsberg has submitted this change and it was merged.
Change subject: link monitor: replace events() with optionally continuous
iteration
..
link monitor: replace events() with optionally continuous iteration
The way to
Nir Soffer has posted comments on this change.
Change subject: sourceRouteThread: log unhandled exceptions
..
Patch Set 1:
(1 comment)
File vdsm/sourceRouteThread.py
Line 42
Antoni Segura Puimedon has uploaded a new change for review.
Change subject: sourceRouteThread: log unhandled exceptions
..
sourceRouteThread: log unhandled exceptions
Change-Id: I23eaf7a41c8decaea64a392d58ef6ba31f24d795
Signed-
oVirt Jenkins CI Server has posted comments on this change.
Change subject: sp: remove unused scsiFencing parameter
..
Patch Set 7:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6242/ : SUCCESS
http://jenkin
oVirt Jenkins CI Server has posted comments on this change.
Change subject: sp: remove scsiKey from connectStoragePool
..
Patch Set 7:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6241/ : SUCCESS
http://jen
oVirt Jenkins CI Server has posted comments on this change.
Change subject: sp: remove unused recoveryMode from spmStart
..
Patch Set 7:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6240/ : SUCCESS
http://j
Federico Simoncelli has posted comments on this change.
Change subject: sp: remove unused scsiFencing parameter
..
Patch Set 7: Verified+1
Verified with manual connectStoragePool/spmStart/spmStop/disconnectStoragePool.
I also
Federico Simoncelli has posted comments on this change.
Change subject: sp: remove unused recoveryMode from spmStart
..
Patch Set 7: Verified+1
Verified with manual connectStoragePool/spmStart/spmStop/disconnectStoragePool.
I
Federico Simoncelli has posted comments on this change.
Change subject: sp: remove scsiKey from connectStoragePool
..
Patch Set 7: Verified+1
Verified with manual connectStoragePool/spmStart/spmStop/disconnectStoragePool.
I al
Antoni Segura Puimedon has posted comments on this change.
Change subject: link monitor: replace events() with optionally continuous
iteration
..
Patch Set 16: Verified+1
@Nir: Dan fast not fast enough making the change ;-)
-
oVirt Jenkins CI Server has posted comments on this change.
Change subject: sp: remove automatic storage pool reconnection
..
Patch Set 13:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/1
Antoni Segura Puimedon has posted comments on this change.
Change subject: link monitor: do not leave stray `ip monitor` behind
..
Patch Set 1:
Thanks Dan! I wasn't aware of the deathSignal part of execCmd :P
--
To view, visi
Antoni Segura Puimedon has posted comments on this change.
Change subject: link monitor: do not leave stray `ip monitor` behind
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/22667
To unsubscribe, visi
Dan Kenigsberg has submitted this change and it was merged.
Change subject: sp: remove automatic storage pool reconnection
..
sp: remove automatic storage pool reconnection
On startup the storage pool directory (/rhev/data-cent
oVirt Jenkins CI Server has posted comments on this change.
Change subject: link monitor: replace events() with optionally continuous
iteration
..
Patch Set 16:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/
Nir Soffer has posted comments on this change.
Change subject: link monitor: replace events() with optionally continuous
iteration
..
Patch Set 16:
Porting to C?
--
To view, visit http://gerrit.ovirt.org/21430
To unsubscribe
Antoni Segura Puimedon has posted comments on this change.
Change subject: link monitor: replace events() with optionally continuous
iteration
..
Patch Set 16:
Not fast enough ;-)
--
To view, visit http://gerrit.ovirt.org/21
oVirt Jenkins CI Server has posted comments on this change.
Change subject: link monitor: do not leave stray `ip monitor` behind
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6239/ : SUCCESS
Dan Kenigsberg has posted comments on this change.
Change subject: link monitor: replace events() with optionally continuous
iteration
..
Patch Set 16: Code-Review+2
Hey, I was just fixing this myself!
--
To view, visit http
Dan Kenigsberg has submitted this change and it was merged.
Change subject: vdsm: add logging to _getUnderlyingDriveInfo
..
vdsm: add logging to _getUnderlyingDriveInfo
_getUnderlyingDriveInfo() currently logs nothing - due
to
Dan Kenigsberg has submitted this change and it was merged.
Change subject: ipwrapper: fix excessive process creation
..
ipwrapper: fix excessive process creation
_detectType is a very very often used operation and it was relyi
Dan Kenigsberg has uploaded a new change for review.
Change subject: link monitor: do not leave stray `ip monitor` behind
..
link monitor: do not leave stray `ip monitor` behind
ipwrapper.Monitor.start() spawns an `ip monitor li
oVirt Jenkins CI Server has posted comments on this change.
Change subject: link monitor: replace events() with optionally continuous
iteration
..
Patch Set 16: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_pep8_
Nir Soffer has posted comments on this change.
Change subject: link monitor: replace events() with optionally continuous
iteration
..
Patch Set 16: Code-Review+1
Beautiful.
--
To view, visit http://gerrit.ovirt.org/21430
To
Federico Simoncelli has posted comments on this change.
Change subject: sp: remove unused transaction in createMaster
..
Patch Set 1: Code-Review-2
Wrong.
--
To view, visit http://gerrit.ovirt.org/22418
To unsubscribe, visit
Federico Simoncelli has posted comments on this change.
Change subject: sp: remove automatic storage pool reconnection
..
Patch Set 12: Verified+1
Verified with multiple connectStoragePool (correct values, missing spUUID,
wron
Dan Kenigsberg has posted comments on this change.
Change subject: sp: remove automatic storage pool reconnection
..
Patch Set 12: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/21424
To unsubscribe, visit http://gerr
oVirt Jenkins CI Server has posted comments on this change.
Change subject: sp: remove automatic storage pool reconnection
..
Patch Set 12:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6237/ : SUCCESS
http:
Dan Kenigsberg has posted comments on this change.
Change subject: link monitor: replace events() with optionally continuous
iteration
..
Patch Set 15: Code-Review-1
(1 comment)
...
Dan Kenigsberg has submitted this change and it was merged.
Change subject: sp: _refreshDomainLinks must not change the metadata
..
sp: _refreshDomainLinks must not change the metadata
Method _refreshDomainLinks is used on HSM
Nir Soffer has posted comments on this change.
Change subject: link monitor: replace events() with optionally continuous
iteration
..
Patch Set 15:
(1 comment)
File lib/vds
Dan Kenigsberg has posted comments on this change.
Change subject: sp: _refreshDomainLinks must not change the metadata
..
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/22131
To unsubscribe, visit http:/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: sp: _refreshDomainLinks must not change the metadata
..
Patch Set 4:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6236/ : SUCCESS
Federico Simoncelli has posted comments on this change.
Change subject: sp: _refreshDomainLinks must not change the metadata
..
Patch Set 4: Verified+1
Verified starting the SPM.
--
To view, visit http://gerrit.ovirt.org/2213
Federico Simoncelli has posted comments on this change.
Change subject: sp: _refreshDomainLinks must not change the metadata
..
Patch Set 3:
(1 comment)
File vdsm/storage/sp
Assaf Muller has posted comments on this change.
Change subject: hooks: Renamed openstacknet_consts file
..
Patch Set 1: -Code-Review
And since you did that, ignore my last comment :)
--
To view, visit http://gerrit.ovirt.org
Dan Kenigsberg has posted comments on this change.
Change subject: sp: _refreshDomainLinks must not change the metadata
..
Patch Set 3:
(1 comment)
File vdsm/storage/sp.py
L
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm: spice support to clipboard copypaste disable
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6235/ : SUCCESS
http
Francesco Romani has uploaded a new change for review.
Change subject: vm: spice support to clipboard copypaste disable
..
vm: spice support to clipboard copypaste disable
since version 0.9.3, libvirt allows to optionally disabl
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: Handling topology for ppc64
..
Patch Set 10:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/177/ :
SUCCES
Dan Kenigsberg has submitted this change and it was merged.
Change subject: vdsm: Handling topology for ppc64
..
vdsm: Handling topology for ppc64
This change adds a method to extract the CPU topology information
thourght the l
Federico Simoncelli has posted comments on this change.
Change subject: sp: remove unused transaction in createMaster
..
Patch Set 1: Code-Review-1
It needs some attention. Skip it for now.
--
To view, visit http://gerrit.ovi
Dan Kenigsberg has submitted this change and it was merged.
Change subject: sp: add setMasterDomain to StoragePool
..
sp: add setMasterDomain to StoragePool
It turns out that getMasterDomain is used mostly as a setter for
the m
Francesco Romani has posted comments on this change.
Change subject: tests: janitorial: cleanup temporary directories
..
Patch Set 4:
Refactor more aggressively the affected test to do proper cleanup. I think the
result is wor
oVirt Jenkins CI Server has posted comments on this change.
Change subject: tests: janitorial: cleanup temporary directories
..
Patch Set 4:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6234/ : SUCCESS
http
Dan Kenigsberg has posted comments on this change.
Change subject: link monitor: replace events() with optionally continuous
iteration
..
Patch Set 15:
(1 comment)
File lib
Dan Kenigsberg has posted comments on this change.
Change subject: vm: janitorial: factorize key deletion in Vm.conf
..
Patch Set 2:
Indeed, "recovery" should never have been in conf. And the current message,
when the same "cr
Federico Simoncelli has posted comments on this change.
Change subject: sp: refactor out the metadata access from StoragePool
..
Patch Set 1: Code-Review-1
Outdated, don't review.
--
To view, visit http://gerrit.ovirt.org/221
oVirt Jenkins CI Server has posted comments on this change.
Change subject: mkimage: do not create world-readable image
..
Patch Set 5: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6233/ : SUCCESS
ht
Francesco Romani has posted comments on this change.
Change subject: mkimage: do not create world-readable image
..
Patch Set 5: Verified-1
Verified against a running VDSM instance. Marking as -1 because the package
isn't yet
Dan Kenigsberg has posted comments on this change.
Change subject: mkimage: create files with explicit permissions
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/21965
To unsubscribe, visit http://gerr
Dan Kenigsberg has submitted this change and it was merged.
Change subject: mkimage: create files with explicit permissions
..
mkimage: create files with explicit permissions
The files in the ISO image created with mkimage.mkIs
70 matches
Mail list logo